[Koha-bugs] [Bug 7430] ModZebra should not be in C4::Biblio

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed Apr 18 15:33:24 CEST 2012


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7430

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #8452|0                           |1
        is obsolete|                            |

--- Comment #10 from Mason James <mtj at kohaaloha.com> ---
Created attachment 9240
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9240&action=edit
From: Juan Romay Sieira <juan.sieira at xercode.es> Date: Wed, 21 Mar 2012
11:05:16 +0100 Subject: [PATCH] Bug 7430 - ModZebra should not be in C4::Biblio

This proof-of-concept commit does the following:
* Moves all the functionality from C4::Biblio::ModZebra into a new
  Koha::Search::Engine namespace, breaking it up into a Zebra class for the
  relevant section.
* Rather than calling ModZebra, callers should now use Koha::Search and
  call AddToIndexQueue() with the same arguments.
* Creates a new Koha::Utils class with GetMarcFromKohaField and GetAuthType
  methods, in an attempt to begin the process of reducing circular dependencies
* Adds a syspref SearchEngine to specify which search engine should be used. At
  present the only option is Zebra.

IMPORTANT NOTE: The syspref is added by the atomicupdate in
installer/data/mysql/atomicupdate/bug_7430_add_searchengine_syspref

IMPORTANT NOTE: NoZebra was deprecated for 3.4.0, and this commit entirely
removes portions of the NoZebra code.

Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
Signing off that the behavior is the same as in my original patch, except for
a fix to the return type of Koha::Search::Engine::get_indexes and
Koha::Search::GetIndexes. Another sign off is required.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list