[Koha-bugs] [Bug 7937] Silence warns in OPAC error log (koha-opac-error_log)

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7937

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |paul.poulain at biblibre.com

--- Comment #14 from Paul Poulain <paul.poulain at biblibre.com> ---
About patch 1, shouldn't we fix the KohaDate itself, to return '' if there is
no date provided ?

Something like:
     my ($self,$text) = @_;
+    return '' unless $text;
    my $date = C4::Dates->new( $text, 'iso' );
    return $date->output("syspref");


patch 3 would also have to be rewriten in this case.
(This option would result in silencing all KohaDates warning isn't it ?)

I agree with patch 2 and 4

I think patch 5 is OK, but there maybe some side effect replacing $x ne 1 by
!$x (even if I think there is none in this case). I'll delay this one for after
3.8.0 release, just to be carefull.

Waiting for feedback on counter-patch for 1 and 3

-- 
You are receiving this mail because:
You are watching all bug changes.