[Koha-bugs] [Bug 8004] Items on Hold Lose Transfer After Being Scanned Twice

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8004

--- Comment #1 from Kyle M Hall <kyle.m.hall at gmail.com> ---
Created attachment 9289
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9289&action=edit
Bug 8004 - Items on Hold Lose Transfer After Being Scanned Twice

When a hold is placed on an item where the pickup location is
different than the holding library, Koha initiates a branch
transfer for that item to fill that hold when items is run through
the returns system.

If the item is then run through returns a second time, the system is
supposed to close that transfer as a 'wrongtransfer', and open a new
transfer with the same from and to branches as the original.

The problem is that the original transfer is closed, but the new
transfer is not created. This is because at some point, someone
replaced the template variable WrongTransfer, which had previously
contained the branchcode for the library to transfer to, with the
full name of the library instead ( I assume to make a look nicer ).

Solved by removing the line that was changing the variable contents
from the branchcode to the branch name, and adding a new TT filter,
KohaBranchName that functions in the same way as KohaDates, except
it takes a branchcode and returns the branch name for the given
branchcode.

The consequence of this, is the the name of the library is passed to
updateWrongTransfer instead of the branchcode, causing the failure.

-- 
You are receiving this mail because:
You are watching all bug changes.