From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 01:17:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jul 2012 23:17:58 +0000 Subject: [Koha-bugs] [Bug 8543] enter an 001 at acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8543 --- Comment #2 from Nicole C. Engard --- In this case the librarian was asking for this because he has the OCLC number now and enters it in the 001 at the time of acquisition in his current system. So in this scenario it will be right :) But I of course do know what you mean :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 02:02:01 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 00:02:01 +0000 Subject: [Koha-bugs] [Bug 8545] New: ZOOM is silent on connection errors Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8545 Priority: P5 - low Change sponsored?: --- Bug ID: 8545 Assignee: gmcharlt at gmail.com Summary: ZOOM is silent on connection errors Severity: enhancement Classification: Unclassified OS: All Reporter: starsid at gmail.com Hardware: All Status: NEW Version: unspecified Component: Searching Product: Koha In file Context.pm, # forge to server $Zconn->connect($host, 0); # check for errors and warn if ($Zconn->errcode() !=0) { warn "something wrong with the connection: ". $Zconn->errmsg(); } the error checking code does not warn when I change $host to something garbage. The subsequent search query just returns an empty set without any errors. OS: Ubuntu 12.04 Koha: 3.9-1~git+20120524174206.f9352e89 Zoom: 1.26-1build2 I also checked this on CentOS 6.2 with Koha 3.08.03 and ZOOM installed as the latest version from the latest CPAN (I can check exact version numbers if needed). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 02:02:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 00:02:58 +0000 Subject: [Koha-bugs] [Bug 8545] ZOOM is silent on connection errors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8545 Siddhartha Bagaria changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |starsid at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 02:10:00 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 00:10:00 +0000 Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 Chris Nighswonger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6476|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 02:10:16 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 00:10:16 +0000 Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 Chris Nighswonger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11129|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 02:26:42 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 00:26:42 +0000 Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 --- Comment #127 from Chris Nighswonger --- (In reply to comment #113) > All the tests we made with Jonathan: > Tests made: > ? start from a clean situation (drop the 3 tables created by the new > mechanism) > ? checked that the old updatedatabase is still working by > ? adding a 3.09.00.028 update, that is empty > ? checked that we're redirected and the update is OK Here is as far as I got before hitting a show-stopper: 1. Performed a clean install over a clean branch off of a freshly updated master 2. git bz apply 7167; all patches applied cleanly to a fresh branch off master 3. Added a 3.09.00.028 update to test the correct functionality of the old update database mechanism after the application of the Bug 7167 code; Koha failed to redirect to the update screen after the addition of the test update. Paul/Jonathan, were your tests run over a clean install on a fresh branch or over a branch which was developed on? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 02:56:59 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 00:56:59 +0000 Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 --- Comment #128 from Chris Nighswonger --- (In reply to comment #127) > (In reply to comment #113) > > All the tests we made with Jonathan: > > Tests made: > > ? start from a clean situation (drop the 3 tables created by the new > > mechanism) > > ? checked that the old updatedatabase is still working by > > ? adding a 3.09.00.028 update, that is empty > > ? checked that we're redirected and the update is OK > > Here is as far as I got before hitting a show-stopper: > > 1. Performed a clean install over a clean branch off of a freshly updated > master > 2. git bz apply 7167; all patches applied cleanly to a fresh branch off > master > 3. Added a 3.09.00.028 update to test the correct functionality of the old > update database mechanism after the application of the Bug 7167 code; Koha > failed to redirect to the update screen after the addition of the test > update. > > Paul/Jonathan, were your tests run over a clean install on a fresh branch or > over a branch which was developed on? On a quick perusal of Auth.pm changes, I'm not sure how this step could ever work with the value of $koha39 hard-coded to 3.0900027. Perhaps I'm misunderstanding your test plan? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 03:49:38 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 01:49:38 +0000 Subject: [Koha-bugs] [Bug 8545] ZOOM is silent on connection errors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8545 --- Comment #1 from Siddhartha Bagaria --- This is because the error code will not necessarily work in the async mode. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 04:19:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 02:19:35 +0000 Subject: [Koha-bugs] [Bug 8545] ZOOM is silent on connection errors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8545 --- Comment #2 from Siddhartha Bagaria --- (In reply to comment #1) > This is because the error code will not necessarily work in the async mode. I was partly wrong above. The eval's catch block is commented out. So the error is not caught immediately. If the async mode is off, then the connect failed error is caught while making the query. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 09:46:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 07:46:27 +0000 Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 --- Comment #129 from Paul Poulain --- (In reply to comment #128) > > Paul/Jonathan, were your tests run over a clean install on a fresh branch or > > over a branch which was developed on? > > On a quick perusal of Auth.pm changes, I'm not sure how this step could ever > work with the value of $koha39 hard-coded to 3.0900027. Perhaps I'm > misunderstanding your test plan? Yikes... when we made the tests, we made some changes to run installer (like adding fake revisions -new and old mechanism-) and, murphy's law, I made a mistake reverting them. The following re-uploaded patches are exactly the same except for "reimplementing Reimplementing Marcel's suggestions & fixes" that check against 3.0900028 instead of 3.0900027 We have found another hidden problem, we will upload another follow-up in the next 2 hours -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 10:57:07 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 08:57:07 +0000 Subject: [Koha-bugs] [Bug 8546] New: OPAC Advanced Search Publication date range guide text FAIL Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8546 Priority: P5 - low Change sponsored?: --- Bug ID: 8546 Assignee: oleonard at myacpl.org Summary: OPAC Advanced Search Publication date range guide text FAIL Severity: trivial Classification: Unclassified OS: All Reporter: m.kirjasto.hailuoto at gmail.com Hardware: All Status: NEW Version: unspecified Component: OPAC Product: Koha Guide text in the advanced search form is incorrect: "For example: 1999-2001. You could also use "-1987" for everything published before 1987 or "2008-" for everything published after 2008." is illogical. The logically and functionally correct way being: For example: 1999-2001. You could also use "-1987" for everything published before 1988 or "2008-" for everything published after 2007. Reproducing the bug: Search date range 2008- for "everything published _after_2008_" and you'll get also books published 2008, not only after 2008. @ http://catalog.farmingtonlibraries.org/cgi-bin/koha/opac-search.pl This text bug prevails in community's demo runs 3.8, 3.6, 3.2 and master, provided by Bywater, CALYX, Equinox, Libriotech, software.coop http://koha-community.org/demo/ The four TOF demo Opacs on the list. Also in Bywater sandbox OPAC http://catalog.bywatersolutions.com/ EVEN THOUGH text bug has been fixed in Bywater sandbox Intranet (ver.3.09.00.026, whatever that would mean) (login bywater - bywater reqrd): http://intranet.bywatersolutions.com/cgi-bin/koha/catalogue/search.pl Bug shows in live instances too, e.g. Farmington Koha, http://catalog.farmingtonlibraries.org/cgi-bin/koha/opac-search.pl Most likely in KOHA 3.10 too. FIX SUGEGSTION, that do not age along the years: like w Bywater format: yyyy-yyyy PS. All in all, when I "patron-eyed" Farmington Adv search, I started to miss guide text feature. The advSearch page is so long. It could be shortened. Esp. the Item type list should be made drop-down type and also divided into 2 or more categories: Item types and thematical types. Or newest item types? Now the list doesn't work for, well, anybody. Schratching here my head: some patrons could use this as an itemtype browsing feature. (Well but this is now off-topic already.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 11:29:59 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 09:29:59 +0000 Subject: [Koha-bugs] [Bug 8192] Update libraries and Missing library in install_misc/ubuntu.packages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8192 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from M. Tompsett --- A similar problem was also dealt with in bug 8489. *** This bug has been marked as a duplicate of bug 8478 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 11:29:59 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 09:29:59 +0000 Subject: [Koha-bugs] [Bug 8478] Update Ubuntu related files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8478 --- Comment #14 from M. Tompsett --- *** Bug 8192 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 11:42:19 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 09:42:19 +0000 Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 --- Comment #130 from Paul Poulain --- Created attachment 11235 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11235&action=edit Bug 7167: New version for updatedatabase This patch use DataTable, see BUG|BZ 6836 - css/datatables.css - lib/jquery/plugins/jquery.dataTables.min.js - js/datatables.js http://bugs.koha-community.org/show_bug.cgi?id=7167 Bug 7167 follow-up Major changes: * creating database tables for update on the fly, the 1st time the update script is called * version is checked on mainpage.pl (and here only). If syspref Version differ from kohaversion.pl, the old updatedatabase is launched. If there are updates missing from new mechanism, the updatedatabase page is reached * kohaversion check on each page is now useless in Auth.pm, removed dead code * Updated installer: at the end of the process, retrieve all updates and automatically mark them "OK", as they're included in installer Minor changes: * adding copyright * adding poddoc * updating a warning, for better clarity * switching from $$var to $var-> * small TT glitch fixed in updatedatabase.tt * about.pl now returns the Version systempreference PLUS all the patches that have been applied Bug 7167 follow-up perlcritic & numbers display & partial apply depending on DEBUG * add use strict to updatedatabase, that is now perlcritic compliant * partial apply of DB revs is now managed by DEBUG env variable = if DEBUG=0, the user can just apply every DBrev. If DEBUG=1, we're in a dev env, the user know has the option to apply DBrevs one by one Display: * in updatedatabase, small spelling changes * in about.pl, remove 0 just after . (3.06.01 is displayed as 3.6.1) * improve the display of applied numbers on about.pl - before this patch, if you have N, N+1, N+2, N+3 and N+10 DB rev applied, about was displaying : , N+1 / N+2 / N+3 / N+10 - after this patch you have N......N+3 / N+10 * add ORDER BY into list_versions_already_knows to have number retrieved in the same order whatever the order they are applied http://bugs.koha-community.org/show_bug.cgi?id=6679 Signed-off-by: Chris Nighswonger Signed-off-by: Paul Poulain -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 11:42:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 09:42:24 +0000 Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 --- Comment #131 from Paul Poulain --- Created attachment 11236 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11236&action=edit Bug 7167: Now, we check versions on mainpage.pl and after login Signed-off-by: Paul Poulain -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 11:42:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 09:42:28 +0000 Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 --- Comment #132 from Paul Poulain --- Created attachment 11237 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11237&action=edit Bug 7167: Improve the update.pl script * Added CLI options to update.pl * Call update.pl from the installer. Signed-off-by: Paul Poulain -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 11:42:34 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 09:42:34 +0000 Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 --- Comment #133 from Paul Poulain --- Created attachment 11238 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11238&action=edit Bug 7167: Reimplementing Marcel's suggestions & fixes * Fixing the bugguy old version check (that was made against 3.0900000 instead of 3.0900027 -the last current kohaversion number * in the CLI script, if there is nothing to report, just say it Signed-off-by: Paul Poulain -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 11:42:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 09:42:39 +0000 Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 --- Comment #134 from Paul Poulain --- Created attachment 11239 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11239&action=edit Bug 7167: Remove check_coherency As suggested by Katrin, we've removed the call to check_coherency. It intended to provide readable comments when some SQL was wrong. Removing this sub result in the SQL error being displayed. That's OK because the sysadmin or the developer can google the error, understand it, then fix it. Signed-off-by: Paul Poulain -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 11:42:46 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 09:42:46 +0000 Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 --- Comment #135 from Paul Poulain --- Created attachment 11240 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11240&action=edit Bug 7167: Changing in .sql parsing We first split on delimiter and then extract comments. You can now put \n for delimiter comments. ex: DELIMITER ; -- this is a comment SELECT * FROM my_table; -- another comment Before this patch, we had to write: DELIMITER ; -- this is a comment; SELECT * FROM my_table; -- another comment; Signed-off-by: Paul Poulain -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 11:42:54 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 09:42:54 +0000 Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 --- Comment #136 from Paul Poulain --- Created attachment 11241 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11241&action=edit Bug 7167: Add .pl and .sql examples Those files are in version directory, so will never be executed by the updater If you want to provide an update, do it in a 3.09/ directory (if your update is expected for 3.10 version) Note that the updater use a md5sum checker. So, if the same update is in 2 different places, it will be detected. That will be handy for changes made on both stable and master: a library running stable will get the update when updating. When upgrading to the next major release, Koha will detect the patch has already been applied, and no error will be thrown. With the previous mechanism, a DBRev ported to stable was re-executed when upgrading to master, resulting in a nasty (but usually harmless) error message Signed-off-by: Paul Poulain -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 11:42:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 09:42:58 +0000 Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 --- Comment #137 from Paul Poulain --- Created attachment 11242 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11242&action=edit Bug 7167: Improve display + factorize get_queries Despite it's size, this patch is dealing with display questions only: * The text "comments" and "queries" was hardcoded in ajax-updatedb-getinfo.pl script. It has been replaced by a JSON call, returning 2 separate values, "comments:" and "queries:" is now in the template, making it translatable * Some minor tweak in the display (like putting things in bold, displaying OK in green, warnings in yellow and KO in red) * Reordering the column headers for more readability: * Status column is merged with availability, column is after status * Status/availability terms more clear: "Not applied" instead of "unknown", "Applied and OK", "Applied and failed", "Applied and forced" are the 3 other statuses * Removed one click to display comments on DBREv not yet applied: before the patch, one had to click "Show details", then "Get comments", now, "Get comments" is enough Signed-off-by: Paul Poulain -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 11:43:03 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 09:43:03 +0000 Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 --- Comment #138 from Paul Poulain --- Created attachment 11243 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11243&action=edit Bug 7167: FIX typos & moving a script to a proper place * renamed availables to available * renamed already_knows to already_applied * fixed FSF & copyright headers * removing a "use strict" because we already had use Modern::Perl * fixed a tiny typo in about.tt * moving update.pl to misc/bin because it's a CLI script Signed-off-by: Paul Poulain -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 11:43:07 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 09:43:07 +0000 Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 --- Comment #139 from Paul Poulain --- Created attachment 11244 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11244&action=edit Bug 7167: Add dependency File::Find::Rule Signed-off-by: Paul Poulain -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 11:43:16 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 09:43:16 +0000 Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 --- Comment #141 from Paul Poulain --- Created attachment 11246 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11246&action=edit Bug 7167 reindentation & removing dead code * The if (! defined $ENV{PERL5LIB}... block was wrongly intented * The 3 lines running update.pl are useless: the update (new mechanism) is run from admin/updatedatabase.pl script. This part of install.pl is run only when you have "old style" DB revisions. Summary: * old mechanism = it's run as previously, by reaching the installer/install.pl?step=3 page, that applies all revisions * new mechanism = when you log-in or reach mainpage.pl, you reach admin/updatedatabase.pl, where you can see what will be run, and run it Tiny side effect = the check for old mechanism is now done *after* authentification (thus it's not done on each page call). It means that the user will have to enter login/password twice : * first to log-in to Koha * second to run installer/updatedatabase.pl?step=3 As the old mechanism is deprecated, we can expect this will happend only a few time in the history of a setup, it's not a big deal. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 11:43:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 09:43:11 +0000 Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 --- Comment #140 from Paul Poulain --- Created attachment 11245 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11245&action=edit Bug 7167: We want to execute non-numeric version with the -all option Dealing with Marcel comment 100: > Note that the current code around line 52/53 does not > handle that correctly: > Argument "\x{74}\x{65}..." isn't numeric in numeric ge (>=) at > installer/data/mysql/update.pl line 52. Now, a non-numeric DBRev will be applied if you provide the --all parameter, without throwing the error Signed-off-by: Paul Poulain -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 11:44:34 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 09:44:34 +0000 Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11222|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 11:44:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 09:44:47 +0000 Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11223|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 11:45:02 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 09:45:02 +0000 Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11224|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 11:45:15 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 09:45:15 +0000 Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11225|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 11:45:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 09:45:28 +0000 Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11226|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 11:45:40 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 09:45:40 +0000 Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11227|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 11:45:53 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 09:45:53 +0000 Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11228|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 11:46:04 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 09:46:04 +0000 Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11229|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 11:46:18 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 09:46:18 +0000 Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11230|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 11:46:32 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 09:46:32 +0000 Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11231|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 11:46:45 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 09:46:45 +0000 Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11232|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 11:50:17 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 09:50:17 +0000 Subject: [Koha-bugs] [Bug 6832] Validation of total > budget in neworderempty In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6832 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |jonathan.druart at biblibre.co | |m --- Comment #9 from Jonathan Druart --- The proposed patch does not apply : fatal: cannot convert from UTF-8utf-8 to UTF-8 Please resubmit this patch well formated. On the way, replace the french commit message ;-) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 11:50:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 09:50:37 +0000 Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 --- Comment #142 from Paul Poulain --- The 12 patches attached does not differ a lot from the 11 attached yesterday: * The " Bug 7167: Reimplementing Marcel's suggestions & fixes" fixes the 3.09.00.028 problem (see comment 129) * The "Bug 7167 reindentation & removing dead code" reindent a block and remove some useless (& bugguy) code I've amended our test plan, so repeating it here: Tests made: ? Start from a clean situation (drop the 3 tables created by the new mechanism drop table updatedb_error;drop table updatedb_query;drop table updatedb_report;) ? Checked that the old updatedatabase is still working by ? adding a 3.09.00.028 update, that is empty ? checked that we're redirected and the update is OK ? Created a 3.09/sample.sql that contains "UPDATE systempreferences SET value='nothing' WHERE variable='NOTHING_TOO';" with a comment "test doing nothing" ? verified that, on mainpage, we're redirected to new updatedatabase ? verified that, trying to acces, unidentified, to a page (in circulation), we're redirected to new updatedatabase ? going to mode DEBUG=1 in Apache config, confirmed that the button "Execute" appears. Checked that DEBUG=0 make the link disappearing ? Tested the 2 sample files (the .sql.sample and the .pl.sample) by copying them in 3.09/ directory ? Checked that Koha displays "2 updates available", let apply both in one click (UPDATE ALL) ? Tested that forcing applying a given update (by manually entering the number: /cgi-bin/koha/admin/updatedatabase.pl?op=update&version=3.09.01.001) result in a message saying it has already been executed ? checked that, if you have 2 files with the same content (ie: same md5sum, but not same name), the installer detect it's a duplicate ? Created an invalid update file, ? Checked that applying it result in a message, with a link to force "mark as applied". ? Checked that the link mark the DBRev as applied and the updater understand it must not bother ? Verified what happen when you have an invalid .pl file that does not even compile ? checked that there is an error thrown ? checked that the Perl error is reported (if the pl is invalid, it means the patch has not been applied, the "librarian" is a developer, displaying the Perl error is relevant) ? checked that you can't "force OK" this error = the .pl must be fixed, no reason to be able to force ? Verified non numeric behaviour ? created a file 3.09/Bug_1234.sql ? Tested that it appears first and can be applied ? Tested that, once the but has been renamed to a number (ie: it has been pushed), Koha detect it's a duplicate already applied ? Possible improvement = if you apply many non-numeric DBRevs because you're testing, they all appear in first place. This can be fixed by removing the entries in tables updatedb_error, updatedb_query, updatedb_report. An improvement could be to have this in the staff interface. For now: ? DELETE FROM updatedb_error WHERE version=?; ? DELETE FROM updatedb_query WHERE version=?; ? DELETE FROM updatedb_report WHERE version=?; ? Checked that, in CLI, misc/bin/updatedb.pl --all execute all available DB updates ? Checked mix of old and new updatedatabase mechanism: ? Applied some new system revisions ? Added some lines in installer/data/mysql/updatedatabase.pl, and checked the old versioning system runs ? Tested that a full install (drop database / create database / run installer.pl) works well -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 11:55:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 09:55:43 +0000 Subject: [Koha-bugs] [Bug 6832] Validation of total > budget in neworderempty In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6832 --- Comment #10 from Katrin Fischer --- Hi Jonathan, this patch will apply if you change the patch file and remove one line: Content-Type: text/plain; charset="utf-8" -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 12:01:54 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 10:01:54 +0000 Subject: [Koha-bugs] [Bug 8544] Make RSS icon styleable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8544 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11234|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 11247 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11247&action=edit Bug 8544 - make the RSS icon CSS-changeable This gives the RSS bits on the search results some CSS classes so it can be modified with CSS or javascript. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 12:02:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 10:02:27 +0000 Subject: [Koha-bugs] [Bug 8544] Make RSS icon styleable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8544 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 12:33:19 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 10:33:19 +0000 Subject: [Koha-bugs] [Bug 8437] Plack and database backup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8437 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dpavlin at rot13.org --- Comment #2 from Paul Poulain --- Dobrica, could you sign-off this one pls ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 12:38:04 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 10:38:04 +0000 Subject: [Koha-bugs] [Bug 8486] Critical error in Koha::Calendar::days_between calculation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8486 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11179|0 |1 is obsolete| | --- Comment #12 from Paul Poulain --- Created attachment 11248 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11248&action=edit Bug 8486 - Follow up making the tests db independent Signed-off-by: Paul Poulain Makes the test db independant by specifying the date format. Thus, there is no call to ->preference() that retrieve a systempreference -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 12:38:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 10:38:39 +0000 Subject: [Koha-bugs] [Bug 8486] Critical error in Koha::Calendar::days_between calculation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8486 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #13 from Paul Poulain --- Patch signed off. Will also pass QA and push in one go, trivial & valid fix -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 12:38:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 10:38:47 +0000 Subject: [Koha-bugs] [Bug 8486] Critical error in Koha::Calendar::days_between calculation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8486 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 12:39:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 10:39:11 +0000 Subject: [Koha-bugs] [Bug 8486] Critical error in Koha::Calendar::days_between calculation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8486 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #14 from Paul Poulain --- Follow-up making the tests db independant pushed on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 12:39:04 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 10:39:04 +0000 Subject: [Koha-bugs] [Bug 8408] Odd OPAC message when OPAC Renewals are disabled and OPACFineNoRenewals is set to blank In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8408 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart at biblibre.co | |m --- Comment #6 from Jonathan Druart --- This patch fixes the reported issue. Marking as Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 13:31:53 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 11:31:53 +0000 Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 --- Comment #143 from M. de Rooy --- (In reply to comment #126) > Hi Paul and Jonathan, I know that you have put a lot of work and thought > into this, but it is a big change in a critical area. I would like to see > this pass QA first before being pushed. 1 day (tomorrow, if you want to push > on Thursday) seems a very short amount of time for the QA team or for anyone > who wants to follow your test plan. If we deviate from the standard workflow, please check with the community or dev list first. Note also that many hours have been spent on QA+ing several versions of this development, but it never reached the final status yet (although I certainly hope that it will!). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 13:36:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 11:36:29 +0000 Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 --- Comment #144 from M. de Rooy --- Just from glancing through some code: + # check if you're uptodate, and if you're not, head to updater + my $koha39 =~ "3.0900000"; Should this be an assignment? Note that I also corrected this before. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 13:37:30 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 11:37:30 +0000 Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 --- Comment #145 from M. de Rooy --- (In reply to comment #144) > Just from glancing through some code: > + # check if you're uptodate, and if you're not, head to updater > + my $koha39 =~ "3.0900000"; > > Should this be an assignment? Note that I also corrected this before. Maybe too fast. Seems to be corrected by another patch... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 13:48:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 11:48:41 +0000 Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 --- Comment #146 from Paul Poulain --- (In reply to comment #143) > (In reply to comment #126) > > Hi Paul and Jonathan, I know that you have put a lot of work and thought > > into this, but it is a big change in a critical area. I would like to see > > this pass QA first before being pushed. 1 day (tomorrow, if you want to push > > on Thursday) seems a very short amount of time for the QA team or for anyone > > who wants to follow your test plan. > > If we deviate from the standard workflow, please check with the community or > dev list first. Note also that many hours have been spent on QA+ing several > versions of this development, but it never reached the final status yet > (although I certainly hope that it will!). As I've announced already, i'll be afk for 3 weeks, on friday. passed QA or not, I think/feel it's unwise to push such a patch just before leaving. If something goes wrong, everybody will be scared (including me !) So I won't push this patch before coming back from holiday. (In reply to comment #145) > > Should this be an assignment? Note that I also corrected this before. > > Maybe too fast. Seems to be corrected by another patch... I hesitated to squash all patches or have follow-ups to clearly point the differences. I choose to keep follow-ups. I feel this question is an unsolvable one... both options have their advantages and their limits... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 13:54:15 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 11:54:15 +0000 Subject: [Koha-bugs] [Bug 8233] New search engine layer - introduce solr without breaking anything else In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8233 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #36 from Paul Poulain --- QA comment: tiny follow-up to please jenkins, passed QA (but I agree it's a workaround, valid because solr is experimental) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 13:54:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 11:54:24 +0000 Subject: [Koha-bugs] [Bug 8233] New search engine layer - introduce solr without breaking anything else In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8233 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 14:10:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 12:10:14 +0000 Subject: [Koha-bugs] [Bug 8533] Non-numeric cardnumbers screw up autoMemberNum In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8533 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #4 from Jonathan Druart --- Hi Kyle, I can't reproduce the issue without your patch. I am under the impression, your patch is useless: mysql> SELECT CAST( "P13000" AS SIGNED ); +----------------------------+ | CAST( "P13000" AS SIGNED ) | +----------------------------+ | 0 | +----------------------------+ Indeed, a non-numeric cast as SIGNED is equal to 0 Maybe I missed something ? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 14:11:06 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 12:11:06 +0000 Subject: [Koha-bugs] [Bug 8407] xt/tt_valid.t is too strict In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8407 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #12 from Paul Poulain --- chris, could you describe the exact tests you made. I did the following: in memberentrygen.tt, replaced [% IF ( categoryloo.categorycodeselected ) %] [% ELSE %] by in english, no problems. then ./translate update fr-FR translate blablabla into bliblibli then ./translate install fr-FR switching to english, I get a very nasty: Template process failed: file error - parse error - /home/paul/koha.dev/koha-community/koha-tmpl/intranet-tmpl/prog/fr-FR/modules/members/memberentrygen.tt line 520: unexpected token (%) [% "[%">[% categoryloo.categoryname %] at /home/paul/koha.dev/koha-community/C4/Templates.pm line 127. at /home/paul/koha.dev/koha-community/members/memberentry.pl line 842 Checking the french templates, I see: [% FOREACH typeloo IN typeloop %] [% FOREACH categoryloo IN typeloo.categoryloop %] [% IF ( loop.first ) %] [% IF ( typeloo.typename_C ) %][% END %] [% IF ( typeloo.typename_A ) %][% END %] [% IF ( typeloo.typename_S ) %][% END %] [% IF ( typeloo.typename_I ) %][% END %] [% IF ( typeloo.typename_P ) %][% END %] [% IF ( typeloo.typename_X ) %][% END %] [% END %] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 14:11:07 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 12:11:07 +0000 Subject: [Koha-bugs] [Bug 8533] Non-numeric cardnumbers screw up autoMemberNum In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8533 --- Comment #5 from Jonathan Druart --- However, mysql raises a warning with the previous query: | Warning | 1292 | Truncated incorrect INTEGER value: 'P13000' | Which it does not exist with your patch. Then I will sign off your patch :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 14:12:07 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 12:12:07 +0000 Subject: [Koha-bugs] [Bug 8533] Non-numeric cardnumbers screw up autoMemberNum In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8533 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11221|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 11249 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11249&action=edit Bug 8533 - Non-numeric cardnumbers screw up autoMemberNum Signed-off-by: Jonathan Druart Removes a warning from mysql: Truncated incorrect INTEGER value: 'P13000' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 14:12:31 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 12:12:31 +0000 Subject: [Koha-bugs] [Bug 8533] Non-numeric cardnumbers screw up autoMemberNum In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8533 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 14:15:40 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 12:15:40 +0000 Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 --- Comment #147 from Jared Camins-Esakov --- I had a thought on this. Would it be possible to change the code to figure out the highest version in updatedatabase programmatically rather than hardcoding it in? It seems to me that pushing it when you get back would be a lot easier if you didn't have to edit the patch on your return and/or change the database update methods for all patches that have passed QA by then. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 14:16:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 12:16:37 +0000 Subject: [Koha-bugs] [Bug 8407] xt/tt_valid.t is too strict In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8407 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 14:17:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 12:17:14 +0000 Subject: [Koha-bugs] [Bug 8407] xt/tt_valid.t is too strict In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8407 --- Comment #13 from Paul Poulain --- (In reply to comment #12) > switching to english, I get a very nasty: One must read "switching to french, I get a very nasty:...3 In english, everything is OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 14:18:30 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 12:18:30 +0000 Subject: [Koha-bugs] [Bug 8547] New: Enabling star ratings causes javascript errors that cause IE to have a boo boo Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8547 Priority: P5 - low Change sponsored?: --- Bug ID: 8547 Assignee: oleonard at myacpl.org Summary: Enabling star ratings causes javascript errors that cause IE to have a boo boo Severity: enhancement Classification: Unclassified OS: All Reporter: robin at catalyst.net.nz Hardware: All Status: NEW Version: rel_3_8 Component: OPAC Product: Koha I think this is due to a trailing comma in a list. Real browser are OK with it, but IE is dumb. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 14:19:16 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 12:19:16 +0000 Subject: [Koha-bugs] [Bug 8547] Enabling star ratings causes javascript errors that cause IE to have a boo boo In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8547 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P2 Status|NEW |ASSIGNED Change sponsored?|--- |Sponsored Assignee|oleonard at myacpl.org |robin at catalyst.net.nz Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 14:20:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 12:20:25 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11145|0 |1 is obsolete| | --- Comment #51 from Paul Poulain --- Comment on attachment 11145 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11145 [SIGNED-OFF] Bug 7143: Updating history and about file This patch has been pushed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 14:20:38 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 12:20:38 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 14:22:00 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 12:22:00 +0000 Subject: [Koha-bugs] [Bug 8548] New: overdue report not sortable by call number Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8548 Priority: P5 - low Change sponsored?: --- Bug ID: 8548 CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Assignee: koha-bugs at lists.koha-community.org Summary: overdue report not sortable by call number Severity: normal Classification: Unclassified OS: All Reporter: nengard at gmail.com Hardware: All Status: NEW Version: master Component: Circulation Product: Koha The overdue report (cgi-bin/koha/circ/overdue.pl) has sort options in the filters but call number isn't there and it does appear on the report so it should be a column you can sort on. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 14:22:54 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 12:22:54 +0000 Subject: [Koha-bugs] [Bug 8407] xt/tt_valid.t is too strict In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8407 --- Comment #14 from Katrin Fischer --- I guess that proves that the problem still exists with TT :( So we shouldn't change the test and fix the templates. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 14:38:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 12:38:37 +0000 Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 --- Comment #148 from Paul Poulain --- (In reply to comment #147) > I had a thought on this. Would it be possible to change the code to figure > out the highest version in updatedatabase programmatically rather than > hardcoding it in? It seems to me that pushing it when you get back would be > a lot easier if you didn't have to edit the patch on your return and/or > change the database update methods for all patches that have passed QA by > then. That's what we'd like to do, but failed to find how. If you've an idea... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 14:40:05 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 12:40:05 +0000 Subject: [Koha-bugs] [Bug 6151] IndependantBranches and HomeOrHoldingBranchReturn can prevent items from being checked in In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6151 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6701|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall --- Created attachment 11250 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11250&action=edit Bug 6151: Add AllowReturnToBranch system preference In order to solve the issue of IndependantBranches being incompatible with HomeOrHoldingBranchReturn, this patch changes the mechanism by which the question "can I return this material here?" is answered. Before, the conditions were "if IndependantBranches is on, and this branch isn't HomeOrHoldingBranchReturn for the item, then no, otherwise yes". Now, the question is answered by consulting CanBookBeReturned (new subroutine) New system preference: AllowReturnToBranch Possible values: - anywhere (default for new installs, and for existing systems with IndependantBranches turned off) - homebranch - holdingbranch (which is also the issuing branch in all normal circumstances) - homeorholdingbranch (default for existing systems with IndependantBranches turned on) New subroutine: CanBookBeReturned Input: $item hash (from GetItems), and $branchcode Output: 0 or 1 to indicate "allowed" or not, and an optional message if not allowed. Message is the 'correct' branchcode to return the material to To Test: 1. Install patch and new syspref 2. Check that default value of the preference: - if IndependantBranches was OFF at install time, should be 'anywhere' - if IndependantBranches was ON at install time, should be 'homeorholdingbranch' Case: 'anywhere' 1. Checkout a Library A book at Library A. Return at Library A should be successful 2. Repeat step 1, returning to Library B. Return should be successful 3. Checkout a Library A book at Library B. Return to A should be successful 4. Repeat step 3 with Library B and Library C Case: 'homebranch' 1. Checkout a Library A book at Library A. Return at Library A should be successful 2. Repeat step 1, returning to Library B. Return should FAIL (returning message to return at A) 3. Checkout a Library A book at Library B. Return to Library A should be successful 4. Repeat step 3 with Library B and Library C. Both should FAIL (returning message to return at A) Case: 'holdingbranch' 1. Checkout a Library A book at Library A. Return at Library A should be successful 2. Repeat step 1, returning to Library B. Return should FAIL (returning message to return at A) 3. Checkout a Library A book at Library B. Return to A should FAIL (returning message to return at B) 4. Repeat step 3 with Library B. Return should be successful 5. Repeat step 3 with Library C. Return should FAIL (returning message to return at B) Case: 'homeorholdingbranch' 1. Checkout a Library A book at Library A. Return at Library A should be successful 2. Repeat step 1, returning to Library B. Return should FAIL (returning message to return at A) 3. Checkout a Library A book at Library B. Return to A should be successful 4. Repeat step 3 with Library B. Return should be successful 5. Repeat step 3 with Library C. Return should FAIL (returning message to return at A) Signed-off-by: Chris Cormack -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 14:41:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 12:41:47 +0000 Subject: [Koha-bugs] [Bug 8206] Add additional search options to authority browser in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8206 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 14:45:01 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 12:45:01 +0000 Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 --- Comment #149 from Jared Camins-Esakov --- (In reply to comment #148) > That's what we'd like to do, but failed to find how. If you've an idea... Wouldn't just searching for the last occurrence of /^\$DBversion =/ and then evaluating that line do it? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 14:47:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 12:47:09 +0000 Subject: [Koha-bugs] [Bug 5327] Unit tests required for all C4 modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 --- Comment #199 from Paul Poulain --- (In reply to comment #195) > Created attachment 11186 [details] > Patch of 'ItemType.t' - added a few tests Hi Bart, just for information = your git config is not correct. Git says that submit patches with a mail address of : From: Bart Jorgensen I suspect it's not your real mail address ;-) Check here to fix it: http://wiki.koha-community.org/wiki/Version_Control_Using_Git#Fill_some_parameters Could you resubmit with a valid mail address please ? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 14:53:44 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 12:53:44 +0000 Subject: [Koha-bugs] [Bug 8547] Enabling star ratings causes javascript errors that cause IE to have a boo boo In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8547 --- Comment #1 from Robin Sheat --- Seeing this issue seems to be a bit hit and miss, I haven't worked out the combination of parameters that causes it, just that sometimes it'll happen and sometimes it won't (even with the same browser.) I suspect it's to do with the order that certain ajax loads take place relative to JS rendering. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 14:56:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 12:56:24 +0000 Subject: [Koha-bugs] [Bug 8547] Enabling star ratings causes javascript errors that cause IE to have a boo boo In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8547 --- Comment #2 from Robin Sheat --- Created attachment 11251 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11251&action=edit Bug 8547 - JS error in star ratings breaks IE Writing code with best practices in mind breaks IE. Thanks Internet Explorer. Now go DiaF. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 14:58:02 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 12:58:02 +0000 Subject: [Koha-bugs] [Bug 8405] add IntranetBiblioDefaultView and BiblioDefaultView to XSLT.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8405 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 14:58:04 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 12:58:04 +0000 Subject: [Koha-bugs] [Bug 8405] add IntranetBiblioDefaultView and BiblioDefaultView to XSLT.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8405 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10741|0 |1 is obsolete| | --- Comment #2 from Jared Camins-Esakov --- Created attachment 11252 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11252&action=edit Bug 8405 : add IntranetBiblioDefaultView and BiblioDefaultView in XSLT.pm Signed-off-by: Jared Camins-Esakov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 14:59:34 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 12:59:34 +0000 Subject: [Koha-bugs] [Bug 8204] Authority viewer in OPAC ugly, unfriendly, and mostly useless In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8204 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #29 from Paul Poulain --- follow-up pushed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 14:59:38 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 12:59:38 +0000 Subject: [Koha-bugs] [Bug 7067] allow patron self registration via the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 --- Comment #11 from koala --- I have simply created a html and php page that speaks with the db. It would have been better if it was in perl and in the koha package, but I need to find some time to get more used with the koha implementation. Regardless, if you'd like, I could share the info here, i.e. the html and php pages. Cheers -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 15:00:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 13:00:11 +0000 Subject: [Koha-bugs] [Bug 6617] table of contents not printing right if entered right In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6617 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |jcamins at cpbibliography.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 15:02:07 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 13:02:07 +0000 Subject: [Koha-bugs] [Bug 8547] Enabling star ratings causes javascript errors that cause IE to have a boo boo In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8547 --- Comment #3 from Robin Sheat --- This patch is based on a hunch of what the issue is and is still waiting for someone who has IE to test it for me, but if anyone else is interested, here's what it looks like when it's going bad: http://i.imgur.com/Jhc3z.jpg -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 15:04:13 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 13:04:13 +0000 Subject: [Koha-bugs] [Bug 7417] Include alternate forms from authorities in bibliographic searches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7417 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11028|0 |1 is obsolete| | --- Comment #2 from Jared Camins-Esakov --- Created attachment 11253 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11253&action=edit Bug 7417: Include see from references in bibliographic searches This patch adds the Koha::Indexer::RecordNormalizer and Koha::Indexer::MARC::RecordNormalizer::EmbedSeeFromHeadings packages to enable the inclusion of alternate forms of headings in bibliographic searches. When the new syspref IncludeSeeFromInSearches is turned on (default is off) rebuild_zebra.pl will insert see from headings from authority records into bibliographic records when indexing, so that a search on an obsolete term will turn up relevant records. To test: 1) Enable IncludeSeeFromInSearches 2) Add a heading that has an alternate form to a record (for example, "Cooking" has the alternate form "Cookery," if you have authority records from LC) 3) Index the zebraqueue (or reindex if you haven't indexed your system yet) 4) Confirm that if you search for "Cookery" you get the record you just modified Signed-off-by: Jared Camins-Esakov Rebased on master 1 August 2012 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 15:12:00 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 13:12:00 +0000 Subject: [Koha-bugs] [Bug 8332] Add relationships to auth_finder for authority links In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8332 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10724|0 |1 is obsolete| | --- Comment #3 from Jared Camins-Esakov --- Created attachment 11254 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11254&action=edit Bug 8332: Add relationships to auth_finder for authority links In addition to the work in bug 8207 that enables auth_finder use, it would be very useful when creating authorities to have the auth_finder plugin automatically fill out the relationship information in $w (in MARC21). To test (note that you must either apply the patch for bug 8207 or manually add a thesaurus to a 5xx linking field in one of the authority type frameworks): 1. Create a new authority record. 2. Go to the 5xx tab. 3. Click the authority control plugin ellipsis. 4. Do a search for an authority. 5. Select a relationship type. 6. Note that after you choose an authority, that the $w control field is automatically populated with the relationship type. Signed-off-by: Fr?d?ric Demians After applying patch for bug 8207, I had been able to follow the test plan step by step, and get the expected result. Signed-off-by: Jared Camins-Esakov Rebased on master 1 August 2012 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 15:13:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 13:13:49 +0000 Subject: [Koha-bugs] [Bug 8332] Add relationships to auth_finder for authority links In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8332 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|frederic at tamil.fr |jcamins at cpbibliography.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 15:26:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 13:26:29 +0000 Subject: [Koha-bugs] [Bug 8407] xt/tt_valid.t is too strict In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8407 --- Comment #15 from Jonathan Druart --- Problem is in routine text_replace_tag (tmpl_process3.pl). I don't know how we can fix it :-/ I abandon this bug (for now...) and will submit a patch for Bug 8385 ;-( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 15:26:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 13:26:49 +0000 Subject: [Koha-bugs] [Bug 8207] Modify authority type frameworks to allow see also fields to link to thesauri In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8207 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact| |paul.poulain at biblibre.com --- Comment #9 from Paul Poulain --- OK, I understood the origin of my comment 6. I was wrong, everything is OK. Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 15:28:04 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 13:28:04 +0000 Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 --- Comment #150 from Chris Nighswonger --- (In reply to comment #149) > (In reply to comment #148) > > That's what we'd like to do, but failed to find how. If you've an idea... > > Wouldn't just searching for the last occurrence of /^\$DBversion =/ and then > evaluating that line do it? I think this is a great idea if it can be implemented. Hardcoding-- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 15:30:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 13:30:29 +0000 Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 --- Comment #151 from Chris Nighswonger --- (In reply to comment #146) > (In reply to comment #143) > > (In reply to comment #126) > > > Hi Paul and Jonathan, I know that you have put a lot of work and thought > > > into this, but it is a big change in a critical area. I would like to see > > > this pass QA first before being pushed. 1 day (tomorrow, if you want to push > > > on Thursday) seems a very short amount of time for the QA team or for anyone > > > who wants to follow your test plan. > > > > If we deviate from the standard workflow, please check with the community or > > dev list first. Note also that many hours have been spent on QA+ing several > > versions of this development, but it never reached the final status yet > > (although I certainly hope that it will!). > > As I've announced already, i'll be afk for 3 weeks, on friday. passed QA or > not, I think/feel it's unwise to push such a patch just before leaving. If > something goes wrong, everybody will be scared (including me !) > > So I won't push this patch before coming back from holiday. I will also be afk until Monday beginning tomorrow, so I will not be able to continue testing and sign-off until then. I'd really like to be able to go through this test plan completely as well as read through the code another time before signing off. Paul, I'll touch base with you Monday. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 15:31:08 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 13:31:08 +0000 Subject: [Koha-bugs] [Bug 8207] Modify authority type frameworks to allow see also fields to link to thesauri In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8207 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |magnus at enger.priv.no Version|master |rel_3_10 --- Comment #10 from Paul Poulain --- Patch pushed, does nothing for UNIMARC, as expected Added Magnus to this bug = Magnus, this patch changes something when upgrading a NORMARC setup. OTOH, it does not change the default NORMARC frameworks. I feel there's a follow-up for NORMARC that could be useful ;-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 15:33:55 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 13:33:55 +0000 Subject: [Koha-bugs] [Bug 7412] Pre-filling items in cataloguing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7412 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #27 from M. de Rooy --- (In reply to comment #26) > I see that this report lost its signoff. Could you clarify, mtj? > IMO it is still at signed off and I will continue with this report soon. No response: resetting status to Signed off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 15:35:17 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 13:35:17 +0000 Subject: [Koha-bugs] [Bug 8485] Make koha_perl_deps.pl batch friendly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8485 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11220|0 |1 is obsolete| | --- Comment #4 from Tom?s Cohen Arazi --- Created attachment 11255 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11255&action=edit Bug 8485 - Make koha_perl_deps.pl batch friendly Added a -b flag for brief which outputs only the perl library name (Foo::BaR), and added a -r flag for required which filters the list to required=Yes perl libraries. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 15:35:36 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 13:35:36 +0000 Subject: [Koha-bugs] [Bug 3462] Link see alsos in authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3462 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11147|0 |1 is obsolete| | --- Comment #12 from Jared Camins-Esakov --- Created attachment 11256 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11256&action=edit Bug 3462: Links in authorities should be hyperlinks Make see also links in both the OPAC and authority module search results into hyperlinks and not just textual strings. To test: 1. Do a search for an authority that will bring up a heading with a see also reference in the staff client and the OPAC. 2. Confirm that the see also references listed in the search results are now hyperlinks, which work. Bug 3462: quiet warn Quiets an unnecessary warning about an uninitialized value. Signed-off-by: Katrin Fischer Patch works nicely and is a great improvement. Tests: - Checked links for existing and non existing "see alsos" give correct search results - Verified links show up for all "see alsos" in a result list - Verified links are properly linked with the correct names - Checked logs don't show errors Signed-off-by: Jared Camins-Esakov Rebased 26 July 2012 Signed-off-by: Jared Camins-Esakov Rebased on master 1 August 2012 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 15:38:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 13:38:27 +0000 Subject: [Koha-bugs] [Bug 8547] Enabling star ratings causes javascript errors that cause IE to have a boo boo In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8547 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Component|OPAC |Browser compatibility --- Comment #4 from Owen Leonard --- For what it's worth, I don't see this problem in IE9 on Windows 7. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 15:41:08 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 13:41:08 +0000 Subject: [Koha-bugs] [Bug 8385] searchengine/solr/indexes.tt fails 'prove ./xt/tt_valid.t' test In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8385 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10916|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 11257 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11257&action=edit Bug 8385: Dirty patch to make tt_valid.t happy A problem in routine text_replace_tag (tmpl_process3.pl) have to be fixed to prevent this kind of dirty patch :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 15:41:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 13:41:29 +0000 Subject: [Koha-bugs] [Bug 8385] searchengine/solr/indexes.tt fails 'prove ./xt/tt_valid.t' test In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8385 Bug 8385 depends on bug 8407, which changed state. Bug 8407 Summary: xt/tt_valid.t is too strict http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8407 What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |LATER -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 15:41:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 13:41:28 +0000 Subject: [Koha-bugs] [Bug 8407] xt/tt_valid.t is too strict In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8407 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |LATER -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 15:41:50 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 13:41:50 +0000 Subject: [Koha-bugs] [Bug 8385] searchengine/solr/indexes.tt fails 'prove ./xt/tt_valid.t' test In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8385 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 15:42:16 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 13:42:16 +0000 Subject: [Koha-bugs] [Bug 2060] Ability to import Authorities from Staff Client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2060 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10900|0 |1 is obsolete| | --- Comment #11 from Jared Camins-Esakov --- Created attachment 11258 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11258&action=edit Bug 7475: Update configuration In order to make matching rules more useful for MARC21 authorities, this patch adds special indexes on previous see-from headings and LCCN. This patch does not change UNIMARC authority configuration in any way. Also modifies the Koha schema in preparation for adding authority import and matching to the Staging tools. To install: 1. Run installer/data/mysql/atomicupdate/importauthorities.pl 2. Update the following four files in your koha-dev: etc/zebradb/authorities/etc/bib1.att etc/zebradb/marc_defs/marc21/authorities/authority-koha-indexdefs.xml etc/zebradb/marc_defs/marc21/authorities/authority-zebra-indexdefs.xsl etc/zebradb/xsl/koha-indexdefs-to-zebra.xsl 3. Reindex your authorities: misc/migration_tools/rebuild_zebra.pl -a -r -v NOTE TO RM: this patch adds an atomicupdate file that needs to be incorporated into updatedatabase.pl if bug 7167 is not pushed. http://bugs.koha-community.org/show_bug.cgi?id=2060 Signed-off-by: Elliott Davis Signed-off-by: Jared Camins-Esakov Rebased on master 1 August 2012 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 15:42:34 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 13:42:34 +0000 Subject: [Koha-bugs] [Bug 2060] Ability to import Authorities from Staff Client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2060 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10901|0 |1 is obsolete| | --- Comment #12 from Jared Camins-Esakov --- Created attachment 11259 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11259&action=edit Bug 7475: Teach matching rules to handle authorities * Add the code necessary to handle authorities with matching rules and import batches. * Update all the scripts that use the matcher and import batch code to use the new API. * Add authority records to the matching rules interface in the staff client. http://bugs.koha-community.org/show_bug.cgi?id=2060 Signed-off-by: Elliott Davis -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 15:42:42 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 13:42:42 +0000 Subject: [Koha-bugs] [Bug 8546] Error in description of OPAC Advanced Search Publication date range search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8546 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|OPAC Advanced Search |Error in description of |Publication date range |OPAC Advanced Search |guide text FAIL |Publication date range | |search -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 15:42:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 13:42:49 +0000 Subject: [Koha-bugs] [Bug 2060] Ability to import Authorities from Staff Client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2060 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10902|0 |1 is obsolete| | --- Comment #13 from Jared Camins-Esakov --- Created attachment 11260 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11260&action=edit Bug 2060: Update command line MARC import scripts Expose authority import functionality to the command line import scripts, and rename them from commit_biblios_file.pl and stage_biblios_file.pl to commit_file.pl and stage_file.pl. To test (note that these instructions assume you have a MARC21 installation and are using the provided sample file): 1. Find a file of authorities (a sample file with MARC21 authorities is attached to bug 7475) and download it to your server 2. Stage the file using the following command (replace with the name of the file you saved in step 1): > misc/stage_file.pl --file --authorities 3. Note the batch number the script assigns to your batch 4. Commit the records using the following command (replace with the batch number you made note of in step 3): > misc/commit_file.pl --batch-number 5. Index the authorities Zebraqueue (or wait) 6. Confirm that the new authorities appear. 7. Create a matching rule with the following settings: Code: AUTHTEST Description: Personal name main entry Match threshold: 999 Record type: Authority record Search index: Heading-main Score: 1000 Tag: 100 Subfields: a Offset: 0 Length: 0 (note the ID of this matching rule) 8. Stage the authority file again, this time using the following command: > misc/stage_file.pl --file --authorities \ --match 7. Revert the import with the following command: > misc/commit_file.pl --batch-number --revert 8. Index the authorities Zebraqueue (or wait) 9. Confirm that the records have been removed 10. Import an authority record with the Stage MARC/Manage staged MARC tools in exactly the way you would for a bibliographic record, but choose "Authority" instead of "Bibliographic" for the record type. Signed-off-by: Elliott Davis Testing plan delivers as it should. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 15:45:30 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 13:45:30 +0000 Subject: [Koha-bugs] [Bug 8405] add IntranetBiblioDefaultView and BiblioDefaultView to XSLT.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8405 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart at biblibre.co | |m --- Comment #3 from Jonathan Druart --- Simple patch, adds 2 sysprefs for xslts. Marking as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 16:04:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 14:04:28 +0000 Subject: [Koha-bugs] [Bug 8547] Enabling star ratings causes javascript errors that cause IE to have a boo boo In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8547 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #5 from Katrin Fischer --- I was testing IE 8 on Windows 7 and saw it sometimes. Most of the time it happened after closing the browser completely and going to the detail page directly following a link from my bookmarks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 16:07:22 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 14:07:22 +0000 Subject: [Koha-bugs] [Bug 7955] Statistics tab in patron module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7955 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #31 from Paul Poulain --- QA comment: small follow-up required to have the feature working. passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 16:07:31 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 14:07:31 +0000 Subject: [Koha-bugs] [Bug 7955] Statistics tab in patron module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7955 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 16:19:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 14:19:33 +0000 Subject: [Koha-bugs] [Bug 8498] can't specify an hour when specifying due date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8498 --- Comment #10 from Paul Poulain --- QA Comment: * Owen/Kyle, I need a confirmation: is the upgrade - * jQuery UI CSS Framework 1.8.20 + * jQuery UI CSS Framework 1.8.22 needed, why ? are you sure it's harmless ? * If you don't use hourly loans, is it possible not to have the hour/minute picker ? (not sure) Other than this, nothing against a passed QA status -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 16:23:12 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 14:23:12 +0000 Subject: [Koha-bugs] [Bug 8532] Old/iffy data causes error checking out In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8532 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11216|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 11261 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11261&action=edit Bug 8532 - improve robustness when converting dates If undef is passed to the date format conversion function, it dies. This can happen when you have old data in the database. Better to handle it in some fashion rather than die, so now it just returns undef too. Signed-off-by: Jonathan Druart I replace "return undef" with just "return" to pass perlcritic -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 16:23:26 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 14:23:26 +0000 Subject: [Koha-bugs] [Bug 8532] Old/iffy data causes error checking out In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8532 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 16:26:23 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 14:26:23 +0000 Subject: [Koha-bugs] [Bug 8498] can't specify an hour when specifying due date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8498 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #11 from Katrin Fischer --- Hi Paul, I think at the moment we don't have a system prefernce for hourly loans, so to not see the minutes the system would have to check the circulation rules? I would like it a bit better too, if it possible to easily differentiate between loans in days and hourly loans. For example I think 'normal' loans shouldn't display the minute part, as it will probably be confusing to some libraries. But probably way out of scope for this bug :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 16:30:30 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 14:30:30 +0000 Subject: [Koha-bugs] [Bug 8268] Koha should offer way to backup entire db In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8268 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11208|0 |1 is obsolete| | --- Comment #36 from Jonathan Druart --- Created attachment 11262 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11262&action=edit Bug 8268: improve error checking Valid download attempts were being denied thanks to an incorrect regular expression. This patch fixes that, and makes it easier to understand what's going on in the code. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 16:30:56 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 14:30:56 +0000 Subject: [Koha-bugs] [Bug 8268] Koha should offer way to backup entire db In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8268 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 16:39:30 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 14:39:30 +0000 Subject: [Koha-bugs] [Bug 5600] Bulk MARC biblio export script In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5600 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #18 from Paul Poulain --- QA comment: running this script under plack, on the web interface does not work at all. I get a nasty: An Error Occurred 500 Internal Server Error In the log, I can see: Variable "$backupdir" is not available at /home/paul/koha.dev/koha-community/tools/export.pl line 452. Unknown option: port Unknown option: i Unknown option: i Unknown option: e Unknown option: reload Trying to reload the page result in CPU being 100% used, Firefox waiting for a long long time, There is no problem in CGI mode -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 16:41:15 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 14:41:15 +0000 Subject: [Koha-bugs] [Bug 5357] Subscription search and displays In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5357 Corinne HAYET changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |corinne.hayet at bulac.fr --- Comment #2 from Corinne HAYET --- ISSN and Bookseller search don't work -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 16:41:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 14:41:33 +0000 Subject: [Koha-bugs] [Bug 5600] Bulk MARC biblio export script In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5600 --- Comment #19 from Jared Camins-Esakov --- (In reply to comment #18) > QA comment: running this script under plack, on the web interface does not > work at all. > > I get a nasty: > An Error Occurred > > 500 Internal Server Error > > In the log, I can see: > Variable "$backupdir" is not available at > /home/paul/koha.dev/koha-community/tools/export.pl line 452. > Unknown option: port > Unknown option: i > Unknown option: i > Unknown option: e > Unknown option: reload > > Trying to reload the page result in CPU being 100% used, Firefox waiting for > a long long time, > There is no problem in CGI mode There is a patch to fix this on another bug. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 16:47:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 14:47:11 +0000 Subject: [Koha-bugs] [Bug 5357] Subscription search and displays In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5357 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #3 from Paul Poulain --- Patch tested with a sandbox, by Corinne HAYET -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 16:47:26 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 14:47:26 +0000 Subject: [Koha-bugs] [Bug 5357] Subscription search and displays In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5357 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10433|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 16:47:31 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 14:47:31 +0000 Subject: [Koha-bugs] [Bug 5357] Subscription search and displays In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5357 --- Comment #4 from Paul Poulain --- Created attachment 11263 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11263&action=edit Bug 5357: Adds a new page for searching subscriptions Test plan: - go on the serial module - click on the 'Advanced search' link (right of subscriptions search in the header) - Search subscriptions (by ISSN, title, EAN, Publisher, Supplier and/or Branch) - Check results are correct Signed-off-by: Corinne HAYET -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 16:48:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 14:48:11 +0000 Subject: [Koha-bugs] [Bug 5357] Subscription search and displays In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5357 --- Comment #5 from Paul Poulain --- Patch tested with a sandbox, by Corinne HAYET -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 16:48:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 14:48:25 +0000 Subject: [Koha-bugs] [Bug 5357] Subscription search and displays In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5357 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11263|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 16:48:32 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 14:48:32 +0000 Subject: [Koha-bugs] [Bug 5357] Subscription search and displays In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5357 --- Comment #6 from Paul Poulain --- Created attachment 11264 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11264&action=edit Bug 8443: Suggestions publication year and copyright date Signed-off-by: Corinne HAYET -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 16:49:12 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 14:49:12 +0000 Subject: [Koha-bugs] [Bug 5357] Subscription search and displays In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5357 --- Comment #7 from Paul Poulain --- Patch tested with a sandbox, by Corinne HAYET -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 16:49:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 14:49:25 +0000 Subject: [Koha-bugs] [Bug 5357] Subscription search and displays In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5357 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11264|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 16:49:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 14:49:29 +0000 Subject: [Koha-bugs] [Bug 5357] Subscription search and displays In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5357 --- Comment #8 from Paul Poulain --- Created attachment 11265 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11265&action=edit Bug 8443: Suggestions publication year and copyright date Signed-off-by: Corinne HAYET http://bugs.koha-community.org/show_bug.cgi?id=5357 Signed-off-by: Corinne HAYET -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 16:50:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 14:50:10 +0000 Subject: [Koha-bugs] [Bug 5357] Subscription search and displays In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5357 --- Comment #9 from Paul Poulain --- Patch tested with a sandbox, by Corinne HAYET -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 16:50:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 14:50:24 +0000 Subject: [Koha-bugs] [Bug 5357] Subscription search and displays In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5357 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11265|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 16:50:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 14:50:29 +0000 Subject: [Koha-bugs] [Bug 5357] Subscription search and displays In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5357 --- Comment #10 from Paul Poulain --- Created attachment 11266 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11266&action=edit Bug 8443: Suggestions publication year and copyright date Signed-off-by: Corinne HAYET http://bugs.koha-community.org/show_bug.cgi?id=5357 Signed-off-by: Corinne HAYET -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 16:53:04 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 14:53:04 +0000 Subject: [Koha-bugs] [Bug 7412] Pre-filling items in cataloguing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7412 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #28 from M. de Rooy --- QA Comment: General One pref instead of two prefs would probably be better in terms of managing the number of prefs. But this may be just easier in use. (No blocker) sub removeFieldsForPrefill Somewhat theoretical, but if you would not use barcode and disconnected that field from 952, the function will not work. (No blocker for me) Cookie > This feature keeps track of what to prefill from one session to another (both in time and user: > if the user disconnects and reconnects, the values are still prefilled. > If a user disconnects and another user logs in, the values are still prefilled.). You assume that the user runs under the same OS credentials. But if he logs out from the OS and another user logs in, the situation is different of course. The line 439 is intriguing: $cookie = ( $cookie, $itemcookie ); Does that work? (Apparently..) It probably should be = [ .. ]; The cookie parameter of CGI accepts an arrayref. Please correct. URI::Escape Just a question, did not examine this further. But should you use uri_escape_utf8 instead of uri_escape? Please test on chars in 128..255 and above, and report back. Indentation: additem.pl lines 356 to 360; the same for segment 426-442 (followup..) Barcode You are adding this comment somewhere: This code is subject to change in 3.2 That sounds a little bit old now? In the new code you add code for incrementing barcode. Note that additem already contains subroutine _increment_barcode. Why not use that? Followup? Conclusion In general. Looks good to me, but needs some further attention. Note for RM: Paul, I am setting status to Passed QA for this one. It was quite long time in the queue. But it needs some clarification and followups. Matthias is close to you :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 16:53:50 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 14:53:50 +0000 Subject: [Koha-bugs] [Bug 5357] Subscription search and displays In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5357 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11263|1 |0 is obsolete| | --- Comment #11 from Paul Poulain --- Comment on attachment 11263 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11263 Bug 5357: Adds a new page for searching subscriptions unobsoleting this patch, signed-off by Corinne Hayet on camembert sandbox Will obsolete the patch not related to this bug, I made a mistake on my sandbox setup, he made silly things. Should be fixed now -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 16:54:03 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 14:54:03 +0000 Subject: [Koha-bugs] [Bug 5357] Subscription search and displays In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5357 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11266|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 16:54:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 14:54:09 +0000 Subject: [Koha-bugs] [Bug 7412] Pre-filling items in cataloguing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7412 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10088|0 |1 is obsolete| | --- Comment #29 from M. de Rooy --- Created attachment 11267 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11267&action=edit Rebased patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 17:02:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 15:02:10 +0000 Subject: [Koha-bugs] [Bug 8357] UNIMARCslim2OPACDetail.xsl, title without class and too links to views In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8357 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain at biblibre.com --- Comment #5 from Paul Poulain --- Patch tested with a sandbox, by Zeno Tajoli -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 17:02:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 15:02:24 +0000 Subject: [Koha-bugs] [Bug 8357] UNIMARCslim2OPACDetail.xsl, title without class and too links to views In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8357 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11188|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 17:02:32 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 15:02:32 +0000 Subject: [Koha-bugs] [Bug 8357] UNIMARCslim2OPACDetail.xsl, title without class and too links to views In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8357 --- Comment #6 from Paul Poulain --- Created attachment 11268 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11268&action=edit Bug 8204: fix UNIMARC display UNIMARC display of authorities in the OPAC wasn't working due to changes in the BuildSummary function since the code was originally developed. Signed-off-by: Paul Poulain Signed-off-by: Zeno Tajoli -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 17:02:56 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 15:02:56 +0000 Subject: [Koha-bugs] [Bug 8357] UNIMARCslim2OPACDetail.xsl, title without class and too links to views In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8357 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11268|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 17:08:50 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 15:08:50 +0000 Subject: [Koha-bugs] [Bug 5357] Subscription search and displays In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5357 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #12 from Katrin Fischer --- Hi Corinne, was your sign-off on this intended? I see you posted a comment first: "ISSN and Bookseller search don't work" Can you confirm all is ok? Thank you and thanks for testing! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 17:18:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 15:18:49 +0000 Subject: [Koha-bugs] [Bug 8357] UNIMARCslim2OPACDetail.xsl, title without class and too links to views In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8357 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11188|1 |0 is obsolete| | --- Comment #7 from Paul Poulain --- Comment on attachment 11188 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11188 Proposed patch (2) This patch signed-off by zeno. The other obsoleted patch ( Bug 8204: fix UNIMARC display (13.66 KB, patch) ) is a mistake made by the sandbox system. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 17:26:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 15:26:41 +0000 Subject: [Koha-bugs] [Bug 8357] UNIMARCslim2OPACDetail.xsl, title without class and too links to views In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8357 --- Comment #8 from Fridolyn SOMERS --- But, signed-off patch is not in attachments. Zeno ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 17:27:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 15:27:24 +0000 Subject: [Koha-bugs] [Bug 5357] Subscription search and displays In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5357 --- Comment #13 from Corinne HAYET --- (En r?ponse au commentaire 12) > Hi Corinne, > was your sign-off on this intended? I see you posted a comment first: > "ISSN and Bookseller search don't work" > Can you confirm all is ok? Thank you and thanks for testing! Hi Katrin, No, it's a mistake :( This patch is not sign-off because ISSN and Bookseller search don't work -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 17:32:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 15:32:24 +0000 Subject: [Koha-bugs] [Bug 8503] Software error n edit items with EasyAnalyticalRecords In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8503 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Version|master |rel_3_8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 17:33:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 15:33:09 +0000 Subject: [Koha-bugs] [Bug 8357] UNIMARCslim2OPACDetail.xsl, title without class and too links to views In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8357 --- Comment #9 from Paul Poulain --- Patch tested with a sandbox, by Zeno Tajoli -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 17:33:22 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 15:33:22 +0000 Subject: [Koha-bugs] [Bug 8357] UNIMARCslim2OPACDetail.xsl, title without class and too links to views In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8357 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11188|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 17:33:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 15:33:27 +0000 Subject: [Koha-bugs] [Bug 8357] UNIMARCslim2OPACDetail.xsl, title without class and too links to views In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8357 --- Comment #10 from Paul Poulain --- Created attachment 11269 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11269&action=edit Bug 8204: fix UNIMARC display UNIMARC display of authorities in the OPAC wasn't working due to changes in the BuildSummary function since the code was originally developed. Signed-off-by: Paul Poulain Signed-off-by: Zeno Tajoli http://bugs.koha-community.org/show_bug.cgi?id=8357 Signed-off-by: Zeno Tajoli -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 17:34:40 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 15:34:40 +0000 Subject: [Koha-bugs] [Bug 5357] Subscription search and displays In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5357 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #14 from Paul Poulain --- so, failing QA (Corinne now knows when to use the 2nd part of the sandbox = only if you want to signoff !) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 17:36:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 15:36:25 +0000 Subject: [Koha-bugs] [Bug 8357] UNIMARCslim2OPACDetail.xsl, title without class and too links to views In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8357 --- Comment #11 from Zeno Tajoli --- Sorry for the problem, I think there is same problem on sanboxes. I try to redo again -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 17:37:19 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 15:37:19 +0000 Subject: [Koha-bugs] [Bug 8357] UNIMARCslim2OPACDetail.xsl, title without class and too links to views In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8357 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11269|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 17:37:59 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 15:37:59 +0000 Subject: [Koha-bugs] [Bug 8357] UNIMARCslim2OPACDetail.xsl, title without class and too links to views In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8357 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11188|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 17:38:22 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 15:38:22 +0000 Subject: [Koha-bugs] [Bug 8357] UNIMARCslim2OPACDetail.xsl, title without class and too links to views In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8357 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 17:38:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 15:38:48 +0000 Subject: [Koha-bugs] [Bug 8516] Add a "Street Address" search option to the patrons search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8516 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Version|unspecified |rel_3_10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 17:41:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 15:41:49 +0000 Subject: [Koha-bugs] [Bug 8518] Self checkout does not display debt amount if syspref AllowFineOverride is set to allow In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8518 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain at biblibre.com --- Comment #7 from Paul Poulain --- QA comment: would be better to introduce a library to display efficiently. Could (should ?) be a T::T plugin (In France, the currency is displayed after the number : 1234.56? for example.) Won't reject this patch for this reason, but if you want to do it, you're highly welcomed ;-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 17:42:01 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 15:42:01 +0000 Subject: [Koha-bugs] [Bug 8518] Self checkout does not display debt amount if syspref AllowFineOverride is set to allow In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8518 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 17:43:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 15:43:39 +0000 Subject: [Koha-bugs] [Bug 8408] Odd OPAC message when OPAC Renewals are disabled and OPACFineNoRenewals is set to blank In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8408 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Version|master |rel_3_8 Severity|enhancement |minor --- Comment #7 from Paul Poulain --- More a minor bugfix than an ENH I think, bumping severity -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 17:53:52 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 15:53:52 +0000 Subject: [Koha-bugs] [Bug 8405] add IntranetBiblioDefaultView and BiblioDefaultView to XSLT.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8405 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Version|master |rel_3_10 --- Comment #4 from Paul Poulain --- Do we agree that there will be a follow-up to implement this feature ? I've pushed the patch, and hope not needing to revert it later ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 17:56:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 15:56:29 +0000 Subject: [Koha-bugs] [Bug 8405] add IntranetBiblioDefaultView and BiblioDefaultView to XSLT.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8405 --- Comment #5 from Jared Camins-Esakov --- (In reply to comment #4) > Do we agree that there will be a follow-up to implement this feature ? I've > pushed the patch, and hope not needing to revert it later ! Even if it is not used right away, this is certainly useful to have, and I see no reason to plan to revert it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 17:57:36 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 15:57:36 +0000 Subject: [Koha-bugs] [Bug 7412] Pre-filling items in cataloguing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7412 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain at biblibre.com --- Comment #30 from Paul Poulain --- (In reply to comment #28) > Paul, I am setting status to Passed QA for this one. It was quite long time > in the queue. But it needs some clarification and followups. Matthias is > close to you :) I think Matts is closer to you than to me, because he live near Strasbourg ;-) Thx for the passed QA. There's not need to hurry to push it, Matts, pls provide follow-up to Marcel's comments -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 18:01:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 16:01:10 +0000 Subject: [Koha-bugs] [Bug 8357] UNIMARCslim2OPACDetail.xsl, title without class and too links to views In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8357 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #12 from Paul Poulain --- Patch tested with a sandbox, by Zeno Tajoli -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 18:01:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 16:01:24 +0000 Subject: [Koha-bugs] [Bug 8357] UNIMARCslim2OPACDetail.xsl, title without class and too links to views In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8357 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11188|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 18:01:30 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 16:01:30 +0000 Subject: [Koha-bugs] [Bug 8357] UNIMARCslim2OPACDetail.xsl, title without class and too links to views In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8357 --- Comment #13 from Paul Poulain --- Created attachment 11270 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11270&action=edit Bug 8357: UNIMARCslim2OPACDetail.xsl, title without class and too links to views Signed-off-by: Zeno Tajoli -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 18:05:50 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 16:05:50 +0000 Subject: [Koha-bugs] [Bug 8357] UNIMARCslim2OPACDetail.xsl, title without class and too links to views In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8357 --- Comment #14 from Zeno Tajoli --- Hi to all, now the situation is OK. I don't know if is my work with sandbox number 3 or by Paul Poulain but it is OK. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 18:16:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 16:16:57 +0000 Subject: [Koha-bugs] [Bug 8443] Suggestions : publication year and copyright date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8443 Corinne HAYET changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |corinne.hayet at bulac.fr --- Comment #4 from Corinne HAYET --- Hi Fridolyn, You talk about copyright date...but there's no copyright date in your new form ??? You talk about itemtype...but there's non itemtype filter ?? budget and date filters dont'work. For date filters, have look to the pop-up for the calendar. There's a problem, date are translated (and searched ?) like MM/JJ/AAAA (for exemple : 01/08/2012 wrong translation in 08/01/2012) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 18:26:16 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 16:26:16 +0000 Subject: [Koha-bugs] [Bug 8524] Add barcode plugin that does not autofill In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8524 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 18:26:18 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 16:26:18 +0000 Subject: [Koha-bugs] [Bug 8524] Add barcode plugin that does not autofill In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8524 --- Comment #1 from Jared Camins-Esakov --- Created attachment 11271 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11271&action=edit Bug 8524: Add a non-automatic barcode plugin In addition to adding a new barcode plugin, this commit begins refactoring the barcode generation code using a new module, C4::Barcodes::ValueBuilder. From the POD: This module is intended as a shim to ease the eventual transition from having all barcode-related code in the value builder plugin barcode.pl file to using C4::Barcodes. Since the shift will require a rather significant amount of refactoring, this module will return value builder-formatted results, at first by merely running the code that was formerly in the barcodes.pl value builder, but later by using C4::Barcodes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 18:30:08 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 16:30:08 +0000 Subject: [Koha-bugs] [Bug 8524] Add barcode plugin that does not autofill In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8524 --- Comment #2 from Jared Camins-Esakov --- To test: 1) Set the plugin for 952$p (or UNIMARC equivalent to items.barcode) for one of your frameworks to barcode_manual.pl instead of barcode.pl. 2) Turn on autobarcode. 3) Observe that when you click in the barcode field, nothing happens. 4) Observe that when you click the value builder link next to the plugin, the barcode field is filled in. 5) Run t/Barcodes_ValueBuilder.t, ensure that the tests complete. That's it, really. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 18:45:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 16:45:29 +0000 Subject: [Koha-bugs] [Bug 8549] New: DataTables upgrade broke display of next/previous buttons in table controls Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8549 Priority: P5 - low Change sponsored?: --- Bug ID: 8549 Assignee: oleonard at myacpl.org Summary: DataTables upgrade broke display of next/previous buttons in table controls Severity: normal Classification: Unclassified OS: All Reporter: oleonard at myacpl.org Hardware: All Status: NEW Version: master Component: Templates Product: Koha Created attachment 11272 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11272&action=edit Screenshot showing the problem commit e77461a3cfb18a851668b99d9d6d323b9fefceb4, "Upgrading DataTables library to 1.9.1" broke the display of the next/previous buttons on DataTables table controls. Link text overlays the button images. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 18:45:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 16:45:58 +0000 Subject: [Koha-bugs] [Bug 8549] DataTables upgrade broke display of next/previous buttons in table controls In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8549 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cnighswonger at foundations.ed | |u -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 19:31:26 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 17:31:26 +0000 Subject: [Koha-bugs] [Bug 8550] New: Z39.50 searches for ISBN/ISSN problematic Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8550 Priority: P5 - low Change sponsored?: --- Bug ID: 8550 CC: m.de.rooy at rijksmuseum.nl Assignee: jcamins at cpbibliography.com Summary: Z39.50 searches for ISBN/ISSN problematic Severity: normal Classification: Unclassified OS: All Reporter: jcamins at cpbibliography.com Hardware: All Status: NEW Version: master Component: Cataloging Product: Koha Copy cataloging via Z39.50 is often done by searching on ISBN or ISSN. Unfortunately, the code for doing this is... problematic, and may cause problems with some Z39.50 servers. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 19:34:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 17:34:29 +0000 Subject: [Koha-bugs] [Bug 8550] Z39.50 searches for ISBN/ISSN problematic In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8550 Jane Wagner changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jwagner at ptfs.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 19:36:30 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 17:36:30 +0000 Subject: [Koha-bugs] [Bug 8550] Z39.50 searches for ISBN/ISSN problematic In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8550 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 19:36:31 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 17:36:31 +0000 Subject: [Koha-bugs] [Bug 8550] Z39.50 searches for ISBN/ISSN problematic In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8550 --- Comment #1 from Jared Camins-Esakov --- Created attachment 11273 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11273&action=edit Bug 8550: Z39.50 searches for ISBN/ISSN problematic Rather than treating ISBN and ISSN as the same, this patch breaks them out into separate parts of the query, as well as changing the truncation attribute to enable right truncation (the correct behavior for the ISBN field in MARC21, and valid behavior in UNIMARC). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 19:49:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 17:49:10 +0000 Subject: [Koha-bugs] [Bug 8505] Records with leading spaces in the 001 line do not return Z39.50 search results. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8505 --- Comment #1 from Joseph Alway --- (In reply to comment #0) > The problem is that when I do Any search in a remote Z39.50 server, any > record that has leading spaces in the 001 line does not return a result. Yeah, ok. This wasn't what was happening. What was happening is that I was not getting any search results from ISBN Searches. See Bug 8550. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 19:52:20 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 17:52:20 +0000 Subject: [Koha-bugs] [Bug 8505] Records with leading spaces in the 001 line do not return Z39.50 search results. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8505 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #2 from Jared Camins-Esakov --- Closing bug since we've identified the problem as actually being that described in bug 8550. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 20:26:45 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 18:26:45 +0000 Subject: [Koha-bugs] [Bug 8520] Authorities display incorrectly in staff results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8520 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11194|0 |1 is obsolete| | --- Comment #2 from Tom?s Cohen Arazi --- Created attachment 11274 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11274&action=edit Bug 8520: fix authority display in staff client Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 20:47:59 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 18:47:59 +0000 Subject: [Koha-bugs] [Bug 8020] Prepare debian packages for 3.8 release In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8020 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 22:09:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 20:09:10 +0000 Subject: [Koha-bugs] [Bug 8551] New: Course reserves Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8551 Priority: P5 - low Change sponsored?: --- Bug ID: 8551 Assignee: oleonard at myacpl.org Summary: Course reserves Severity: enhancement Classification: Unclassified OS: All Reporter: pelletiermaxime at gmail.com Hardware: All Status: NEW Version: master Component: OPAC Product: Koha New functionnality to add a status Reserved for the Not For Loan field of items. It also adds fields to add the name of the Teacher and the Course. It adds a new page in the OPAC to list all the items that have this status. The functionnality looks like what is in bug #8215, but it's much more simple. It was also one of the first features I added to koha, so it really lacks comments, isn't based on master (based on 3.8.2) and doesn't have database updates yet. I'm posting it here to see if there's any interest and to have feedback on how I did the functionnality. Thanks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 22:12:32 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 20:12:32 +0000 Subject: [Koha-bugs] [Bug 8551] Course reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8551 --- Comment #1 from Maxime Pelletier --- Created attachment 11275 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11275&action=edit Screenshot of the intranet interface to add an item (sry it's in french :P) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 22:13:00 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 20:13:00 +0000 Subject: [Koha-bugs] [Bug 8551] Course reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8551 --- Comment #2 from Maxime Pelletier --- Created attachment 11276 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11276&action=edit OPAC page (using datatables) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 22:15:52 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 20:15:52 +0000 Subject: [Koha-bugs] [Bug 8551] Course reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8551 --- Comment #3 from Maxime Pelletier --- Created attachment 11277 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11277&action=edit First version of the patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 22:17:59 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 20:17:59 +0000 Subject: [Koha-bugs] [Bug 8551] Course reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8551 --- Comment #4 from Maxime Pelletier --- Also I believe there's no page using Datatables in the OPAC. I had to fix the images paths and copy some images from the intranet img folder. Should I just open this as a separate bug report ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 23:42:26 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 21:42:26 +0000 Subject: [Koha-bugs] [Bug 8552] New: BiblioAddsAuthorities set to Allow causes Software Error on Z3950 import Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8552 Priority: P5 - low Change sponsored?: --- Bug ID: 8552 CC: m.de.rooy at rijksmuseum.nl Assignee: gmcharlt at gmail.com Summary: BiblioAddsAuthorities set to Allow causes Software Error on Z3950 import Severity: enhancement Classification: Unclassified OS: All Reporter: joy at bywatersolutions.com Hardware: All Status: NEW Version: unspecified Component: Z39.50 / SRU / OpenSearch Servers Product: Koha Setting the BiblioAddsAuthorities to 'allow' causes a software error when importing a record through Z3950 in Cataloging. Setting it to 'don't allow' allows import to proceed without error. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 23:50:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 21:50:39 +0000 Subject: [Koha-bugs] [Bug 8386] Error in duplicate detection message for authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8386 JA changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pussman at gmail.com --- Comment #6 from JA --- I was trying to create a new Authority with the fowling parameters: Lastname: Lopes, Firstname: Francisco I with version 3.08.03.000 I this error when I'm creating a new Authority and koha finds a possible duplicate: Software error: Can't use string ("Lopes, Francisco Luiz

duplicateauthvalue => $duplicateauthvalue, Ver: 3.08.03.000 duplicateauthvalue => $duplicateauthvalue->{authorized}->[0], When I remove ->{authorized}->[0] it works OK. -- Jos? Anjos -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 01:12:01 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 23:12:01 +0000 Subject: [Koha-bugs] [Bug 8204] Authority viewer in OPAC ugly, unfriendly, and mostly useless In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8204 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #30 from Chris Cormack --- Follow up pushed the 3.8.x will be in 3.8.4 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 01:36:52 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 23:36:52 +0000 Subject: [Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720 Melia Meggs changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff CC| |melia at bywatersolutions.com --- Comment #39 from Melia Meggs --- I think Kyle forgot to change the status... Changing status to "needs signoff" for the new patch from 7/23. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 01:41:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 23:41:33 +0000 Subject: [Koha-bugs] [Bug 8503] Software error n edit items with EasyAnalyticalRecords In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8503 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #7 from Chris Cormack --- Pushed to 3.8.x will be in 3.8.4 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 01:56:15 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Aug 2012 23:56:15 +0000 Subject: [Koha-bugs] [Bug 8518] Self checkout does not display debt amount if syspref AllowFineOverride is set to allow In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8518 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #8 from Chris Cormack --- Pushed to 3.8.x, will be in 3.8.4 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 02:04:40 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 00:04:40 +0000 Subject: [Koha-bugs] [Bug 8408] Odd OPAC message when OPAC Renewals are disabled and OPACFineNoRenewals is set to blank In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8408 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |In Discussion CC| |chris at bigballofwax.co.nz --- Comment #8 from Chris Cormack --- This changes the behaviour, Now instead of telling them they are blocked from renewing because they owe over the fine threshold, it just tells them how much they owe. (which they can see on their user page) So they don't know how much they have to pay to be able to renew again. I don't know if this is a good thing or not, or to change the behaviour was a conscious decision? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 02:38:51 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 00:38:51 +0000 Subject: [Koha-bugs] [Bug 8550] Z39.50 searches for ISBN/ISSN problematic In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8550 Joseph Alway changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jbalway at gmail.com --- Comment #2 from Joseph Alway --- (In reply to comment #1) > Created attachment 11273 [details] > Bug 8550: Z39.50 searches for ISBN/ISSN problematic I finally got koha running off my git install and applied the patch. It works! :-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 05:52:08 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 03:52:08 +0000 Subject: [Koha-bugs] [Bug 5327] Unit tests required for all C4 modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Bart Jorgensen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11212|0 |1 is obsolete| | --- Comment #200 from Bart Jorgensen --- Created attachment 11278 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11278&action=edit Changed Itemtype.t patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 06:40:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 04:40:14 +0000 Subject: [Koha-bugs] [Bug 5327] Unit tests required for all C4 modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11278|0 |1 is obsolete| | --- Comment #201 from Chris Cormack --- Created attachment 11279 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11279&action=edit Bug 5327 : Added a few more lines of code to the ItemType.t unit test Signed-off-by: Jared Camins-Esakov Signed-off-by: Chris Cormack -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 06:41:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 04:41:49 +0000 Subject: [Koha-bugs] [Bug 5327] Unit tests required for all C4 modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11213|0 |1 is obsolete| | --- Comment #202 from Chris Cormack --- Created attachment 11280 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11280&action=edit Bug 5327 follow-up: add DBD::Mock dependency In order for the awesome new t/ItemType.t test to work, we need DBD::Mock. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 06:42:52 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 04:42:52 +0000 Subject: [Koha-bugs] [Bug 5327] Unit tests required for all C4 modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 07:06:04 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 05:06:04 +0000 Subject: [Koha-bugs] [Bug 5327] Unit tests required for all C4 modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Bart Jorgensen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff Assignee|paul.poulain at biblibre.com |bart.tj at gmail.com --- Comment #203 from Bart Jorgensen --- Created attachment 11281 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11281&action=edit Added tests to C4 Matcher. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 07:11:55 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 05:11:55 +0000 Subject: [Koha-bugs] [Bug 8209] "Did you mean?" suggestions based on authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8209 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- Sorry, Jared: Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all y Applying: Bug 8209: "Did you mean?" from authorities /home/katrin/kohaclone/.git/rebase-apply/patch:834: trailing whitespace. fatal: sha1 information is lacking or useless (C4/AuthoritiesMarc.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 8209: "Did you mean?" from authorities When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 09:00:12 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 07:00:12 +0000 Subject: [Koha-bugs] [Bug 8553] New: encountered a problem in searching through Barcode Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8553 Priority: P5 - low Change sponsored?: --- Bug ID: 8553 CC: m.de.rooy at rijksmuseum.nl Assignee: gmcharlt at gmail.com Summary: encountered a problem in searching through Barcode Severity: enhancement Classification: Unclassified OS: Linux Reporter: irfan.a.mirza at gmail.com Hardware: All Status: NEW Version: rel_3_8 Component: Cataloging Product: Koha I can't search the items through Barcode but all other fields are working well. An other problem I am encountering is "Can't call method "subfield" on an undefined value at /usr/share/koha/intranet/cgi-bin/cataloguing/additem.pl line 703." Please any one may guide me how can I fix it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 09:12:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 07:12:33 +0000 Subject: [Koha-bugs] [Bug 7292] new permission for claims In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7292 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |jonathan.druart at biblibre.co | |m --- Comment #10 from Jonathan Druart --- Same error with this one: Applying: Bug 7292: More granular permissions for claiming orders fatal: sha1 information is lacking or useless (installer/data/mysql/de-DE/mandatory/userpermissions.sql). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 09:37:17 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 07:37:17 +0000 Subject: [Koha-bugs] [Bug 7295] list of librarian managing a basket In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10885|0 |1 is obsolete| | --- Comment #10 from Julian Maurice --- Created attachment 11282 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11282&action=edit Bug 7295: More granular permissions for baskets Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 09:37:42 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 07:37:42 +0000 Subject: [Koha-bugs] [Bug 7295] list of librarian managing a basket In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10886|0 |1 is obsolete| | --- Comment #11 from Julian Maurice --- Created attachment 11283 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11283&action=edit Bug 7295: Follow-up: Several fixes Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 09:40:38 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 07:40:38 +0000 Subject: [Koha-bugs] [Bug 7292] new permission for claims In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7292 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10968|0 |1 is obsolete| | --- Comment #11 from Julian Maurice --- Created attachment 11284 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11284&action=edit Bug 7292: More granular permissions for claiming orders Rebased on master Just a reminder: this patch needs patch(es) (at least the first) from bug 7295 in order to work (and apply correctly) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 09:40:38 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 07:40:38 +0000 Subject: [Koha-bugs] [Bug 6515] can't set advanced notice days In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6515 --- Comment #1 from Marc V?ron --- Created attachment 11285 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11285&action=edit Advanced Notice: Set day needs checkbox Email to be checked Updating the value needs the Email checkbox to be checked, otherwise it is reset to 0. I think this is by design, because setting days makes no sense if no notice is to be sent. However I needed some time to find it out. Maybe it would be a good idea to display some explanation? Marc -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 09:40:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 07:40:48 +0000 Subject: [Koha-bugs] [Bug 6515] can't set advanced notice days In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6515 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 10:05:52 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 08:05:52 +0000 Subject: [Koha-bugs] [Bug 8554] New: marck bibliographic framework test Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8554 Priority: P5 - low Change sponsored?: --- Bug ID: 8554 Assignee: gmcharlt at gmail.com Summary: marck bibliographic framework test Severity: enhancement Classification: Unclassified OS: Linux Reporter: irfan.a.mirza at gmail.com Hardware: All Status: NEW Version: rel_3_8 Component: MARC Bibliographic data support Product: Koha Please check it and guide me how can I solve it. MARC bibliographic framework test Test Result itemnum * The field itemnum MUST be mapped * The corresponding subfield MUST be in with -1 (ignore) tab Item tag There is more than 1 MARC tag related to items tab (10) : 952,042,942, subfields not in same tabs Not all subfields for the following tags are in the same tab (or marked 'ignored'). Code Description Tag Tabs in use BKS Books, Booklets, Workbooks 942 0,10 TOTAL You have 3 error(s) in your MARC configuration. Please fix them before using Koha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 10:19:05 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 08:19:05 +0000 Subject: [Koha-bugs] [Bug 8555] New: Quick fix for authority search results in staff Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8555 Priority: P5 - low Change sponsored?: --- Bug ID: 8555 CC: jcamins at cpbibliography.com Assignee: m.de.rooy at rijksmuseum.nl Summary: Quick fix for authority search results in staff Severity: enhancement Classification: Unclassified OS: All Reporter: m.de.rooy at rijksmuseum.nl Hardware: All Status: ASSIGNED Version: master Component: MARC Authority data support Product: Koha Currently, it shows things like HASH(xxx) instead of a name. Sending a patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 10:19:46 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 08:19:46 +0000 Subject: [Koha-bugs] [Bug 8555] Quick fix for authority search results display in staff In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8555 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Quick fix for authority |Quick fix for authority |search results in staff |search results display in | |staff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 10:21:56 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 08:21:56 +0000 Subject: [Koha-bugs] [Bug 8555] Quick fix for authority search results display in staff In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8555 --- Comment #1 from M. de Rooy --- Created attachment 11286 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11286&action=edit Patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 10:22:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 08:22:29 +0000 Subject: [Koha-bugs] [Bug 8555] Quick fix for authority search results display in staff In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8555 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 10:23:08 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 08:23:08 +0000 Subject: [Koha-bugs] [Bug 8555] Quick fix for authority search results display in staff In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8555 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P3 Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 10:24:31 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 08:24:31 +0000 Subject: [Koha-bugs] [Bug 8206] Add additional search options to authority browser in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8206 --- Comment #20 from M. de Rooy --- (In reply to comment #19) > (In reply to comment #18) > > I am fixing this on another bug, but what is the problem with this patch > > that caused it to fail QA? Jared, could you please look at bug 8555? Just a quick fix. If you agree, please sign off on it.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 10:40:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 08:40:09 +0000 Subject: [Koha-bugs] [Bug 8556] New: "Mark seen and continue" not translatable in inventory.tt Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8556 Priority: P5 - low Change sponsored?: --- Bug ID: 8556 Assignee: oleonard at myacpl.org Summary: "Mark seen and continue" not translatable in inventory.tt Severity: minor Classification: Unclassified OS: All Reporter: veron at veron.ch Hardware: All Status: NEW Version: master Component: Templates Product: Koha Start ? Werkzeuge ? Inventarisierung ? Ergebnisse shows buttons with labels: Gesehen - Mark seen and continue - Ohne Kennzeichnung fortfahren Seems to be related to missing _(...) wrapper in JavaScript in inventory.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 10:40:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 08:40:28 +0000 Subject: [Koha-bugs] [Bug 8556] "Mark seen and continue" not translatable in inventory.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8556 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 10:41:17 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 08:41:17 +0000 Subject: [Koha-bugs] [Bug 5357] Subscription search and displays In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5357 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11263|0 |1 is obsolete| | --- Comment #15 from Jonathan Druart --- Created attachment 11287 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11287&action=edit Bug 5357: Adds a new page for searching subscriptions This patch fixes search for ISSN and bookseller. + removes dead code in serials-home.[pl|tt] -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 10:41:44 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 08:41:44 +0000 Subject: [Koha-bugs] [Bug 5357] Subscription search and displays In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5357 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 10:57:17 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 08:57:17 +0000 Subject: [Koha-bugs] [Bug 8357] UNIMARCslim2OPACDetail.xsl, title without class and too links to views In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8357 --- Comment #15 from Paul Poulain --- (In reply to comment #14) > Hi to all, > > now the situation is OK. > I don't know if is my work with sandbox number 3 or by Paul Poulain but it > is OK. Well, the explanation is the following: * there was a mistake in my sandbox setup that made the signoff script to badly fail to do anything. * 2 days later, when I fixed the problem, your pending "sign-off" has been applied. Except that ... the signoff is made on the top patch. As 2 days have ellapsed, the "head" patch was no more the correct one and another one was attached as signed off ! My fault, but now it's fixed. The patch, signed-off by you, is uploaded ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 11:28:34 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 09:28:34 +0000 Subject: [Koha-bugs] [Bug 8557] New: in orderreceive.tt and serials-edit.tt the use of a barcode scan send the form unexpectedly Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8557 Priority: P5 - low Change sponsored?: --- Bug ID: 8557 Assignee: koha-bugs at lists.koha-community.org Summary: in orderreceive.tt and serials-edit.tt the use of a barcode scan send the form unexpectedly Severity: enhancement Classification: Unclassified OS: All Reporter: christophe.croullebois at biblibre.com Hardware: All Status: NEW Version: master Component: Acquisitions Product: Koha in orderreceive when you receive an order with 'AcqCreateItem ' on 'receiving', you must first fill the 'Item' block and validating by clicking 'add' before clicking the 'save' button. Using a scan machine is like typing 'enter' and saving this receive, it is unwanted. For serials-edit it's the same problem. So this patch do the same in the two pages. To test: You must have a barcode scan... ;o) Or try to type enter without the patch, it's what the scan machine sends. thx -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 11:29:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 09:29:29 +0000 Subject: [Koha-bugs] [Bug 8556] "Mark seen and continue" not translatable in inventory.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8556 --- Comment #1 from Marc V?ron --- Created attachment 11288 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11288&action=edit Bug 8556 - "Mark seen and continue" not translatable in inventory.tt Added missing _(...) wrapper in JavaScript in inventory.tt Additionaly added two blanks to separate buttons (were sticked together without white space) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 11:31:06 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 09:31:06 +0000 Subject: [Koha-bugs] [Bug 8556] "Mark seen and continue" not translatable in inventory.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8556 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 11:46:44 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 09:46:44 +0000 Subject: [Koha-bugs] [Bug 8556] "Mark seen and continue" not translatable in inventory.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8556 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11288|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart --- Created attachment 11289 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11289&action=edit Bug 8556 - "Mark seen and continue" not translatable in inventory.tt Added missing _(...) wrapper in JavaScript in inventory.tt Additionaly added two blanks to separate buttons (were sticked together without white space) Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 11:47:01 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 09:47:01 +0000 Subject: [Koha-bugs] [Bug 8556] "Mark seen and continue" not translatable in inventory.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8556 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 11:57:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 09:57:11 +0000 Subject: [Koha-bugs] [Bug 5357] Subscription search and displays In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5357 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #16 from Paul Poulain --- Patch tested with a sandbox, by Corinne HAYET -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 11:57:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 09:57:25 +0000 Subject: [Koha-bugs] [Bug 5357] Subscription search and displays In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5357 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11287|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 11:57:30 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 09:57:30 +0000 Subject: [Koha-bugs] [Bug 5357] Subscription search and displays In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5357 --- Comment #17 from Paul Poulain --- Created attachment 11290 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11290&action=edit Bug 5357: Adds a new page for searching subscriptions Test plan: - go on the serial module - click on the 'Advanced search' link (right of subscriptions search in the header) - Search subscriptions (by ISSN, title, EAN, Publisher, Supplier and/or Branch) - Check results are correct Signed-off-by: Corinne HAYET -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 12:00:12 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 10:00:12 +0000 Subject: [Koha-bugs] [Bug 7913] Automatically receive serial issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7913 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |paul.poulain at biblibre.com --- Comment #7 from Paul Poulain --- Patch tested with a sandbox, by Delaye Stephane -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 12:00:31 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 10:00:31 +0000 Subject: [Koha-bugs] [Bug 7913] Automatically receive serial issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7913 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9702|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 12:00:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 10:00:35 +0000 Subject: [Koha-bugs] [Bug 7913] Automatically receive serial issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7913 --- Comment #8 from Paul Poulain --- Created attachment 11291 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11291&action=edit Receiving serials in a loop generate the number of issues entered from a message box and apply 'arrived' status. http://bugs.koha-community.org/show_bug.cgi?id=7913 Signed-off-by: Delaye Stephane -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 12:05:17 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 10:05:17 +0000 Subject: [Koha-bugs] [Bug 7839] Enhancement: Show routing lists attached to patron in Patron record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7839 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #24 from Paul Poulain --- QA comment: * passes perlcritic, tt_valid, valid_templates * does not respect "(HTML4) We have decided to use upper cases only for the first letter of a given sentence/label/tab description/page title/..." Sometimes I put "failed QA", sometimes I fix myself. As it's a simple template, i've fixed passed QA The number of tabs attached to a given patron is quite large (Check out, Details, Fines, Routing lists, Circulation history, Modification log, Notices, Statistics, Files) We will have to find a solution for a more useable display... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 12:06:23 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 10:06:23 +0000 Subject: [Koha-bugs] [Bug 7839] Enhancement: Show routing lists attached to patron in Patron record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7839 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 12:09:19 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 10:09:19 +0000 Subject: [Koha-bugs] [Bug 6655] Sorting order of serial issues in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6655 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain at biblibre.com --- Comment #9 from Paul Poulain --- QA comment: tiny -and logical- change, passed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 12:12:56 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 10:12:56 +0000 Subject: [Koha-bugs] [Bug 6655] Sorting order of serial issues in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6655 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|unspecified |rel_3_8 Severity|enhancement |trivial --- Comment #10 from Paul Poulain --- I think it's more a trivial bugfix than an ENH: sorting by publisheddate is logical. sorting by expecteddate is not -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 12:55:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 10:55:41 +0000 Subject: [Koha-bugs] [Bug 8558] New: Better confirmation message for importing frameworks Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8558 Priority: P5 - low Change sponsored?: --- Bug ID: 8558 CC: gmcharlt at gmail.com Assignee: koha-bugs at lists.koha-community.org Summary: Better confirmation message for importing frameworks Severity: enhancement Classification: Unclassified OS: All Reporter: katrin.fischer at bsz-bw.de Hardware: All Status: NEW Version: master Component: System Administration Product: Koha When importing frameworks using open office or another program a confirmation message asks you, if you are really sure you want to overwrite the existing framework, fields and subfields. It would be nice, if this message showed which framework you are going to overlay, because this is not visible from the page or the message at the moment. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 13:20:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 11:20:09 +0000 Subject: [Koha-bugs] [Bug 8432] Improvement of serials search results list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8432 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain at biblibre.com --- Comment #3 from Paul Poulain --- QA comment: * tiny patch that add some information * passes koha-qa.pl script -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 13:24:55 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 11:24:55 +0000 Subject: [Koha-bugs] [Bug 8432] Improvement of serials search results list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8432 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|unspecified |rel_3_10 --- Comment #4 from Paul Poulain --- my tests showed: Edit () for subscriptions that have a routing list, in the "routing list" column Looking at the code, I see ([% routingedit %]) that should be ([% subscription.routingedit %]) I've fixed the mistake in a follow-up, it display the number of patrons being routed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 13:33:26 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 11:33:26 +0000 Subject: [Koha-bugs] [Bug 8520] Authorities display incorrectly in staff results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8520 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #3 from Jared Camins-Esakov --- Marking as signed off, since it already was. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 13:33:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 11:33:48 +0000 Subject: [Koha-bugs] [Bug 8555] Quick fix for authority search results display in staff In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8555 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from Jared Camins-Esakov --- This is a duplicate of the patch that Tomas signed off on yesterday. *** This bug has been marked as a duplicate of bug 8520 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 13:33:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 11:33:48 +0000 Subject: [Koha-bugs] [Bug 8520] Authorities display incorrectly in staff results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8520 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #4 from Jared Camins-Esakov --- *** Bug 8555 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 13:34:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 11:34:33 +0000 Subject: [Koha-bugs] [Bug 4118] Add Collection Code to Statistics Table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4118 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain at biblibre.com --- Comment #12 from Paul Poulain --- QA comment: Why do you have + +=item DropAllForeignKeys($table) + in 1st patch ? Other than this, it's OK, and it passes ../qa/koha-qa.pl -c 3 answer my previous question (and remove it if it was not intended) to earn "passed QA" -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 13:38:05 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 11:38:05 +0000 Subject: [Koha-bugs] [Bug 8520] Authorities display incorrectly in staff results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8520 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #5 from M. de Rooy --- Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 13:41:04 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 11:41:04 +0000 Subject: [Koha-bugs] [Bug 8427] Patron search results not consistent In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8427 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain at biblibre.com --- Comment #5 from Paul Poulain --- QA comment: tiny patch, passes QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 13:41:45 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 11:41:45 +0000 Subject: [Koha-bugs] [Bug 8427] Patron search results not consistent In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8427 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_8 QA Contact| |paul.poulain at biblibre.com Severity|normal |minor --- Comment #6 from Paul Poulain --- Maybe saying it's a "normal" bug is a little bit too much. Lowering to "minor", but agreed it's a bug -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 14:14:30 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 12:14:30 +0000 Subject: [Koha-bugs] [Bug 8209] "Did you mean?" suggestions based on authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8209 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 14:14:32 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 12:14:32 +0000 Subject: [Koha-bugs] [Bug 8209] "Did you mean?" suggestions based on authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8209 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11151|0 |1 is obsolete| | --- Comment #3 from Jared Camins-Esakov --- Created attachment 11292 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11292&action=edit Bug 8209: "Did you mean?" from authorities One of the ideas behind authority records is that users who search for one term should have related terms (according to the authority file) suggested to them. At the moment, Koha doesn't do that. Adding an authority searching step to regular searches and displaying any suggestions in a "Did you mean" bar at the top of the results would be very useful. This commit adds a Koha::SuggestionEngine class which is in charge of getting suggestions from individual suggestion engine plugins, which much be in the Koha::SuggestionEngine::Plugin::* namespace, and extend Koha::SuggestionEngine::Base. Suggestions are loaded asynchronously using AJAX, and a link to a page with suggestions is provided for users with Javascript turned off. The AuthorityFile suggestion engine plugin looks up the specified search terms in the authority file and then suggests searches for records using matching authorities. Signed-off-by: Jared Camins-Esakov Rebased 2 August 2012 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 14:15:42 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 12:15:42 +0000 Subject: [Koha-bugs] [Bug 7470] Babeltheque improvement and social networks links (like, +1, ...) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7470 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #38 from Paul Poulain --- QA comment: * the 1st patch remove css declarations that are useless when you don't use babeltheque, it's good. I just have added a follow-up with some doc to avoid removal of this babeltheque.css file ! * the 2nd patch is tiny Passed QA (patches pushed on master branch, they don't apply correctly on new/bug_7470) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 14:15:54 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 12:15:54 +0000 Subject: [Koha-bugs] [Bug 7470] Babeltheque improvement and social networks links (like, +1, ...) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7470 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 14:16:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 12:16:58 +0000 Subject: [Koha-bugs] [Bug 8421] patron images fail when barcode for patron has a + In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8421 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain at biblibre.com Version|master |rel_3_8 --- Comment #3 from Paul Poulain --- QA comment: tiny template-only patch, passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 14:17:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 12:17:28 +0000 Subject: [Koha-bugs] [Bug 8421] patron images fail when barcode for patron has a + In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8421 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 14:20:42 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 12:20:42 +0000 Subject: [Koha-bugs] [Bug 8547] Enabling star ratings causes javascript errors that cause IE to have a boo boo In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8547 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #6 from Robin Sheat --- Confirmed from client that this solves the issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 14:22:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 12:22:58 +0000 Subject: [Koha-bugs] [Bug 8559] New: conflicting item statuses Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8559 Priority: P5 - low Change sponsored?: --- Bug ID: 8559 CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Assignee: koha-bugs at lists.koha-community.org Summary: conflicting item statuses Severity: normal Classification: Unclassified OS: All Reporter: nengard at gmail.com Hardware: All Status: NEW Version: master Component: Circulation Product: Koha Created attachment 11293 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11293&action=edit conflicting statuses if you check out a waiting hold to a different patron it gives the item conflicting statuses See the attached screenshot. Item was waiting for Rob, but staff checked it out Jessie, and it kept the "waiting status". So now it is both "waiting" and "checked out" - we need a way to handle this better. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 14:27:01 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 12:27:01 +0000 Subject: [Koha-bugs] [Bug 6151] IndependantBranches and HomeOrHoldingBranchReturn can prevent items from being checked in In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6151 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11250|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall --- Created attachment 11294 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11294&action=edit Bug 6151: Add AllowReturnToBranch system preference In order to solve the issue of IndependantBranches being incompatible with HomeOrHoldingBranchReturn, this patch changes the mechanism by which the question "can I return this material here?" is answered. Before, the conditions were "if IndependantBranches is on, and this branch isn't HomeOrHoldingBranchReturn for the item, then no, otherwise yes". Now, the question is answered by consulting CanBookBeReturned (new subroutine) New system preference: AllowReturnToBranch Possible values: - anywhere (default for new installs, and for existing systems with IndependantBranches turned off) - homebranch - holdingbranch (which is also the issuing branch in all normal circumstances) - homeorholdingbranch (default for existing systems with IndependantBranches turned on) New subroutine: CanBookBeReturned Input: $item hash (from GetItems), and $branchcode Output: 0 or 1 to indicate "allowed" or not, and an optional message if not allowed. Message is the 'correct' branchcode to return the material to To Test: 1. Install patch and new syspref 2. Check that default value of the preference: - if IndependantBranches was OFF at install time, should be 'anywhere' - if IndependantBranches was ON at install time, should be 'homeorholdingbranch' Case: 'anywhere' 1. Checkout a Library A book at Library A. Return at Library A should be successful 2. Repeat step 1, returning to Library B. Return should be successful 3. Checkout a Library A book at Library B. Return to A should be successful 4. Repeat step 3 with Library B and Library C Case: 'homebranch' 1. Checkout a Library A book at Library A. Return at Library A should be successful 2. Repeat step 1, returning to Library B. Return should FAIL (returning message to return at A) 3. Checkout a Library A book at Library B. Return to Library A should be successful 4. Repeat step 3 with Library B and Library C. Both should FAIL (returning message to return at A) Case: 'holdingbranch' 1. Checkout a Library A book at Library A. Return at Library A should be successful 2. Repeat step 1, returning to Library B. Return should FAIL (returning message to return at A) 3. Checkout a Library A book at Library B. Return to A should FAIL (returning message to return at B) 4. Repeat step 3 with Library B. Return should be successful 5. Repeat step 3 with Library C. Return should FAIL (returning message to return at B) Case: 'homeorholdingbranch' 1. Checkout a Library A book at Library A. Return at Library A should be successful 2. Repeat step 1, returning to Library B. Return should FAIL (returning message to return at A) 3. Checkout a Library A book at Library B. Return to A should be successful 4. Repeat step 3 with Library B. Return should be successful 5. Repeat step 3 with Library C. Return should FAIL (returning message to return at A) Signed-off-by: Chris Cormack Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 14:27:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 12:27:49 +0000 Subject: [Koha-bugs] [Bug 6151] IndependantBranches and HomeOrHoldingBranchReturn can prevent items from being checked in In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6151 --- Comment #10 from Kyle M Hall --- Created attachment 11295 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11295&action=edit Bug 6151 - Followup - Display message for failed returns on circulation.pl when returning via issues table. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 14:28:04 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 12:28:04 +0000 Subject: [Koha-bugs] [Bug 6151] IndependantBranches and HomeOrHoldingBranchReturn can prevent items from being checked in In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6151 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 14:30:05 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 12:30:05 +0000 Subject: [Koha-bugs] [Bug 8553] encountered a problem in searching through Barcode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8553 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #1 from Owen Leonard --- This sounds like a configuration issue rather than a bug in Koha code. I recommend you take your question to the Koha mailing list (http://lists.katipo.co.nz/mailman/listinfo/koha) where it will reach a wider audience. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 14:30:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 12:30:27 +0000 Subject: [Koha-bugs] [Bug 8554] marck bibliographic framework test In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8554 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #1 from Owen Leonard --- This sounds like a configuration issue rather than a bug in Koha code. I recommend you take your question to the Koha mailing list (http://lists.katipo.co.nz/mailman/listinfo/koha) where it will reach a wider audience. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 14:47:17 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 12:47:17 +0000 Subject: [Koha-bugs] [Bug 5600] Bulk MARC biblio export script In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5600 --- Comment #20 from Jonathan Druart --- (In reply to comment #19) > There is a patch to fix this on another bug. See Bug 8437 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 14:47:38 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 12:47:38 +0000 Subject: [Koha-bugs] [Bug 8560] New: renewing lost items Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8560 Priority: P5 - low Change sponsored?: --- Bug ID: 8560 CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Assignee: koha-bugs at lists.koha-community.org Summary: renewing lost items Severity: major Classification: Unclassified OS: All Reporter: nengard at gmail.com Hardware: All Status: NEW Version: master Component: Circulation Product: Koha I got this report from a library: When items age to long overdue lost, they assess a fee equivalent to the replacement price of the item. That makes sense. When those items are checked in, the fee is removed and the titles no longer display as checked out. The overdue does remain in the patron's history under fines. That also makes sense. However, if we renew one of those items, it assigns a new due date, but does not remove the fee or the long overdue lost designation. And, if we take payment on the item, it balances out the fee, reducing the amount due accordingly, but the title continues to display in the list of items out as long overdue lost. The result of this is that our staff members continue to mention these overdue items to the patron even after they've been taken care of. Other categories of lost - those that are manually set - remove the title from the list of items out. Renewing an item should also remove the fees and the long overdue designation. And paying for the item should remove it from items out and show it only in payment history. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 15:12:52 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 13:12:52 +0000 Subject: [Koha-bugs] [Bug 6720] Saved authorities always show as 'Default' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6720 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED --- Comment #25 from Paul Poulain --- I think I've found a big problem with this patch. Under certain circumstances (I think it's because zebra & mysql are unsynched, this can happen when you just deleted an authority, and it hasn't been deleted on zebra) I get: Can't use an undefined value as a HASH reference at /home/paul/koha.dev/koha-community/C4/AuthoritiesMarc.pm line 355. at /home/paul/koha.dev/koha-community/authorities/authorities-home.pl line 203 git blame tells me the culprit is here. Investigating a little bit, I see that: + GetAuthType($authtypecode)->{'summary'}; will fail if GetAuthType() returns nothing Changing this line to ( GetAuthType($authtypecode) ? $_->{'authtypetext'}:''); seems to fix the problem. Jared, could you check, confirm & provide a patch, i'll sign it immediately Another problem, maybe not related = the authorities in the list are now displayed HASH(0xb67ed88) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 15:19:19 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 13:19:19 +0000 Subject: [Koha-bugs] [Bug 6720] Saved authorities always show as 'Default' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6720 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 15:19:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 13:19:21 +0000 Subject: [Koha-bugs] [Bug 6720] Saved authorities always show as 'Default' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6720 --- Comment #26 from Jared Camins-Esakov --- Created attachment 11296 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11296&action=edit Bug 6720 follow-up: fix error when auth has been deleted Thanks to Paul Poulain for finding the problem and proposing a solution. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 15:20:31 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 13:20:31 +0000 Subject: [Koha-bugs] [Bug 6720] Saved authorities always show as 'Default' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6720 --- Comment #27 from Jared Camins-Esakov --- Your suggested fix worked perfectly, as far as I could tell. (In reply to comment #25) > Another problem, maybe not related = the authorities in the list are now > displayed HASH(0xb67ed88) See bug 8520 for a patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 15:29:17 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 13:29:17 +0000 Subject: [Koha-bugs] [Bug 8552] BiblioAddsAuthorities set to Allow causes Software Error on Z3950 import In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8552 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P4 Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 15:31:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 13:31:43 +0000 Subject: [Koha-bugs] [Bug 7943] Untranslatable strings in OPAC's authority search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7943 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |ASSIGNED Severity|normal |blocker --- Comment #13 from Paul Poulain --- I think (although i'm not sure it's the culprit) that this patch broke the display of authorities search, I see " HASH(0xb4c3d88) " instead of the summary of the authority it's a blocker ! Side question = is it unimarc specific or no ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 15:38:06 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 13:38:06 +0000 Subject: [Koha-bugs] [Bug 7943] Untranslatable strings in OPAC's authority search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7943 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #14 from M. de Rooy --- (In reply to comment #13) > I think (although i'm not sure it's the culprit) that this patch broke the > display of authorities search, I see " > HASH(0xb4c3d88) " instead of the summary of the authority > > it's a blocker ! > > Side question = is it unimarc specific or no ? Please have a look at the patch in the Passed QA queue for staff display! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 15:39:06 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 13:39:06 +0000 Subject: [Koha-bugs] [Bug 8520] Authorities display incorrectly in staff results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8520 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Version|master |rel_3_10 Severity|major |critical --- Comment #6 from Paul Poulain --- Well done ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 15:40:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 13:40:48 +0000 Subject: [Koha-bugs] [Bug 6720] Saved authorities always show as 'Default' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6720 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #28 from Paul Poulain --- follow-up signed-off, passed QA & pushed in one go -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 15:41:05 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 13:41:05 +0000 Subject: [Koha-bugs] [Bug 6720] Saved authorities always show as 'Default' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6720 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 15:41:32 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 13:41:32 +0000 Subject: [Koha-bugs] [Bug 6720] Saved authorities always show as 'Default' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6720 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 15:45:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 13:45:57 +0000 Subject: [Koha-bugs] [Bug 4198] deleting an authority refreshes the page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4198 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain at biblibre.com --- Comment #5 from Paul Poulain --- QA comment: * I had some trouble testing this one due to 983012d5b8d32abebf862f348b0de13aa3e549f3 and 42e20381fbd2cebaf06f00f80761008745d038b4 (that was not here already) * Other than this, this patch mostly move some code and add some parameters to URL * ../qa/koha-qa.pl -c 2 is OK passed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 15:46:32 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 13:46:32 +0000 Subject: [Koha-bugs] [Bug 4198] deleting an authority refreshes the page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4198 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_8 QA Contact|koha-bugs at lists.koha-commun |paul.poulain at biblibre.com |ity.org | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 15:47:32 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 13:47:32 +0000 Subject: [Koha-bugs] [Bug 7943] Untranslatable strings in OPAC's authority search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7943 --- Comment #15 from Paul Poulain --- (In reply to comment #14) > (In reply to comment #13) > > I think (although i'm not sure it's the culprit) that this patch broke the > > display of authorities search, I see " > > HASH(0xb4c3d88) " instead of the summary of the authority > > > > it's a blocker ! > > > > Side question = is it unimarc specific or no ? > > Please have a look at the patch in the Passed QA queue for staff display! yep. Jared pointed it on IRC. It passed QA between this morning and now, that's why I missed it. Thanks though -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 15:49:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 13:49:14 +0000 Subject: [Koha-bugs] [Bug 8552] BiblioAddsAuthorities set to Allow causes Software Error on Z3950 import In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8552 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P4 |P1 - high Severity|normal |critical --- Comment #1 from Joy Nelson --- The system preference AutoCreatesAuthorities states that "BiblioAddsAuthorities ust be set to 'allow' for this to have any effect". For libraries that wish to autogenerate authorities when cataloging via z3950import this is not possible at all. If biblioaddsauthorities is set to 'don't allow' in order to allow the z3950 cataloging to be successful, then authorities are not autogenerated. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 15:55:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 13:55:58 +0000 Subject: [Koha-bugs] [Bug 8028] Make table collapsing on parcel.pl sticky In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8028 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain at biblibre.com --- Comment #9 from Paul Poulain --- QA comment: I'm unable to understand & reproduce the problem and the solution. Could you give me more explanations ? A screenshot ? 2 comments (that will maybe be removed when I understand & reproduce): * is using a cookie the best way to do that ? * isn't DataTable jquery plugin what we should use ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 16:03:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 14:03:39 +0000 Subject: [Koha-bugs] [Bug 8544] Make RSS icon styleable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8544 --- Comment #4 from Robin Sheat --- Created attachment 11297 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11297&action=edit Bug 8544 - make the RSS icon CSS-changeable This gives the RSS bits on the search results some CSS classes so it can be modified with CSS or javascript. Updated: added also to the RSS icon shown when no results are found. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 16:04:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 14:04:11 +0000 Subject: [Koha-bugs] [Bug 8544] Make RSS icon styleable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8544 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11247|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 16:04:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 14:04:58 +0000 Subject: [Koha-bugs] [Bug 8544] Make RSS icon styleable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8544 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #5 from Robin Sheat --- I missed an instance of the RSS icon, so replacing the previous patch with one that does both. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 16:05:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 14:05:37 +0000 Subject: [Koha-bugs] [Bug 8561] New: can't alter manual invoice descriptions Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8561 Priority: P5 - low Change sponsored?: --- Bug ID: 8561 CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Assignee: koha-bugs at lists.koha-community.org Summary: can't alter manual invoice descriptions Severity: normal Classification: Unclassified OS: All Reporter: nengard at gmail.com Hardware: All Status: NEW Version: master Component: Circulation Product: Koha Created attachment 11298 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11298&action=edit not helpful single letter description For custom manual invoice categories there is the MANUAL_INV authorized value, but some of these types are hard coded with single letter descriptions which is not terribly useful. I vote that we move them all to the authorized value or at least update the descriptions to be more useful for people who install or upgrade Koha. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 16:10:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 14:10:09 +0000 Subject: [Koha-bugs] [Bug 8443] Suggestions : publication year and copyright date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8443 --- Comment #5 from Fridolyn SOMERS --- Hie Corinne. > You talk about copyright date...but there's no copyright date in your new form ??? I changed the filter on publication year into copyright date. Copyright date is suggestion form in OPAC and intranet. > You talk about itemtype...but there's non itemtype filter ?? I talk about item type in "organize by" combobox. > budget and date filters dont'work. I did not test budget filter. Maybe I'll try, otherwise I can be a new bug. > For date filters, ... Can't reproduce this problem. If it's a javascript problem, it can be a new bug. I corrected something in pl file. Best regards, -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 16:12:54 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 14:12:54 +0000 Subject: [Koha-bugs] [Bug 8463] Koha/SearchEngine/Solr/Search.pm fails perlcritic test In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8463 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain at biblibre.com --- Comment #4 from Paul Poulain --- QA comment: tiny patch just for perlcritic. Fixes perlcritic stuff, so it's OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 16:13:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 14:13:39 +0000 Subject: [Koha-bugs] [Bug 8463] Koha/SearchEngine/Solr/Search.pm fails perlcritic test In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8463 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_10 Assignee|gmcharlt at gmail.com |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 16:14:00 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 14:14:00 +0000 Subject: [Koha-bugs] [Bug 8463] Koha/SearchEngine/Solr/Search.pm fails perlcritic test In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8463 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |paul.poulain at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 16:33:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 14:33:25 +0000 Subject: [Koha-bugs] [Bug 8520] Authorities display incorrectly in staff results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8520 --- Comment #7 from Tom?s Cohen Arazi --- Please push. Affects 3.8 installs too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 16:36:30 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 14:36:30 +0000 Subject: [Koha-bugs] [Bug 7688] Change subscriptions numbering pattern and frequencies In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #30 from Paul Poulain --- QA comment: * this path is huge, but most of it's size is due to sample files in various language. Well done, even if they are not all translated. Will call for more translation when pushing * passing our QA script says: 1st problem = # Subroutines::ProhibitExplicitReturnUndef: Got 1 violation(s). I see that there is + return undef unless $subscriptionid; in GetSubscriptionIrregularities Should be + return unless $subscriptionid; 2nd problem = - xt/tt_valid.t tests... FAIL intranet-tmpl/prog/en/modules/serials/subscription-add.tt: 656, 666, 687 FAIL Those lines contain a construction that is still invalid (despite joubu effort): My git hook says nothing wrong. This patch will earn "passed QA" once the 2 previous problems have been fixed. Also note that there is a conflict easy to solve in C4/Serials.pm I've added a sub in bug 7839, just keep it, with your own ones (beware the closing } for subs !) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 16:37:52 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 14:37:52 +0000 Subject: [Koha-bugs] [Bug 8520] Authorities display incorrectly in staff results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8520 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_10 |rel_3_8 --- Comment #8 from Paul Poulain --- (In reply to comment #7) > Please push. Affects 3.8 installs too. I changed the version, for chris_c -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 16:48:26 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 14:48:26 +0000 Subject: [Koha-bugs] [Bug 8455] Check ins processed through "Check Out" tab of the Patron Record ignore Circulation System Preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8455 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain at biblibre.com Version|master |rel_3_8 --- Comment #7 from Paul Poulain --- QA comment: * fixes a real problem. The best fix would have been to refactor circulation to avoid code duplication. If we had a single entry point for circulation, the behaviour would have been correct. But I won't reject your patch because you haven't changed 100000 lines :-) No other comment, passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 16:52:46 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 14:52:46 +0000 Subject: [Koha-bugs] [Bug 8455] Check ins processed through "Check Out" tab of the Patron Record ignore Circulation System Preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8455 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Paul Poulain --- Another comment: on the members pages members/moremember.pl?borrowernumber=NNN, you can also check-in. This page calls reserve/renewscript.pl as well, so it fixes the behaviour here as well. ( Note that I haven't tested it works, but at least it does not break anything if you don't have InProcessingToShelvingCart or ReturnToShelvingCart set) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 16:55:55 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 14:55:55 +0000 Subject: [Koha-bugs] [Bug 8110] Fines accruing on closed days In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8110 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain at biblibre.com Depends on| |8486 --- Comment #38 from Paul Poulain --- Isn't this bug/patch also related to bug 8486 ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 16:55:55 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 14:55:55 +0000 Subject: [Koha-bugs] [Bug 8486] Critical error in Koha::Calendar::days_between calculation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8486 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8110 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 16:56:31 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 14:56:31 +0000 Subject: [Koha-bugs] [Bug 8418] Koha::Calendar is_holiday ignores all user data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8418 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain at biblibre.com --- Comment #19 from Paul Poulain --- isn't this patch somewhere redundant with bug 8486 ? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 17:00:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 15:00:25 +0000 Subject: [Koha-bugs] [Bug 7688] Change subscriptions numbering pattern and frequencies In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10985|0 |1 is obsolete| | --- Comment #31 from Julian Maurice --- Created attachment 11299 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11299&action=edit [SIGNED-OFF]?Bug 7688: Change subscription numbering pattern and frequencies Rebased on master Fixed conflict in updatedatabase.pl and trivial conflict in C4/Serials.pm as said by Paul -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 17:01:19 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 15:01:19 +0000 Subject: [Koha-bugs] [Bug 7688] Change subscriptions numbering pattern and frequencies In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688 --- Comment #32 from Julian Maurice --- Created attachment 11300 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11300&action=edit Bug 7688 follow-up: Small fixes for QA - # Subroutines::ProhibitExplicitReturnUndef: Got 1 violation(s) in C4::Serials::GetSubscriptionIrregularities - Bad template constructions fixed in serials/subscription-add.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 17:01:40 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 15:01:40 +0000 Subject: [Koha-bugs] [Bug 7688] Change subscriptions numbering pattern and frequencies In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 17:12:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 15:12:37 +0000 Subject: [Koha-bugs] [Bug 8209] "Did you mean?" suggestions based on authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8209 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #4 from Katrin Fischer --- Hi Jared, the new patch applies, a few first findings: 1) Tiny: +our $NAME = 'EmbedItems'; looks suspicious to me. 2) Tiny: The database update message has a tiny typo: Upgrade to 3.09.00.XXX done (Add system preference DidYouMeanFromAuthorities)) 3) Blocker: The suggestions don't show up correctly after activating the feature in system preferences: Did you mean: HASH(0x42a70e0) HASH(0x42a6ed0) HASH(0x429fbd0) HASH(0x429f630) 4) Might be data: I don't get results for the an=[0-9]* searches. I am not sure if this is my database or a general problem, but will wait with testing until 3) is fixed. 5) Suggestion: Use links instead of buttons for display of the suggestions. 6) Tiny: If I have no results for my search and no suggestions are generated, the "Sorry, no suggestions." section covers my "Powered by Koha". The variant for deactivated Javascript works very nicely, except for 3). Sorry to fail QA :( Because Paul pushed so many authority related featured today: I rebased the patch to current master shortly before I started testing. commit 9226ae46419a5c54447c7d6e27b6163d2c6fd95a -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 17:31:45 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 15:31:45 +0000 Subject: [Koha-bugs] [Bug 8185] Plugin for linking records in MARC21 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8185 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9904|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 17:33:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 15:33:58 +0000 Subject: [Koha-bugs] [Bug 8477] Display home & holding branches when checking in In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8477 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain at biblibre.com --- Comment #4 from Paul Poulain --- very usefull (necessary ?) for network libraries to know where an item comes from (if the librarian misses the transfer message and check-in another item for example) QA: small patch, passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 17:38:12 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 15:38:12 +0000 Subject: [Koha-bugs] [Bug 8477] Display home & holding branches when checking in In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8477 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |rel_3_8 Severity|enhancement |trivial --- Comment #5 from Paul Poulain --- it's an ENH, but could also be considered as a bugfix, because the information is missing. chris_c, your decision, upgrading severity a little -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 17:38:26 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 15:38:26 +0000 Subject: [Koha-bugs] [Bug 8477] Display home & holding branches when checking in In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8477 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master QA Contact| |paul.poulain at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 17:41:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 15:41:14 +0000 Subject: [Koha-bugs] [Bug 8477] Display home & holding branches when checking in In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8477 --- Comment #6 from Paul Poulain --- Another QA comment: [HTML4] coding guideline was not respected. I made a tiny follow-up -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 18:12:15 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 16:12:15 +0000 Subject: [Koha-bugs] [Bug 8209] "Did you mean?" suggestions based on authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8209 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 18:12:18 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 16:12:18 +0000 Subject: [Koha-bugs] [Bug 8209] "Did you mean?" suggestions based on authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8209 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11292|0 |1 is obsolete| | --- Comment #5 from Jared Camins-Esakov --- Created attachment 11301 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11301&action=edit Bug 8209: "Did you mean?" from authorities One of the ideas behind authority records is that users who search for one term should have related terms (according to the authority file) suggested to them. At the moment, Koha doesn't do that. Adding an authority searching step to regular searches and displaying any suggestions in a "Did you mean" bar at the top of the results would be very useful. This commit adds a Koha::SuggestionEngine class which is in charge of getting suggestions from individual suggestion engine plugins, which much be in the Koha::SuggestionEngine::Plugin::* namespace, and extend Koha::SuggestionEngine::Base. Suggestions are loaded asynchronously using AJAX, and a link to a page with suggestions is provided for users with Javascript turned off. The AuthorityFile suggestion engine plugin looks up the specified search terms in the authority file and then suggests searches for records using matching authorities. Signed-off-by: Jared Camins-Esakov Rebased 2 August 2012 and incorporated QA feedback -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 18:18:26 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 16:18:26 +0000 Subject: [Koha-bugs] [Bug 7455] Authority subfields are cloned in the wrong field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7455 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |paul.poulain at biblibre.com --- Comment #11 from Paul Poulain --- QA comments: * patch factorize many things, his size is mostly due to moving things * passes koha-qa.pl * very good test plan Worth a gold "passed QA" ! H?las ! my tests show there's a remaining problem: * create an authority with a subfield repeated containing AA, BB, CC, DD * save it, everything is OK * modify it * click on the clone image on DD... you get AA, AA, BB, CC, DD (AA is duplicated, it should be DD) (Checked for biblio, the problem is not here) Please provide a follow-up to earn your gold passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 18:22:08 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 16:22:08 +0000 Subject: [Koha-bugs] [Bug 8562] New: RandomizeHoldsQueueWeight ignored if StaticHoldsQueueWeight is empty. Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8562 Priority: P5 - low Change sponsored?: --- Bug ID: 8562 CC: gmcharlt at gmail.com Assignee: koha-bugs at lists.koha-community.org Summary: RandomizeHoldsQueueWeight ignored if StaticHoldsQueueWeight is empty. Severity: minor Classification: Unclassified OS: All Reporter: kyle at bywatersolutions.com Hardware: All Status: NEW Version: master Component: Hold requests Product: Koha If StaticHoldsQueueWeight is empty, but RandomizeHoldsQueueWeight is enabled, the script build_holds_queue.pl should select branches for fulfillment requests at random. Instead, it will select them in alphabetical order. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 18:22:13 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 16:22:13 +0000 Subject: [Koha-bugs] [Bug 8562] RandomizeHoldsQueueWeight ignored if StaticHoldsQueueWeight is empty. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8562 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 18:24:02 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 16:24:02 +0000 Subject: [Koha-bugs] [Bug 8562] RandomizeHoldsQueueWeight ignored if StaticHoldsQueueWeight is empty. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8562 --- Comment #1 from Kyle M Hall --- Created attachment 11302 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11302&action=edit Bug 8562 - RandomizeHoldsQueueWeight ignored if StaticHoldsQueueWeight is empty. If StaticHoldsQueueWeight is empty, but RandomizeHoldsQueueWeight is enabled, the script build_holds_queue.pl should select branches for fulfillment requests at random. Instead, it will select them in alphabetical order. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 18:24:13 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 16:24:13 +0000 Subject: [Koha-bugs] [Bug 8562] RandomizeHoldsQueueWeight ignored if StaticHoldsQueueWeight is empty. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8562 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 18:25:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 16:25:41 +0000 Subject: [Koha-bugs] [Bug 8562] RandomizeHoldsQueueWeight ignored if StaticHoldsQueueWeight is empty. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8562 --- Comment #2 from Kyle M Hall --- One thought, I wonder if we should just always randomize them in the case that StaticHoldsQueueWeight is empty. I cannot imagine an instance where a library system would want holds to be filled in alphabetical order. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 18:29:45 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 16:29:45 +0000 Subject: [Koha-bugs] [Bug 8562] RandomizeHoldsQueueWeight ignored if StaticHoldsQueueWeight is empty. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8562 --- Comment #3 from Kyle M Hall --- Created attachment 11303 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11303&action=edit Bug 8562 - RandomizeHoldsQueueWeight ignored if StaticHoldsQueueWeight is empty. Force randomization instead. If StaticHoldsQueueWeight is empty, but RandomizeHoldsQueueWeight is enabled, the script build_holds_queue.pl should select branches for fulfillment requests at random. Instead, it will select them in alphabetical order. This patch forces randomization in the event that StaticHoldsQueueWeight is empty, under the assumption that no library would wish to have libraries fulfill hold requests in alphabetical order. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 18:33:55 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 16:33:55 +0000 Subject: [Koha-bugs] [Bug 8562] RandomizeHoldsQueueWeight ignored if StaticHoldsQueueWeight is empty. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8562 --- Comment #4 from Kyle M Hall --- This second variation forces the shuffling in the case that StaticHoldsQueueWeight is empty. The larger benefit is the reduction of calls to C4::Context->preference from @bibs_with_pending_requests + 1 back down to 1. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 18:40:03 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 16:40:03 +0000 Subject: [Koha-bugs] [Bug 7417] Include alternate forms from authorities in bibliographic searches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7417 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Katrin Fischer --- I am very very excited about this feature, as it's something a lot of libraries have asked about. It already works, but we have to fix some rough edges: 1) Blocker: The detail page is all ok, but in the result list all the "see from" variations of the name show up in the results. 2) Blocker: There is a problem with the concatenation of strings for indexing: Authority record: used for/see from: Abraham, Barf??er Result list (see 1) ): AbrahamBarf??er; Search: Barf??er does not give any results, but AbrahamBarf??er does - so I think that display reflects the indexing here. 3) Tiny: You have to reindex _after_ activating the feature. I think it would be good to note that in the text of the system preference so people know that it won't work immediately and what to do about it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 18:45:56 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 16:45:56 +0000 Subject: [Koha-bugs] [Bug 6448] EAN-13 barcode support In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6448 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain at biblibre.com --- Comment #21 from Paul Poulain --- QA comment: * passes test-qa.pl * mostly include new feature using a lot of elsif, depending on the itemBarcodeInputFilter syspref. I tried to use "Remove spaces", still work well (dunno how to tests other cases) passed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 18:46:05 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 16:46:05 +0000 Subject: [Koha-bugs] [Bug 8550] Z39.50 searches for ISBN/ISSN problematic In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8550 Joseph Alway changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11273|0 |1 is obsolete| | --- Comment #3 from Joseph Alway --- Created attachment 11304 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11304&action=edit Bug 8550: Z39.50 searches for ISBN/ISSN problematic - Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 18:47:34 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 16:47:34 +0000 Subject: [Koha-bugs] [Bug 8550] Z39.50 searches for ISBN/ISSN problematic In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8550 Joseph Alway changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 18:48:42 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 16:48:42 +0000 Subject: [Koha-bugs] [Bug 8209] "Did you mean?" suggestions based on authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8209 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11301|0 |1 is obsolete| | --- Comment #6 from Jared Camins-Esakov --- Created attachment 11305 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11305&action=edit Bug 8209: "Did you mean?" from authorities One of the ideas behind authority records is that users who search for one term should have related terms (according to the authority file) suggested to them. At the moment, Koha doesn't do that. Adding an authority searching step to regular searches and displaying any suggestions in a "Did you mean" bar at the top of the results would be very useful. This commit adds a Koha::SuggestionEngine class which is in charge of getting suggestions from individual suggestion engine plugins, which much be in the Koha::SuggestionEngine::Plugin::* namespace, and extend Koha::SuggestionEngine::Base. Suggestions are loaded asynchronously using AJAX, and a link to a page with suggestions is provided for users with Javascript turned off. The AuthorityFile suggestion engine plugin looks up the specified search terms in the authority file and then suggests searches for records using matching authorities. Signed-off-by: Jared Camins-Esakov Rebased 2 August 2012 and incorporated QA feedback -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 18:50:20 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 16:50:20 +0000 Subject: [Koha-bugs] [Bug 6448] EAN-13 barcode support In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6448 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_10 QA Contact|koha-bugs at lists.koha-commun |paul.poulain at biblibre.com |ity.org | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 19:17:20 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 17:17:20 +0000 Subject: [Koha-bugs] [Bug 8563] New: hieroglyphs on Bar codes Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8563 Priority: P5 - low Change sponsored?: --- Bug ID: 8563 Assignee: cnighswonger at foundations.edu Summary: hieroglyphs on Bar codes Severity: enhancement Classification: Unclassified OS: All Reporter: agergedava at yahoo.com Hardware: All Status: NEW Version: unspecified Component: Label printing Product: Koha Created attachment 11306 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11306&action=edit hieroglyphs on Bar codes Hi, we have problems. On the photo, I have attached, you can see that on the bar code there is some hieroglyphs instead of Georgian letters. Cataloging we are doing in Georgian, so there should appear Georgian letters but it don't. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 19:17:59 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 17:17:59 +0000 Subject: [Koha-bugs] [Bug 8564] New: Bar codes in two rows Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8564 Priority: P5 - low Change sponsored?: --- Bug ID: 8564 Assignee: cnighswonger at foundations.edu Summary: Bar codes in two rows Severity: enhancement Classification: Unclassified OS: All Reporter: agergedava at yahoo.com Hardware: All Status: NEW Version: unspecified Component: Label printing Product: Koha Created attachment 11307 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11307&action=edit Bar codes in three rows as you can see bar codes are split in three rows. Our bar code papers are split in two rows? what and how to change in settings? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 19:28:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 17:28:48 +0000 Subject: [Koha-bugs] [Bug 8563] hieroglyphs on Bar codes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8563 Chris Nighswonger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Chris Nighswonger --- This topic is dealt with under bug 2246 which will not be fixed for the reasons stated there. *** This bug has been marked as a duplicate of bug 2246 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 19:28:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 17:28:48 +0000 Subject: [Koha-bugs] [Bug 2246] Label printing doesn't work with Unicode characters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2246 Chris Nighswonger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |agergedava at yahoo.com --- Comment #19 from Chris Nighswonger --- *** Bug 8563 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 19:30:16 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 17:30:16 +0000 Subject: [Koha-bugs] [Bug 8564] Bar codes in two rows In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8564 Chris Nighswonger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #1 from Chris Nighswonger --- You'll have to setup a template and layout to match your particular label sheets. Please see the documentation for further details. Docs may be found here: http://koha-community.org/documentation/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 19:45:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 17:45:35 +0000 Subject: [Koha-bugs] [Bug 8565] New: forgive fines doesn't work Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8565 Priority: P5 - low Change sponsored?: --- Bug ID: 8565 CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Assignee: koha-bugs at lists.koha-community.org Summary: forgive fines doesn't work Severity: major Classification: Unclassified OS: All Reporter: nengard at gmail.com Hardware: All Status: NEW Version: master Component: Circulation Product: Koha It does not appear that forgive fines on the checkin screen actually forgives anything. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 19:45:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 17:45:48 +0000 Subject: [Koha-bugs] [Bug 8565] forgive fines doesn't work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8565 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=5216 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 19:45:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 17:45:48 +0000 Subject: [Koha-bugs] [Bug 5216] Returning lost material with Forgive Fines does not forgive overdue charges In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5216 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8565 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 20:06:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 18:06:14 +0000 Subject: [Koha-bugs] [Bug 6617] table of contents not printing right if entered right In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6617 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #5 from Nicole C. Engard --- Bug 6617: Improve MARC21 enhanced contents display Apply? [yn] y Applying: Bug 6617: Improve MARC21 enhanced contents display error: patch failed: koha-tmpl/opac-tmpl/prog/en/css/opac.css:2769 error: koha-tmpl/opac-tmpl/prog/en/css/opac.css: patch does not apply Patch failed at 0001 Bug 6617: Improve MARC21 enhanced contents display When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". Patch left in /tmp/Bug-6617-Improve-MARC21-enhanced-contents-display-i2WrDf.patch nengard at kohavm:~/kohaclone$ -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 20:14:45 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 18:14:45 +0000 Subject: [Koha-bugs] [Bug 6617] table of contents not printing right if entered right In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6617 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 20:14:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 18:14:47 +0000 Subject: [Koha-bugs] [Bug 6617] table of contents not printing right if entered right In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6617 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11211|0 |1 is obsolete| | --- Comment #6 from Jared Camins-Esakov --- Created attachment 11308 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11308&action=edit Bug 6617: Improve MARC21 enhanced contents display The display of "Enhanced" 505 (contents) fields in the MARC21 XSLT is very poor, resulting in large, unreadable blocks of text, and -- for some series -- so much unnecessary duplication in the Notes tab that important information is entirely obscured. This patch reformats "enhanced" contents fields (MARC21 505 fields with $t and $r) so as to be more readable by breaking up entries on separate lines and making titles bold (to make them stand out more). To test: 1) View record with enhanced 505 field before applying patch. Observe it is very unfriendly. 2) Apply patch. 3) View same record, note that display is much improved. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 20:16:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 18:16:39 +0000 Subject: [Koha-bugs] [Bug 6617] table of contents not printing right if entered right In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6617 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #7 from Nicole C. Engard --- it applies but now my toc is replaced with the word Test -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 20:18:53 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 18:18:53 +0000 Subject: [Koha-bugs] [Bug 6617] table of contents not printing right if entered right In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6617 --- Comment #8 from Nicole C. Engard --- Oh .. that 'Test' string was my note :) hehe - so the patch removes my TOC altogether from the Title Notes tab and shows it the same way in the top XSLT as it did before. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 20:22:03 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 18:22:03 +0000 Subject: [Koha-bugs] [Bug 6617] table of contents not printing right if entered right In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6617 --- Comment #9 from Jared Camins-Esakov --- And you are using $t and $r in your table of contents? Any chance you could attach the record? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 20:30:55 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 18:30:55 +0000 Subject: [Koha-bugs] [Bug 6617] table of contents not printing right if entered right In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6617 --- Comment #10 from Nicole C. Engard --- Created attachment 11309 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11309&action=edit updated marc -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 20:31:08 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 18:31:08 +0000 Subject: [Koha-bugs] [Bug 6617] table of contents not printing right if entered right In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6617 --- Comment #11 from Nicole C. Engard --- Created attachment 11310 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11310&action=edit opac view -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 20:31:51 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 18:31:51 +0000 Subject: [Koha-bugs] [Bug 6617] table of contents not printing right if entered right In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6617 --- Comment #12 from Nicole C. Engard --- Created attachment 11311 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11311&action=edit staff view the title/author toc shows now - but doesn't have any formatting like in the opac. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 20:52:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 18:52:47 +0000 Subject: [Koha-bugs] [Bug 7161] Open Library - Larger image, Read, borrow and checked-out status In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7161 --- Comment #13 from Nicole C. Engard --- Created attachment 11312 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11312&action=edit tini tiny cover on search results My bug was marked a duplicate of this - but this didn't fix my my bug which was that the open library images are too small to see on the search results. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 20:59:07 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 18:59:07 +0000 Subject: [Koha-bugs] [Bug 6617] table of contents not printing right if entered right In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6617 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 20:59:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 18:59:09 +0000 Subject: [Koha-bugs] [Bug 6617] table of contents not printing right if entered right In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6617 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11308|0 |1 is obsolete| | --- Comment #13 from Jared Camins-Esakov --- Created attachment 11313 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11313&action=edit Bug 6617: Improve MARC21 enhanced contents display The display of "Enhanced" 505 (contents) fields in the MARC21 XSLT is very poor, resulting in large, unreadable blocks of text, and -- for some series -- so much unnecessary duplication in the Notes tab that important information is entirely obscured. This patch reformats "enhanced" contents fields (MARC21 505 fields with $t and $r) so as to be more readable by breaking up entries on separate lines and making titles bold (to make them stand out more). To test: 1) View record with enhanced 505 field before applying patch. Observe it is very unfriendly. 2) Apply patch. 3) View same record, note that display is much improved. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 21:01:18 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 19:01:18 +0000 Subject: [Koha-bugs] [Bug 6617] table of contents not printing right if entered right In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6617 --- Comment #14 from Nicole C. Engard --- Created attachment 11314 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11314&action=edit toc after patch TOC looks great! The fact that it's under the image instead of to the right of it is a problem. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 21:01:42 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 19:01:42 +0000 Subject: [Koha-bugs] [Bug 6617] table of contents not printing right if entered right In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6617 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 21:02:03 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 19:02:03 +0000 Subject: [Koha-bugs] [Bug 6617] table of contents not printing right if entered right In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6617 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11310|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 21:02:40 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 19:02:40 +0000 Subject: [Koha-bugs] [Bug 6617] table of contents not printing right if entered right In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6617 --- Comment #15 from Nicole C. Engard --- Created attachment 11315 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11315&action=edit toc before the patch TOC is to the right of the cover image (coming from open library) before the patch. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 21:10:19 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 19:10:19 +0000 Subject: [Koha-bugs] [Bug 6617] table of contents not printing right if entered right In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6617 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 21:10:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 19:10:21 +0000 Subject: [Koha-bugs] [Bug 6617] table of contents not printing right if entered right In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6617 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11313|0 |1 is obsolete| | --- Comment #16 from Jared Camins-Esakov --- Created attachment 11316 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11316&action=edit Bug 6617: Improve MARC21 enhanced contents display The display of "Enhanced" 505 (contents) fields in the MARC21 XSLT is very poor, resulting in large, unreadable blocks of text, and -- for some series -- so much unnecessary duplication in the Notes tab that important information is entirely obscured. This patch reformats "enhanced" contents fields (MARC21 505 fields with $t and $r) so as to be more readable by breaking up entries on separate lines and making titles bold (to make them stand out more). This patch does not address duplication of information in the Notes tab, per discussion on the #koha IRC channel. To test: 1) View record with enhanced 505 field before applying patch. Observe it is very unfriendly. 2) Apply patch. 3) View same record, note that display is much improved. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 21:12:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 19:12:39 +0000 Subject: [Koha-bugs] [Bug 6617] table of contents not printing right if entered right In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6617 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11314|0 |1 is obsolete| | --- Comment #17 from Nicole C. Engard --- Created attachment 11317 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11317&action=edit toc after patch This time most of the stuff is to the right, but not the TOC. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 21:12:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 19:12:48 +0000 Subject: [Koha-bugs] [Bug 6617] table of contents not printing right if entered right In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6617 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 21:49:17 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 19:49:17 +0000 Subject: [Koha-bugs] [Bug 6617] table of contents not printing right if entered right In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6617 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 21:49:19 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 19:49:19 +0000 Subject: [Koha-bugs] [Bug 6617] table of contents not printing right if entered right In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6617 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11316|0 |1 is obsolete| | --- Comment #18 from Jared Camins-Esakov --- Created attachment 11318 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11318&action=edit Bug 6617: Improve MARC21 enhanced contents display The display of "Enhanced" 505 (contents) fields in the MARC21 XSLT is very poor, resulting in large, unreadable blocks of text, and -- for some series -- so much unnecessary duplication in the Notes tab that important information is entirely obscured. This patch reformats "enhanced" contents fields (MARC21 505 fields with $t and $r) so as to be more readable by breaking up entries on separate lines and making titles bold (to make them stand out more). This patch does not address duplication of information in the Notes tab, per discussion on the #koha IRC channel. To test: 1) View record with enhanced 505 field before applying patch. Observe it is very unfriendly. 2) Apply patch. 3) View same record, note that display is much improved. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 22:11:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 20:11:28 +0000 Subject: [Koha-bugs] [Bug 7417] Include alternate forms from authorities in bibliographic searches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7417 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 22:11:30 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 20:11:30 +0000 Subject: [Koha-bugs] [Bug 7417] Include alternate forms from authorities in bibliographic searches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7417 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11253|0 |1 is obsolete| | --- Comment #4 from Jared Camins-Esakov --- Created attachment 11319 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11319&action=edit Bug 7417: Include see from references in bibliographic searches This patch adds the Koha::Indexer::RecordNormalizer and Koha::Indexer::MARC::RecordNormalizer::EmbedSeeFromHeadings packages to enable the inclusion of alternate forms of headings in bibliographic searches. When the new syspref IncludeSeeFromInSearches is turned on (default is off) rebuild_zebra.pl will insert see from headings from authority records into bibliographic records when indexing, so that a search on an obsolete term will turn up relevant records. To test: 1) Enable IncludeSeeFromInSearches 2) Add a heading that has an alternate form to a record (for example, "Cooking" has the alternate form "Cookery," if you have authority records from LC) 3) Index the zebraqueue (or reindex if you haven't indexed your system yet) 4) Confirm that if you search for "Cookery" you get the record you just modified Signed-off-by: Jared Camins-Esakov Rebased on master 1 August 2012 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 22:13:15 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 20:13:15 +0000 Subject: [Koha-bugs] [Bug 7417] Include alternate forms from authorities in bibliographic searches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7417 --- Comment #5 from Jared Camins-Esakov --- (In reply to comment #3) > I am very very excited about this feature, as it's something a lot of > libraries have asked about. It already works, but we have to fix some rough > edges: > > 1) Blocker: The detail page is all ok, but in the result list all the "see > from" variations of the name show up in the results. Fixed. > 2) Blocker: There is a problem with the concatenation of strings for > indexing: > > Authority record: used for/see from: Abraham, Barf??er > > Result list (see 1) ): AbrahamBarf??er; > > Search: Barf??er does not give any results, but AbrahamBarf??er does - so I > think that display reflects the indexing here. I was not able to replicate the problem, but I have an idea what it might have been, and fixed the issue I identified, so let me know if the updated patch works. > 3) Tiny: You have to reindex _after_ activating the feature. I think it > would be good to note that in the text of the system preference so people > know that it won't work immediately and what to do about it. Noted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 23:31:20 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 21:31:20 +0000 Subject: [Koha-bugs] [Bug 6655] Sorting order of serial issues in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6655 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #11 from Chris Cormack --- Pushed to 3.8.x will be in 3.8.4 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 23:34:31 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 21:34:31 +0000 Subject: [Koha-bugs] [Bug 7848] Issues data missing from circulation notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7848 --- Comment #14 from Jared Camins-Esakov --- If this is intended to apply to 3.6.x, please provide a patch rebased against 3.6-testing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 23:48:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 21:48:58 +0000 Subject: [Koha-bugs] [Bug 8421] patron images fail when barcode for patron has a + In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8421 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #4 from Chris Cormack --- Pushed to 3.8.x, will be in 3.8.4 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 2 23:56:34 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 21:56:34 +0000 Subject: [Koha-bugs] [Bug 8520] Authorities display incorrectly in staff results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8520 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #9 from Chris Cormack --- Pushed to 3.8.x, will be in 3.8.4 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 00:34:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 22:34:57 +0000 Subject: [Koha-bugs] [Bug 6720] Saved authorities always show as 'Default' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6720 --- Comment #29 from Chris Cormack --- The three patches here don't apply cleanly to 3.8.x <<<<<<< HEAD ======= my $thisauthtype = GetAuthType(GetAuthTypeCode($authid)); $newline{authtype} = defined ($thisauthtype) ? $thisauthtype->{'authtypetext'} : (GetAuthType($authtypecode) ? $_->{'authtypetext'} : ''); >>>>>>> 983012d... Bug 6720 follow-up: fix error when auth has been deleted -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 01:11:26 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Aug 2012 23:11:26 +0000 Subject: [Koha-bugs] [Bug 8455] Check ins processed through "Check Out" tab of the Patron Record ignore Circulation System Preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8455 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #9 from Chris Cormack --- Bug fix patch is in 3.8.x, will be in 3.8.4 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 02:26:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 00:26:09 +0000 Subject: [Koha-bugs] [Bug 8477] Display home & holding branches when checking in In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8477 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Version|rel_3_8 |rel_3_10 Severity|trivial |enhancement -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 05:49:20 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 03:49:20 +0000 Subject: [Koha-bugs] [Bug 8003] Tag "" is not a valid tag. at /usr/share/koha/lib/C4/Biblio.pm line 2045 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8003 mustaqeem changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mustaqeemabd at gmail.com --- Comment #3 from mustaqeem --- I get this error using Koha 3.08 how to solve this..? thank you. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 07:34:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 05:34:21 +0000 Subject: [Koha-bugs] [Bug 8033] add print receipt option to Koha self-check In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 07:50:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 05:50:29 +0000 Subject: [Koha-bugs] [Bug 8544] Make RSS icon styleable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8544 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11297|0 |1 is obsolete| | --- Comment #6 from Marc V?ron --- Created attachment 11320 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11320&action=edit [SIGNED-OFF] Bug 8544 - make the RSS icon CSS-changeable This gives the RSS bits on the search results some CSS classes so it can be modified with CSS or javascript. Updated: added also to the RSS icon shown when no results are found. Signed-off-by: Marc Veron Patch behaves as expected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 07:51:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 05:51:11 +0000 Subject: [Koha-bugs] [Bug 8544] Make RSS icon styleable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8544 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 08:46:55 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 06:46:55 +0000 Subject: [Koha-bugs] [Bug 8209] "Did you mean?" suggestions based on authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8209 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11305|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer --- Created attachment 11321 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11321&action=edit [SIGNED-OFF] Bug 8209: "Did you mean?" from authorities One of the ideas behind authority records is that users who search for one term should have related terms (according to the authority file) suggested to them. At the moment, Koha doesn't do that. Adding an authority searching step to regular searches and displaying any suggestions in a "Did you mean" bar at the top of the results would be very useful. This commit adds a Koha::SuggestionEngine class which is in charge of getting suggestions from individual suggestion engine plugins, which much be in the Koha::SuggestionEngine::Plugin::* namespace, and extend Koha::SuggestionEngine::Base. Suggestions are loaded asynchronously using AJAX, and a link to a page with suggestions is provided for users with Javascript turned off. The AuthorityFile suggestion engine plugin looks up the specified search terms in the authority file and then suggests searches for records using matching authorities. Signed-off-by: Jared Camins-Esakov Rebased 2 August 2012 and incorporated QA feedback Signed-off-by: Katrin Fischer Test plan: - Verified database update added system preference correctly, pref defaults to OFF - Verified search results and detail pages in OPAC and staff still worked the same as before * for no results * with results - Activated system preference and tested various searches * Searches from simple search * Searches from advanced search * Search links in records - Deactivated Javascript - verified fallback works correctly Notes: - Suggested terms can include autorities with no linked records. - When combining more than one search option using advanced search this results in "no suggestions" more often. Feature works best from simple search. Overall great feature making use of authorities in a user friendly way! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 08:47:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 06:47:09 +0000 Subject: [Koha-bugs] [Bug 8209] "Did you mean?" suggestions based on authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8209 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 09:32:16 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 07:32:16 +0000 Subject: [Koha-bugs] [Bug 8544] Make RSS icon styleable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8544 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #7 from Jonathan Druart --- Add 2 class for the RSS icon (the 2 only occurrences). Marking as Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 11:23:23 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 09:23:23 +0000 Subject: [Koha-bugs] [Bug 6448] EAN-13 barcode support In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6448 --- Comment #22 from Paul Poulain --- Jenkins warning = this patch makes db_dependant test failed: perl t/db_dependent/Barcodes.t 1..66 ok 1 - use C4::Barcodes; 3.436456908560981e17 not valid EAN-13 barcode at /home/paul/koha.dev/koha-community//C4/Barcodes/EAN13.pm line 43. # Looks like you planned 66 tests but ran 1. # Looks like your test exited with 255 just after 1; The test dies because the 25 ok($obj1 = C4::Barcodes->new($_), "$pre Barcode Creation : new($_)"); calls C4::Barcodes::EAN13::parse, and the barcode is invalid I thought it was because of my database, but I'm not sure it is. Is it because of the database jenkins uses or something else, I can't say. But for sure, you're welcomed to investigate. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 11:25:02 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 09:25:02 +0000 Subject: [Koha-bugs] [Bug 8566] New: Enable koha-foreach to insert the instancename into commands Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8566 Priority: P5 - low Change sponsored?: --- Bug ID: 8566 CC: robin at catalyst.net.nz Assignee: koha-bugs at lists.koha-community.org Summary: Enable koha-foreach to insert the instancename into commands Severity: enhancement Classification: Unclassified OS: All Reporter: magnus at enger.priv.no Hardware: All Status: NEW Version: master Component: Packaging Product: Koha The synopsis for koha-foreach looks like this: koha-foreach [--enabled] [--email|--noemail] [command] It is used e.g. in cron configs, like this: koha-foreach --enabled /usr/share/koha/bin/cronjobs/fines.pl It would be very useful if we could provide a placeholder in the command, which could then be replaced with the name of the current instance. Then we could do e.g.: koha-foreach --enabled /usr/share/koha/bin/cronjobs/fines.pl --out /var/log/koha/__instancename__ and have fines.pl use the right directory for each instance. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 11:32:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 09:32:43 +0000 Subject: [Koha-bugs] [Bug 6448] EAN-13 barcode support In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6448 --- Comment #23 from Paul Poulain --- (In reply to comment #22) > I thought it was because of my database, but I'm not sure it is. Is it > because of the database jenkins uses or something else, I can't say. OK, it is my database, but also the jenkin's one ! I activated $debug, and see: autoBarcode format = EAN13 at t/db_dependent/Barcodes.t line 26 trying to create new EAN13 Retrieving max database query. (current) max barcode found: 3.436456908560981e17 3.436456908560981e17 not valid EAN-13 barcode at /home/paul/koha.dev/koha-community//C4/Barcodes/EAN13.pm line 43. I see that the (current) max barcode found comes from SELECT max(abs(barcode)) FROM items LIMIT 1; which is wrong for me because I don't have EAN13 as barcodes, but seems it's also wrong for the jenkins database. Dobrica, please provide needed information to chris_c ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 11:35:23 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 09:35:23 +0000 Subject: [Koha-bugs] [Bug 8567] New: Set output directory for fines.pl in cron config created by the packages Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8567 Priority: P5 - low Change sponsored?: --- Bug ID: 8567 CC: robin at catalyst.net.nz Assignee: koha-bugs at lists.koha-community.org Summary: Set output directory for fines.pl in cron config created by the packages Severity: enhancement Classification: Unclassified OS: All Reporter: magnus at enger.priv.no Hardware: All Status: NEW Version: master Component: Packaging Product: Koha When the Debian packages are installed, they create a /etc/cron.daily/koha-common config based on the template in debian/koha-common.cron.daily. This results in the following command for fines.pl: koha-foreach --enabled /usr/share/koha/bin/cronjobs/fines.pl and this results in this script writing daily log files to /tmp, which is less than ideal. Now, fines.pl has an option --out to specify where the logs are saved, so we could change the cron config to something like this: koha-foreach --enabled /usr/share/koha/bin/cronjobs/fines.pl --out /var/log/koha/__instancename__ Caveat: This depends on Bug 8566 being implemented first! (Because without it there is no way for koha-foreach to use directories named after the instances.) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 11:35:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 09:35:35 +0000 Subject: [Koha-bugs] [Bug 8567] Set output directory for fines.pl in cron config created by the packages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8567 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |8566 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 11:35:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 09:35:35 +0000 Subject: [Koha-bugs] [Bug 8566] Enable koha-foreach to insert the instancename into commands In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8566 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8567 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 11:45:59 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 09:45:59 +0000 Subject: [Koha-bugs] [Bug 8385] searchengine/solr/indexes.tt fails 'prove ./xt/tt_valid.t' test In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8385 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |paul.poulain at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 11:47:04 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 09:47:04 +0000 Subject: [Koha-bugs] [Bug 8385] searchengine/solr/indexes.tt fails 'prove ./xt/tt_valid.t' test In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8385 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Version|master |rel_3_10 --- Comment #6 from Paul Poulain --- QA comment: this patch is needed because of the limits of our translation tools. Jonathan tried to fix it, but failed. So it's still required that there is no [% %] inside html, because the translation parser can't handle them at all. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 11:47:13 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 09:47:13 +0000 Subject: [Koha-bugs] [Bug 8385] searchengine/solr/indexes.tt fails 'prove ./xt/tt_valid.t' test In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8385 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 11:51:54 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 09:51:54 +0000 Subject: [Koha-bugs] [Bug 8544] Make RSS icon styleable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8544 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com QA Contact| |jonathan.druart at biblibre.co | |m --- Comment #8 from Paul Poulain --- Patch pushed. It's a minor enhancement, probably not for 3.8, but chris_c, it's up to you, Robin put 3.8, I don't change it -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 12:00:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 10:00:43 +0000 Subject: [Koha-bugs] [Bug 8568] New: Fix some errors in docs for scripts provided by the Debian packages Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8568 Priority: P5 - low Change sponsored?: --- Bug ID: 8568 Assignee: magnus at enger.priv.no Summary: Fix some errors in docs for scripts provided by the Debian packages Severity: enhancement Classification: Unclassified OS: All Reporter: magnus at enger.priv.no Hardware: All Status: NEW Version: master Component: Documentation Product: Koha 1. debian/docs/koha-common.xml does not list koha-create 2. debian/docs/koha-common.xml does list koha-remove, but on one system I tested it was not displayed, this needs some more investigation 3. debian/docs/koha-foreach.xml uses koha-list in the synopsis of the command. The arguments are the same, but doh... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 12:06:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 10:06:37 +0000 Subject: [Koha-bugs] [Bug 8263] Make OPAC stylesheet preferences more consistent In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8263 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain at biblibre.com Version|master |rel_3_10 QA Contact| |paul.poulain at biblibre.com --- Comment #14 from Paul Poulain --- QA comment: * FAUSP leader is happy ;-) * clean code that should gracefully handle existing setups * passes koha-qa.pl -c 2 * grepped opacstylesheet, and I can't see references to this string outside from updatedatabase and translations (it will be removed automatically later, when translation process start) passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 12:29:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 10:29:27 +0000 Subject: [Koha-bugs] [Bug 8263] Make OPAC stylesheet preferences more consistent In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8263 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 12:41:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 10:41:25 +0000 Subject: [Koha-bugs] [Bug 8117] Divide budget periods into two tabs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8117 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain at biblibre.com --- Comment #16 from Paul Poulain --- QA comment: * small patch, just for a better display * passes test-qa.pl * A fix and a question: - you weren't respecting [HTML4] coding guideline (Active Budget should have been Active budget). I've fixed them - why do you repeat (as

the title of the tab at the beginning ot the tab ?) * is it me or the toolbar does not display nice buttons but basic links New budget, New, Budgets, Budget planning are in blue, not styled. I tried shift-reload, switching to another page, switching to another language, the problem is still here pls check my last point -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 12:42:59 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 10:42:59 +0000 Subject: [Koha-bugs] [Bug 8376] Command line utility for exporting borrowers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8376 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #8 from Julian Maurice --- Ok in master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 12:43:56 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 10:43:56 +0000 Subject: [Koha-bugs] [Bug 7292] new permission for claims In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7292 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 13:19:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 11:19:48 +0000 Subject: [Koha-bugs] [Bug 8028] Make table collapsing on parcel.pl sticky In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8028 --- Comment #10 from Kyle M Hall --- (In reply to comment #9) > QA comment: I'm unable to understand & reproduce the problem and the > solution. Could you give me more explanations ? A screenshot ? Currently, if there are more than 5 items in the table on parcel.pl, it only shows you the first 5. You must click a link to show more than 5. This patch makes the page 'remember' if you would prefer to see just the first 5, or more than 5. > 2 comments (that will maybe be removed when I understand & reproduce): > * is using a cookie the best way to do that ? I think it is the best way to accomplish this. The idea is to give the librarians the choice. A system preference would force all the librarians to have the same behavior ( 5 or more than 5 ). Additionally, parameter passing won't work without adding the parameter to *every* page in Koha, which sounds like a far worse solution. > * isn't DataTable jquery plugin what we should use ? Nobody as implemented DataTables here, and it is outside the scope of this bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 13:24:08 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 11:24:08 +0000 Subject: [Koha-bugs] [Bug 4118] Add Collection Code to Statistics Table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4118 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #13 from Kyle M Hall --- (In reply to comment #12) > QA comment: > > Why do you have > + > +=item DropAllForeignKeys($table) > + > in 1st patch ? That was an accident. I'll add another followup to remove it. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 13:28:02 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 11:28:02 +0000 Subject: [Koha-bugs] [Bug 4118] Add Collection Code to Statistics Table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4118 --- Comment #14 from Kyle M Hall --- Created attachment 11322 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11322&action=edit Bug 4118 - Add Collection Code to Statistics Table - QA Followup -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 13:28:50 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 11:28:50 +0000 Subject: [Koha-bugs] [Bug 4118] Add Collection Code to Statistics Table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4118 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 13:36:13 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 11:36:13 +0000 Subject: [Koha-bugs] [Bug 8546] Error in description of OPAC Advanced Search Publication date range search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8546 Kari Blomster changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.kirjasto.hailuoto at gmail.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 13:52:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 11:52:28 +0000 Subject: [Koha-bugs] [Bug 8408] Odd OPAC message when OPAC Renewals are disabled and OPACFineNoRenewals is set to blank In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8408 --- Comment #9 from Kyle M Hall --- (In reply to comment #8) > This changes the behaviour, > > Now instead of telling them they are blocked from renewing because they owe > over the fine threshold, it just tells them how much they owe. This message never told the user they were blocked from renewing, it is the message given if OpacRenewalAllowed is disabled. The previous message was "Please note: You have more than X.XX in fines." I don't think this is radically different. If you think is should mention renewing items, I can add that. On another not, it appears that this patch has been pushed to master. I just noticed this patch breaks the OpacRenewalAllowed version of the message. I will write a followup to address this issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 13:54:36 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 11:54:36 +0000 Subject: [Koha-bugs] [Bug 8408] Odd OPAC message when OPAC Renewals are disabled and OPACFineNoRenewals is set to blank In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8408 --- Comment #10 from Kyle M Hall --- Created attachment 11323 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11323&action=edit Bug 8408 - Followup - Fix broken messages. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 13:57:55 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 11:57:55 +0000 Subject: [Koha-bugs] [Bug 8408] Odd OPAC message when OPAC Renewals are disabled and OPACFineNoRenewals is set to blank In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8408 --- Comment #11 from Kyle M Hall --- Created attachment 11324 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11324&action=edit Bug 8408 - Followup 2 - Add reference to renewing items. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 13:59:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 11:59:41 +0000 Subject: [Koha-bugs] [Bug 8408] Odd OPAC message when OPAC Renewals are disabled and OPACFineNoRenewals is set to blank In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8408 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 14:19:51 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 12:19:51 +0000 Subject: [Koha-bugs] [Bug 8117] Divide budget periods into two tabs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8117 --- Comment #17 from Jonathan Druart --- (In reply to comment #16) > QA comment: > - you weren't respecting [HTML4] coding guideline (Active Budget should > have been Active budget). I've fixed them Thanks! > - why do you repeat (as

the title of the tab at the beginning ot > the tab ?) You're right. It's useless, I will submit a followup > * is it me or the toolbar does not display nice buttons but basic links New > budget, New, Budgets, Budget planning are in blue, not styled. I tried > shift-reload, switching to another page, switching to another language, the > problem is still here I don't reproduce this behaviour. Buttons display correctly for me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 14:20:03 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 12:20:03 +0000 Subject: [Koha-bugs] [Bug 8117] Divide budget periods into two tabs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8117 --- Comment #18 from Jonathan Druart --- Created attachment 11325 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11325&action=edit Bug 8117: Followup: remove h3 title (duplicate infos) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 14:21:42 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 12:21:42 +0000 Subject: [Koha-bugs] [Bug 6617] table of contents not printing right if entered right In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6617 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11318|0 |1 is obsolete| | --- Comment #19 from Nicole C. Engard --- Created attachment 11326 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11326&action=edit [SIGNED-OFF] Bug 6617: Improve MARC21 enhanced contents display The display of "Enhanced" 505 (contents) fields in the MARC21 XSLT is very poor, resulting in large, unreadable blocks of text, and -- for some series -- so much unnecessary duplication in the Notes tab that important information is entirely obscured. This patch reformats "enhanced" contents fields (MARC21 505 fields with $t and $r) so as to be more readable by breaking up entries on separate lines and making titles bold (to make them stand out more). This patch does not address duplication of information in the Notes tab, per discussion on the #koha IRC channel. To test: 1) View record with enhanced 505 field before applying patch. Observe it is very unfriendly. 2) Apply patch. 3) View same record, note that display is much improved. Signed-off-by: Nicole C. Engard This first patch works as advertised. It formats the table of contents on the opac detail display in a cleaner format. I recommend that future follow ups fix the staff client to match and update the title notes tabs on the opac and staff client to also match the cleaner format for table of contents. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 14:22:01 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 12:22:01 +0000 Subject: [Koha-bugs] [Bug 6617] table of contents not printing right if entered right In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6617 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 14:57:19 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 12:57:19 +0000 Subject: [Koha-bugs] [Bug 7189] preference to control if returning lost items gives refund In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7189 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain at biblibre.com --- Comment #18 from Paul Poulain --- QA Comment: * FFUSP (Fundation For Usefull System Preferences) agrees that FFAUSP leader must not complain for this one ;-) * passes test-qa.pl * Not a lot of code. What is written passes QA, But I can't test this patch. I have an item with items.price and items.replacementprice set to 10 I've LOST authorised values defined, and they are attached to items.lost When I open catalogue/moredetail.pl?biblionumber=21668&itemnumber=23170#item23170 I see the "LOST list". If I choose one of them, the book is automatically checked-in, that's OK, but the price is not charged to the patron. What did I miss ? (marking passed QA, it's probably me, but I won't push until I could test) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 14:57:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 12:57:33 +0000 Subject: [Koha-bugs] [Bug 7189] preference to control if returning lost items gives refund In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7189 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|koha.sekjal at gmail.com |paul.poulain at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 15:05:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 13:05:09 +0000 Subject: [Koha-bugs] [Bug 7628] Required format is not enforced for Patron Categories In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7628 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain at biblibre.com --- Comment #11 from Paul Poulain --- QA comment: small patch, test-qa.pl OK, passes QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 15:05:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 13:05:57 +0000 Subject: [Koha-bugs] [Bug 7628] Required format is not enforced for Patron Categories In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7628 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_8 QA Contact|koha.sekjal at gmail.com |paul.poulain at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 15:06:52 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 13:06:52 +0000 Subject: [Koha-bugs] [Bug 8498] can't specify an hour when specifying due date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8498 --- Comment #12 from Kyle M Hall --- (In reply to comment #10) > QA Comment: > * Owen/Kyle, I need a confirmation: is the upgrade > - * jQuery UI CSS Framework 1.8.20 > + * jQuery UI CSS Framework 1.8.22 > needed, why ? are you sure it's harmless ? I needed to add components that were not in our current version. The jQuery UI builder does not give the option of selecting a previous version. > > * If you don't use hourly loans, is it possible not to have the hour/minute > picker ? (not sure) Not in this iteration, but I don't feel that it gets in the way, even if it is not hidden. We aren't hiding the hours portion of due dates anywhere else ( at least not on purpose ). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 15:07:00 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 13:07:00 +0000 Subject: [Koha-bugs] [Bug 7628] Required format is not enforced for Patron Categories In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7628 --- Comment #12 from Paul Poulain --- follow-up comment: would be good to add the same control for itemtypes and branches, because I'm not sure at all having them with a special character will work... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 15:07:03 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 13:07:03 +0000 Subject: [Koha-bugs] [Bug 8185] Plugin for linking records in MARC21 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8185 --- Comment #5 from Zeno Tajoli --- Created attachment 11327 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11327&action=edit linking plugin marc21 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 15:10:53 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 13:10:53 +0000 Subject: [Koha-bugs] [Bug 7067] allow patron self registration via the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 15:15:01 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 13:15:01 +0000 Subject: [Koha-bugs] [Bug 8017] Remove unnecessary processing on return of GetAllIssues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8017 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #5 from Jonathan Druart --- This patch seems already signed off. But it does not apply. Could you resubmit a rebased patch please ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 15:22:34 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 13:22:34 +0000 Subject: [Koha-bugs] [Bug 7067] allow patron self registration via the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 --- Comment #12 from Owen Leonard --- This is sponsored now? Is there an RFC? Has there been communication with the library which has already implemented this feature? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 15:26:55 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 13:26:55 +0000 Subject: [Koha-bugs] [Bug 8185] Plugin for linking records in MARC21 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8185 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Version|rel_3_8 |master --- Comment #6 from Zeno Tajoli --- Now the plugin is all in english -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 15:35:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 13:35:27 +0000 Subject: [Koha-bugs] [Bug 8525] Highlight matches on details page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8525 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11210|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart --- Created attachment 11328 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11328&action=edit Bug 8525: highlight matches on OPAC detail page After doing a search and going to the details page, it can sometimes be difficult to see exactly *why* a record was returned by a search. By highlighting matches on the detail page as well as the results page, we make it much easier to figure that out. This patch uses a query_desc CGI parameter which is inserted into links from the results page with javascript. This serves to avoid the potential privacy implications of a cookie, and ensures that users without javascript enabled see no change whatsoever. To test: 1) Do a search (or two) in the OPAC with OpacHighlightedWords on. 2) View a record or two of the results, and ensure that the correct words are highlighted. 3) Disable OpacHighlightedWords and do another search (or two), this time ensuring that no words are highlighted. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 15:35:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 13:35:47 +0000 Subject: [Koha-bugs] [Bug 8525] Highlight matches on details page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8525 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 15:42:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 13:42:41 +0000 Subject: [Koha-bugs] [Bug 8525] Highlight matches on details page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8525 --- Comment #3 from Jonathan Druart --- Created attachment 11329 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11329&action=edit Bug 8525: Followup Don't reset the hz scrollbar to the top Hum... an annoying behaviour exists when we click on the "highlight" or "unhighlight" links: the scrollbar is repositionned to the top. This patch fixes that. Switch to NSO. It's a very quick SO ! :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 15:43:00 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 13:43:00 +0000 Subject: [Koha-bugs] [Bug 8525] Highlight matches on details page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8525 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 15:53:36 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 13:53:36 +0000 Subject: [Koha-bugs] [Bug 7067] allow patron self registration via the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 --- Comment #13 from Kyle M Hall --- (In reply to comment #12) > This is sponsored now? Is there an RFC? Has there been communication with > the library which has already implemented this feature? Yes, http://wiki.koha-community.org/wiki/Online_Borrower_Registration_RFC , and no. Hope this helps. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 15:56:54 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 13:56:54 +0000 Subject: [Koha-bugs] [Bug 7067] allow patron self registration via the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 --- Comment #14 from Paul Poulain --- (In reply to comment #12) > This is sponsored now? Is there an RFC? Has there been communication with > the library which has already implemented this feature? I had some discussion with BULAC some weeks ago. They still plan to share the code of what they did, but not before the end of the year or something like that. Progilone does not the job without BULAC explicit request, and Corinne is in vacation until end of august -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 16:06:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 14:06:33 +0000 Subject: [Koha-bugs] [Bug 3383] Item due reminder digests - cannot display title information In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3383 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain at biblibre.com QA Contact|koha.sekjal at gmail.com |paul.poulain at biblibre.com --- Comment #12 from Paul Poulain --- QA comment: * passes koha-qa.pl * small & localised patch * add a relevant warning in notices passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 16:07:17 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 14:07:17 +0000 Subject: [Koha-bugs] [Bug 3383] Item due reminder digests - cannot display title information In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3383 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 16:18:44 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 14:18:44 +0000 Subject: [Koha-bugs] [Bug 8017] Remove unnecessary processing on return of GetAllIssues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8017 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10192|0 |1 is obsolete| | --- Comment #6 from Colin Campbell --- Created attachment 11330 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11330&action=edit Patch rebased against current head Rebase of patch against HEAD -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 16:32:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 14:32:27 +0000 Subject: [Koha-bugs] [Bug 5600] Bulk MARC biblio export script In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5600 --- Comment #21 from Julian Maurice --- Created attachment 11331 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11331&action=edit Bug 5600 follow-up: Fix commandline check in order to work under Plack With plackup, @ARGV can contains elements so we can't check the size of @ARGV to tell whether we are in command line mode or not. Instead we check environment variable GATEWAY_INTERFACE. Also fix the use of a global variable in a subroutine -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 16:34:00 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 14:34:00 +0000 Subject: [Koha-bugs] [Bug 5600] Bulk MARC biblio export script In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5600 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #22 from Julian Maurice --- The follow-up needs a signoff here. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 16:34:42 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 14:34:42 +0000 Subject: [Koha-bugs] [Bug 5335] More granular VAT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10781|0 |1 is obsolete| | --- Comment #37 from Jonathan Druart --- Created attachment 11332 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11332&action=edit BZ5335: More granular VAT signed-off-by: Pierre Angot -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 16:46:52 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 14:46:52 +0000 Subject: [Koha-bugs] [Bug 8569] New: Paying for a lost item overwrites nonpublic notes Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8569 Priority: P5 - low Change sponsored?: --- Bug ID: 8569 CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Assignee: koha-bugs at lists.koha-community.org Summary: Paying for a lost item overwrites nonpublic notes Severity: enhancement Classification: Unclassified OS: All Reporter: ruth at bywatersolutions.com Hardware: All Status: NEW Version: unspecified Component: Circulation Product: Koha C4::Circulation::ReturnLostItem, as currently implemented, overwrites items.paidfor for the designated item, but some libraries are using this field for nonpublic notes that they would like to keep. Patch coming momentarily, which will *append* the paid-for note to the existing data. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 16:54:22 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 14:54:22 +0000 Subject: [Koha-bugs] [Bug 8137] Checkout limit by patron category for all libraries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain at biblibre.com --- Comment #5 from Paul Poulain --- QA Comment: This patch is highly sensible, because it changes Circulation behaviour. It replaces: SELECT COUNT(*) FROM issues JOIN items USING (itemnumber) WHERE borrowernumber = ? AND issues.branchcode = ? (or AND items.homebranch = ? or nothing, depending on sysprefs) by a simple SELECT COUNT(*) FROM issues WHERE borrowernumber = ? Digging into the code, I see that the comparison is made against GetBranchBorrowerCircRule, which retrieve data from branch_borrower_circ_rules Looking at admin/smart-rules.pl, I see that the description says: ========= Checkout limit by patron category for <> For this library, you can specify the maximum number of loans that a patron of a given category can make, regardless of the item type. If the total amount loanable for a given patron category is left blank, no limit applies, except possibly for a limit you define for a specific item type. ========= I feel it's unclear. What does "For this library" mean exactly ? is it "for items checked out from this library" "For patrons registered at this library" ? The sub GetBranchBorrowerCircRule is called with $branch and $cat_borrower parameters $branch is filled depending on sysprefs by _GetCircControlBranch, that return a value depending on CircControl syspref the patch, if I understand it well, understand the smart-rule.pl description as: "For patrons registered to this library, you can specify the maimum number of loans, all branches included" So it discard the behaviour: "You can specify the maximum number of loans that a patron can do from this library" As a conclusion, I feel that this patch could unplease some libraries. Maybe more explanations are needed on smart-rules.pl. Is there something I misunderstood ? (Am I clear in my explanations -because it's quite tricky- ?) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 16:55:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 14:55:57 +0000 Subject: [Koha-bugs] [Bug 8569] Paying for a lost item overwrites nonpublic notes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8569 D Ruth Bavousett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |ruth at bywatersolutions.com |ity.org | --- Comment #1 from D Ruth Bavousett --- Created attachment 11333 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11333&action=edit Proposed patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 16:56:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 14:56:21 +0000 Subject: [Koha-bugs] [Bug 8017] Remove unnecessary processing on return of GetAllIssues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8017 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA --- Comment #7 from Jonathan Druart --- Thanks Colin ! I did not find any regression. So I mark it as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 17:01:36 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 15:01:36 +0000 Subject: [Koha-bugs] [Bug 5600] Bulk MARC biblio export script In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5600 --- Comment #23 from Julian Maurice --- Created attachment 11334 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11334&action=edit Bug 5600: very tiny follow-up to pass perlcritic open was called with 2 arguments instead of 3 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 17:04:20 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 15:04:20 +0000 Subject: [Koha-bugs] [Bug 5600] Bulk MARC biblio export script In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5600 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #24 from Paul Poulain --- QA comment: * the 1st follow-up fixes the Plack problem, well done * the 2nd follow-up makes perlcritc happy No reason not to pass QA. So... follow-up signed-off & everything passed QA ! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 17:04:44 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 15:04:44 +0000 Subject: [Koha-bugs] [Bug 5600] Bulk MARC biblio export script In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5600 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Version|master |rel_3_10 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 17:27:50 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 15:27:50 +0000 Subject: [Koha-bugs] [Bug 8569] Paying for a lost item overwrites nonpublic notes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8569 --- Comment #2 from Kyle M Hall --- Created attachment 11335 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11335&action=edit Bug 8569: Paying for lost item overwrites nonpublic notes. This patch modifies C4::Circulation::ReturnLostItem to append the Paid-for note to existing data, rather than overwriting it. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 17:28:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 15:28:09 +0000 Subject: [Koha-bugs] [Bug 8569] Paying for a lost item overwrites nonpublic notes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8569 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11333|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 17:31:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 15:31:47 +0000 Subject: [Koha-bugs] [Bug 5600] Bulk MARC biblio export script In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5600 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 17:32:51 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 15:32:51 +0000 Subject: [Koha-bugs] [Bug 8525] Highlight matches on details page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8525 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11328|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 11336 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11336&action=edit Bug 8525: highlight matches on OPAC detail page After doing a search and going to the details page, it can sometimes be difficult to see exactly *why* a record was returned by a search. By highlighting matches on the detail page as well as the results page, we make it much easier to figure that out. This patch uses a query_desc CGI parameter which is inserted into links from the results page with javascript. This serves to avoid the potential privacy implications of a cookie, and ensures that users without javascript enabled see no change whatsoever. To test: 1) Do a search (or two) in the OPAC with OpacHighlightedWords on. 2) View a record or two of the results, and ensure that the correct words are highlighted. 3) Disable OpacHighlightedWords and do another search (or two), this time ensuring that no words are highlighted. Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 17:33:03 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 15:33:03 +0000 Subject: [Koha-bugs] [Bug 8525] Highlight matches on details page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8525 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11329|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall --- Created attachment 11337 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11337&action=edit Bug 8525: Followup Don't reset the hz scrollbar to the top Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 17:33:16 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 15:33:16 +0000 Subject: [Koha-bugs] [Bug 8525] Highlight matches on details page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8525 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 17:37:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 15:37:14 +0000 Subject: [Koha-bugs] [Bug 7455] Authority subfields are cloned in the wrong field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7455 --- Comment #12 from Fridolyn SOMERS --- Created attachment 11338 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11338&action=edit Proposed patch (follow-up) Asked patch. Fixes cloning problem. + uses subfield '@' replacing by '00' behavior like in biblios. + fixedfield variable was missing in subfields, in both authities and biblios, => test it with a field < 010. + fixes a missing random in id of indicator div. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 17:37:46 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 15:37:46 +0000 Subject: [Koha-bugs] [Bug 5327] Unit tests required for all C4 modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11279|0 |1 is obsolete| | --- Comment #204 from Kyle M Hall --- Created attachment 11339 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11339&action=edit Bug 5327 : Added a few more lines of code to the ItemType.t unit test Signed-off-by: Jared Camins-Esakov Signed-off-by: Chris Cormack Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 17:38:08 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 15:38:08 +0000 Subject: [Koha-bugs] [Bug 5327] Unit tests required for all C4 modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11280|0 |1 is obsolete| | --- Comment #205 from Kyle M Hall --- Created attachment 11340 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11340&action=edit Bug 5327 follow-up: add DBD::Mock dependency In order for the awesome new t/ItemType.t test to work, we need DBD::Mock. Signed-off-by: Chris Cormack Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 17:38:26 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 15:38:26 +0000 Subject: [Koha-bugs] [Bug 5327] Unit tests required for all C4 modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11281|0 |1 is obsolete| | --- Comment #206 from Kyle M Hall --- Created attachment 11341 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11341&action=edit Bug 5327 Tests for C4::Matcher Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 17:38:46 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 15:38:46 +0000 Subject: [Koha-bugs] [Bug 5327] Unit tests required for all C4 modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 17:43:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 15:43:49 +0000 Subject: [Koha-bugs] [Bug 8485] Make koha_perl_deps.pl batch friendly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8485 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11255|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall --- Created attachment 11342 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11342&action=edit Bug 8485 - Make koha_perl_deps.pl batch friendly Added a -b flag for brief which outputs only the perl library name (Foo::BaR), and added a -r flag for required which filters the list to required=Yes perl libraries. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 17:44:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 15:44:11 +0000 Subject: [Koha-bugs] [Bug 8485] Make koha_perl_deps.pl batch friendly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8485 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 17:47:19 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 15:47:19 +0000 Subject: [Koha-bugs] [Bug 8329] GetLostItems in C4::Items.pm has a SELECT * In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8329 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain at biblibre.com --- Comment #3 from Paul Poulain --- QA comment: this patch looks good, but a small question: why not SELECT biblio,author,...,items.* (all items fields) ? would that solve your performance problem ? if yest, I think it's better, because it will be more evolutive in case one want to introduce a new column in the report. But I won't fail QA for that, if you say enumerating fields is needed, I'll push your patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 17:50:53 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 15:50:53 +0000 Subject: [Koha-bugs] [Bug 8524] Add barcode plugin that does not autofill In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8524 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11271|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 11343 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11343&action=edit Bug 8524: Add a non-automatic barcode plugin In addition to adding a new barcode plugin, this commit begins refactoring the barcode generation code using a new module, C4::Barcodes::ValueBuilder. From the POD: This module is intended as a shim to ease the eventual transition from having all barcode-related code in the value builder plugin barcode.pl file to using C4::Barcodes. Since the shift will require a rather significant amount of refactoring, this module will return value builder-formatted results, at first by merely running the code that was formerly in the barcodes.pl value builder, but later by using C4::Barcodes. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 17:57:53 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 15:57:53 +0000 Subject: [Koha-bugs] [Bug 8524] Add barcode plugin that does not autofill In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8524 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 18:23:51 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 16:23:51 +0000 Subject: [Koha-bugs] [Bug 8479] Opac Holds being created with priority set to NULL In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8479 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11037|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 11344 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11344&action=edit Bug 8479 Calculate rank irrespective of display option Calculation of rank was being skipped based on display option but it is used in calculating the rank passed to AddReserve resulting in reserves being created with null priorities causing them to be skipped in subsequent processing Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 18:24:00 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 16:24:00 +0000 Subject: [Koha-bugs] [Bug 8479] Opac Holds being created with priority set to NULL In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8479 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 19:08:08 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 17:08:08 +0000 Subject: [Koha-bugs] [Bug 4048] CSS and JS libs must be outside of translated paths In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4048 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |kyle at bywatersolutions.com --- Comment #14 from Kyle M Hall --- I'm afraid there are a huge number of conflicts when I attempted to apply. Even using git am -3. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 19:11:01 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 17:11:01 +0000 Subject: [Koha-bugs] [Bug 4321] C4::Biblio::GetBiblio is badly coded In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4321 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11108|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 11345 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11345&action=edit Bug 4321: clean C4::Biblio::GetBiblio and uses Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 19:18:50 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 17:18:50 +0000 Subject: [Koha-bugs] [Bug 7671] add a real primary key "accountlinesid" in accountlines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7671 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #16 from Kyle M Hall --- I cannot apply this patch. I receive this error: fatal: cannot convert from UTF-8utf-8 to UTF-8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 19:20:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 17:20:37 +0000 Subject: [Koha-bugs] [Bug 8244] Script to find exporter problems In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8244 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #13 from Kyle M Hall --- PPI needs to be added as a dependency for this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 19:30:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 17:30:49 +0000 Subject: [Koha-bugs] [Bug 8244] Script to find exporter problems In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8244 --- Comment #14 from Kyle M Hall --- Created attachment 11346 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11346&action=edit Bug 8244 follow-up: improvements to find-undefined-subroutines * Adds a repeatable --ignore option so that the user can choose to ignore certain files. * Exit with the same success or failure code that the prove command returns Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 19:31:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 17:31:10 +0000 Subject: [Koha-bugs] [Bug 8244] Script to find exporter problems In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8244 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10943|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 19:31:17 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 17:31:17 +0000 Subject: [Koha-bugs] [Bug 8244] Script to find exporter problems In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8244 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 19:41:01 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 17:41:01 +0000 Subject: [Koha-bugs] [Bug 8542] <> token produces a funny looking time on Reserves Slip In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8542 Melia Meggs changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11233|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 19:53:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 17:53:29 +0000 Subject: [Koha-bugs] [Bug 8542] <> token produces a funny looking time on Reserves Slip In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8542 --- Comment #1 from Galen Charlton --- The content of attachment 11233 has been deleted by Galen Charlton who provided the following reason: Per Melia's request The token used to delete this attachment was generated at 2012-08-03 17:53:18 UTC. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 20:01:04 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 18:01:04 +0000 Subject: [Koha-bugs] [Bug 8570] New: Add pagination to the Z39.50 results page Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8570 Priority: P5 - low Change sponsored?: --- Bug ID: 8570 CC: m.de.rooy at rijksmuseum.nl Assignee: gmcharlt at gmail.com Summary: Add pagination to the Z39.50 results page Severity: enhancement Classification: Unclassified OS: All Reporter: fcapovilla at live.ca Hardware: All Status: NEW Version: rel_3_8 Component: Z39.50 / SRU / OpenSearch Servers Product: Koha Created attachment 11347 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11347&action=edit Add paginations to the Z39.50 search results. When doing Z39.50 searches, a maximum of 20 results are show even if there are a lot more matching results returned by the server. This patch adds some pagination code to the Z39.50 results pages so all results returned by the Z39.50 server can be accessed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 20:02:32 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 18:02:32 +0000 Subject: [Koha-bugs] [Bug 8570] Add pagination to the Z39.50 results page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8570 Fr?d?rick Capovilla changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Change sponsored?|--- |Sponsored Assignee|gmcharlt at gmail.com |fcapovilla at live.ca --- Comment #1 from Fr?d?rick Capovilla --- Patch sponsored by the CCSR ( http://www.ccsr.qc.ca ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 20:20:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 18:20:10 +0000 Subject: [Koha-bugs] [Bug 7688] Change subscriptions numbering pattern and frequencies In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #33 from Nicole C. Engard --- I have a ticket from a library asking if Koha can do the following - I'm wondering if this patch does any of these things (just a yes or no would be great for each point): Ability to customize Chronology Type More options and customizability in Publication Cycle Omit dates/months Ability to modify independent issues after they arrive Ability to combine issues (ex. June and July are usually separate but the publication decides to combine them for that year) Date functionality in dropbox (ex. Volume, Number, Date) And have the actual Month spelled out (January...) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 20:31:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 18:31:10 +0000 Subject: [Koha-bugs] [Bug 5044] should be able to page through z39.50 search results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5044 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Owen Leonard --- *** This bug has been marked as a duplicate of bug 8570 *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 20:31:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 18:31:10 +0000 Subject: [Koha-bugs] [Bug 8570] Add pagination to the Z39.50 results page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8570 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #2 from Owen Leonard --- *** Bug 5044 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 20:31:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 18:31:28 +0000 Subject: [Koha-bugs] [Bug 8570] Add pagination to the Z39.50 results page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8570 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_8 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 20:34:34 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 18:34:34 +0000 Subject: [Koha-bugs] [Bug 8570] Add pagination to the Z39.50 results page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8570 Jane Wagner changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jwagner at ptfs.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 20:59:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 18:59:11 +0000 Subject: [Koha-bugs] [Bug 8571] New: Add search suggestions on the OPAC ("Did you mean?" feature) Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8571 Priority: P5 - low Change sponsored?: --- Bug ID: 8571 Assignee: oleonard at myacpl.org Summary: Add search suggestions on the OPAC ("Did you mean?" feature) Severity: enhancement Classification: Unclassified OS: All Reporter: fcapovilla at live.ca Hardware: All Status: NEW Version: rel_3_8 Component: OPAC Product: Koha Created attachment 11348 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11348&action=edit Add search suggestions to search results on the OPAC. This patch will add search suggestions at the beginning of search results on the OPAC if the "OPACSearchSuggestions" preference is activated. This feature can be compared to "Did you mean?" or autocorrect features in search engines. Authorities records are used as a source of suggestions. The search terms the user entered are used in a "see also" authority search to find suggestions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 21:00:05 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 19:00:05 +0000 Subject: [Koha-bugs] [Bug 8571] Add search suggestions on the OPAC ("Did you mean?" feature) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8571 Fr?d?rick Capovilla changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Change sponsored?|--- |Sponsored Assignee|oleonard at myacpl.org |fcapovilla at live.ca --- Comment #1 from Fr?d?rick Capovilla --- Patch sponsored by the CCSR ( http://www.ccsr.qc.ca ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 21:08:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 19:08:14 +0000 Subject: [Koha-bugs] [Bug 8570] Add pagination to the Z39.50 results page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8570 --- Comment #3 from Owen Leonard --- I am really happy to see this long-missing feature added, but I'm not so happy to see an entirely new method of offering the user pagination options. Currently we have two primary ways of offering pagination options: The plain link kind (as seen on catalog search results) and the DataTables way. It would be much, much better in my opinion to pick one of these established interface patterns than to introduce a whole new one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 21:09:31 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 19:09:31 +0000 Subject: [Koha-bugs] [Bug 8571] Add search suggestions on the OPAC ("Did you mean?" feature) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8571 --- Comment #2 from Owen Leonard --- A duplicate of Bug 8209? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 21:09:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 19:09:43 +0000 Subject: [Koha-bugs] [Bug 8571] Add search suggestions on the OPAC ("Did you mean?" feature) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8571 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_8 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 21:16:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 19:16:49 +0000 Subject: [Koha-bugs] [Bug 8571] Add search suggestions on the OPAC ("Did you mean?" feature) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8571 Jane Wagner changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jwagner at ptfs.com --- Comment #3 from Jane Wagner --- Duplicate of Bug 4240 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 21:27:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 19:27:33 +0000 Subject: [Koha-bugs] [Bug 8570] Add pagination to the Z39.50 results page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8570 --- Comment #4 from Fr?d?rick Capovilla --- This feature was made a long time ago and got approved for release to the community by our client recently. There is no doubt using the existing patterns would be the best way to do this, but for now all we have is a working version with it's own pagination method. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 22:00:51 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 20:00:51 +0000 Subject: [Koha-bugs] [Bug 6448] EAN-13 barcode support In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6448 --- Comment #24 from Chris Cormack --- Yes, the tests should work with the sample db, do you need to add an EAN-13 to the sample data. Either that or use Test::MockModule and DBD::Mock to mock a database. Otherwise Jenkins is going to keep complaining at an ever increasing number of people. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 22:04:44 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 20:04:44 +0000 Subject: [Koha-bugs] [Bug 8571] Add search suggestions on the OPAC ("Did you mean?" feature) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8571 --- Comment #4 from Jared Camins-Esakov --- Actually, I disagree with both the earlier suggestions. I think this is a duplicate of bug 7417, since the idea is that it will suggest relevant records based on see from fields in authority records. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 3 22:11:52 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 20:11:52 +0000 Subject: [Koha-bugs] [Bug 8571] Add search suggestions on the OPAC ("Did you mean?" feature) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8571 --- Comment #5 from Jared Camins-Esakov --- (In reply to comment #4) > Actually, I disagree with both the earlier suggestions. I think this is a > duplicate of bug 7417, since the idea is that it will suggest relevant > records based on see from fields in authority records. To clarify, I think the end result is closer to bug 7417, even though the display looks more like 8209. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 4 00:00:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 22:00:37 +0000 Subject: [Koha-bugs] [Bug 6448] EAN-13 barcode support In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6448 --- Comment #25 from Dobrica Pavlinusic --- Adding EAN13 bar-code to database might help, but only if all other bar-codes are shorter than 13 digits. Excuse my ignorance, but where is the sample data and how can I add to it? I tried sandbox databases from http://git.koha-community.org/gitweb/?p=contrib/global.git;a=tree;f=sandbox and I can reproduce problem with them. Other bar-code plugins seems to carp on invalid input instead of die, so that might be another possible solution. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 4 00:04:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 22:04:11 +0000 Subject: [Koha-bugs] [Bug 6448] EAN-13 barcode support In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6448 --- Comment #26 from Jared Camins-Esakov --- I think for the test the best option would be to use DBD::Mock, because there is no reason to think that all barcodes will be shorter than 13 digits on any arbitrary installation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 4 00:04:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 22:04:39 +0000 Subject: [Koha-bugs] [Bug 6448] EAN-13 barcode support In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6448 --- Comment #27 from Dobrica Pavlinusic --- Created attachment 11349 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11349&action=edit Bug 6448 - carp on invalid barcode This is consistent with implementation of other barcode types which all carp instead of die on invalid barcodes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 4 00:08:26 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 22:08:26 +0000 Subject: [Koha-bugs] [Bug 6448] EAN-13 barcode support In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6448 --- Comment #28 from Dobrica Pavlinusic --- I would almost prefer DBD::Mock, but it's another dependency, we should really require it for production deployment so it seems like overkill to introduce it for this case. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 4 00:11:18 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Aug 2012 22:11:18 +0000 Subject: [Koha-bugs] [Bug 6448] EAN-13 barcode support In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6448 --- Comment #29 from Jared Camins-Esakov --- We are already using DBD::Mock in tests (or, if we aren't, we will be soon). I think people will be willing to install one additional dependency in order to ensure a more stable system. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 4 07:53:12 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Aug 2012 05:53:12 +0000 Subject: [Koha-bugs] [Bug 8220] Allow koc uploads to go to process queue instead of being applied directly. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8220 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |paul.poulain at biblibre.com --- Comment #7 from Paul Poulain --- Patch tested with a sandbox, by Bob Birchall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 4 07:53:26 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Aug 2012 05:53:26 +0000 Subject: [Koha-bugs] [Bug 8220] Allow koc uploads to go to process queue instead of being applied directly. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8220 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10587|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 4 07:53:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Aug 2012 05:53:33 +0000 Subject: [Koha-bugs] [Bug 8220] Allow koc uploads to go to process queue instead of being applied directly. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8220 --- Comment #8 from Paul Poulain --- Created attachment 11350 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11350&action=edit Bug 8220 - Allow koc uploads to go to process queue instead of being applied directly. The primary advantage to the Firefox offline cirulation plugin when compared to the offline circulation desktop application, is the ability to add offline circulation actions to a queue so that multiple machines running offline circ can have their circ actions combined and ordered chronologically before being executed. This commit adds the ability to put actions from uploaded KOC files into this queue. In this way, both the FF plugina and the desktop application can be run side by side with no ill effects. Signed-off-by: Bob Birchall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 4 07:57:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Aug 2012 05:57:29 +0000 Subject: [Koha-bugs] [Bug 8220] Allow koc uploads to go to process queue instead of being applied directly. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8220 --- Comment #9 from Bob Birchall --- Test 1: Created two Koc files. Loaded both to Koha. Was able to manage the processing of the files OK. Test 2: Used KOC utility to record an issue of an item to a patron. Saved the KOC file as file A. Closed KOC. Opened KOC again, recorded the return of the same item. Saved the KOC file as file B. Returned to Koha, uploaded file B first, then file A. Processed the queue. Transactions processed in correct sequence (by timestamp). All good. Signed off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 4 08:20:36 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Aug 2012 06:20:36 +0000 Subject: [Koha-bugs] [Bug 7671] add a real primary key "accountlinesid" in accountlines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7671 --- Comment #17 from Marc V?ron --- I had the same error, see comment #8 Martin Renvoize then sent a new patch. I foound following solution from Markus Enger, see http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1633#c4 ----------------- * Patch did not apply, giving this message: "fatal: cannot convert from UTF-8utf-8 to UTF-8". Removing 'Content-Type: text/plain; charset="utf-8"' from the patch by hand solved this. ----------------- Marc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 4 09:51:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Aug 2012 07:51:10 +0000 Subject: [Koha-bugs] [Bug 5335] More granular VAT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #38 from Paul Poulain --- Patch tested with a sandbox, by Pierre Angot -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 4 09:51:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Aug 2012 07:51:33 +0000 Subject: [Koha-bugs] [Bug 5335] More granular VAT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11332|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 4 09:51:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Aug 2012 07:51:41 +0000 Subject: [Koha-bugs] [Bug 5335] More granular VAT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 --- Comment #39 from Paul Poulain --- Created attachment 11351 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11351&action=edit BZ5335: More granular VAT signed-off-by: Pierre Angot Signed-off-by: Pierre Angot -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 4 09:53:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Aug 2012 07:53:57 +0000 Subject: [Koha-bugs] [Bug 5335] More granular VAT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 --- Comment #40 from Pierre Angot --- Created attachment 11352 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11352&action=edit screenshots about some tests -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 4 09:58:46 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Aug 2012 07:58:46 +0000 Subject: [Koha-bugs] [Bug 5335] More granular VAT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 --- Comment #41 from Pierre Angot --- I've made some new tests. syspref gist : 0.1|0.196|0.05|0.07 I've created 2 vendors : one with discount and one without. - basket 1 : no discount, default tax rate 10%, add order with different VAT (5%) - basket 2 : 2% discount. Need to test list prices and invoices prices. New vendor. - basket 4 : tax rate = 10%, no discount, list prices and invoice prices include tax. - basket 5 : tax rate = 10%, no discount, invoice prices include tax. - basket 6 : tax rate = 10%, no discount, list prices include tax. Theses baskets have also an ACQ framework. You can check calculations (correct words ?) with the screenshots ("screenshots about some tests" : 1 zip, 4 files). I haven't noticed any problems. Test on sandbox. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 4 10:14:12 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Aug 2012 08:14:12 +0000 Subject: [Koha-bugs] [Bug 8544] Make RSS icon styleable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8544 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz Severity|enhancement |trivial --- Comment #9 from Chris Cormack --- Adding a class to 2 html elements, no visible change at all, but allows them to be styled now. Pushed to 3.8.x, will be in 3.8.4 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 4 10:31:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Aug 2012 08:31:10 +0000 Subject: [Koha-bugs] [Bug 7628] Required format is not enforced for Patron Categories In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7628 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #13 from Chris Cormack --- Pushed to 3.8.x, will be in 3.8.4 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 4 10:38:07 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Aug 2012 08:38:07 +0000 Subject: [Koha-bugs] [Bug 3383] Item due reminder digests - cannot display title information In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3383 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #13 from Chris Cormack --- Pushed to the 3.8.x, will be in 3.8.4 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 4 13:42:51 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Aug 2012 11:42:51 +0000 Subject: [Koha-bugs] [Bug 8437] Plack and database backup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8437 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11177|0 |1 is obsolete| | --- Comment #3 from Dobrica Pavlinusic --- Created attachment 11353 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11353&action=edit Bug 8437: variable scoping for tools/export.pl Variable scoping problems prevented database export from working under Plack. This patch fixes that. Signed-off-by: Dobrica Pavlinusic -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 4 13:44:23 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Aug 2012 11:44:23 +0000 Subject: [Koha-bugs] [Bug 8437] Plack and database backup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8437 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #4 from Dobrica Pavlinusic --- Signed off using test scenario from Bug 8268 - Koha should offer way to backup entire db -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 4 14:35:40 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Aug 2012 12:35:40 +0000 Subject: [Koha-bugs] [Bug 8437] Plack and database backup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8437 --- Comment #5 from Dobrica Pavlinusic --- Created attachment 11354 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11354&action=edit Bug 8437 - fix koha-dump configuration tar permissions This allows backups created using Debian package to show up automatically in web interface and makes permissions of database files consistent. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 4 14:38:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Aug 2012 12:38:09 +0000 Subject: [Koha-bugs] [Bug 8437] Plack and database backup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8437 --- Comment #6 from Dobrica Pavlinusic --- Created attachment 11355 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11355&action=edit Bug 8437 - fix koha-dump configuration tar permissions This allows backups created using Debian package to show up automatically in web interface and makes permissions of backup files consistent. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 4 14:38:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Aug 2012 12:38:41 +0000 Subject: [Koha-bugs] [Bug 8437] Plack and database backup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8437 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11354|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 4 15:17:38 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Aug 2012 13:17:38 +0000 Subject: [Koha-bugs] [Bug 8437] Plack and database backup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8437 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #7 from Dobrica Pavlinusic --- This patch fixes errors under plack but doesn't work for large backup files. The problem is in download_backup which tries to print data back to browser in 64K chunks. Under plack, that gets buffered in memory and with backup of our production database it dies after a while and returns zero length file. Correct way to fix this is to issue redirect under plack in download_backup to some plack handled URL so we don't read whole file in memory. I don't know how to detect plack if we are running under plack since script is inside CGI::Compile, but we could use environment variable to signal that we are under plack. That would, however, require us to have some kind of koha.psgi in which we can implement this in master. I also had to remove && not $filename =~ m#|# from download_backup to make download work at all, so I will have to remove signed-off on this patch, sorry. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 4 15:18:36 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Aug 2012 13:18:36 +0000 Subject: [Koha-bugs] [Bug 8437] Plack and database backup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8437 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11177|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 4 15:18:54 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Aug 2012 13:18:54 +0000 Subject: [Koha-bugs] [Bug 8437] Plack and database backup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8437 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11353|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 4 15:23:53 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Aug 2012 13:23:53 +0000 Subject: [Koha-bugs] [Bug 8437] Plack and database backup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8437 --- Comment #8 from Jared Camins-Esakov --- (In reply to comment #7) > This patch fixes errors under plack but doesn't work for large backup files. > > The problem is in download_backup which tries to print data back to browser > in 64K chunks. Under plack, that gets buffered in memory and with backup of > our production database it dies after a while and returns zero length file. > > Correct way to fix this is to issue redirect under plack in download_backup > to some plack handled URL so we don't read whole file in memory. > > I don't know how to detect plack if we are running under plack since script > is inside CGI::Compile, but we could use environment variable to signal that > we are under plack. > > That would, however, require us to have some kind of koha.psgi in which we > can implement this in master. I guess the thing to do is note that this is not available under Plack? > I also had to remove > > && not $filename =~ m#|# > > from download_backup to make download work at all, so I will have to remove > signed-off on this patch, sorry. There's a signed off patch which makes that last change on bug 8268. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 4 16:02:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Aug 2012 14:02:28 +0000 Subject: [Koha-bugs] [Bug 8437] Plack and database backup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8437 --- Comment #9 from Jared Camins-Esakov --- (In reply to comment #7) > This patch fixes errors under plack but doesn't work for large backup files. > > The problem is in download_backup which tries to print data back to browser > in 64K chunks. Under plack, that gets buffered in memory and with backup of > our production database it dies after a while and returns zero length file. > > Correct way to fix this is to issue redirect under plack in download_backup > to some plack handled URL so we don't read whole file in memory. This can't be how exporting large blobs from a database would be handled under Plack. Do you have any idea how that would work? Maybe we can use the same technique. > I don't know how to detect plack if we are running under plack since script > is inside CGI::Compile, but we could use environment variable to signal that > we are under plack. > > That would, however, require us to have some kind of koha.psgi in which we > can implement this in master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 4 16:17:34 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Aug 2012 14:17:34 +0000 Subject: [Koha-bugs] [Bug 8437] Plack and database backup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8437 --- Comment #10 from Jared Camins-Esakov --- Would using this syntax (borrowed from bug 7952) fix the problem? + open(my $fh, '<', $filename) + print <$fh>; + close $fh; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 4 17:18:32 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Aug 2012 15:18:32 +0000 Subject: [Koha-bugs] [Bug 6617] table of contents not printing right if entered right In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6617 --- Comment #20 from Jared Camins-Esakov --- (In reply to comment #19) > I recommend that future follow ups fix the staff client to match > and update the title notes tabs on the opac and staff client > to also match the cleaner format for table of contents. I will be updating the XSLT in the staff client shortly. While I would love for the title notes tab to be usable, that is a much larger project, and not one to jumble in with this bug. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 4 17:34:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Aug 2012 15:34:27 +0000 Subject: [Koha-bugs] [Bug 6617] table of contents not printing right if entered right In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6617 --- Comment #21 from Jared Camins-Esakov --- Created attachment 11356 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11356&action=edit Bug 6617: Improve MARC21 enhanced contents display (intranet) The display of "Enhanced" 505 (contents) fields in the MARC21 XSLT is very poor, resulting in large, unreadable blocks of text, and -- for some series -- so much unnecessary duplication in the Notes tab that important information is entirely obscured. This patch reformats "enhanced" contents fields (MARC21 505 fields with $t and $r) so as to be more readable by breaking up entries on separate lines and making titles bold (to make them stand out more). This patch does not address duplication of information in the Notes tab, per discussion on the #koha IRC channel. To test: 1) View record with enhanced 505 field before applying patch. Observe it is very unfriendly. 2) Apply patch. 3) View same record, note that display is much improved. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 4 17:35:00 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Aug 2012 15:35:00 +0000 Subject: [Koha-bugs] [Bug 6617] table of contents not printing right if entered right In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6617 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #22 from Jared Camins-Esakov --- First patch has been signed off. Second has not. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 4 18:56:20 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Aug 2012 16:56:20 +0000 Subject: [Koha-bugs] [Bug 6617] table of contents not printing right if entered right In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6617 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11356|0 |1 is obsolete| | --- Comment #23 from Jared Camins-Esakov --- Created attachment 11357 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11357&action=edit Bug 6617: Improve MARC21 enhanced contents display (intranet) The display of "Enhanced" 505 (contents) fields in the MARC21 XSLT is very poor, resulting in large, unreadable blocks of text, and -- for some series -- so much unnecessary duplication in the Notes tab that important information is entirely obscured. This patch reformats "enhanced" contents fields (MARC21 505 fields with $t and $r) so as to be more readable by breaking up entries on separate lines and making titles bold (to make them stand out more). This patch does not address duplication of information in the Notes tab, per discussion on the #koha IRC channel. To test: 1) View record with enhanced 505 field before applying patch. Observe it is very unfriendly. 2) Apply patch. 3) View same record, note that display is much improved. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 4 19:20:04 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Aug 2012 17:20:04 +0000 Subject: [Koha-bugs] [Bug 5888] opac-detail subject/author links improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5888 --- Comment #17 from Jared Camins-Esakov --- Julian, With permission I would like to break this patch into two parts: one that links to the authority record, which I think is fairly uncontroversial, and one that adds the cool new subject search pop-up. Any objections? I would, of course, be sure to retain your authorship. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 4 19:39:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Aug 2012 17:39:49 +0000 Subject: [Koha-bugs] [Bug 8572] New: Attempting to view an invalid authority in the OPAC gives an error instead of 404 Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8572 Priority: P5 - low Change sponsored?: --- Bug ID: 8572 Assignee: jcamins at cpbibliography.com Summary: Attempting to view an invalid authority in the OPAC gives an error instead of 404 Severity: major Classification: Unclassified OS: All Reporter: jcamins at cpbibliography.com Hardware: All Status: NEW Version: master Component: OPAC Product: Koha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 4 19:44:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Aug 2012 17:44:28 +0000 Subject: [Koha-bugs] [Bug 8572] Attempting to view an invalid authority in the OPAC gives an error instead of 404 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8572 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 4 19:44:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Aug 2012 17:44:29 +0000 Subject: [Koha-bugs] [Bug 8572] Attempting to view an invalid authority in the OPAC gives an error instead of 404 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8572 --- Comment #1 from Jared Camins-Esakov --- Created attachment 11358 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11358&action=edit Bug 8572: invalid auth shouldn't cause error Prior to this patch, attempting to view an invalid authority in the OPAC gave a system error instead of a 404. With this patch, the user will just get a 404, as is the case with invalid bibs. To test: 1) Try to view an invalid authority by going to: /cgi-bin/koha/opac-authoritiesdetail.pl?authid=999999999999 (presuming that you don't have an authority with authid 999999999999 in your database) before and after applying this patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 4 19:45:07 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Aug 2012 17:45:07 +0000 Subject: [Koha-bugs] [Bug 8210] Headings in OPAC bib details should link to authority record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8210 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 4 19:45:08 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Aug 2012 17:45:08 +0000 Subject: [Koha-bugs] [Bug 8210] Headings in OPAC bib details should link to authority record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8210 --- Comment #1 from Jared Camins-Esakov --- Created attachment 11359 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11359&action=edit Bug 8210: add links to authorities to headings in OPAC At the moment, there is no way to get to an authority record from a bib record that uses it other than doing a new search on the authority file. This patch adds a link (a cute little magnifying glass) to linked authority records on the OPAC detail view for MARC21 and NORMARC with XSLT enabled. A follow-up patch will add the link to regular mode. Because UNIMARC handles authorities differently, the link is not added to the XSLT. Test plan: 1) Set OPACXSLTDetailsDisplay to 'default' 2) View a record that has some headings that are linked to authority records in the OPAC (easiest way to find a record like that is to edit a record and add some headings using the thesaurus plugin) 3) Observe the cute little magnifying glass links to the authority. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 4 22:34:32 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Aug 2012 20:34:32 +0000 Subject: [Koha-bugs] [Bug 8547] Enabling star ratings causes javascript errors that cause IE to have a boo boo In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8547 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #7 from Marc V?ron --- Bug confirmeed with IE 7.0.5730.13 on Windows XP -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 4 23:07:36 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Aug 2012 21:07:36 +0000 Subject: [Koha-bugs] [Bug 8523] Authority hierarchies only support UNIMARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8523 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 4 23:07:44 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Aug 2012 21:07:44 +0000 Subject: [Koha-bugs] [Bug 8523] Authority hierarchies only support UNIMARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8523 --- Comment #1 from Jared Camins-Esakov --- Created attachment 11360 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11360&action=edit Bug 8523: Display auth hierarchies w/all marcflavours This commit adds support for displaying authority hierarchies for all flavours of MARC, not just UNIMARC. Display now uses the jQuery jstree plugin, selected with the help of Owen Leonard, resulting in a much faster experience for users. Be aware that the jstree file uses tabs rather than 4-space indentation, which I left as-is so as to make it easier to integrate upstream releases in the future. To test: 1) Enable the AuthDisplayHierarchy syspref 2) Create authority records with a hierarchy of see also fields (in MARC21/NORMARC, you'll be using 5xx fields for this, with a subfield $w=g for broader terms and subfield $w=h for narrower terms) 3) View the authorities in the OPAC, noting the hierarchical view at the top of the page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 5 00:00:34 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Aug 2012 22:00:34 +0000 Subject: [Koha-bugs] [Bug 8547] Enabling star ratings causes javascript errors that cause IE to have a boo boo In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8547 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11251|0 |1 is obsolete| | --- Comment #8 from Marc V?ron --- Created attachment 11361 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11361&action=edit [SIGNED-OFF] Bug 8547 - JS error in star ratings breaks IE Writing code with best practices in mind breaks IE. Thanks Internet Explorer. Now go DiaF. Signed-off-by: Marc Veron Tested with with IE 7.0.5730.13 on Windows XP, no JS errors, stars display and behave as expected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 5 00:01:59 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Aug 2012 22:01:59 +0000 Subject: [Koha-bugs] [Bug 8547] Enabling star ratings causes javascript errors that cause IE to have a boo boo In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8547 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 5 00:52:03 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Aug 2012 22:52:03 +0000 Subject: [Koha-bugs] [Bug 4998] OPAC Browse by Hierarchy fails badly, links to old Koha Wiki In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4998 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 5 21:58:20 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Aug 2012 19:58:20 +0000 Subject: [Koha-bugs] [Bug 7417] Include alternate forms from authorities in bibliographic searches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7417 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11319|0 |1 is obsolete| | --- Comment #6 from Jared Camins-Esakov --- Created attachment 11362 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11362&action=edit Bug 7417: Include see from references in bibliographic searches This patch adds the Koha::Indexer::RecordNormalizer and Koha::Indexer::MARC::RecordNormalizer::EmbedSeeFromHeadings packages to enable the inclusion of alternate forms of headings in bibliographic searches. When the new syspref IncludeSeeFromInSearches is turned on (default is off) rebuild_zebra.pl will insert see from headings from authority records into bibliographic records when indexing, so that a search on an obsolete term will turn up relevant records. To test: 1) Enable IncludeSeeFromInSearches 2) Add a heading that has an alternate form to a record (for example, "Cooking" has the alternate form "Cookery," if you have authority records from LC) 3) Index the zebraqueue (or reindex if you haven't indexed your system yet) 4) Confirm that if you search for "Cookery" you get the record you just modified Signed-off-by: Jared Camins-Esakov Rebased on master 5 August 2012 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 5 22:29:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Aug 2012 20:29:57 +0000 Subject: [Koha-bugs] [Bug 7417] Include alternate forms from authorities in bibliographic searches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7417 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11362|0 |1 is obsolete| | --- Comment #7 from Jared Camins-Esakov --- Created attachment 11363 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11363&action=edit Bug 7417: Include see from references in bibliographic searches This patch adds the Koha::Indexer::RecordNormalizer and Koha::Indexer::MARC::RecordNormalizer::EmbedSeeFromHeadings packages to enable the inclusion of alternate forms of headings in bibliographic searches. When the new syspref IncludeSeeFromInSearches is turned on (default is off) rebuild_zebra.pl will insert see from headings from authority records into bibliographic records when indexing, so that a search on an obsolete term will turn up relevant records. To test: 1) Enable IncludeSeeFromInSearches 2) Add a heading that has an alternate form to a record (for example, "Cooking" has the alternate form "Cookery," if you have authority records from LC) 3) Index the zebraqueue (or reindex if you haven't indexed your system yet) 4) Confirm that if you search for "Cookery" you get the record you just modified Signed-off-by: Jared Camins-Esakov Rebased on master 5 August 2012 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 5 22:52:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Aug 2012 20:52:33 +0000 Subject: [Koha-bugs] [Bug 7417] Include alternate forms from authorities in bibliographic searches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7417 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11363|0 |1 is obsolete| | --- Comment #8 from Jared Camins-Esakov --- Created attachment 11364 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11364&action=edit Bug 7417: Include see from references in bibliographic searches This patch adds the Koha::Indexer::RecordNormalizer and Koha::Indexer::MARC::RecordNormalizer::EmbedSeeFromHeadings packages to enable the inclusion of alternate forms of headings in bibliographic searches. When the new syspref IncludeSeeFromInSearches is turned on (default is off) rebuild_zebra.pl will insert see from headings from authority records into bibliographic records when indexing, so that a search on an obsolete term will turn up relevant records. To test: 1) Enable IncludeSeeFromInSearches 2) Add a heading that has an alternate form to a record (for example, "Cooking" has the alternate form "Cookery," if you have authority records from LC) 3) Index the zebraqueue (or reindex if you haven't indexed your system yet) 4) Confirm that if you search for "Cookery" you get the record you just modified Signed-off-by: Jared Camins-Esakov Rebased on master 5 August 2012 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 5 23:04:51 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Aug 2012 21:04:51 +0000 Subject: [Koha-bugs] [Bug 7417] Include alternate forms from authorities in bibliographic searches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7417 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11364|0 |1 is obsolete| | --- Comment #9 from Jared Camins-Esakov --- Created attachment 11365 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11365&action=edit Bug 7417: Include see from references in bibliographic searches This patch adds the Koha::Indexer::RecordNormalizer and Koha::Indexer::MARC::RecordNormalizer::EmbedSeeFromHeadings packages to enable the inclusion of alternate forms of headings in bibliographic searches. When the new syspref IncludeSeeFromInSearches is turned on (default is off) rebuild_zebra.pl will insert see from headings from authority records into bibliographic records when indexing, so that a search on an obsolete term will turn up relevant records. To test: 1) Enable IncludeSeeFromInSearches 2) Add a heading that has an alternate form to a record (for example, "Cooking" has the alternate form "Cookery," if you have authority records from LC) 3) Index the zebraqueue (or reindex if you haven't indexed your system yet) 4) Confirm that if you search for "Cookery" you get the record you just modified Signed-off-by: Jared Camins-Esakov Rebased on master 5 August 2012 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 5 23:25:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Aug 2012 21:25:28 +0000 Subject: [Koha-bugs] [Bug 7417] Include alternate forms from authorities in bibliographic searches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7417 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11365|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer --- Created attachment 11366 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11366&action=edit [SIGNED-OFF] Bug 7417: Include see from references in bibliographic searches This patch adds the Koha::Indexer::RecordNormalizer and Koha::Indexer::MARC::RecordNormalizer::EmbedSeeFromHeadings packages to enable the inclusion of alternate forms of headings in bibliographic searches. When the new syspref IncludeSeeFromInSearches is turned on (default is off) rebuild_zebra.pl will insert see from headings from authority records into bibliographic records when indexing, so that a search on an obsolete term will turn up relevant records. To test: 1) Enable IncludeSeeFromInSearches 2) Add a heading that has an alternate form to a record (for example, "Cooking" has the alternate form "Cookery," if you have authority records from LC) 3) Index the zebraqueue (or reindex if you haven't indexed your system yet) 4) Confirm that if you search for "Cookery" you get the record you just modified Signed-off-by: Jared Camins-Esakov Rebased on master 5 August 2012 Signed-off-by: Katrin Fischer Also checked: - Verified database update works correctly - Checked system preference and its description - Checked staff/opac detail pages with feature on/off - Checked staff/opac search facets - Downloaded and tested records in various formats - Tried different searches for 'see from' entries of authorities - Ran all unit tests No problems found. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 5 23:25:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Aug 2012 21:25:49 +0000 Subject: [Koha-bugs] [Bug 7417] Include alternate forms from authorities in bibliographic searches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7417 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 5 23:35:07 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Aug 2012 21:35:07 +0000 Subject: [Koha-bugs] [Bug 6886] Single branch mode should disable showing the branch name in front of all callnumbers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6886 --- Comment #4 from Chris Cormack --- Created attachment 11367 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11367&action=edit Bug 6886 - OPAC XSLT respecting single branch mode This is only for the MARC21 XSLT at this stage, follow up patch for UNIMARC will come Conflicts: C4/XSLT.pm koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 5 23:35:23 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Aug 2012 21:35:23 +0000 Subject: [Koha-bugs] [Bug 6886] Single branch mode should disable showing the branch name in front of all callnumbers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6886 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 5 23:39:02 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Aug 2012 21:39:02 +0000 Subject: [Koha-bugs] [Bug 6617] table of contents not printing right if entered right In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6617 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11357|0 |1 is obsolete| | --- Comment #24 from Katrin Fischer --- Created attachment 11368 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11368&action=edit [SIGNED-OFF] Bug 6617: Improve MARC21 enhanced contents display (intranet) The display of "Enhanced" 505 (contents) fields in the MARC21 XSLT is very poor, resulting in large, unreadable blocks of text, and -- for some series -- so much unnecessary duplication in the Notes tab that important information is entirely obscured. This patch reformats "enhanced" contents fields (MARC21 505 fields with $t and $r) so as to be more readable by breaking up entries on separate lines and making titles bold (to make them stand out more). This patch does not address duplication of information in the Notes tab, per discussion on the #koha IRC channel. To test: 1) View record with enhanced 505 field before applying patch. Observe it is very unfriendly. 2) Apply patch. 3) View same record, note that display is much improved. Signed-off-by: Katrin Fischer Display in staff and OPAC is consistent and improved after applying the patch. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 5 23:39:34 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Aug 2012 21:39:34 +0000 Subject: [Koha-bugs] [Bug 6617] table of contents not printing right if entered right In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6617 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 5 23:45:04 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Aug 2012 21:45:04 +0000 Subject: [Koha-bugs] [Bug 6886] Single branch mode should disable showing the branch name in front of all callnumbers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6886 --- Comment #5 from Chris Cormack --- Created attachment 11369 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11369&action=edit Bug 6886 - Follow up for UNIMARC -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 00:00:26 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Aug 2012 22:00:26 +0000 Subject: [Koha-bugs] [Bug 6886] Single branch mode should disable showing the branch name in front of all callnumbers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6886 --- Comment #6 from Chris Cormack --- Created attachment 11370 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11370&action=edit Bug 6886 Follow up for NORMARC -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 00:01:51 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Aug 2012 22:01:51 +0000 Subject: [Koha-bugs] [Bug 6886] Single branch mode should disable showing the branch name in front of all callnumbers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6886 --- Comment #7 from Chris Cormack --- Please test NORMAC and UNIMARC thoroughly -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 03:33:51 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 01:33:51 +0000 Subject: [Koha-bugs] [Bug 3782] delivered z39.50 targets wrong for NY Public Library and NY University Library In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3782 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #7 from Chris Cormack --- I vote for removing them. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 06:50:55 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 04:50:55 +0000 Subject: [Koha-bugs] [Bug 5357] Subscription search and displays In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5357 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_4 |master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 07:17:30 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 05:17:30 +0000 Subject: [Koha-bugs] [Bug 6310] Add a syspref for injecting CSS into the self checkout screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6310 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 07:48:50 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 05:48:50 +0000 Subject: [Koha-bugs] [Bug 6310] Add a syspref for injecting CSS into the self checkout screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6310 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7953 --- Comment #2 from Marc V?ron --- Is resolved in version 3.8 with system preferences opacuserjs and opacusercss. See http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7953#c4 and http://wiki.koha-community.org/wiki/JQuery_Library Is this Bug still needed for 3.6? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 07:48:50 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 05:48:50 +0000 Subject: [Koha-bugs] [Bug 7953] opacuserjs to the sco template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7953 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=6310 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 08:06:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 06:06:57 +0000 Subject: [Koha-bugs] [Bug 6583] Self checkout by login fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6583 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #1 from Marc V?ron --- Tested with 3.09.00.030, works. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 09:22:38 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 07:22:38 +0000 Subject: [Koha-bugs] [Bug 7919] Display of values depending on the connexion library In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 Alexandre Lengereau changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexandre.lengereau at biblibr | |e.com --- Comment #18 from Alexandre Lengereau --- Sandbox test result: Something went wrong ! Applying: Bug 7919 : Display of values depending on the connexion librairy Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging C4/Budgets.pm Auto-merging C4/Input.pm Auto-merging C4/Koha.pm Auto-merging C4/Members.pm Auto-merging C4/Members/AttributeTypes.pm Auto-merging C4/Members/Attributes.pm Auto-merging admin/authorised_values.pl Auto-merging admin/categorie.pl CONFLICT (content): Merge conflict in admin/categorie.pl Auto-merging admin/patron-attr-types.pl Auto-merging cataloguing/addbiblio.pl Auto-merging cataloguing/additem.pl Auto-merging installer/data/mysql/kohastructure.sql Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/authorised_values.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/categorie.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/categorie.tt Failed to merge in the changes. Patch failed at 0001 Bug 7919 : Display of values depending on the connexion librairy When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". Bug 7919 - Display of values depending on the connexion library Bug 7919 : Display of values depending on the connexion librairy Apply? [yn] Patch left in /tmp/Bug-7919--Display-of-values-depending-on-the-conne-hVli22.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 09:30:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 07:30:39 +0000 Subject: [Koha-bugs] [Bug 7919] Display of values depending on the connexion library In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 09:36:56 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 07:36:56 +0000 Subject: [Koha-bugs] [Bug 7688] Change subscriptions numbering pattern and frequencies In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688 --- Comment #34 from Julian Maurice --- (In reply to comment #33) > I have a ticket from a library asking if Koha can do the following - I'm > wondering if this patch does any of these things (just a yes or no would be > great for each point): > > > Ability to customize Chronology Type I'm not sure what you mean by 'chronology type' but you are able to create "frequencies" which are defined by a "unit" (day, week, month or year), a "number of issues per unit" (for example if you receive 2 issues per day), and a number of unit between each issues (for example if you receive 1 issue every 2 days) > More options and customizability in Publication Cycle I don't understand, what is the difference between Publication Cycle and Chronology Type ? > Omit dates/months What does it mean exactly? > Ability to modify independent issues after they arrive Hmm I think you actually can modify already received issues via serials-collection.pl page, by checking appropriate issues and clicking "Edit serials". > Ability to combine issues (ex. June and July are usually separate but the > publication decides to combine them for that year) No. This patch do not allow that. > Date functionality in dropbox (ex. Volume, Number, Date) Do you mean having the received date of issue in its serial number ? In this case, no, but I think this could be added without much effort > And have the actual Month spelled out (January...) Yes, you can indicate 'monthname' in the new field 'Formatting' of numbering pattern, and a value of 1 will be saved as "January". You can choose the locale in the subscription edit page. ('dayname' is also possible) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 09:37:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 07:37:39 +0000 Subject: [Koha-bugs] [Bug 7688] Change subscriptions numbering pattern and frequencies In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #35 from Julian Maurice --- As Fr?deric asked for a second signoff, I reset the status to "Needs signoff" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 09:58:08 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 07:58:08 +0000 Subject: [Koha-bugs] [Bug 8572] Attempting to view an invalid authority in the OPAC gives an error instead of 404 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8572 --- Comment #2 from Chris Cormack --- Created attachment 11371 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11371&action=edit Bug 8572: invalid auth shouldn't cause error Prior to this patch, attempting to view an invalid authority in the OPAC gave a system error instead of a 404. With this patch, the user will just get a 404, as is the case with invalid bibs. To test: 1) Try to view an invalid authority by going to: /cgi-bin/koha/opac-authoritiesdetail.pl?authid=999999999999 (presuming that you don't have an authority with authid 999999999999 in your database) before and after applying this patch Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 09:58:45 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 07:58:45 +0000 Subject: [Koha-bugs] [Bug 8572] Attempting to view an invalid authority in the OPAC gives an error instead of 404 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8572 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 09:59:17 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 07:59:17 +0000 Subject: [Koha-bugs] [Bug 8572] Attempting to view an invalid authority in the OPAC gives an error instead of 404 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8572 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11358|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 09:59:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 07:59:24 +0000 Subject: [Koha-bugs] [Bug 8573] New: Translation difficult in picture-upload.tt due to nested sentence in if/foreach/if/elsif - construction Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8573 Priority: P5 - low Change sponsored?: --- Bug ID: 8573 CC: frederic at tamil.fr Assignee: koha-bugs at lists.koha-community.org Summary: Translation difficult in picture-upload.tt due to nested sentence in if/foreach/if/elsif - construction Severity: normal Classification: Unclassified OS: All Reporter: veron at veron.ch Hardware: All Status: NEW Version: master Component: translate.koha-community.org Product: Koha The following code in koha-tmpl/intranet-tmpl/prog/en/modules/tools/picture-upload.tt leads in Pootle to a situation where a correct ranslation is simply not possible: ------------ [% IF ( COUNT.TCOUNTS ) %]
  • [% COUNT.TCOUNTS %] image(s) moved into the database:
  • [% END %] [% FOREACH filename IN COUNT.filenames %]
  • [% filename.source %] - Cardnumber: [% filename.cardnumber %] [% IF ( filename.filerrors ) %]
    WARNING: This image not imported because [% FOREACH filerror IN filename.filerrors %] [% IF ( filerror.DBERR ) %]the database returned an error. Please refer to the error log for more details.
  • [% ELSIF ( filerror.IMGEXISTS ) %]this patron does not exist in the database. [% ELSIF ( filerror.MIMERR ) %]the image format is unrecognized. [% ELSIF ( filerror.CORERR ) %]the image file is corrupted. [% ELSIF ( filerror.OPNERR ) %]Koha was unable to open the image for reading. [% ELSIF ( filerror.OVRSIZ ) %]the image file is too big. [% ELSIF ( filerror.CRDFIL ) %]the [% filerror.CRDFIL %] is missing. [% ELSE %]of an unknown error. Please refer to the error log for more details.[% END %] [% END %] [% ELSE %] imported successfully. [% END %] [% END %] ---------------------- Pootle separates this poorly: "imported because %s %sthe database returned an error. Please refer to the error log for more details." "imported because" then is missing for all following if/elsif branches, leading to mutilated sentences. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 10:00:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 08:00:58 +0000 Subject: [Koha-bugs] [Bug 8573] Translation difficult in picture-upload.tt due to nested sentence in if/foreach/if/elsif - construction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8573 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P3 Assignee|koha-bugs at lists.koha-commun |veron at veron.ch |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 10:03:38 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 08:03:38 +0000 Subject: [Koha-bugs] [Bug 8573] Translation difficult in picture-upload.tt due to nested sentence in if/foreach/if/elsif - construction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8573 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Component|translate.koha-community.or |Templates |g | Assignee|veron at veron.ch |oleonard at myacpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 10:03:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 08:03:47 +0000 Subject: [Koha-bugs] [Bug 8513] OPAC detail page broken with XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8513 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #2 from Chris Cormack --- Fridolyn, does this only occur in UNIMARC, or does NORMARC and MARC21 have the same problem? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 10:08:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 08:08:33 +0000 Subject: [Koha-bugs] [Bug 8172] Missing dereference marker for buildQuery parameter in addbooks.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8172 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10606|0 |1 is obsolete| | --- Comment #5 from Chris Cormack --- Created attachment 11372 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11372&action=edit Bug 8172: Followup: Removes useless empty params Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 10:08:51 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 08:08:51 +0000 Subject: [Koha-bugs] [Bug 8172] Missing dereference marker for buildQuery parameter in addbooks.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8172 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 10:11:03 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 08:11:03 +0000 Subject: [Koha-bugs] [Bug 8307] Set a value for items when receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8307 Alexandre Lengereau changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexandre.lengereau at biblibr | |e.com --- Comment #2 from Alexandre Lengereau --- SandBox Test result:

    Something went wrong !

    Applying: Bug 8307: Set a value for items when ordering
    Using index info to reconstruct a base tree...
    Falling back to patching base and 3-way merge...
    Auto-merging installer/data/mysql/sysprefs.sql
    CONFLICT (content): Merge conflict in installer/data/mysql/sysprefs.sql
    Auto-merging installer/data/mysql/updatedatabase.pl
    CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl
    Failed to merge in the changes.
    Patch failed at 0001 Bug 8307: Set a value for items when ordering
    When you have resolved this problem run git am --resolved.
    If you would prefer to skip this patch, instead run git am --skip.
    To restore the original branch and stop patching run git am --abort.
    Bug 8307 - Set a value for items when receiving

    Bug 8307: Set a value for items when ordering
    Apply? [yn]
    Patch left in /tmp/Bug-8307-Set-a-value-for-items-when-ordering-K_sCQB.patch

    === translation installation ===
    If you use this system for the 1st time, you may find usefull to reach the wiki page http://wiki.koha-community.org/wiki/Sandboxes to have some information about those results, to check if everything went well & if you can test the patch properly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 10:17:07 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 08:17:07 +0000 Subject: [Koha-bugs] [Bug 7919] Display of values depending on the connexion library In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9984|0 |1 is obsolete| | Attachment #11163|0 |1 is obsolete| | Attachment #11168|0 |1 is obsolete| | --- Comment #19 from Jonathan Druart --- Created attachment 11373 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11373&action=edit Bug 7919 : Display of values depending on the connexion library Rebased and squashed patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 10:17:17 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 08:17:17 +0000 Subject: [Koha-bugs] [Bug 7919] Display of values depending on the connexion library In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 10:22:40 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 08:22:40 +0000 Subject: [Koha-bugs] [Bug 7671] add a real primary key "accountlinesid" in accountlines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7671 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #18 from Chris Cormack --- Before +----------------+-----------+------------+------------+----------+-------------+---------+-------------+-------------------+---------------+---------------------+-----------+--------------+------+------------+ | borrowernumber | accountno | itemnumber | date | amount | description | dispute | accounttype | amountoutstanding | lastincrement | timestamp | notify_id | notify_level | note | manager_id | +----------------+-----------+------------+------------+----------+-------------+---------+-------------+-------------------+---------------+---------------------+-----------+--------------+------+------------+ | 1 | 1 | NULL | 2012-08-06 | 2.000000 | NULL | NULL | Pay | NULL | NULL | 2012-08-06 20:15:58 | 0 | 0 | NULL | NULL | +----------------+-----------+------------+------------+----------+-------------+---------+-------------+-------------------+---------------+---------------------+-----------+--------------+------+------------+ After patch +----------------+----------------+-----------+------------+------------+----------+-------------+---------+-------------+-------------------+---------------+---------------------+-----------+--------------+------+------------+ | accountlinesid | borrowernumber | accountno | itemnumber | date | amount | description | dispute | accounttype | amountoutstanding | lastincrement | timestamp | notify_id | notify_level | note | manager_id | +----------------+----------------+-----------+------------+------------+----------+-------------+---------+-------------+-------------------+---------------+---------------------+-----------+--------------+------+------------+ | 1 | 1 | 1 | NULL | 2012-08-06 | 2.000000 | NULL | NULL | Pay | NULL | NULL | 2012-08-06 20:15:58 | 0 | 0 | NULL | NULL | +----------------+----------------+-----------+------------+------------+----------+-------------+---------+-------------+-------------------+---------------+---------------------+-----------+--------------+------+------------+ I then tested creating manual invoices, credits, reversing payments, paying, and writing off. The only thing I didnt test was overdue charges being added correctly. But as 2 others have already signed off on this. Marking signed off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 10:23:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 08:23:39 +0000 Subject: [Koha-bugs] [Bug 7671] add a real primary key "accountlinesid" in accountlines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7671 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10343|0 |1 is obsolete| | --- Comment #19 from Chris Cormack --- Created attachment 11374 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11374&action=edit Bug 7671 : add a real primary key accountlinesid in accountlines Signed-off-by: St?phane Delaune Signed-off-by: Marc Veron NOTE: After applying the patch I got following errors in members/pay.pl: Global symbol "$writeoff_sth" requires explicit package name Global symbol "$add_writeoff_sth" requires explicit package name Added to lines at the begin of members/pay.pl: our $writeoff_sth; our $add_writeoff_sth; Now the patch worked as expected. However I am not quite sure if signing off is OK in this situation. Marc Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 10:26:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 08:26:58 +0000 Subject: [Koha-bugs] [Bug 7417] Include alternate forms from authorities in bibliographic searches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7417 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart at biblibre.co | |m --- Comment #11 from Jonathan Druart --- QA Comments: This patch fixes a "Trailing comma of death" (see http://www.enterprisedojo.com/2010/12/19/beware-the-trailing-comma-of-death/) for IE Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 10:27:54 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 08:27:54 +0000 Subject: [Koha-bugs] [Bug 7417] Include alternate forms from authorities in bibliographic searches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7417 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |ASSIGNED --- Comment #12 from Jonathan Druart --- Oupps ! Wrong bug, sorry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 10:28:05 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 08:28:05 +0000 Subject: [Koha-bugs] [Bug 7417] Include alternate forms from authorities in bibliographic searches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7417 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 10:28:12 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 08:28:12 +0000 Subject: [Koha-bugs] [Bug 7417] Include alternate forms from authorities in bibliographic searches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7417 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 10:28:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 08:28:29 +0000 Subject: [Koha-bugs] [Bug 8547] Enabling star ratings causes javascript errors that cause IE to have a boo boo In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8547 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart at biblibre.co | |m --- Comment #9 from Jonathan Druart --- QA Comments: This patch fixes a "Trailing comma of death" (see http://www.enterprisedojo.com/2010/12/19/beware-the-trailing-comma-of-death/) for IE Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 10:28:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 08:28:43 +0000 Subject: [Koha-bugs] [Bug 8307] Set a value for items when receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8307 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 10:36:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 08:36:24 +0000 Subject: [Koha-bugs] [Bug 8547] Enabling star ratings causes javascript errors that cause IE to have a boo boo In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8547 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #10 from Chris Cormack --- Have picked this into 3.8.x, will be in 3.8.4, safe change, fixes broken IE. (Well fixes one small symptom of its huge pile of brokenness anyway) Leaving as Passed QA, so Paul can push to master when he gets back. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 10:53:06 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 08:53:06 +0000 Subject: [Koha-bugs] [Bug 8435] new permissions on subscriptions "superserials" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435 Alexandre Lengereau changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |alexandre.lengereau at biblibr | |e.com --- Comment #2 from Alexandre Lengereau --- Sandbox test: CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl
    CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-home.tt
    -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 10:53:20 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 08:53:20 +0000 Subject: [Koha-bugs] [Bug 8573] Translation difficult in picture-upload.tt due to nested sentence in if/foreach/if/elsif - construction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8573 --- Comment #1 from Marc V?ron --- Created attachment 11375 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11375&action=edit Bug 8573 - Translation difficult in picture-upload.tt due to nested sentence in if/foreach/if/elsif - construction Text could not be correctly translated due to poor parsing of nested sentences in Pootle. *Sentences de-nested to have whole sentence in each if /elsif branch *Changed WARNING to ERROR because it is an *Error* during upload. *Wording simplified. In one case added hint to refer to online help (size). This way text should be easier to be translated in Pootle. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 10:54:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 08:54:41 +0000 Subject: [Koha-bugs] [Bug 8573] Translation difficult in picture-upload.tt due to nested sentence in if/foreach/if/elsif - construction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8573 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 11:17:45 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 09:17:45 +0000 Subject: [Koha-bugs] [Bug 8537] In moremember.pl the call of output_pref is without check In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8537 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11219|0 |1 is obsolete| | --- Comment #2 from Chris Cormack --- Created attachment 11376 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11376&action=edit Bug 8537 : In moremember.pl the call of 'output_pref' is without check the argument passed to "output_pref", could be undefined, in this case koha is not happy. I just put a condition, the same logic than for the line below. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 11:18:07 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 09:18:07 +0000 Subject: [Koha-bugs] [Bug 8537] In moremember.pl the call of output_pref is without check In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8537 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 11:21:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 09:21:10 +0000 Subject: [Koha-bugs] [Bug 8573] Translation difficult in picture-upload.tt due to nested sentence in if/foreach/if/elsif - construction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8573 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 11:51:42 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 09:51:42 +0000 Subject: [Koha-bugs] [Bug 8574] New: test Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8574 Priority: P5 - low Change sponsored?: --- Bug ID: 8574 Assignee: koha-bugs at lists.koha-community.org Summary: test Severity: enhancement Classification: Unclassified OS: Windows Reporter: savitri_gokarnesan01 at infosys.com Hardware: PC Status: NEW Version: unspecified Component: Acquisitions Product: Koha -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 11:52:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 09:52:49 +0000 Subject: [Koha-bugs] [Bug 7417] Include alternate forms from authorities in bibliographic searches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7417 --- Comment #13 from Jonathan Druart --- Hi Jared, For discussion: This patch is interesting. It introduces some new notions into Koha. For example, objects appear into Koha with an (not one of the least) Authority module \o/ But ... :) Why do you choose an old method to do OOP in Perl (bless, SUPER) ? I think you may have heard about Moose or Moo, why don't use one of them directly from the beginning of the Koha::* rewriting? It seems your naming into the Koha namespace is not in agreement with the wiki page: http://wiki.koha-community.org/wiki/Koha_Namespace_RFC For new files, I think a best practice is to use "use Modern::Perl" instead of "use strict; use warnings;" But nothing is written on the wiki. You are free to keep these lines. I really like your system of plugin. Our BibLibre dev/solr branch already have this kind of plugin for the routine index_record. This system is used for 1 index (for example we have a lot of plugins: Date (for index containing dates), Callnumber, isbn (for a dash management), etc.). Here we want to add a processing in 1 case (but other cases will certainly come). We can imagine to add a new part in the searchengine configuration page containing a list of features like this one. Thus, the routine will grow quickly and make it unmaintanable. In fact, we would have a pluggable system here too. But it is not for now... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 12:03:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 10:03:29 +0000 Subject: [Koha-bugs] [Bug 8435] new permissions on subscriptions "superserials" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10821|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 11377 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11377&action=edit Bug 8435: If IndependantBranches is on, Serials can't be manage from others libraries Rebased patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 12:03:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 10:03:37 +0000 Subject: [Koha-bugs] [Bug 8435] new permissions on subscriptions "superserials" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 12:05:16 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 10:05:16 +0000 Subject: [Koha-bugs] [Bug 8513] OPAC detail page broken with XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8513 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11191|0 |1 is obsolete| | --- Comment #3 from Fridolyn SOMERS --- Created attachment 11378 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11378&action=edit Proposed patch (all MARC) Added same control on 'm880Select' template used in MARC21 and NORMARC. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 12:07:03 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 10:07:03 +0000 Subject: [Koha-bugs] [Bug 7417] Include alternate forms from authorities in bibliographic searches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7417 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #14 from Chris Cormack --- (In reply to comment #13) > Hi Jared, > > For discussion: > > This patch is interesting. It introduces some new notions into Koha. > For example, objects appear into Koha with an (not one of the least) > Authority module \o/ > But ... :) > > Why do you choose an old method to do OOP in Perl (bless, SUPER) ? I think > you may have heard about Moose or Moo, why don't use one of them directly > from the beginning of the Koha::* rewriting? > This is using Class::Accessor http://search.cpan.org/~rjbs/perl-5.16.0/pod/perlootut.pod#Class::Accessor Which introduces no new dependencies, and importantly it's fast Class::Accessor does not employ an autoloader, thus it is much faster than you'd think. Its generated methods incur no special penalty over ones you'd write yourself. And for those who want it, it has a moose like interface http://search.cpan.org/~kasei/Class-Accessor-0.34/lib/Class/Accessor.pm#Moose-like -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 12:07:54 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 10:07:54 +0000 Subject: [Koha-bugs] [Bug 8513] OPAC detail page broken with XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8513 --- Comment #4 from Fridolyn SOMERS --- Note that there are a lot of links in intranet XSLT, the problem can appear there. For me, the problem could be solved by changing XSTL output method. I send a mail 'XSLT output method' to koha-devel to open the discussion. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 12:12:56 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 10:12:56 +0000 Subject: [Koha-bugs] [Bug 8307] Set a value for items when receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8307 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10472|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 11379 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11379&action=edit Bug 8307: Set a value for items when ordering Rebased patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 12:13:04 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 10:13:04 +0000 Subject: [Koha-bugs] [Bug 8307] Set a value for items when receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8307 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 14:08:08 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 12:08:08 +0000 Subject: [Koha-bugs] [Bug 8575] New: Number of items expected is wrong Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8575 Priority: P5 - low Change sponsored?: --- Bug ID: 8575 Assignee: koha-bugs at lists.koha-community.org Summary: Number of items expected is wrong Severity: normal Classification: Unclassified OS: All Reporter: julian.maurice at biblibre.com Hardware: All Status: NEW Version: master Component: Acquisitions Product: Koha In acqui/booksellers.pl, the number below "Items expected" column is wrong, because it also takes into account cancelled orders. Steps to reproduce: 1/ create a new basket with 2 orders, one with 1 item, another with 2 items 2/ look at booksellers.pl page, you should see that 3 items are expected 3/ cancel one order 4/ refresh booksellers.pl page, there are still 3 items expected -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 14:08:55 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 12:08:55 +0000 Subject: [Koha-bugs] [Bug 5349] Moving an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 --- Comment #26 from Julian Maurice --- This issue is not related to this bug. I've created another bug for it: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8575 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 14:10:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 12:10:33 +0000 Subject: [Koha-bugs] [Bug 8575] Number of items expected is wrong In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8575 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |julian.maurice at biblibre.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 14:22:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 12:22:21 +0000 Subject: [Koha-bugs] [Bug 7417] Include alternate forms from authorities in bibliographic searches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7417 --- Comment #15 from Jonathan Druart --- (In reply to comment #14) Chris, Thanks for your answer. > Which introduces no new dependencies Koha already use a lot of dependencies. For a dependency as much important part (OOP) I think it is not a good argument. Furthermore this dependency will be used elsewhere :) > and importantly it's fast Class::Accessor does not employ an autoloader Yes, I agree with you, fastness is one of the more important thing > thus it is much faster than you'd think. Its generated methods incur no > special penalty over ones you'd write yourself. Ok cool. But it is just for accessor isn't it ? I think we will quickly want to add relations between our classes (roles, superclasses, etc.). Before introducing new important classes (as Authority) in the Koha namespace, I think it is important to start a global discussion. What do we want for this new namespace and for this rewriting ? It would be great to have new classes written as we want from the beginning. This would show what are the best practices to follow for futures classes. To have a reflexion about how we want to rewrite the C4 modules seems to be the first step. How we want to order our classes ? What Koha::Authority must do ? We agree we don't want all C4::AuthoritiesMarc into Koha::Authority :) Mo[o][se] module[s] permits to create classes (with attr, method, etc.), inheritance, etc. In fact it allows to do OO, very simply if an application design has been made before. If we don't take the time to make cleanly things, my fear is to see a lot of extra developements inside the module not related to it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 14:25:15 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 12:25:15 +0000 Subject: [Koha-bugs] [Bug 8575] Number of items expected is wrong In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8575 --- Comment #1 from Julian Maurice --- Created attachment 11380 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11380&action=edit Bug 8575: Expected items count should not include cancelled orders To test: 1/ create a new basket with 2 orders, one with 1 item, another with 2 items 2/ look at booksellers.pl page, you should see that 3 items are expected 3/ cancel the order with 1 item 4/ refresh booksellers.pl page, it should remains 2 expected items -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 14:25:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 12:25:24 +0000 Subject: [Koha-bugs] [Bug 8575] Number of items expected is wrong In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8575 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 14:33:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 12:33:41 +0000 Subject: [Koha-bugs] [Bug 5888] opac-detail subject/author links improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5888 --- Comment #18 from Julian Maurice --- Jared, I have no objections at all. You can do what you want with these patches ;-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 14:36:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 12:36:09 +0000 Subject: [Koha-bugs] [Bug 7417] Include alternate forms from authorities in bibliographic searches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7417 --- Comment #16 from Katrin Fischer --- Hi Jonathan, I think I am more worried that we won't ever agree on something and we should start doing things. Also sometimes something in theory is good, but doesn't work really well in reality. Jared does a lot of work in authorities recently and has revamped a big part of it already, I would hate to see this work lost. Especially this feature is of big importance to libraries here. I think this could be seen as a working example of how we could make use of Class::Accessor, while I think the Solr code is using Moose? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 14:37:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 12:37:35 +0000 Subject: [Koha-bugs] [Bug 8537] In moremember.pl the call of output_pref is without check In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8537 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |RESOLVED CC| |jonathan.druart at biblibre.co | |m Resolution|--- |DUPLICATE --- Comment #3 from Jonathan Druart --- QA Comments: This patch becomes useless with the patch proposed by Robin for Bug 8532. I mark this one as Resolved *** This bug has been marked as a duplicate of bug 8532 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 14:37:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 12:37:35 +0000 Subject: [Koha-bugs] [Bug 8532] Old/iffy data causes error checking out In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8532 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |christophe.croullebois at bibl | |ibre.com --- Comment #4 from Jonathan Druart --- *** Bug 8537 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 14:38:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 12:38:09 +0000 Subject: [Koha-bugs] [Bug 8412] add color icon set In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8412 --- Comment #5 from Nicole C. Engard --- My thinking was law libraries and the different shades of law books :) but here is a smaller set of images, I'd like to allow people to download the entire site of images via the wiki maybe or something if that helps. As for the SQL do you mean as a tip on the patch? I can totally do that, I can also add a new authorized value for Colors, but then that has to be moved to LOC or CCOODE if you plan to use one of those for holding color info. Keep an eye out - new patch coming in a few minutes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 14:45:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 12:45:49 +0000 Subject: [Koha-bugs] [Bug 7417] Include alternate forms from authorities in bibliographic searches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7417 --- Comment #17 from Jared Camins-Esakov --- (In reply to comment #13) > Hi Jared, > > For discussion: > > This patch is interesting. It introduces some new notions into Koha. > For example, objects appear into Koha with an (not one of the least) > Authority module \o/ > But ... :) > > Why do you choose an old method to do OOP in Perl (bless, SUPER) ? I think > you may have heard about Moose or Moo, why don't use one of them directly > from the beginning of the Koha::* rewriting? My experience with Moose and CGI is that it's kind of slow. This seems like a huge problem on something as core as authority and bibliographic record objects. Also, after I tried to get the solr code working on my system Moose no longer functions. Choosing between core functionality (with a version of Moose that installs) and Solr (with a complex install procedure that will presumably leave Moose not working elsewhere) seems like a bad choice. > It seems your naming into the Koha namespace is not in agreement with the > wiki page: http://wiki.koha-community.org/wiki/Koha_Namespace_RFC It's easy to do a follow up to change the name. If you tell me what you'd like it called, I will do a follow-up that changes the name. I think it should probably be Koha::DataObject::Authority, based on the RFC, but I decided to just call it "Koha::Authority" until I had a second opinion. > For new files, I think a best practice is to use "use Modern::Perl" instead > of "use strict; use warnings;" > But nothing is written on the wiki. You are free to keep these lines. I'm not attached to them. :) > I really like your system of plugin. Our BibLibre dev/solr branch already > have this kind of plugin for the routine index_record. This system is used > for 1 index (for example we have a lot of plugins: Date (for index > containing dates), Callnumber, isbn (for a dash management), etc.). > Here we want to add a processing in 1 case (but other cases will certainly > come). We can imagine to add a new part in the searchengine configuration > page containing a list of features like this one. > Thus, the routine will grow quickly and make it unmaintanable. In fact, we > would have a pluggable system here too. But it is not for now... I wrote this with the idea that we should be able to use this filter system elsewhere in Koha, too... as a place to put the filters from dev/solr, as well as (conceivably) before display. This of course makes speed even more crucial. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 14:47:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 12:47:11 +0000 Subject: [Koha-bugs] [Bug 7921] Software error while placing order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7921 --- Comment #2 from Fridolyn SOMERS --- (In reply to comment #1) > ACQ Framework should be used. But in actual version, the default framework > is used instead and a message is displayed on acquisition pages. I mean, default framework is used if ACQ framework does not exist. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 14:51:36 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 12:51:36 +0000 Subject: [Koha-bugs] [Bug 7417] Include alternate forms from authorities in bibliographic searches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7417 --- Comment #18 from Jared Camins-Esakov --- (In reply to comment #15) > (In reply to comment #14) > > Chris, > Thanks for your answer. > > > Which introduces no new dependencies > Koha already use a lot of dependencies. For a dependency as much important > part (OOP) I think it is not a good argument. > Furthermore this dependency will be used elsewhere :) > > > and importantly it's fast Class::Accessor does not employ an autoloader > Yes, I agree with you, fastness is one of the more important thing > > > thus it is much faster than you'd think. Its generated methods incur no > > special penalty over ones you'd write yourself. > Ok cool. > But it is just for accessor isn't it ? > I think we will quickly want to add relations between our classes (roles, > superclasses, etc.). > Before introducing new important classes (as Authority) in the Koha > namespace, I think it is important to start a global discussion. What do we > want for this new namespace and for this rewriting ? I think we want it to work, and provide much-needed features. > It would be great to have new classes written as we want from the beginning. > This would show what are the best practices to follow for futures classes. > To have a reflexion about how we want to rewrite the C4 modules seems to be > the first step. How we want to order our classes ? What Koha::Authority must > do ? We agree we don't want all C4::AuthoritiesMarc into Koha::Authority :) We have been talking about this for a year, and no one actually seems to have much of an opinion, other than the concepts set down in the namespace RFC. As for what Koha::Authority does, I propose the following list: 1. Retrieve an authority from the database. 2. Update/create an authority in the database. 3. Retrieve metadata about the authority. 4. Set metadata about the authority. 5. There is no five. > Mo[o][se] module[s] permits to create classes (with attr, method, etc.), > inheritance, etc. In fact it allows to do OO, very simply if an application > design has been made before. I don't think I see the benefit here. Don't get me wrong, I really like the idea of Moose, but the speed issue, and the errors every time I try to load it, make me think that we're better off using Class::Accessor, which we already use elsewhere in Koha to great success. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 14:59:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 12:59:41 +0000 Subject: [Koha-bugs] [Bug 8576] New: Software error on authority edition when using merge Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8576 Priority: P5 - low Change sponsored?: --- Bug ID: 8576 CC: m.de.rooy at rijksmuseum.nl Assignee: gmcharlt at gmail.com Summary: Software error on authority edition when using merge Severity: critical Classification: Unclassified OS: All Reporter: fridolyn.somers at biblibre.com Hardware: All Status: NEW Version: master Component: Cataloging Product: Koha When using the update of biblios on authorities edition (managed by 'dontmerge' syspref), and when biblionumber is on a control field (< 10) : When editing or creating an authority, you get a software error : "Software error: Control fields (generally, just tags below 010) do not have subfields, use data() at /usr/share/perl5/MARC/Record.pm line 239 For help, ..." This comes from the fact that, to find biblionumber in a record, one must check if biblio.biblionumber is mapped on a control field to call "$record->field($tagfield)->data" instead if "$record->subfield($tagfield,$tagsubfield)". It was also missing in batchImportMARCWithBiblionumbers.pl. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 15:05:18 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 13:05:18 +0000 Subject: [Koha-bugs] [Bug 8412] add color icon set In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8412 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10758|0 |1 is obsolete| | --- Comment #6 from Nicole C. Engard --- Created attachment 11381 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11381&action=edit Bug 8412: add color icon set My goal here is to make it so that libraries can use one of the authorized values (shelving location or collection code) to store the color of the material and then make that searchable on the advanced search page. To do this for collection codes you'd need to add the following jqueries: intranetuserjs $(document).ready(function(){ $("#advsearch-tab-ccode a:contains('Collection')").text("Color"); $("#holdings th:contains('Collection')").text("Color"); }); opacuserjs $(document).ready(function(){ $("#advsearch-tab-ccode a:contains('Collection')").text("Color"); $('#item_ccode').text("Color"); }); And update the frameworks to change the 952$8 label to say Color. The following SQL could be used to add these colors to the CCODE authorized value category if you planned on using these this way. If you wanted to use these colors for another authorized value you'd have to edit this to use that category: insert into authorised_values (category, authorised_value, lib, lib_opac, imageurl) values ('CCODE','000000','Black','','colors/000000.png'); insert into authorised_values (category, authorised_value, lib, lib_opac, imageurl) values ('CCODE','66cc66','Bright Green','','colors/66cc66.png'); insert into authorised_values (category, authorised_value, lib, lib_opac, imageurl) values ('CCODE','99cc33','Olive','','colors/99cc33.png'); insert into authorised_values (category, authorised_value, lib, lib_opac, imageurl) values ('CCODE','3333cc','Dark Blue','','colors/3333cc.png'); insert into authorised_values (category, authorised_value, lib, lib_opac, imageurl) values ('CCODE','006600' ,'Dark Green','','colors/006600.png'); insert into authorised_values (category, authorised_value, lib, lib_opac, imageurl) values ('CCODE','6600cc','Plum','','colors/6600cc.png'); insert into authorised_values (category, authorised_value, lib, lib_opac, imageurl) values ('CCODE','6666cc','Purple','','colors/6666cc.png'); insert into authorised_values (category, authorised_value, lib, lib_opac, imageurl) values ('CCODE','9999cc','Light Purple','','colors/9999cc.png'); insert into authorised_values (category, authorised_value, lib, lib_opac, imageurl) values ('CCODE','660000' ,'Burgundy','','colors/660000.png'); insert into authorised_values (category, authorised_value, lib, lib_opac, imageurl) values ('CCODE','663333' ,'Brown','','colors/663333.png'); insert into authorised_values (category, authorised_value, lib, lib_opac, imageurl) values ('CCODE','990000' ,'Red','','colors/990000.png'); insert into authorised_values (category, authorised_value, lib, lib_opac, imageurl) values ('CCODE','996633' ,'Tan','','colors/996633.png'); insert into authorised_values (category, authorised_value, lib, lib_opac, imageurl) values ('CCODE','999999' ,'Gray','','colors/999999.png'); insert into authorised_values (category, authorised_value, lib, lib_opac, imageurl) values ('CCODE','cc66cc','Pink','','colors/cc66cc.png'); insert into authorised_values (category, authorised_value, lib, lib_opac, imageurl) values ('CCODE','cc99cc','Bubble Gum','','colors/cc99cc.png'); insert into authorised_values (category, authorised_value, lib, lib_opac, imageurl) values ('CCODE','cc3333' ,'Orange','','colors/cc3333.png'); insert into authorised_values (category, authorised_value, lib, lib_opac, imageurl) values ('CCODE','cc6666' ,'Peach','','colors/cc6666.png'); insert into authorised_values (category, authorised_value, lib, lib_opac, imageurl) values ('CCODE','cc9999' ,'Rose','','colors/cc9999.png'); insert into authorised_values (category, authorised_value, lib, lib_opac, imageurl) values ('CCODE','cccc00' ,'Gold','','colors/cccc00.png'); insert into authorised_values (category, authorised_value, lib, lib_opac, imageurl) values ('CCODE','ffff33' ,'Yellow','','colors/ffff33.png'); insert into authorised_values (category, authorised_value, lib, lib_opac, imageurl) values ('CCODE','ffffcc','Cream','','colors/ffffcc.png'); insert into authorised_values (category, authorised_value, lib, lib_opac, imageurl) values ('CCODE','ffffff','White','','colors/ffffff.png'); I'll add this tip to a blog post and to the manual once this set of icons has been pushed to Koha. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 15:07:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 13:07:37 +0000 Subject: [Koha-bugs] [Bug 8412] add color icon set In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8412 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11381|0 |1 is obsolete| | --- Comment #7 from Nicole C. Engard --- Created attachment 11382 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11382&action=edit Bug 8412: add color icon set My goal here is to make it so that libraries can use one of the authorized values (shelving location or collection code) to store the color of the material and then make that searchable on the advanced search page. To do this for collection codes you'd need to add the following jqueries: intranetuserjs $(document).ready(function(){ $("#advsearch-tab-ccode a:contains('Collection')").text("Color"); $("#holdings th:contains('Collection')").text("Color"); }); opacuserjs $(document).ready(function(){ $("#advsearch-tab-ccode a:contains('Collection')").text("Color"); $('#item_ccode').text("Color"); }); And update the frameworks to change the 952$8 label to say Color. The following SQL could be used to add these colors to the CCODE authorized value category if you planned on using these this way. If you wanted to use these colors for another authorized value you'd have to edit this to use that category: insert into authorised_values (category, authorised_value, lib, lib_opac, imageurl) values ('CCODE','000000','Black','','colors/000000.png'); insert into authorised_values (category, authorised_value, lib, lib_opac, imageurl) values ('CCODE','66cc66','Bright Green','','colors/66cc66.png'); insert into authorised_values (category, authorised_value, lib, lib_opac, imageurl) values ('CCODE','99cc33','Olive','','colors/99cc33.png'); insert into authorised_values (category, authorised_value, lib, lib_opac, imageurl) values ('CCODE','3333cc','Dark Blue','','colors/3333cc.png'); insert into authorised_values (category, authorised_value, lib, lib_opac, imageurl) values ('CCODE','006600' ,'Dark Green','','colors/006600.png'); insert into authorised_values (category, authorised_value, lib, lib_opac, imageurl) values ('CCODE','6600cc','Plum','','colors/6600cc.png'); insert into authorised_values (category, authorised_value, lib, lib_opac, imageurl) values ('CCODE','6666cc','Purple','','colors/6666cc.png'); insert into authorised_values (category, authorised_value, lib, lib_opac, imageurl) values ('CCODE','9999cc','Light Purple','','colors/9999cc.png'); insert into authorised_values (category, authorised_value, lib, lib_opac, imageurl) values ('CCODE','660000' ,'Burgundy','','colors/660000.png'); insert into authorised_values (category, authorised_value, lib, lib_opac, imageurl) values ('CCODE','663333' ,'Brown','','colors/663333.png'); insert into authorised_values (category, authorised_value, lib, lib_opac, imageurl) values ('CCODE','990000' ,'Red','','colors/990000.png'); insert into authorised_values (category, authorised_value, lib, lib_opac, imageurl) values ('CCODE','996633' ,'Tan','','colors/996633.png'); insert into authorised_values (category, authorised_value, lib, lib_opac, imageurl) values ('CCODE','999999' ,'Gray','','colors/999999.png'); insert into authorised_values (category, authorised_value, lib, lib_opac, imageurl) values ('CCODE','cc66cc','Pink','','colors/cc66cc.png'); insert into authorised_values (category, authorised_value, lib, lib_opac, imageurl) values ('CCODE','cc99cc','Bubble Gum','','colors/cc99cc.png'); insert into authorised_values (category, authorised_value, lib, lib_opac, imageurl) values ('CCODE','cc3333' ,'Orange','','colors/cc3333.png'); insert into authorised_values (category, authorised_value, lib, lib_opac, imageurl) values ('CCODE','cc6666' ,'Peach','','colors/cc6666.png'); insert into authorised_values (category, authorised_value, lib, lib_opac, imageurl) values ('CCODE','cc9999' ,'Rose','','colors/cc9999.png'); insert into authorised_values (category, authorised_value, lib, lib_opac, imageurl) values ('CCODE','cccc00' ,'Gold','','colors/cccc00.png'); insert into authorised_values (category, authorised_value, lib, lib_opac, imageurl) values ('CCODE','ffff33' ,'Yellow','','colors/ffff33.png'); insert into authorised_values (category, authorised_value, lib, lib_opac, imageurl) values ('CCODE','ffffcc','Cream','','colors/ffffcc.png'); insert into authorised_values (category, authorised_value, lib, lib_opac, imageurl) values ('CCODE','ffffff','White','','colors/ffffff.png'); I'll add this tip to a blog post and to the manual once this set of icons has been pushed to Koha. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 15:14:40 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 13:14:40 +0000 Subject: [Koha-bugs] [Bug 3782] delivered z39.50 targets wrong for NY Public Library and NY University Library In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3782 --- Comment #8 from Nicole C. Engard --- +1 for removing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 15:19:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 13:19:35 +0000 Subject: [Koha-bugs] [Bug 3782] delivered z39.50 targets wrong for NY Public Library and NY University Library In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3782 --- Comment #9 from Jared Camins-Esakov --- NYPL is working fine as far as I can tell. Can someone else confirm? NYU's Z39.50 server changes every few weeks, so +1 on removing that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 15:23:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 13:23:10 +0000 Subject: [Koha-bugs] [Bug 8253] Fine doubling In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8253 --- Comment #12 from Julian Maurice --- I replayed my tests. Here's what I did: # empty the accounlines table mysql> delete from accountlines; # run fines script $ misc/cronjobs/fines.pl mysql> select * from accountlines\G *************************** 1. row *************************** borrowernumber: 58 accountno: 1 itemnumber: 2 date: 2012-08-06 amount: 112.000000 description: Orchid?es 06/01/2012 23:59 dispute: NULL accounttype: FU amountoutstanding: 112.000000 lastincrement: 112.000000 timestamp: 2012-08-06 14:46:45 notify_id: 0 notify_level: 0 note: NULL manager_id: NULL 1 row in set (0.00 sec) # simulate that fines script was run pre-3.8 mysql> update accountlines set description="Orchid?es 06/01/2012"; # re-run $ misc/cronjobs/fines.pl # lines are duplicated (OK) mysql> select * from accountlines\G *************************** 1. row *************************** borrowernumber: 58 accountno: 1 itemnumber: 2 date: 2012-08-06 amount: 112.000000 description: Orchid?es 06/01/2012 dispute: NULL accounttype: FU amountoutstanding: 112.000000 lastincrement: 112.000000 timestamp: 2012-08-06 15:01:49 notify_id: 0 notify_level: 0 note: NULL manager_id: NULL *************************** 2. row *************************** borrowernumber: 58 accountno: 2 itemnumber: 2 date: 2012-08-06 amount: 112.000000 description: Orchid?es 06/01/2012 23:59 dispute: NULL accounttype: FU amountoutstanding: 112.000000 lastincrement: 112.000000 timestamp: 2012-08-06 15:01:52 notify_id: 0 notify_level: 0 note: NULL manager_id: NULL 2 rows in set (0.00 sec) # run the update script $ perl installer/data/mysql/updatedatabase.pl # by the way, this warning is introduced by your patch: "my" variable $sth masks earlier declaration in same scope at installer/data/mysql/updatedatabase.pl line 5697. Upgrade to 3.09.00.XXX done (Fix fine descriptions and remove duplicate fines) # lines are still duplicated, but description has changed mysql> select * from accountlines\G *************************** 1. row *************************** borrowernumber: 58 accountno: 1 itemnumber: 2 date: 2012-08-06 amount: 112.000000 description: Orchid?es 06/01/2012 23:59 dispute: NULL accounttype: FU amountoutstanding: 112.000000 lastincrement: 112.000000 timestamp: 2012-08-06 15:02:25 notify_id: 0 notify_level: 0 note: NULL manager_id: NULL *************************** 2. row *************************** borrowernumber: 58 accountno: 2 itemnumber: 2 date: 2012-08-06 amount: 112.000000 description: Orchid?es 06/01/2012 23:59 dispute: NULL accounttype: FU amountoutstanding: 112.000000 lastincrement: 112.000000 timestamp: 2012-08-06 15:01:52 notify_id: 0 notify_level: 0 note: NULL manager_id: NULL 2 rows in set (0.00 sec) This is because, in the update process, you try to delete only lines that do not contain 23:59: $query = "SELECT * FROM accountlines WHERE description LIKE ? AND description NOT LIKE ?"; ... foreach my $keeper ( @$results ) { my ( $description_to_match ) = split( / 23:59/, $keeper->{'description'} ); $description_to_match .= '%'; $sth->execute( $description_to_match, $keeper->{'description'} ); while ( my $f = $sth->fetchrow_hashref() ) { ... my $sql = "DELETE FROM accountlines WHERE borrowernumber = ? AND accountno = ? AND itemnumber = ? AND date = ? AND description = ? LIMIT 1"; $dbh->do($sql,undef,$f->{'borrowernumber'},$f->{'accountno'},$f->{'itemnumber'}, $f->{'date'}, $f->{'description'}); } } -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 15:23:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 13:23:27 +0000 Subject: [Koha-bugs] [Bug 8419] Suspended holds appear on the daily holds queue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8419 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10771|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 11383 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11383&action=edit [SIGNED-OFF] Bug 8419 - Suspended holds appear on the daily holds queue Suspended holds are showing up in both the holds queue and holds to pull reports. This patch adds to the sql queries such that any hold that is suspended is not selected. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 15:25:59 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 13:25:59 +0000 Subject: [Koha-bugs] [Bug 8419] Suspended holds appear on the daily holds queue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8419 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #3 from Owen Leonard --- Before the patch, a title with a single hold, suspended, appeared in the holds queue report. After the patch that hold no longer appeared in the report. I added another hold on that same title, rebuilt the holds queue report, and the new hold appeared. The holds to pull report appears correct as well. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 15:35:32 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 13:35:32 +0000 Subject: [Koha-bugs] [Bug 8577] New: build_holds_queue.pl needs command-line options for help, verbosity, and summary Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8577 Priority: P5 - low Change sponsored?: --- Bug ID: 8577 Assignee: gmcharlt at gmail.com Summary: build_holds_queue.pl needs command-line options for help, verbosity, and summary Severity: normal Classification: Unclassified OS: All Reporter: oleonard at myacpl.org Hardware: All Status: NEW Version: master Component: Command-line Utilities Product: Koha As per FIXME from 2009: # FIXME: add command-line options for verbosity and summary # FIXME: expand perldoc, explain intended logic # FIXME: refactor all subroutines into C4 for testability It is not user-friendly to have a command-line script which doesn't accept a --help parameter. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 15:37:16 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 13:37:16 +0000 Subject: [Koha-bugs] [Bug 4064] Uninitialized variable errors in opac-search.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4064 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10572|0 |1 is obsolete| | --- Comment #2 from Julian Maurice --- Created attachment 11384 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11384&action=edit [SIGNED-OFF] Bug 4064 - Uninitialized variable errors in opac-search.pl Merely optimized two if statements, already fixed in master. Simple patch, makes code clearer. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 15:37:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 13:37:33 +0000 Subject: [Koha-bugs] [Bug 4064] Uninitialized variable errors in opac-search.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4064 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |julian.maurice at biblibre.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 15:42:55 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 13:42:55 +0000 Subject: [Koha-bugs] [Bug 8578] New: Borrowers Log should Log Actions Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8578 Priority: P5 - low Change sponsored?: --- Bug ID: 8578 Assignee: gmcharlt at gmail.com Summary: Borrowers Log should Log Actions Severity: enhancement Classification: Unclassified OS: All Reporter: nengard at gmail.com Hardware: All Status: NEW Version: master Component: Tools Product: Koha When the BorrowersLog is turned on all the log viewer (and database) show for updates is "UPDATE (executed w/ arg:nn)" with nn being the patrons borrower number. That's not terribly helpful - it would be nice to know what updates were made. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 15:43:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 13:43:21 +0000 Subject: [Koha-bugs] [Bug 8578] Borrowers Log should Log Actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8578 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=3470 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 15:43:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 13:43:21 +0000 Subject: [Koha-bugs] [Bug 3470] Track changes to borrower record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3470 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8578 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 15:45:03 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 13:45:03 +0000 Subject: [Koha-bugs] [Bug 3782] delivered z39.50 targets wrong for NY Public Library and NY University Library In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3782 --- Comment #10 from Owen Leonard --- NYPL times out for me. Even if it works some of the time, it doesn't make sense to include by default a resource which works inconsistently. Anyone have a recommended replacement? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 15:45:08 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 13:45:08 +0000 Subject: [Koha-bugs] [Bug 8391] Cannot view reading record through staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8391 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #6 from Jonathan Druart --- QA Comments: return undef or an empty string if the argument is empty or equal "0000-00-00" Marking as Passed QA see Bug 8532 (same modification for the routine output_pref). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 15:48:02 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 13:48:02 +0000 Subject: [Koha-bugs] [Bug 3782] delivered z39.50 targets wrong for NY Public Library and NY University Library In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3782 --- Comment #11 from Jared Camins-Esakov --- (In reply to comment #10) > NYPL times out for me. Even if it works some of the time, it doesn't make > sense to include by default a resource which works inconsistently. Anyone > have a recommended replacement? It would be nice to include some non-US targets. Perhaps BSZ-BW or DNB? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 15:49:26 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 13:49:26 +0000 Subject: [Koha-bugs] [Bug 5349] Moving an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11118|0 |1 is obsolete| | --- Comment #27 from Marc V?ron --- Created attachment 11385 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11385&action=edit [SIGNED-OFF] Bug 5349 follow-up: run transferorder.pl in a popup -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 15:50:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 13:50:21 +0000 Subject: [Koha-bugs] [Bug 5349] Moving an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 --- Comment #28 from Marc V?ron --- Created attachment 11386 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11386&action=edit [SIGNED-OFF] Bug 5349 follow-up: run transferorder.pl in a popup -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 15:50:50 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 13:50:50 +0000 Subject: [Koha-bugs] [Bug 4064] Uninitialized variable errors in opac-search.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4064 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Assignee|henridamien at koha-fr.org |mtompset at hotmail.com --- Comment #3 from Jonathan Druart --- QA Comments: Remove a muzzy comparison in opac-search.pl Passed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 15:50:55 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 13:50:55 +0000 Subject: [Koha-bugs] [Bug 4064] Uninitialized variable errors in opac-search.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4064 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 15:51:12 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 13:51:12 +0000 Subject: [Koha-bugs] [Bug 5349] Moving an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11385|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 15:53:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 13:53:28 +0000 Subject: [Koha-bugs] [Bug 8523] Authority hierarchies only support UNIMARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8523 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #2 from Fr?d?ric Demians --- I can't sign-off before the end of August. But I have 2 libraries using the authority hierarchy display with UNIMARC. So I really want to confirm that this patch doesn't imply any regression before it is pushed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 15:53:51 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 13:53:51 +0000 Subject: [Koha-bugs] [Bug 5349] Moving an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 --- Comment #29 from Marc V?ron --- Hmm, that was my first multi-patch sign-off, hope it is OK. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 16:06:00 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 14:06:00 +0000 Subject: [Koha-bugs] [Bug 8523] Authority hierarchies only support UNIMARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8523 --- Comment #3 from Jared Camins-Esakov --- (In reply to comment #2) > I can't sign-off before the end of August. But I have 2 libraries using the > authority hierarchy display with UNIMARC. So I really want to confirm that > this patch doesn't imply any regression before it is pushed. This was one of my major concerns when writing the code, and I believe there are not any. However, I had limited UNIMARC authority data to test with. If you would be willing to send me more examples of hierarchical UNIMARC authorities, I would love to test the code against those, and fix any problems I find. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 16:15:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 14:15:39 +0000 Subject: [Koha-bugs] [Bug 5349] Moving an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 16:18:16 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 14:18:16 +0000 Subject: [Koha-bugs] [Bug 8579] New: Need script for updating authority 001s Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8579 Priority: P5 - low Change sponsored?: --- Bug ID: 8579 Assignee: jcamins at cpbibliography.com Summary: Need script for updating authority 001s Severity: enhancement Classification: Unclassified OS: All Reporter: jcamins at cpbibliography.com Hardware: All Status: NEW Version: master Component: MARC Authority data support Product: Koha Because bulkmarcimport.pl does not correctly set the 001 field for authority records, libraries end up with authority files full of records with invalid 001 fields. There should be a script that can retroactively populate the 001 field with the authid. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 16:21:06 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 14:21:06 +0000 Subject: [Koha-bugs] [Bug 8440] Dates does not appear in suggestions management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8440 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|jonathan.druart at biblibre.co | |m | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 16:27:59 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 14:27:59 +0000 Subject: [Koha-bugs] [Bug 5787] Move OPACItemHolds system preference to the Circulation Matrix. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5787 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED CC| |julian.maurice at biblibre.com Resolution|--- |DUPLICATE --- Comment #7 from Julian Maurice --- As it was merged with bug 5786, I think the appropriate status is RESOLVED - DUPLICATE *** This bug has been marked as a duplicate of bug 5786 *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 16:27:59 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 14:27:59 +0000 Subject: [Koha-bugs] [Bug 5786] Move AllowOnShelfHolds system preference to the Circulation Matrix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5786 --- Comment #48 from Julian Maurice --- *** Bug 5787 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 16:28:01 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 14:28:01 +0000 Subject: [Koha-bugs] [Bug 5609] Holds Rewrite In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5609 Bug 5609 depends on bug 5787, which changed state. Bug 5787 Summary: Move OPACItemHolds system preference to the Circulation Matrix. http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5787 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 16:28:30 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 14:28:30 +0000 Subject: [Koha-bugs] [Bug 5788] Move ReservesMaxPickupDelay system preference to the Circulation Matrix. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5788 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED CC| |julian.maurice at biblibre.com Resolution|--- |DUPLICATE --- Comment #35 from Julian Maurice --- As it was merged with bug 5786, I think the appropriate status is RESOLVED - DUPLICATE *** This bug has been marked as a duplicate of bug 5786 *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 16:28:30 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 14:28:30 +0000 Subject: [Koha-bugs] [Bug 5786] Move AllowOnShelfHolds system preference to the Circulation Matrix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5786 --- Comment #49 from Julian Maurice --- *** Bug 5788 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 16:28:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 14:28:33 +0000 Subject: [Koha-bugs] [Bug 5609] Holds Rewrite In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5609 Bug 5609 depends on bug 5788, which changed state. Bug 5788 Summary: Move ReservesMaxPickupDelay system preference to the Circulation Matrix. http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5788 What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 16:38:02 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 14:38:02 +0000 Subject: [Koha-bugs] [Bug 8576] Software error on authority edition when using merge In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8576 --- Comment #1 from Fridolyn SOMERS --- To reproduce the bug, use a used authority, in order to perform the merge. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 16:45:00 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 14:45:00 +0000 Subject: [Koha-bugs] [Bug 8032] sort lists by call number In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8032 JA changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pussman at gmail.com --- Comment #1 from JA --- Hi. It would be very helpfull if we could sort by "Date added". Another great feature it would be the "Export to CSV" option to the Lists. Thanks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 16:50:13 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 14:50:13 +0000 Subject: [Koha-bugs] [Bug 7963] Parallel HTTP requests when checking URLs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7963 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #11 from Jonathan Druart --- QA Comments (before Sign-off): 1/ Why don't you remove the old script? (check-url.pl) 2/ Please replace +use 5.010; +use strict; +use warnings; with use Modern::Perl; 3/ It seems in Koha, the scripts have an extension. Please add the .pl 4/ It would be great to pass an argument (or syspref :-/) to the script containing a list of field to check ? In UNIMARC, we can have 316$u, 317$u, 464$u, etc. with urls. 5/ For a new script it is very nice to submit the patch after a perltidy ;) 1, 3 and 5 are mandatory to pass QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 16:52:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 14:52:11 +0000 Subject: [Koha-bugs] [Bug 7187] Prioritize cover image sources such as Amazon, Google and add fail over i.e. if first source fails, go to next In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7187 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #4 from Tom?s Cohen Arazi --- I propose the addition of two new sysprefs for this task: a) Choose a default cover location (Local, Google, Amazon, etc) (combo with fixed values) b) Choose whether to traverse the list of services looking for the cover (starting from the default) or 'just use the default' (YesNo syspref. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 16:54:01 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 14:54:01 +0000 Subject: [Koha-bugs] [Bug 8576] Software error on authority edition when using merge In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8576 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt at gmail.com |fridolyn.somers at biblibre.co | |m --- Comment #2 from Fridolyn SOMERS --- Created attachment 11387 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11387&action=edit Proposed patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 16:54:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 14:54:27 +0000 Subject: [Koha-bugs] [Bug 7187] Prioritize cover image sources such as Amazon, Google and add fail over i.e. if first source fails, go to next In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7187 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 17:01:36 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 15:01:36 +0000 Subject: [Koha-bugs] [Bug 4222] Nonpublic note not appearing in the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4222 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #41 from Kyle M Hall --- Can someone provide a test plan for this? I created a magazine with a nonpublic note. Then I applied the patch and ran updatedatabase. I then rebuilt my zebra index, and ran touch_all_items and touch_all_biblios. The new nonpublicnote is still null. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 17:02:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 15:02:37 +0000 Subject: [Koha-bugs] [Bug 8350] $search = '0' or 0 will fail to affect SQL statement correctly in C4::Breeding In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8350 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #3 from Julian Maurice --- Patch looks ok, but I'm not able to reproduce a bug. git grep tells me that the unique place where BreedingSearch is used is cataloguing/addbooks.pl. In cataloguing/addbooks.pl, if I search '0' or 0, BreedingSearch is not called, because of "if($query)" in script. If you want to allow searching for string '0', I think you should modify addbooks.pl as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 17:10:46 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 15:10:46 +0000 Subject: [Koha-bugs] [Bug 7986] Export issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7986 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11002|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart --- Created attachment 11388 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11388&action=edit Bug 7986: Export issues for patron Rebased patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 17:11:26 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 15:11:26 +0000 Subject: [Koha-bugs] [Bug 7986] Export issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7986 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 17:20:02 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 15:20:02 +0000 Subject: [Koha-bugs] [Bug 8576] Software error on authority edition when using merge In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8576 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 17:21:12 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 15:21:12 +0000 Subject: [Koha-bugs] [Bug 7417] Include alternate forms from authorities in bibliographic searches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7417 --- Comment #19 from Jonathan Druart --- (In reply to comment #17 and comment #13) > My experience with Moose and CGI is that it's kind of slow. This seems like > a huge problem on something as core as authority and bibliographic record > objects. Also, after I tried to get the solr code working on my system Moose > no longer functions. Choosing between core functionality (with a version of > Moose that installs) and Solr (with a complex install procedure that will > presumably leave Moose not working elsewhere) seems like a bad choice. Yes, it is a debian packages problem. Not easy to solve :-/ It for what I speak about Moo (a minimalist Moose, light-weight, less dependencies, etc.) In all cases it is a decision to have after a global discussion. > It's easy to do a follow up to change the name. If you tell me what you'd > like it called, I will do a follow-up that changes the name. I think it > should probably be Koha::DataObject::Authority, based on the RFC, but I > decided to just call it "Koha::Authority" until I had a second opinion. It seems this modification will be removing all ambiguity. > > For new files, I think a best practice is to use "use Modern::Perl" instead > > of "use strict; use warnings;" > > But nothing is written on the wiki. You are free to keep these lines. > I'm not attached to them. :) Great, no discussion :) > > Before introducing new important classes (as Authority) in the Koha > > namespace, I think it is important to start a global discussion. What do we > > want for this new namespace and for this rewriting ? > I think we want it to work, and provide much-needed features. Hum yes, but it is not precise. I didn't wait an exact answer :) (for now...) > I don't think I see the benefit here. Don't get me wrong, I really like the > idea of Moose, but the speed issue, and the errors every time I try to load > it, make me think that we're better off using Class::Accessor, which we > already use elsewhere in Koha to great success. If we have 2 modules to change when we will be choosing, it would be easy. If we have 15 modules using Moose, Class:Accessor and whatever, we will reproduce a new C4 shambles :-/ For me, this patch can passed QA if the module are moved (Koha::Authority => Koha::DataObject::Authority). But I think using Class::Accessor is not what we want. We should (re)rewrite modules using it. I hope you understand my goal is not to be annoy you or to waste your time ! ;-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 17:31:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 15:31:14 +0000 Subject: [Koha-bugs] [Bug 7417] Include alternate forms from authorities in bibliographic searches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7417 --- Comment #20 from Chris Cormack --- (In reply to comment #19) > > But I think using Class::Accessor is not what we want. We should (re)rewrite > modules using it. > I disagree, I think we should rewrite modules using Moose. But mostly, I don't care, working code that is clean and passes tests is much more important, so far the code in Koha:: using Class::Accessor does this, the code using Moose ..... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 17:39:40 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 15:39:40 +0000 Subject: [Koha-bugs] [Bug 7417] Include alternate forms from authorities in bibliographic searches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7417 --- Comment #21 from Chris Cormack --- (In reply to comment #20) > (In reply to comment #19) > > > > > But I think using Class::Accessor is not what we want. We should (re)rewrite > > modules using it. > > > I disagree, I think we should rewrite modules using Moose. But mostly, I > don't care, working code that is clean and passes tests is much more > important, so far the code in Koha:: using Class::Accessor does this, the > code using Moose ..... Heh I realise now this isn't clear, I mean we shouldn't rewrite any modules, but if were to rewrite some. I would pick the ones already written in Moose as good candidates for a rewrite as those are the ones that are causing problems. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 17:51:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 15:51:21 +0000 Subject: [Koha-bugs] [Bug 7417] Include alternate forms from authorities in bibliographic searches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7417 --- Comment #22 from Chris Cormack --- If we were to rewrite anything, I agree Moo (at first glance) looks like an OK candidate. http://search.cpan.org/~mstrout/Moo-1.000002/lib/Moo.pm However it is not in Debian squeeze yet, so for 3.10 I think we should wait. http://packages.debian.org/search?keywords=libmoo-perl It is going to be in wheezy. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 18:56:20 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 16:56:20 +0000 Subject: [Koha-bugs] [Bug 8580] New: transfer slip doesn't have transfers or items table Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8580 Priority: P5 - low Change sponsored?: --- Bug ID: 8580 Assignee: koha-bugs at lists.koha-community.org Summary: transfer slip doesn't have transfers or items table Severity: normal Classification: Unclassified OS: All Reporter: nengard at gmail.com Hardware: All Status: NEW Version: master Component: Notices Product: Koha When working on the transfers slip there isn't access to the transfers table. If you want to show From and To branches you have to use branches.branchcode for From and items.holdingbranch for To - but tobranch and frombranch are in the transfers table. Along those lines I know you can use items.holdingbranch cause I tested it, but it's not an option in the tables on the left so a regular user wouldn't know this. I think the transfers and items tables should be accessible (aka visible) on the left of the transfer slip. Nicole -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 19:09:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 17:09:24 +0000 Subject: [Koha-bugs] [Bug 7634] Permanent Location (shelving location) is NULL when Import MARC records tool is used In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7634 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=6034 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 19:09:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 17:09:24 +0000 Subject: [Koha-bugs] [Bug 6034] Shelving cart feature can wipe permanent shelving location in certain circumstances In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6034 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7634 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 19:10:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 17:10:27 +0000 Subject: [Koha-bugs] [Bug 7417] Include alternate forms from authorities in bibliographic searches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7417 --- Comment #23 from Jared Camins-Esakov --- (In reply to comment #22) > If we were to rewrite anything, I agree Moo (at first glance) looks like an > OK candidate. > > http://search.cpan.org/~mstrout/Moo-1.000002/lib/Moo.pm > > However it is not in Debian squeeze yet, so for 3.10 I think we should wait. > http://packages.debian.org/search?keywords=libmoo-perl > > It is going to be in wheezy. I don't know, I think Moo is a good candidate for packaging ourselves, and using that instead of Moose for Solr, etc. It would be easy enough to do the packaging. I just tried it, and unlike when I tried to get Moose to compile, it worked without any major hitches. I did some performance comparisons on Moo and Moose (and Class::Accessor). Here is my test script: #!/usr/bin/perl use [Moo|Moose|Class::Accessor]; print "Hi\n"; When running under NYTProf, I got the following results: Moo: Profile of test.pl for 140ms, executing 2273 statements and 823 subroutine calls in 36 source files and 7 string evals. Moose: Profile of test.pl for 3.34s, executing 112435 statements and 51928 subroutine calls in 112 source files and 153 string evals. Class::Accessor: Profile of test.pl for 42.5ms, executing 525 statements and 106 subroutine calls in 15 source files and 2 string evals. Class::Accessor is clearly way less overhead, and given how basic authority (and bibliographic) records are to Koha, I think that would be a powerful argument in favor of using it. However, Moo is only one order of magnitude slower to load, which I think probably isn't too bad. Moose, of course, is two orders of magnitude more expensive, making simply loading the file take an unacceptably long time. Since we don't support mod_perl, I think it is critical that we maintain CGI-compatibility for Koha. Setting up Plack is much more involved than pointing Apache at the appropriate directory and telling it to use CGI or mod_perl. All of which is a bit of a tangent. I would have no objection to rewriting Koha::Authority and the RecordProcessor stuff to use Moo, if there is a clear reason why it is better than using Class::Accessor. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 19:20:23 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 17:20:23 +0000 Subject: [Koha-bugs] [Bug 4906] Problem with grace period calculation and fine intervals >1 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4906 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Assignee|katrin.fischer at bsz-bw.de |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 19:26:22 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 17:26:22 +0000 Subject: [Koha-bugs] [Bug 8337] System preferences for longoverdue cron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8337 Maxime Pelletier changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10569|0 |1 is obsolete| | --- Comment #3 from Maxime Pelletier --- Created attachment 11389 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11389&action=edit new patch without our po -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 19:49:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 17:49:11 +0000 Subject: [Koha-bugs] [Bug 8581] New: Authority display doesn't like GND records Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8581 Priority: P5 - low Change sponsored?: --- Bug ID: 8581 CC: katrin.fischer at bsz-bw.de Assignee: jcamins at cpbibliography.com Summary: Authority display doesn't like GND records Severity: normal Classification: Unclassified OS: All Reporter: jcamins at cpbibliography.com Hardware: All Status: NEW Version: master Component: MARC Authority data support Product: Koha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 19:51:05 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 17:51:05 +0000 Subject: [Koha-bugs] [Bug 8581] Authority display doesn't like GND records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8581 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |3462 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 19:51:05 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 17:51:05 +0000 Subject: [Koha-bugs] [Bug 3462] Link see alsos in authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3462 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8581 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 19:54:16 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 17:54:16 +0000 Subject: [Koha-bugs] [Bug 3462] Link see alsos in authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3462 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11256|0 |1 is obsolete| | --- Comment #13 from Jared Camins-Esakov --- Created attachment 11390 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11390&action=edit Bug 3462: Links in authorities should be hyperlinks Make see also links in both the OPAC and authority module search results into hyperlinks and not just textual strings. To test: 1. Do a search for an authority that will bring up a heading with a see also reference in the staff client and the OPAC. 2. Confirm that the see also references listed in the search results are now hyperlinks, which work. Also quiets an unnecessary warning about an uninitialized value. Signed-off-by: Jared Camins-Esakov Rebased 26 July 2012 Signed-off-by: Jared Camins-Esakov Rebased on master 1 August 2012 Signed-off-by: Jared Camins-Esakov Rebased on master 6 August 2012 Signed-off-by: Katrin Fischer Patch works nicely and is a great improvement. Tests: - Checked links for existing and non existing "see alsos" give correct search results - Verified links show up for all "see alsos" in a result list - Verified links are properly linked with the correct names - Checked logs don't show errors -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 20:03:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 18:03:33 +0000 Subject: [Koha-bugs] [Bug 8581] Authority display doesn't like GND records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8581 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 20:03:34 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 18:03:34 +0000 Subject: [Koha-bugs] [Bug 8581] Authority display doesn't like GND records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8581 --- Comment #1 from Jared Camins-Esakov --- Created attachment 11391 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11391&action=edit Bug 8581: don't display parentheses when we don't have a type Prior to this patch, see also references in certain authority records (most notably GND records) were being followed by empty parentheses in the search results display. This patch resolves that problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 20:16:00 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 18:16:00 +0000 Subject: [Koha-bugs] [Bug 4906] Problem with grace period calculation and fine intervals >1 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4906 --- Comment #2 from Katrin Fischer --- Hi Kyle, is there a reason you removed me as assignee from this bug? I know it's an old bug - but I have some code that would have worked before hourly loans an I hoped to look into this again before end of August. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 20:20:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 18:20:11 +0000 Subject: [Koha-bugs] [Bug 8582] New: NULL issuedates with offline circ Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8582 Priority: P5 - low Change sponsored?: --- Bug ID: 8582 CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Assignee: koha-bugs at lists.koha-community.org Summary: NULL issuedates with offline circ Severity: enhancement Classification: Unclassified OS: All Reporter: melia at bywatersolutions.com Hardware: All Status: NEW Version: rel_3_8 Component: Circulation Product: Koha We don't think offline circ works quite right with 3.8. It may be a date vs. datetime problem, perhaps? After processing offline circ files in 3.8, we have seen some NULL issues.issuedate. We discovered these after seeing the following error occur when going to the check-out screen. Software error: Can't call method "strftime" on an undefined value at /home/koha/kohaclone/Koha/DateUtils.pm line 117 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 21:20:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 19:20:21 +0000 Subject: [Koha-bugs] [Bug 7963] Parallel HTTP requests when checking URLs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7963 --- Comment #12 from Fr?d?ric Demians --- > 1/ Why don't you remove the old script? (check-url.pl) To avoid any regression to any library using the old script in a way I can't figure out. Maybe later? > 3/ It seems in Koha, the scripts have an extension. Please add the .pl I don't like this rule but I can follow it... > 4/ It would be great to pass an argument (or syspref :-/) to the script > containing a list of field to check ? In UNIMARC, we can have 316$u, 317$u, > 464$u, etc. with urls. Good suggestion. > 5/ For a new script it is very nice to submit the patch after a perltidy ;) Will send a new version in few weeks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 21:31:52 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 19:31:52 +0000 Subject: [Koha-bugs] [Bug 8392] Memberentry is not enforcing birthdate restrictions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8392 --- Comment #13 from Nicole C. Engard --- Manual updated -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 21:39:32 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 19:39:32 +0000 Subject: [Koha-bugs] [Bug 8583] New: Add a warning if a Z39.50 search is started from the "Edit biblio record" page Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8583 Priority: P5 - low Change sponsored?: --- Bug ID: 8583 CC: m.de.rooy at rijksmuseum.nl Assignee: gmcharlt at gmail.com Summary: Add a warning if a Z39.50 search is started from the "Edit biblio record" page Severity: enhancement Classification: Unclassified OS: All Reporter: fcapovilla at live.ca Hardware: All Status: NEW Version: rel_3_8 Component: Cataloging Product: Koha Created attachment 11392 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11392&action=edit Add a warning if a Z39.50 search is started from biblio edition page. If the "Z39.50 Search" is clicked when editing an existing biblio record, the current record will be overwritten by the imported Z39.50 record. This patch simply adds a warning when the button is clicked so the user is aware that doing a Z39.50 import from the edition page will overwrite the current record. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 21:40:05 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 19:40:05 +0000 Subject: [Koha-bugs] [Bug 8583] Add a warning if a Z39.50 search is started from the "Edit biblio record" page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8583 Fr?d?rick Capovilla changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Change sponsored?|--- |Sponsored Assignee|gmcharlt at gmail.com |fcapovilla at live.ca --- Comment #1 from Fr?d?rick Capovilla --- Patch sponsored by the CCSR ( http://www.ccsr.qc.ca ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 22:42:38 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 20:42:38 +0000 Subject: [Koha-bugs] [Bug 8532] Old/iffy data causes error checking out In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8532 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz QA Contact| |m.de.rooy at rijksmuseum.nl --- Comment #5 from Chris Cormack --- Marcel if you could QA this, that would be fantastic! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 22:46:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 20:46:28 +0000 Subject: [Koha-bugs] [Bug 7417] Include alternate forms from authorities in bibliographic searches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7417 --- Comment #24 from Jared Camins-Esakov --- Created attachment 11393 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11393&action=edit Bug 7417 follow-up: incorporate QA comments This patch incorporates the two QA comments: * Renames Koha::Authority to Koha::DataObject::Authority * Uses Modern::Perl instead of 'use strict; use warnings;' This patch also improves test coverage, and eliminates the need for a database to test the EmbedSeeFromHeadings RecordProcessor plugin. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 22:51:16 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 20:51:16 +0000 Subject: [Koha-bugs] [Bug 8391] Cannot view reading record through staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8391 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #7 from Chris Cormack --- Pushed to 3.8.x, will be in 3.8.4, leaving set to Passed QA so Paul can push to master when he is back -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 22:56:38 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 20:56:38 +0000 Subject: [Koha-bugs] [Bug 8251] Patrons are systematically debarred at checkin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8251 --- Comment #35 from Chris Cormack --- Second patch (follow up) pushed to 3.8.x, will be in 3.8.4 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 23:05:59 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 21:05:59 +0000 Subject: [Koha-bugs] [Bug 8584] New: Improve cleanup_database.pl to only purge emails older than X days. Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8584 Priority: P5 - low Change sponsored?: --- Bug ID: 8584 Assignee: gmcharlt at gmail.com Summary: Improve cleanup_database.pl to only purge emails older than X days. Severity: enhancement Classification: Unclassified OS: All Reporter: fcapovilla at live.ca Hardware: All Status: NEW Version: rel_3_8 Component: Command-line Utilities Product: Koha Created attachment 11394 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11394&action=edit cleanup_database.pl : Add a DAYS parameter for email purges. The cleanup_database.pl script doesn't give the option to only delete emails older than X days. This feature is important for libraries that want to keep a short history of notifications sent to users (on the members/notices.pl page). Patch attached. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 23:06:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 21:06:28 +0000 Subject: [Koha-bugs] [Bug 8584] Improve cleanup_database.pl to only purge emails older than X days. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8584 Fr?d?rick Capovilla changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Change sponsored?|--- |Sponsored Assignee|gmcharlt at gmail.com |fcapovilla at live.ca --- Comment #1 from Fr?d?rick Capovilla --- Patch sponsored by the CCSR ( http://www.ccsr.qc.ca ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 23:29:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 21:29:41 +0000 Subject: [Koha-bugs] [Bug 8581] Authority display doesn't like GND records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8581 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11391|0 |1 is obsolete| | --- Comment #2 from Chris Cormack --- Created attachment 11395 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11395&action=edit Bug 8581: don't display parentheses when we don't have a type Prior to this patch, see also references in certain authority records (most notably GND records) were being followed by empty parentheses in the search results display. This patch resolves that problem. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 6 23:29:51 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Aug 2012 21:29:51 +0000 Subject: [Koha-bugs] [Bug 8581] Authority display doesn't like GND records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8581 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 7 05:54:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Aug 2012 03:54:14 +0000 Subject: [Koha-bugs] [Bug 8522] Markup errors cause problems with customized CSS In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8522 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11199|0 |1 is obsolete| | --- Comment #3 from Chris Cormack --- Created attachment 11396 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11396&action=edit Bug 8522 - Markup errors cause problems with customized CSS Some includes and templates contained duplicate "header" ids in the markup. The problem should have come up in routine page validation, but was obvious when custom CSS was applied. To test, load any of the affected pages and validate the generated HTML. There should be no errors about 'ID "header" already defined." Or, add custom CSS to intranetusercss: ...and confirm that only the topmost menu background is affected. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 7 05:54:36 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Aug 2012 03:54:36 +0000 Subject: [Koha-bugs] [Bug 8522] Markup errors cause problems with customized CSS In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8522 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 7 05:57:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Aug 2012 03:57:35 +0000 Subject: [Koha-bugs] [Bug 8413] Space in barcode breaks GET request in benchmark_staff.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8413 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10765|0 |1 is obsolete| | --- Comment #5 from Chris Cormack --- Created attachment 11397 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11397&action=edit Bug 8413 Space in barcodes breaks GET request in benchmark_staff.pl GET requests in benchmark_staff.pl test 6 do not work if a space character is part of the barcode. That seems highly unlikely to happen in barcodes, but is possible if no real barcodes are used but a substitute, like a copy of the call number. Space character needs to be changed to %20 for the request to work. Also fixes a typo. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 7 05:57:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Aug 2012 03:57:49 +0000 Subject: [Koha-bugs] [Bug 8413] Space in barcode breaks GET request in benchmark_staff.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8413 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 7 06:11:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Aug 2012 04:11:47 +0000 Subject: [Koha-bugs] [Bug 7500] Use CSS Sprites for faster page loading In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7500 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9599|0 |1 is obsolete| | --- Comment #25 from Chris Cormack --- Created attachment 11398 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11398&action=edit Bug 7500 [FOLLOW-UP][Star ratings] Use CSS Sprites for faster page loading Combines two star ratings sprites into one and makes the corresponding CSS changes. The two original images have been removed. To test, view star ratings on search results and the detail page. Try setting star ratings on the detail page. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 7 06:14:06 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Aug 2012 04:14:06 +0000 Subject: [Koha-bugs] [Bug 7500] Use CSS Sprites for faster page loading In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7500 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9623|0 |1 is obsolete| | --- Comment #26 from Chris Cormack --- Created attachment 11399 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11399&action=edit Bug 7500 [FOLLOW-UP][Missing images] Use CSS Sprites for faster page loading - Adds shelf browser navigational arrows to the main sprite. - Removes "caret.gif" (a sort of breadcrumbs separator in the OPAC) and replaces it with a similar Unicode arrow entity. - Replaces item-bullet.gif (a custom list bullet used in the Cart) with data URI encoding the image in the CSS Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 7 06:14:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Aug 2012 04:14:35 +0000 Subject: [Koha-bugs] [Bug 7500] Use CSS Sprites for faster page loading In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7500 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 7 06:19:44 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Aug 2012 04:19:44 +0000 Subject: [Koha-bugs] [Bug 8089] Use Koha::Cache everywhere In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8089 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10166|0 |1 is obsolete| | --- Comment #11 from Chris Cormack --- Created attachment 11400 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11400&action=edit Bug 8089: Use Koha::Cache for all caching 1. Replace all instances of memoize_memcached with appropriate calls into Koha::Cache: * reports/guided_reports.pl * C4::Biblio::GetMarcStructure * C4::Languages::getFrameworkLanguages * C4::Languages::getAllLanguages * C4::SQLHelper::GetPrimaryKeys * C4::SQLHelper::_get_columns 2. Replace all references to memcached with the appropriate calls into Koha::Cache in C4::Context. Test plan : * have DEBUG env set to 1 * reach addbiblio page to test the patch in Biblio.pm, or setup more than 1 language * you should see in the logs that you're reading and writing from cache * run the test suite twice both with and without the following environment variables set: export MEMCACHED_SERVERS=127.0.0.1:11211 export MEMCACHED_NAMESPACE=KOHA export CACHING_SYSTEM=memcached Signed-off-by: Chris Cormack I'm unsure about some of the caching times 10000 is a long long time, but other than that, works fine. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 7 06:20:34 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Aug 2012 04:20:34 +0000 Subject: [Koha-bugs] [Bug 8089] Use Koha::Cache everywhere In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8089 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10167|0 |1 is obsolete| | --- Comment #12 from Chris Cormack --- Created attachment 11401 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11401&action=edit Bug 8089: Cache sysprefs using Koha::Cache Cache sysprefs using Koha::Cache in a way that is safe even for caching-related sysprefs. This lays the groundwork for removing caching configuration from the httpd.conf and configuring it using sysprefs. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 7 06:21:17 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Aug 2012 04:21:17 +0000 Subject: [Koha-bugs] [Bug 8089] Use Koha::Cache everywhere In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8089 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10168|0 |1 is obsolete| | --- Comment #13 from Chris Cormack --- Created attachment 11402 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11402&action=edit Bug 8089: Correct cache timeout to 1000 There was a typo in the original patch for bug 8089 which set the cache timeout on getAllLanguages to 10000. Correct it to 1000. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 7 06:21:46 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Aug 2012 04:21:46 +0000 Subject: [Koha-bugs] [Bug 8089] Use Koha::Cache everywhere In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8089 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 7 07:46:36 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Aug 2012 05:46:36 +0000 Subject: [Koha-bugs] [Bug 8585] New: Add System Preference to specify Holds to Pull List Start Date Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8585 Priority: P5 - low Change sponsored?: --- Bug ID: 8585 CC: gmcharlt at gmail.com Assignee: koha-bugs at lists.koha-community.org Summary: Add System Preference to specify Holds to Pull List Start Date Severity: enhancement Classification: Unclassified OS: All Reporter: dcook at prosentient.com.au Hardware: All Status: NEW Version: master Component: Hold requests Product: Koha When you are on the "Holds to Pull" page in the Circulation module, the default "Start Date" in the "Refine Results" section is 2 days in the past. I plan to introduce a system preference that changes the number of days to however many the librarian chooses. If the system preference isn't set, the default of 2 days will continue to be used. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 7 09:19:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Aug 2012 07:19:41 +0000 Subject: [Koha-bugs] [Bug 7963] Parallel HTTP requests when checking URLs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7963 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10238|0 |1 is obsolete| | Attachment #10239|0 |1 is obsolete| | --- Comment #13 from Fr?d?ric Demians --- Created attachment 11403 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11403&action=edit Proposed patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 7 09:38:30 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Aug 2012 07:38:30 +0000 Subject: [Koha-bugs] [Bug 8576] Software error on authority edition when using merge In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8576 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11387|0 |1 is obsolete| | --- Comment #3 from Chris Cormack --- Created attachment 11404 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11404&action=edit Bug 8576: Software error on authority edition when using merge Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 7 09:38:53 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Aug 2012 07:38:53 +0000 Subject: [Koha-bugs] [Bug 8576] Software error on authority edition when using merge In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8576 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 7 10:00:59 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Aug 2012 08:00:59 +0000 Subject: [Koha-bugs] [Bug 7986] Export issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7986 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |chris at bigballofwax.co.nz --- Comment #13 from Chris Cormack --- The good news is no regressions, the bad news is, the checkboxes to select items are not showing, so I cant test that you can export from circulation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 7 10:06:50 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Aug 2012 08:06:50 +0000 Subject: [Koha-bugs] [Bug 7986] Export issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7986 --- Comment #14 from Chris Cormack --- Ah ha The checkboxes are only there for the previssues loop, but they dont show for items issued today (in the todayissues loop) Do you want to fix or I can do a follow up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 7 10:21:42 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Aug 2012 08:21:42 +0000 Subject: [Koha-bugs] [Bug 7963] Parallel HTTP requests when checking URLs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7963 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11403|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart --- Created attachment 11405 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11405&action=edit Bug 7963 Parallel HTTP requests when checking URLs Current script check-url.pl checks URL found in 856$u by sending HTTP requests, one by one. The next request can't be sent before the previous one get a result, which can be very slow for dead URL. I propose a new script which send multiple requests simultaneously which improve drastically URL checking execution time. This script is based on AnyEvent and AnyEvent::HTTP CPAN modules. Add new dependencies AnyEvent & AnyEvent::HTTP. See doc: perldoc check-url-quick.pl Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 7 10:21:59 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Aug 2012 08:21:59 +0000 Subject: [Koha-bugs] [Bug 7963] Parallel HTTP requests when checking URLs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7963 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 7 10:28:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Aug 2012 08:28:11 +0000 Subject: [Koha-bugs] [Bug 8575] Number of items expected is wrong In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8575 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11380|0 |1 is obsolete| | --- Comment #2 from Chris Cormack --- Created attachment 11406 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11406&action=edit Bug 8575: Expected items count should not include cancelled orders To test: 1/ create a new basket with 2 orders, one with 1 item, another with 2 items 2/ look at booksellers.pl page, you should see that 3 items are expected 3/ cancel the order with 1 item 4/ refresh booksellers.pl page, it should remains 2 expected items Signed-off-by: Chris Cormack Works exactly as designed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 7 10:28:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Aug 2012 08:28:49 +0000 Subject: [Koha-bugs] [Bug 8575] Number of items expected is wrong In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8575 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 7 10:37:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Aug 2012 08:37:37 +0000 Subject: [Koha-bugs] [Bug 7963] Parallel HTTP requests when checking URLs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7963 --- Comment #15 from Jonathan Druart --- Hi Fr?d?ric, Thank you for submitting this patch such fast :) It works very well in all my tests. Just somes little remarks: - POD is not up to date (--tags in summary, -h is not supported, "Scan all URLs found in 856$u" or in others tags :)) - Perhaps a modification in the other script is necessary (to indicate that an other one is available). - I think the following lines my %h = map { $_ => undef } @tags; @tags = sort keys %h; could be replaced with: @tags = sort @tags; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 7 10:44:46 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Aug 2012 08:44:46 +0000 Subject: [Koha-bugs] [Bug 7986] Export issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7986 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11388|0 |1 is obsolete| | --- Comment #15 from Jonathan Druart --- Created attachment 11407 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11407&action=edit Bug 7986: Followup: FIX display checkboxes for the today checkouts Hi Chris, Good catch ! :) This followup should solve the issue. Thanks for testing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 7 10:44:55 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Aug 2012 08:44:55 +0000 Subject: [Koha-bugs] [Bug 7986] Export issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7986 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 7 10:49:23 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Aug 2012 08:49:23 +0000 Subject: [Koha-bugs] [Bug 7986] Export issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7986 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11388|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 7 11:02:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Aug 2012 09:02:14 +0000 Subject: [Koha-bugs] [Bug 7986] Export issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7986 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11388|0 |1 is obsolete| | --- Comment #16 from Chris Cormack --- Created attachment 11408 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11408&action=edit Bug 7986: Export issues for patron In the circulation page, you can now export (as csv or iso2709) a list of items which are currently checked out by a borrower. 3 export types: - iso2709 with items: Export the items list in iso2709 format with item informations. - iso2709 without items: Export the items list in iso2709 format without item informations. - CSV: Export the items list based on a csv profil. 2 new system preferences: - DontExportFields: a list of fields not to be export - CsvProfileForExport: The Csv profile name used for the csv export Test plan: - Fill the CsvProfileForExport syspref - go on the borrower circulation page containing checkouts - Select one or more items and export them to the 3 different formats. - check if the result file is what you expected - Test there is no regression with the export authority - Test there is no regression using tools/export.pl with the command line interface Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 7 11:02:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Aug 2012 09:02:29 +0000 Subject: [Koha-bugs] [Bug 7986] Export issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7986 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11407|0 |1 is obsolete| | --- Comment #17 from Chris Cormack --- Created attachment 11409 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11409&action=edit Bug 7986: Followup: FIX display checkboxes for the today checkouts Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 7 11:03:59 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Aug 2012 09:03:59 +0000 Subject: [Koha-bugs] [Bug 7986] Export issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7986 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 7 11:44:38 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Aug 2012 09:44:38 +0000 Subject: [Koha-bugs] [Bug 7417] Include alternate forms from authorities in bibliographic searches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7417 --- Comment #25 from Jonathan Druart --- (In reply to comment #23) > I don't know, I think Moo is a good candidate for packaging ourselves, and > using that instead of Moose for Solr, etc. It would be easy enough to do the > packaging. I just tried it, and unlike when I tried to get Moose to compile, > it worked without any major hitches. We can rewrite Koha::SearchEngine::Solr with Moo. But this module use a Data::SearchEngine::Solr module which use Moose :-/ Then we have to rewrite this external library too to drop the Moose dependency. > All of which is a bit of a tangent. I would have no objection to rewriting > Koha::Authority and the RecordProcessor stuff to use Moo, if there is a > clear reason why it is better than using Class::Accessor. I never used Moo and just used Moose for the Koha::SearchEngine::Solr. But I heard many good about it and it seems it is widely used now by Perl programmers communities. I am not attached or a fervent defender of any of them. However I'm convinced that Koha should have a powerfull and adapted object system. We want to write less code as possible then we have to choose a system with a minimum of code verbosity. In fact I think it will be difficult to have a consensus but all propositions must be considered in order to choose the most pertinent. My 1st comment there was not to troll or to impose my choices. I just gave my opinion about introducing a new auth class without rules However if each one of us keeps waiting for others not decision will be taken :-/ That is why I think that it would be worth having this discussion in a special topic in the koha-devel mailing list. Then everybody will participate and share about the subject, and then maybe we could reach a global consensus in agreement with the whole community (Maybe we should wait for the end of summer to launch such a discussion, as many people are currently on vacation :)). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 7 11:54:03 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Aug 2012 09:54:03 +0000 Subject: [Koha-bugs] [Bug 7417] Include alternate forms from authorities in bibliographic searches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7417 --- Comment #26 from Chris Cormack --- (In reply to comment #25) > (In reply to comment #23) > > I don't know, I think Moo is a good candidate for packaging ourselves, and > > using that instead of Moose for Solr, etc. It would be easy enough to do the > > packaging. I just tried it, and unlike when I tried to get Moose to compile, > > it worked without any major hitches. > > We can rewrite Koha::SearchEngine::Solr with Moo. But this module use a > Data::SearchEngine::Solr module which use Moose :-/ > Then we have to rewrite this external library too to drop the Moose > dependency. > > > All of which is a bit of a tangent. I would have no objection to rewriting > > Koha::Authority and the RecordProcessor stuff to use Moo, if there is a > > clear reason why it is better than using Class::Accessor. > > I never used Moo and just used Moose for the Koha::SearchEngine::Solr. But I > heard many good about it and it seems it is widely used now by Perl > programmers communities. > I am not attached or a fervent defender of any of them. However I'm > convinced that Koha should have a powerfull and adapted object system. > We want to write less code as possible then we have to choose a system with > a minimum of code verbosity. This isn't my goal, my goal is clean and tested code, verbosity has very little to do with that. Writing less code isn't inherently a good thing. So in order to have a consensus on how to achieve the goal, we need to have consensus on what that goal is. > In fact I think it will be difficult to have a consensus but all > propositions must be considered in order to choose the most pertinent. > > My 1st comment there was not to troll or to impose my choices. I just gave > my opinion about introducing a new auth class without rules > > However if each one of us keeps waiting for others not decision will be > taken :-/ > > That is why I think that it would be worth having this discussion in a > special topic in the koha-devel mailing list. > > Then everybody will participate and share about the subject, and then maybe > we could reach a global consensus in agreement with the whole community > (Maybe we should wait for the end of summer to launch such a discussion, as > many people are currently on vacation :)). End of summer isn't until april :) But seriously, if you mean the end of northern hemisphere summer, that is fine, but do we need to hold this patch until then? It is feature that a lot of people have been asking for, has close to 100% test coverage and works well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 7 11:59:20 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Aug 2012 09:59:20 +0000 Subject: [Koha-bugs] [Bug 7417] Include alternate forms from authorities in bibliographic searches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7417 --- Comment #27 from Katrin Fischer --- I am with Chris here, I don't think discussion should stop this from going in. It doesn't introduce any new dependency, we already have examples of both Moose and Class::Accessor in Koha... I don't see, why this should be held up. This is a much needed feature, that is programmed well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 7 12:19:19 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Aug 2012 10:19:19 +0000 Subject: [Koha-bugs] [Bug 6151] IndependantBranches and HomeOrHoldingBranchReturn can prevent items from being checked in In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6151 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11295|0 |1 is obsolete| | --- Comment #11 from Chris Cormack --- Created attachment 11410 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11410&action=edit Bug 6151 - Followup - Display message for failed returns on circulation.pl when returning via issues table. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 7 12:19:50 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Aug 2012 10:19:50 +0000 Subject: [Koha-bugs] [Bug 6151] IndependantBranches and HomeOrHoldingBranchReturn can prevent items from being checked in In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6151 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P3 Status|Needs Signoff |Signed Off Version|rel_3_4 |master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 7 12:31:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Aug 2012 10:31:57 +0000 Subject: [Koha-bugs] [Bug 8586] New: Small bug in die if no mapping in framework for biblioitems.biblioitemnumber Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8586 Priority: P5 - low Change sponsored?: --- Bug ID: 8586 CC: m.de.rooy at rijksmuseum.nl Assignee: gmcharlt at gmail.com Summary: Small bug in die if no mapping in framework for biblioitems.biblioitemnumber Severity: normal Classification: Unclassified OS: All Reporter: fridolyn.somers at biblibre.com Hardware: All Status: NEW Version: master Component: Cataloging Product: Koha If a framework does not have a biblio.biblionumber mapping, cataloguing dies saying : No biblionumber tag for framework "$frameworkcode". It is the same for biblioitems.biblioitemnumber. But the code uses the biblio tag var instead of biblioitem tag. This causes on cataloguing with this framework the message : Software error: Tag "0" is not a valid tag. at /home/koha/src/C4/Biblio.pm line 3138 Very small patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 7 12:36:08 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Aug 2012 10:36:08 +0000 Subject: [Koha-bugs] [Bug 8435] new permissions on subscriptions "superserials" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11377|0 |1 is obsolete| | --- Comment #4 from Chris Cormack --- Created attachment 11411 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11411&action=edit Bug 8435: If IndependantBranches is on, Serials can't be manage from others libraries In the serial module, we want to hide serials from others libraries. New permission 'superserials'. If a patron have this permission, he can override this restriction. Test plan: - Switch on the IndependantBranches syspref - Add the permission 'superserials' for a patron and test you can navigate and see all serials - Remove this permission and test you cannot manage/view subscriptions from others libraries Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 7 12:37:12 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Aug 2012 10:37:12 +0000 Subject: [Koha-bugs] [Bug 8435] new permissions on subscriptions "superserials" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |chris at bigballofwax.co.nz Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 7 12:40:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Aug 2012 10:40:25 +0000 Subject: [Koha-bugs] [Bug 7417] Include alternate forms from authorities in bibliographic searches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7417 --- Comment #28 from Jonathan Druart --- (In reply to comment #26) > End of summer isn't until april :) > > But seriously, if you mean the end of northern hemisphere summer, that is > fine, but do we need to hold this patch until then? > > It is feature that a lot of people have been asking for, has close to 100% > test coverage and works well. Yes, ~septembre, sorry. I never say I want to wait 2 months before adopting this patch. > For me, this patch can passed QA if the module are moved (Koha::Authority => Koha::DataObject::Authority). It's my quote ! :) I never failed QA this patch. Just launch a discussion. A new patch is proposed. It is a normal workflow. It's why I proposed to continue (or restart) this discusion elsewhere. I tried to do some efforts to be understood. Sorry if it is not the case. > Writing less code isn't inherently a good thing. Though the code of Koha should show you that not having a good design and having a lot of code dupplicated don't make it easy to maintain ;-) But it is not a high priority, you are right. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 7 14:20:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Aug 2012 12:20:58 +0000 Subject: [Koha-bugs] [Bug 7419] Add authority deduplication script In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7419 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11161|0 |1 is obsolete| | --- Comment #7 from Julian Maurice --- Created attachment 11412 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11412&action=edit Bug 7419: Move indexation subs in C4::Search Rebased on master. Add support for --skip-index option of rebuild_zebra.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 7 14:21:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Aug 2012 12:21:27 +0000 Subject: [Koha-bugs] [Bug 7419] Add authority deduplication script In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7419 --- Comment #8 from Julian Maurice --- Created attachment 11413 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11413&action=edit Bug 7419: New script dedup_authorities.pl Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 7 14:21:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Aug 2012 12:21:43 +0000 Subject: [Koha-bugs] [Bug 7419] Add authority deduplication script In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7419 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11162|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 7 14:23:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Aug 2012 12:23:39 +0000 Subject: [Koha-bugs] [Bug 6151] IndependantBranches and HomeOrHoldingBranchReturn can prevent items from being checked in In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6151 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #12 from Jonathan Druart --- My previous test still does not work. Maybe you should replace l.470 (circ/circulation.pl) with: $it->{'return_failed'} = $return_failed{$it->{'barcode'}}; the failedreturn param contains a barcode, not an itemnumber. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 7 14:58:52 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Aug 2012 12:58:52 +0000 Subject: [Koha-bugs] [Bug 8532] Old/iffy data causes error checking out In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8532 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #6 from M. de Rooy --- Tiny patch, handling passed undefs. Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 7 15:00:02 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Aug 2012 13:00:02 +0000 Subject: [Koha-bugs] [Bug 8586] Small bug in die if no mapping in framework for biblioitems.biblioitemnumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8586 --- Comment #1 from Fridolyn SOMERS --- Created attachment 11414 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11414&action=edit Proposed patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 7 15:01:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Aug 2012 13:01:11 +0000 Subject: [Koha-bugs] [Bug 7241] circulation action logs record biblionumber instead of item number In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7241 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9870|0 |1 is obsolete| | --- Comment #20 from Owen Leonard --- Created attachment 11415 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11415&action=edit [SIGNED-OFF] Bug 7241: fix for the CIRC logs -> itemnumber stored correctly Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 7 15:02:18 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Aug 2012 13:02:18 +0000 Subject: [Koha-bugs] [Bug 7241] circulation action logs record biblionumber instead of item number In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7241 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #21 from Owen Leonard --- After applying the patch entries in the action_logs tables for ISSUE and RETURN show the itemnumber instead of the biblionumber. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 7 15:02:42 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Aug 2012 13:02:42 +0000 Subject: [Koha-bugs] [Bug 7241] circulation action logs record biblionumber instead of item number In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7241 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P5 - low Version|unspecified |master Severity|minor |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 7 15:04:13 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Aug 2012 13:04:13 +0000 Subject: [Koha-bugs] [Bug 8586] Small bug in die if no mapping in framework for biblioitems.biblioitemnumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8586 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #2 from Fridolyn SOMERS --- Test plan : ----------- Create a new framework using default one. Delete subfield definition mapped on biblioitems.biblioitemnumber. Create a new record using this framework. Without patch => software error With patch => error message -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 7 15:09:30 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Aug 2012 13:09:30 +0000 Subject: [Koha-bugs] [Bug 7168] Search orders by basket group name In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7168 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Assignee|jonathan.druart at biblibre.co |julian.maurice at biblibre.com |m | --- Comment #1 from Julian Maurice --- Created attachment 11416 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11416&action=edit Bug 7168: Add basket group search field in histsearch.pl Allow to search orders by basket group name -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 7 15:09:52 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Aug 2012 13:09:52 +0000 Subject: [Koha-bugs] [Bug 7168] Search orders by basket group name In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7168 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|5336 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 7 15:09:52 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Aug 2012 13:09:52 +0000 Subject: [Koha-bugs] [Bug 5336] Acq history search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|7168 | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 7 15:11:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Aug 2012 13:11:33 +0000 Subject: [Koha-bugs] [Bug 7967] Z39.50 client should negotiate encoding with server In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7967 --- Comment #5 from Owen Leonard --- Can we get a test plan for this? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 7 15:21:05 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Aug 2012 13:21:05 +0000 Subject: [Koha-bugs] [Bug 7805] Exposing the new list permissions in opac and staff In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7805 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10274|0 |1 is obsolete| | --- Comment #10 from Owen Leonard --- Created attachment 11417 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11417&action=edit [SIGNED-OFF] Bug 7805 Followup for perlcritic messages Signed-off-by: Owen Leonard Tested by going to Lists and doubleclicking a list to see its contents (in opac or staff). It works. No warnings in the log. I am ready to sign off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 7 15:21:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Aug 2012 13:21:35 +0000 Subject: [Koha-bugs] [Bug 7805] Exposing the new list permissions in opac and staff In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7805 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 7 15:35:06 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Aug 2012 13:35:06 +0000 Subject: [Koha-bugs] [Bug 7830] return policy error in hold policy by item type after upgrade In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7830 Albert Oller changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ago at bywatersolutions.com --- Comment #1 from Albert Oller --- Seen on upgrade to 3.08.01.002. returnbranch in branch_item_rules is being set to NULL - no other columns are affected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 7 15:43:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Aug 2012 13:43:37 +0000 Subject: [Koha-bugs] [Bug 4045] No check for maximum number of allowed holds. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4045 --- Comment #39 from Liz Rea --- Created attachment 11418 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11418&action=edit Bug 4045 - No check for maximum number of allowed holds. Re-add the system preference maxreserves. All the code using maxreserves is still in place. Though it is not used in the Reserves module, it is used in all the scripts where holds are placed. Also adds a check so that a borrower cannot exceed the maximum number of allowed holds by using the multi-hold feature via the opac. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 7 15:47:59 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Aug 2012 13:47:59 +0000 Subject: [Koha-bugs] [Bug 7308] new column in admin/aqbudgets In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7308 --- Comment #6 from Julian Maurice --- This sounds ok(In reply to comment #5) > Sorry Maurice for me not being clear. I prefer my firstname: Julian ;-) > > I took another look to admin/aqbudgets.pl and I found more confusing stuff, > so I will try to make it clear what I think this table should look like to > be really useful. I am looking at my production data. > > admin/aqbudgets.pl should have the following columns: > > Base-level allocated (or just Allocated) > Base-level ordered > Total sub-levels ordered > Base-level spent > Total sub-levels spent > Base-level available > Total sub-levels available > > Base-level is always calculated for one level, without children. > Total sub-levels should include child funds. > Available is calculated as "allocated - (ordered + spent)". > > So, this means that: > - "Total allocated" should be removed because currently it shows the same > data as "Base-level alloceted". > - three new columns should be added: "Base-level ordered", "Total sub-levels > ordered" and "Total sub-levels available"; > - wording should be changed from "remaining" to "available" (consistency > with acqui/acqui-home.pl) This sounds ok for me. Can anyone else confirm that this is what we want in these tables? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 7 16:08:56 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Aug 2012 14:08:56 +0000 Subject: [Koha-bugs] [Bug 5544] All Notices from Branch Email Address In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5544 --- Comment #3 from Owen Leonard --- I tested this and it worked as expected when processing item checkout notices. I'm not sure how to test case 1) Address specified in message. Where does that arise? Does comment 2 imply that this has failed QA? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 7 16:25:38 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Aug 2012 14:25:38 +0000 Subject: [Koha-bugs] [Bug 5544] All Notices from Branch Email Address In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5544 --- Comment #4 from Jonathan Druart --- (In reply to comment #3) > Does comment 2 imply that this has failed QA? No. It is a code optimization. It does not impact testings. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 7 16:25:45 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Aug 2012 14:25:45 +0000 Subject: [Koha-bugs] [Bug 7417] Include alternate forms from authorities in bibliographic searches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7417 --- Comment #29 from Jared Camins-Esakov --- Created attachment 11419 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11419&action=edit Bug 7417 follow-up: use Moose-like syntax for accessors In order to make the Koha codebase more consistent, this patch switches the RecordProcessor code to use the Moose-like syntax supported by Class::Accessor. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 7 16:42:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Aug 2012 14:42:35 +0000 Subject: [Koha-bugs] [Bug 6707] Add alternative, textual MARC editor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6707 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #17 from Owen Leonard --- Patch still applies with minor conflict revisions. Testing one quick change to an existing record (just changing words in 245a) I couldn't save the record. Clicking the save button didn't appear to do anything, but this error was in the log: addbiblio-text.pl: Can't call method "param" on unblessed reference at /home/oleonard/kohaclone/C4/Biblio.pm line 2326 A revised version of this patch should correct the error *and* offer some error-handling so that the user can be told something went wrong. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 7 16:47:52 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Aug 2012 14:47:52 +0000 Subject: [Koha-bugs] [Bug 8520] Authorities display incorrectly in staff results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8520 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 7 16:48:04 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Aug 2012 14:48:04 +0000 Subject: [Koha-bugs] [Bug 8520] Authorities display incorrectly in staff results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8520 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 7 16:48:06 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Aug 2012 14:48:06 +0000 Subject: [Koha-bugs] [Bug 8520] Authorities display incorrectly in staff results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8520 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11274|0 |1 is obsolete| | --- Comment #10 from Jared Camins-Esakov --- Created attachment 11420 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11420&action=edit Bug 8520: fix authority display in autocomplete -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 7 16:51:07 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Aug 2012 14:51:07 +0000 Subject: [Koha-bugs] [Bug 8551] Course reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8551 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |pelletiermaxime at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 7 16:51:59 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Aug 2012 14:51:59 +0000 Subject: [Koha-bugs] [Bug 8520] Authorities display incorrectly in staff results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8520 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11420|0 |1 is obsolete| | --- Comment #11 from Jared Camins-Esakov --- Created attachment 11421 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11421&action=edit Bug 8520: fix authority display in autocomplete -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 7 16:56:12 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Aug 2012 14:56:12 +0000 Subject: [Koha-bugs] [Bug 8520] Authorities display incorrectly in staff results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8520 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11421|0 |1 is obsolete| | --- Comment #12 from Jared Camins-Esakov --- Created attachment 11422 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11422&action=edit Bug 8520: fix authority display in autocomplete -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 7 16:59:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Aug 2012 14:59:58 +0000 Subject: [Koha-bugs] [Bug 8520] Authorities display incorrectly in staff results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8520 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11422|0 |1 is obsolete| | --- Comment #13 from Tom?s Cohen Arazi --- Created attachment 11423 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11423&action=edit Bug 8520: fix authority display in autocomplete Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 7 17:01:02 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Aug 2012 15:01:02 +0000 Subject: [Koha-bugs] [Bug 8520] Authorities display incorrectly in staff results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8520 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 7 17:04:22 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Aug 2012 15:04:22 +0000 Subject: [Koha-bugs] [Bug 7583] undo receive In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7583 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #1 from Julian Maurice --- There is a BibLibre development which do what you want, but it depends on Bug 5336 which depends on Bug 7294 which is waiting for signoff. BibLibre repository: http://git.biblibre.com/koha_biblibre.git Branch: itt/ft/MT8378 (commit ed0e9e7ebcdf61c6ab17f4f68f219577754d5a6b) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 7 17:04:38 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Aug 2012 15:04:38 +0000 Subject: [Koha-bugs] [Bug 7583] undo receive In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7583 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |5336 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 7 17:04:38 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Aug 2012 15:04:38 +0000 Subject: [Koha-bugs] [Bug 5336] Acq history search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7583 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 7 17:50:51 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Aug 2012 15:50:51 +0000 Subject: [Koha-bugs] [Bug 8587] New: Add a serial lifespan to serial subscriptions Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8587 Priority: P5 - low Change sponsored?: --- Bug ID: 8587 CC: colin.campbell at ptfs-europe.com Assignee: koha-bugs at lists.koha-community.org Summary: Add a serial lifespan to serial subscriptions Severity: enhancement Classification: Unclassified OS: All Reporter: pelletiermaxime at gmail.com Hardware: All Status: NEW Version: master Component: Serials Product: Koha This field is mostly useful when it comes to weeding. Sharing it here hoping it could be useful to anyone. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 7 17:52:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Aug 2012 15:52:37 +0000 Subject: [Koha-bugs] [Bug 8587] Add a serial lifespan to serial subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8587 --- Comment #1 from Maxime Pelletier --- Created attachment 11424 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11424&action=edit Add new field serial lifespan -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 7 17:53:55 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Aug 2012 15:53:55 +0000 Subject: [Koha-bugs] [Bug 8587] Add a serial lifespan to serial subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8587 Maxime Pelletier changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Change sponsored?|--- |Sponsored --- Comment #2 from Maxime Pelletier --- Patch sponsored by the CCSR ( http://www.ccsr.qc.ca ). The new field is in the Add a new subscription page of the serials, above the Library field. The patch was based on 3.8.3. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 7 18:32:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Aug 2012 16:32:41 +0000 Subject: [Koha-bugs] [Bug 6832] Validation of total > budget in neworderempty In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6832 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11209|0 |1 is obsolete| | --- Comment #11 from Marc V?ron --- Created attachment 11425 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11425&action=edit Fix Validation of total higher as budget in neworderempty I downloaded the patch, removed the line following Katrins advice, changed Maximes French text to English and uploaded the patch. Hope this works. Marc -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 7 18:46:01 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Aug 2012 16:46:01 +0000 Subject: [Koha-bugs] [Bug 8588] New: Duplicate field IDs cause problems with SQL report parameter entry Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8588 Priority: P5 - low Change sponsored?: --- Bug ID: 8588 Assignee: oleonard at myacpl.org Summary: Duplicate field IDs cause problems with SQL report parameter entry Severity: normal Classification: Unclassified OS: All Reporter: oleonard at myacpl.org Hardware: All Status: ASSIGNED Version: master Component: Reports Product: Koha When the SQL repots template displays form fields for entering runtime parameters the fields do not have unique ids. This prevents correct label+input markup from being possible and causes buggy behavior by the jQueryUI datepicker widget. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 7 18:54:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Aug 2012 16:54:28 +0000 Subject: [Koha-bugs] [Bug 6832] Validation of total > budget in neworderempty In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6832 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #12 from Marc V?ron --- Did a short test with new patch. Works as expected. I sign off again. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 7 20:38:59 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Aug 2012 18:38:59 +0000 Subject: [Koha-bugs] [Bug 8589] New: Advanced Search for itemtype and location produces some results that are not useful Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8589 Priority: P5 - low Change sponsored?: --- Bug ID: 8589 Assignee: gmcharlt at gmail.com Summary: Advanced Search for itemtype and location produces some results that are not useful Severity: enhancement Classification: Unclassified OS: All Reporter: melia at bywatersolutions.com Hardware: All Status: NEW Version: rel_3_8 Component: Searching Product: Koha When searching for a list of circulating books in New York, I can run a search specifying an item type of "circulating item" and a location of "New York" from Advanced Search. The search returns some results that look like this: Item type Location Call Number Status Book New York 500 GRA (Browse Shelf) Not for loan Book San Francisco 500 GRA (Browse Shelf) Not for loan Circulating item Atlanta 500 GRA (Browse Shelf) Not for loan Circulating item Cleveland 500 GRA (Browse Shelf) Available The last two items are circulating items, and the first item has a location of New York, but there aren't any items that are BOTH circulating AND in New York, so this is not a useful result. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 7 21:02:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Aug 2012 19:02:57 +0000 Subject: [Koha-bugs] [Bug 8589] Advanced Search for itemtype and location produces some results that are not useful In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8589 --- Comment #1 from Jared Camins-Esakov --- In order to fix this you are going to need composed indexes on the item field and a search structure capable of handling a query of this complexity. I proposed the latter in my search rewrite, but I think there is really no point to the former until there is a query parser capable of using a composed index. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 7 21:06:05 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Aug 2012 19:06:05 +0000 Subject: [Koha-bugs] [Bug 8589] Advanced Search for itemtype and location produces some results that are not useful In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8589 --- Comment #2 from Owen Leonard --- I can confirm this in our catalog: http://search.myacpl.org/cgi-bin/koha/opac-search.pl?idx=kw&q=chilton&idx=kw&idx=kw&limit=mc-itype%2Cphr%3ACIRC&limit=branch%3ACOV&sort_by=relevance&do=Search This search for keyword "Chilton," item type "Circulating," and library "Coolville" returns results at that library which are *not* of type "Circulating" (reference copies). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 7 21:14:56 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Aug 2012 19:14:56 +0000 Subject: [Koha-bugs] [Bug 8588] Duplicate field IDs cause problems with SQL report parameter entry In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8588 --- Comment #1 from Owen Leonard --- Created attachment 11426 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11426&action=edit Bug 8588 - Duplicate field IDs cause problems with SQL report parameter entry Changes to markup and script to enable unique ids on form fields. These changes allow for working label+input pairs on one or more text and select inputs and multiple working datepickers. To test, create a report with more than one date parameter, at least one text parameter, and one or more authorised value parameters. The datepickers should each work properly, and labels should by clickable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 7 21:15:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Aug 2012 19:15:28 +0000 Subject: [Koha-bugs] [Bug 8588] Duplicate field IDs cause problems with SQL report parameter entry In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8588 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 7 21:20:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Aug 2012 19:20:09 +0000 Subject: [Koha-bugs] [Bug 7417] Include alternate forms from authorities in bibliographic searches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7417 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11419|0 |1 is obsolete| | --- Comment #30 from Jared Camins-Esakov --- Created attachment 11427 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11427&action=edit Bug 7417 follow-up: use Moose-like syntax for accessors In order to make the Koha codebase more consistent, this patch switches the RecordProcessor and Koha::DataObject::Authority code to use the Moose-like syntax supported by Class::Accessor. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 7 21:21:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Aug 2012 19:21:43 +0000 Subject: [Koha-bugs] [Bug 8590] New: checked out from missing on patron detail Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8590 Priority: P5 - low Change sponsored?: --- Bug ID: 8590 CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Assignee: koha-bugs at lists.koha-community.org Summary: checked out from missing on patron detail Severity: normal Classification: Unclassified OS: All Reporter: nengard at gmail.com URL: cgi-bin/koha/members/moremember.pl?borrowernumber=53 Hardware: All Status: NEW Version: master Component: Circulation Product: Koha When on the patron details tab it has a column for 'checked out from' but that's not populated. If you look at the check out tab on it does show data in that column. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 7 21:33:36 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Aug 2012 19:33:36 +0000 Subject: [Koha-bugs] [Bug 7417] Include alternate forms from authorities in bibliographic searches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7417 --- Comment #31 from Jared Camins-Esakov --- Jonathan, I think the thing to do here is move forward with the Class::Accessor-based code. While I am willing to rewrite this to use Moo, I think that it might be a bit premature to do that at this point. Better, I think, to make sure that there's consensus on using Moo as a compromise framework first, per comment 19. In the meantime, if you don't mind I would like to incorporate any further QA comments you might have so that this patch can move forward. Regarding what exactly goes in Koha::DataObject::Authority, I think we all agree that we can't just leave C4::AuthoritiesMarc as it is. I suggest that taking a minimalist approach to Koha::DataObject::Authority is the best we can do. My patch does that We can't possibly know what metadata we might have about authorities in the future, so any precise list of what can go in Koha::DataObject::Authority is guaranteed to be obsolete almost as soon as we have written it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 7 22:09:46 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Aug 2012 20:09:46 +0000 Subject: [Koha-bugs] [Bug 8590] checked out from missing on patron detail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8590 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | --- Comment #1 from Owen Leonard --- Looks like the information stopped getting pulled by the script when it was modified for Bug 5549: http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=f74da1e83442a730e2e56866f57b9f5aef93a3f5#patch3 - $issue->[$i]{'issuingbranchname'} = GetBranchName($issue->[$i]{'branchcode'}); -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 7 22:11:30 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Aug 2012 20:11:30 +0000 Subject: [Koha-bugs] [Bug 8590] checked out from missing on patron detail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8590 --- Comment #2 from Owen Leonard --- Created attachment 11428 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11428&action=edit Bug 8590 - checked out from missing on patron detail Adding back the line in the script which pulls the name of the branch where the item was checked out. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 7 22:11:42 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Aug 2012 20:11:42 +0000 Subject: [Koha-bugs] [Bug 8590] checked out from missing on patron detail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8590 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 7 22:18:02 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Aug 2012 20:18:02 +0000 Subject: [Koha-bugs] [Bug 8330] Overdue mail link contains untranslatable strings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8330 --- Comment #2 from Owen Leonard --- I wonder if these links are ever used? Would be possible to instead generate a one-time notice? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 7 22:32:56 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Aug 2012 20:32:56 +0000 Subject: [Koha-bugs] [Bug 8330] Overdue mail link contains untranslatable strings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8330 --- Comment #3 from Katrin Fischer --- Hi Owen, an option so send a real mail from there using a notice template would certainly be much better! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 7 22:52:53 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Aug 2012 20:52:53 +0000 Subject: [Koha-bugs] [Bug 8532] Old/iffy data causes error checking out In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8532 --- Comment #7 from Chris Cormack --- Pushed to 3.8.x, will be in 3.8.4 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 8 00:11:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Aug 2012 22:11:47 +0000 Subject: [Koha-bugs] [Bug 8590] checked out from missing on patron detail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8590 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11428|0 |1 is obsolete| | --- Comment #3 from Nicole C. Engard --- Created attachment 11429 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11429&action=edit [SIGNED-OFF] Bug 8590 - checked out from missing on patron detail Adding back the line in the script which pulls the name of the branch where the item was checked out. Signed-off-by: Nicole C. Engard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 8 00:12:02 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Aug 2012 22:12:02 +0000 Subject: [Koha-bugs] [Bug 8590] checked out from missing on patron detail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8590 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 8 00:21:55 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Aug 2012 22:21:55 +0000 Subject: [Koha-bugs] [Bug 7572] Add Clubs & Services Feature In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7572 --- Comment #18 from Marc V?ron --- Patch did not apply. I tried to resolve it using git am -iu3 (...), got it to apply. However I got errors running updatedatabase.pl, removed Line 5250 (<<<..) that was alredy in the patch, droped all tables that were alreade created by the first run, and run updatedatabase.pl again. BTW, the SQL statements in updatedatabase.pl contain backticks (`). Got JavaScript Eror while Editing Clubs & Services (Calendar not defined), not sure if any follwoing JavaScript then is broken (validations etc.) On a patrons checkout page the menu at the left is doubled, I suppose it is a conflict with the new layout. Anyway, I could then follow the test plan and enroll a patron to a club (and cancel as well), both in the staff client and in the Opac. Then I was a little bit lost in testing. It took a while until I found out that a self made Club Archetype *must* have the title "Bestsellers Club" to trigger holdings, see ClubsAndServices.pm line 1175: $sth = $dbh->prepare("SELECT * FROM clubsAndServicesArchetypes WHERE title LIKE 'Bestsellers Club' "); Adding items for biblios with matching titles somtimes placed a hold for the patron and sometimes not. Could not find out why. Maybe it is due to some misconfiguration related to my try to resolve the patch issue. It seems to be a great and promising feature, but for now I am stuck. For a new test with a rebased patch I would really appreciate a more complete description of the overall concept and functionality (Wiki?) and a more detailed testing plan. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 8 00:22:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Aug 2012 22:22:48 +0000 Subject: [Koha-bugs] [Bug 7572] Add Clubs & Services Feature In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7572 --- Comment #19 from Marc V?ron --- Created attachment 11430 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11430&action=edit Strange display of menu at the left -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 8 00:23:20 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Aug 2012 22:23:20 +0000 Subject: [Koha-bugs] [Bug 7572] Add Clubs & Services Feature In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7572 --- Comment #20 from Marc V?ron --- Created attachment 11431 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11431&action=edit Java Script Error related to Calendar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 8 01:02:54 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Aug 2012 23:02:54 +0000 Subject: [Koha-bugs] [Bug 8591] New: show sum of any outstanding fines for patron on the issue slip Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8591 Priority: P5 - low Change sponsored?: --- Bug ID: 8591 Assignee: koha-bugs at lists.koha-community.org Summary: show sum of any outstanding fines for patron on the issue slip Severity: enhancement Classification: Unclassified OS: All Reporter: melia at bywatersolutions.com Hardware: All Status: NEW Version: rel_3_8 Component: Notices Product: Koha We would like to show a sum of any outstanding fines for a particular patron at the bottom of the issue slip. Would this require adding some fields from the accountlines table as available fields to be used in a notice? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 8 05:47:45 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Aug 2012 03:47:45 +0000 Subject: [Koha-bugs] [Bug 8592] New: Pendingreserves.tt is showing "Previous" and "Next" text over the "Previous" and "Next" buttons on the jQuery datatable Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8592 Priority: P5 - low Change sponsored?: --- Bug ID: 8592 Assignee: oleonard at myacpl.org Summary: Pendingreserves.tt is showing "Previous" and "Next" text over the "Previous" and "Next" buttons on the jQuery datatable Severity: minor Classification: Unclassified OS: All Reporter: dcook at prosentient.com.au Hardware: All Status: NEW Version: master Component: Templates Product: Koha On pendingreserves.tt (or the Holds to Pull screen), the Previous and Next buttons now have "Previous" and "Next" link text appearing overtop of them. In 3.8.0, there are just the buttons and no text overtop. If you look at the element that has the button images, it is a div element with titles for "Previous" and "Next". In 3.9.0.30, the div elements no longer have titles, but instead of links within them that have link text of "Previous" and "Next" that appear overtop of the button images. jquery.dataTables.min.js 1.8.1 - Shows "Previous" and "Next" as titles for the div showing the image jquery.dataTables.min.js 1.9.1 - Removes the title from the div and adds links which have "Previous" and "Next" as link text. -- I haven't tested this extensively, but I do wonder why there are links in 3.9.x and not 3.8.x. Since there aren't enough holds to generate another page of results, the earlier behaviour might be the correct one. Or maybe the links weren't showing up and the button images were worthless in 1.8.1. I don't know. I just know that it looks terrible. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 8 05:48:07 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Aug 2012 03:48:07 +0000 Subject: [Koha-bugs] [Bug 8592] Pendingreserves.tt is showing "Previous" and "Next" text over the "Previous" and "Next" buttons on the jQuery datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8592 --- Comment #1 from David Cook --- Created attachment 11432 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11432&action=edit 3.8.x - jquery 1.8.1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 8 05:48:23 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Aug 2012 03:48:23 +0000 Subject: [Koha-bugs] [Bug 8592] Pendingreserves.tt is showing "Previous" and "Next" text over the "Previous" and "Next" buttons on the jQuery datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8592 --- Comment #2 from David Cook --- Created attachment 11433 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11433&action=edit 3.9.x - jquery 1.9.1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 8 05:48:38 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Aug 2012 03:48:38 +0000 Subject: [Koha-bugs] [Bug 8592] Pendingreserves.tt is showing "Previous" and "Next" text over the "Previous" and "Next" buttons on the jQuery datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8592 --- Comment #3 from David Cook --- Created attachment 11434 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11434&action=edit 3.8.x - template view -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 8 05:48:52 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Aug 2012 03:48:52 +0000 Subject: [Koha-bugs] [Bug 8592] Pendingreserves.tt is showing "Previous" and "Next" text over the "Previous" and "Next" buttons on the jQuery datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8592 --- Comment #4 from David Cook --- Created attachment 11435 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11435&action=edit 3.9.x - template view -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 8 09:17:19 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Aug 2012 07:17:19 +0000 Subject: [Koha-bugs] [Bug 8330] Overdue mail link contains untranslatable strings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8330 --- Comment #4 from Gaetan Boisson --- They are used in at least one library i know of. I think it makes sense to have this functionnality in a report that lists overdues. Even though i agree most libraries will choose to automate sending overdue notices. Some are small enough and would rather take care of it 100% manually, other might want to be able to send another notice, manually in some cases. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 8 09:18:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Aug 2012 07:18:39 +0000 Subject: [Koha-bugs] [Bug 8330] Overdue mail link contains untranslatable strings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8330 --- Comment #5 from Gaetan Boisson --- Actually there used to be, i've seen it in libraries using an older version, a 'MANUAL_ODUE' notice, which would be sent from here. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 8 09:36:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Aug 2012 07:36:10 +0000 Subject: [Koha-bugs] [Bug 8330] Overdue mail link contains untranslatable strings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8330 --- Comment #6 from Katrin Fischer --- Hi Gaetan, yes, and we have been trying to make it work in the past - see bug 4990. Seems it was working in 2.2, then it got reintegrated in 3.0.x, while development was already done for 3.2. There never was a working patch for 3.2 (master back then), so the the feature got lost again after updating from 3.0.x. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 8 10:17:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Aug 2012 08:17:43 +0000 Subject: [Koha-bugs] [Bug 8593] New: bug for html Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8593 Priority: P5 - low Change sponsored?: --- Bug ID: 8593 CC: gmcharlt at gmail.com Assignee: koha-bugs at lists.koha-community.org Summary: bug for html Severity: enhancement Classification: Unclassified OS: All Reporter: jorgia_m_kelsey at hotmail.com Hardware: All Status: NEW Version: unspecified Component: Staff Client Product: Koha Created attachment 11436 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11436&action=edit edited intranet-main file -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 8 10:17:44 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Aug 2012 08:17:44 +0000 Subject: [Koha-bugs] [Bug 8587] Add a serial lifespan to serial subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8587 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11424|0 |1 is obsolete| | --- Comment #3 from Chris Cormack --- Created attachment 11437 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11437&action=edit 8587 Add serial subscript lifespan Add lifespan to serial subscriptions Sponsored-by: CCSR ( http://www.ccsr.qc.ca ) Signed-off-by: Chris Cormack -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 8 10:18:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Aug 2012 08:18:28 +0000 Subject: [Koha-bugs] [Bug 8587] Add a serial lifespan to serial subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8587 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 8 10:36:08 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Aug 2012 08:36:08 +0000 Subject: [Koha-bugs] [Bug 8588] Duplicate field IDs cause problems with SQL report parameter entry In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8588 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11426|0 |1 is obsolete| | --- Comment #2 from Chris Cormack --- Created attachment 11438 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11438&action=edit Bug 8588 - Duplicate field IDs cause problems with SQL report parameter entry Changes to markup and script to enable unique ids on form fields. These changes allow for working label+input pairs on one or more text and select inputs and multiple working datepickers. To test, create a report with more than one date parameter, at least one text parameter, and one or more authorised value parameters. The datepickers should each work properly, and labels should by clickable. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 8 10:41:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Aug 2012 08:41:57 +0000 Subject: [Koha-bugs] [Bug 8588] Duplicate field IDs cause problems with SQL report parameter entry In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8588 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 8 11:14:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Aug 2012 09:14:35 +0000 Subject: [Koha-bugs] [Bug 7583] undo receive In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7583 --- Comment #2 from Julian Maurice --- Created attachment 11439 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11439&action=edit Bug 7583: Cancel a receipt In acqui/parcel.pl, there is now the possibility to cancel a receipt. In "Already received" table, just click on "Cancel receipt" and the order line will go back to pending orders. If it was a partial receipt, order line is merged to its 'parent' line. Attached items are modified so that they become attached to the merged order line. If AcqCreateItem is 'receiving', attached items are deleted. If an order line was first partially received, and then completed, you must cancel the 'parent' order line before cancelling the 'child'. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 8 11:15:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Aug 2012 09:15:10 +0000 Subject: [Koha-bugs] [Bug 7583] undo receive In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7583 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Depends on|5336 | Assignee|henridamien at koha-fr.org |julian.maurice at biblibre.com --- Comment #3 from Julian Maurice --- Patch was modified so that it's not dependant anymore on other bugs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 8 11:15:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Aug 2012 09:15:10 +0000 Subject: [Koha-bugs] [Bug 5336] Acq history search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|7583 | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 8 11:31:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Aug 2012 09:31:47 +0000 Subject: [Koha-bugs] [Bug 5327] Unit tests required for all C4 modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 --- Comment #207 from Bart Jorgensen --- Created attachment 11440 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11440&action=edit Added unit tests to 'Members_AttributeTypes.t' increases overal coverage of C4/Members/AttributeTypes.pm from 7.7% to 33% :) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 8 11:49:46 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Aug 2012 09:49:46 +0000 Subject: [Koha-bugs] [Bug 7690] hidelostitems not working in Normal Display In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7690 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers at biblibre.co | |m See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=6488 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 8 11:49:46 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Aug 2012 09:49:46 +0000 Subject: [Koha-bugs] [Bug 6488] opachiddenitems not working in master In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6488 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7690 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 8 11:57:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Aug 2012 09:57:25 +0000 Subject: [Koha-bugs] [Bug 7417] Include alternate forms from authorities in bibliographic searches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7417 --- Comment #32 from Jonathan Druart --- (In reply to comment #31) > Jonathan, > > I think the thing to do here is move forward with the Class::Accessor-based > code. While I am willing to rewrite this to use Moo, I think that it might > be a bit premature to do that at this point. Better, I think, to make sure > that there's consensus on using Moo as a compromise framework first, per > comment 19. In the meantime, if you don't mind I would like to incorporate > any further QA comments you might have so that this patch can move forward. Jared, All seems good. To be perfect, the following should be made: - pass perltidy on new files - for discussion: Isn't it possible to have an "intelligent" constructor for Authorities ? I think we don't want a lot of get_from_*. Perhaps a "new" routine with a test on param: either: new( { record => $record} ), new ({authid => $authid}) or: new ($var). sub new {my $self = shift; if (ref $var eq 'MARC::Record') { print "it's a record" } else { print "it's an authid"} - You have to check the returned value of get_from_id in AuthoritiesMarc::GetAuthority: add a 'return unless $authority' seems to be sufficient - I don't understand what you do exactly with the indicator: Your comment: +In order to differentiate added headings from actual headings, a 'z' is +put in the first indicator. I am not an UNIMARC or *MARC* expert but isn't the content of this indicator normalized ? I don't manage to find if it is a work around or the best way to do that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 8 12:24:17 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Aug 2012 10:24:17 +0000 Subject: [Koha-bugs] [Bug 8594] New: A report containing a subquery that has a 'limit' will have that limit stripped out Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8594 Priority: P5 - low Change sponsored?: --- Bug ID: 8594 Assignee: gmcharlt at gmail.com Summary: A report containing a subquery that has a 'limit' will have that limit stripped out Severity: normal Classification: Unclassified OS: All Reporter: robin at catalyst.net.nz Hardware: All Status: NEW Version: rel_3_8 Component: Reports Product: Koha The limit is stripped out when Koha fetches the headers* so that another limit can be applied. However, if you have a subquery in the fields part, then you probably need to apply a limit for things to work. So fetching the headers fails. I'm thinking that the limit should be removed after the last where clause, or if there's no where clause, do what is currently done. This won't fix every case, but should result in more things working. * in other news, I'm not a fan of it having to run the query twice, which it seems to do, just to grab the headers. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 8 12:24:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Aug 2012 10:24:33 +0000 Subject: [Koha-bugs] [Bug 8594] A report containing a subquery that has a 'limit' will have that limit stripped out In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8594 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Change sponsored?|--- |Sponsored Assignee|gmcharlt at gmail.com |robin at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 8 12:51:15 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Aug 2012 10:51:15 +0000 Subject: [Koha-bugs] [Bug 8587] Add a serial lifespan to serial subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8587 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart at biblibre.co | |m --- Comment #4 from Jonathan Druart --- QA comments: Hi Maxime, 1/+ `seriallifespan` TINYINT(1) DEFAULT -1 You cannot store '10' into a TINYINT(1) 2/ 3 loops can be created to avoid a list of 10 lines: [% FOREACH i IN [ 2 .. 10 ] %] [% END %] Furthermore you cannot write this line :-/ (see Bug 8407) And: [% IF seriallifespan == -1 %] Immortal [% ELSIF ( seriallifespan == 1 ) %] 1 year [% ELSIF ( seriallifespan >= 10 ) %] [% FOREACH i IN [ 2 .. 10 ] %] [% seriallifespan %] years [% END %] [% END %] Something like that, I didn't test. 3/ Fonctionnaly what is the goal of this field? Indeed, you don't use this field, just store and display. Failed QA for 1 and 2 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 8 13:04:40 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Aug 2012 11:04:40 +0000 Subject: [Koha-bugs] [Bug 8587] Add a serial lifespan to serial subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8587 --- Comment #5 from Chris Cormack --- (In reply to comment #4) > QA comments: > > Hi Maxime, > > 1/+ `seriallifespan` TINYINT(1) DEFAULT -1 > You cannot store '10' into a TINYINT(1) > > 2/ 3 loops can be created to avoid a list of 10 lines: > [% FOREACH i IN [ 2 .. 10 ] %] > > [% END %] > > Furthermore you cannot write this line :-/ (see Bug 8407) > > And: > [% IF seriallifespan == -1 %] > Immortal > [% ELSIF ( seriallifespan == 1 ) %] > 1 year > [% ELSIF ( seriallifespan >= 10 ) %] > [% FOREACH i IN [ 2 .. 10 ] %] > [% seriallifespan %] years > [% END %] > [% END %] > > Something like that, I didn't test. > > 3/ Fonctionnaly what is the goal of this field? Indeed, you don't use this > field, just store and display. > > Failed QA for 1 and 2 I think its just 2, tt inside a tag that is a problem, tinyint(1) is 0 - 255 unsigned and -128 to 127 signed. select seriallifespan from subscription; +----------------+ | seriallifespan | +----------------+ | 10 | +----------------+ (I tested that when signing off) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 8 13:31:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Aug 2012 11:31:24 +0000 Subject: [Koha-bugs] [Bug 8587] Add a serial lifespan to serial subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8587 --- Comment #6 from Jonathan Druart --- (In reply to comment #5) > I think its just 2, tt inside a tag that is a problem, tinyint(1) is 0 - 255 > unsigned and -128 to 127 signed. Oups yes, you are right ! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 8 13:36:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Aug 2012 11:36:27 +0000 Subject: [Koha-bugs] [Bug 7417] Include alternate forms from authorities in bibliographic searches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7417 --- Comment #33 from Jared Camins-Esakov --- (In reply to comment #32) > (In reply to comment #31) > > Jonathan, > > > > I think the thing to do here is move forward with the Class::Accessor-based > > code. While I am willing to rewrite this to use Moo, I think that it might > > be a bit premature to do that at this point. Better, I think, to make sure > > that there's consensus on using Moo as a compromise framework first, per > > comment 19. In the meantime, if you don't mind I would like to incorporate > > any further QA comments you might have so that this patch can move forward. > > Jared, > > All seems good. > To be perfect, the following should be made: > > - pass perltidy on new files Will do. > - for discussion: Isn't it possible to have an "intelligent" constructor for > Authorities ? I think we don't want a lot of get_from_*. Perhaps a "new" > routine with a test on param: > either: new( { record => $record} ), new ({authid => $authid}) > or: new ($var). sub new {my $self = shift; if (ref $var eq > 'MARC::Record') { print "it's a record" } else { print "it's an authid"} We could certainly do this. My original implementation used the former option, but for some reason I changed it. I don't remember quite why. > - You have to check the returned value of get_from_id in > AuthoritiesMarc::GetAuthority: > add a 'return unless $authority' seems to be sufficient Will do. > - I don't understand what you do exactly with the indicator: > Your comment: > +In order to differentiate added headings from actual headings, a 'z' is > +put in the first indicator. > I am not an UNIMARC or *MARC* expert but isn't the content of this > indicator normalized ? > I don't manage to find if it is a work around or the best way to do that. Yes. 'z' is always an invalid indicator value, because the standard calls for a numeric value. So any time we find a letter in an indicator, we can safely assume that the field is one that should not be displayed or used other than for searching. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 8 14:13:51 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Aug 2012 12:13:51 +0000 Subject: [Koha-bugs] [Bug 7417] Include alternate forms from authorities in bibliographic searches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7417 --- Comment #34 from Jared Camins-Esakov --- Created attachment 11441 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11441&action=edit Bug 7417 follow-up: additional QA fixes * perltidied all new files again * wrote an intelligent constructor for Koha::DataObject::Authority which takes a hash with the construction criteria * added rudimentary error handling in C4::AuthoritiesMarc::GetAuthority * added missing t/AuthoritiesMarc.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 8 14:27:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Aug 2012 12:27:27 +0000 Subject: [Koha-bugs] [Bug 8549] DataTables upgrade broke display of next/previous buttons in table controls In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8549 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #1 from Owen Leonard --- *** Bug 8592 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 8 14:27:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Aug 2012 12:27:27 +0000 Subject: [Koha-bugs] [Bug 8592] Pendingreserves.tt is showing "Previous" and "Next" text over the "Previous" and "Next" buttons on the jQuery datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8592 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #5 from Owen Leonard --- *** This bug has been marked as a duplicate of bug 8549 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 8 14:29:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Aug 2012 12:29:57 +0000 Subject: [Koha-bugs] [Bug 8595] New: link to 'host item' confusing Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8595 Priority: P5 - low Change sponsored?: --- Bug ID: 8595 CC: m.de.rooy at rijksmuseum.nl Assignee: gmcharlt at gmail.com Summary: link to 'host item' confusing Severity: minor Classification: Unclassified OS: All Reporter: nengard at gmail.com Hardware: All Status: NEW Version: master Component: Cataloging Product: Koha When using analytics the word 'item' is confusing some people. What you're doing is linking an item to a host bib record - not a host item record. I recommend just removing the word Item and having the option say 'Link to Host' so that it's clearer to those using the option. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 8 14:31:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Aug 2012 12:31:39 +0000 Subject: [Koha-bugs] [Bug 8593] Add unique IDs to pending approval markup on staff client home page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8593 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master Summary|bug for html |Add unique IDs to pending | |approval markup on staff | |client home page -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 8 14:33:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Aug 2012 12:33:57 +0000 Subject: [Koha-bugs] [Bug 8593] Add unique IDs to pending approval markup on staff client home page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8593 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11436|0 |1 is obsolete| | --- Comment #1 from Owen Leonard --- Created attachment 11442 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11442&action=edit [SIGNED-OFF] Bug 8593 - Add unique IDs to pending approval markup on staff client home page edited the intranet main-tt file. updated "suggestions pending". (w box) http://bugs.koha-community.org/show_bug.cgi?id=8593 Signed-off-by: Owen Leonard -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 8 14:34:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Aug 2012 12:34:58 +0000 Subject: [Koha-bugs] [Bug 8593] Add unique IDs to pending approval markup on staff client home page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8593 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 8 14:41:01 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Aug 2012 12:41:01 +0000 Subject: [Koha-bugs] [Bug 8593] Add unique IDs to pending approval markup on staff client home page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8593 --- Comment #2 from Owen Leonard --- Created attachment 11443 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11443&action=edit Bug 8593 - Follow-up - Add unique IDs to pending approval markup on staff client home page This patch adds similar IDs to the tags and comments
    -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 8 14:53:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Aug 2012 12:53:58 +0000 Subject: [Koha-bugs] [Bug 7290] new permission for recieving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7290 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9944|0 |1 is obsolete| | --- Comment #6 from Julian Maurice --- Created attachment 11444 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11444&action=edit Bug 7290: More granular permissions for order receiving Add branch to aqorders. Add subpermission acquisition => order_receive_all Users with order_receive_all can receive all orders. Users with only order_receive can receive an order if: - order branch is defined and is the same as the current working branch - order branch is not defined, basket branch is defined and basket branch is the same as the current working branch - order branch and basket branch are not defined Use dataTables filters possibilities instead of custom JS solution in parcel.pl This patch needs patch for bug 7295 (for basket branch) Unit tests are available in t/Acquisition/CanUserReceiveBasket.t -- patch rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 8 15:07:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Aug 2012 13:07:58 +0000 Subject: [Koha-bugs] [Bug 8574] test In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8574 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 8 15:41:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Aug 2012 13:41:43 +0000 Subject: [Koha-bugs] [Bug 7417] Include alternate forms from authorities in bibliographic searches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7417 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #35 from Jonathan Druart --- Followups need signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 8 15:49:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Aug 2012 13:49:28 +0000 Subject: [Koha-bugs] [Bug 8015] Add MARC Modifications Templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 delaye changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |stephane.delaye at biblibre.co | |m --- Comment #6 from delaye --- If asked to do a action(move) on subfield in which is repeated within a single field (exemplae : UNIMARC 200 or $ f $ G or $ 606 x ... etc.) the tool don't update all the subfield. Only the 1rt subfield is changed the others are deleted Example: move thedata from 200 $g to 200 $f the tool delete the $ g and recreated only one subfield $f corresponding to the first $g -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 8 15:49:52 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Aug 2012 13:49:52 +0000 Subject: [Koha-bugs] [Bug 8015] Add MARC Modifications Templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 delaye changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 8 16:32:31 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Aug 2012 14:32:31 +0000 Subject: [Koha-bugs] [Bug 7678] stat wizrad :patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7678 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt at gmail.com |julian.maurice at biblibre.com --- Comment #1 from Julian Maurice --- Created attachment 11445 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11445&action=edit Bug 7678: Adds extended patron attributes in patron reports This patch allows to choose row and column amongst extended patron attributes and to filter on them in reports/borrower_stats.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 8 16:45:38 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Aug 2012 14:45:38 +0000 Subject: [Koha-bugs] [Bug 8293] Software error when clicking on first or last result of each page on OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8293 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |fridolyn.somers at biblibre.co |ity.org |m --- Comment #1 from Fridolyn SOMERS --- Created attachment 11446 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11446&action=edit Proposed patch Very small patch for a big bug. Some have this error message : Software error: Can't call method "data" on an undefined value at /home/kokha/src/C4/Search.pm line 1505. The problem appears in the 'searchAgain' function in opac-detail.pl. This function is called only on a detail page that is at the end or the begining of a result page. So : In opac-detail.pl, in searchResults method call : The zebra results are used in a hash instead of an array (see opac-results.pl). + The parameter giving hidelostitems syspref is useless, this syspref is managed into method. Please test and signoff. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 8 16:49:36 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Aug 2012 14:49:36 +0000 Subject: [Koha-bugs] [Bug 7678] Statistics wizard: patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7678 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|stat wizrad :patron |Statistics wizard: patrons -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 8 16:51:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Aug 2012 14:51:21 +0000 Subject: [Koha-bugs] [Bug 8587] Add a serial lifespan to serial subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8587 --- Comment #7 from Maxime Pelletier --- (In reply to comment #4) > QA comments: > > Hi Maxime, > > 2/ 3 loops can be created to avoid a list of 10 lines: > [% FOREACH i IN [ 2 .. 10 ] %] > > [% END %] > > Furthermore you cannot write this line :-/ (see Bug 8407) > > And: > [% IF seriallifespan == -1 %] > Immortal > [% ELSIF ( seriallifespan == 1 ) %] > 1 year > [% ELSIF ( seriallifespan >= 10 ) %] > [% FOREACH i IN [ 2 .. 10 ] %] > [% seriallifespan %] years > [% END %] > [% END %] > > Something like that, I didn't test. I have to disagree on this. I don't think hardcoding the number and just translating the word year/years is the right way to go. I'm sure there's a language out there where the number is after or something like that. Id rather have 10 lines than an if/elseif/else. I don't understand bug 8407. Maybe translation for [IF] inside options is broken inside loops, but it's working for me in this patch. In french I have : . Anyway that doesn't mather because : > > 3/ Fonctionnaly what is the goal of this field? Indeed, you don't use this > field, just store and display. Good question. We use it with a saved sql report here attached. Anyway I wasn't really expecting this to be accepted. I think i'm fine leaving it here as Failed QA and to be an option if something needs it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 8 16:52:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Aug 2012 14:52:37 +0000 Subject: [Koha-bugs] [Bug 8587] Add a serial lifespan to serial subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8587 --- Comment #8 from Maxime Pelletier --- Created attachment 11447 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11447&action=edit saved sql report we use -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 8 16:56:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Aug 2012 14:56:10 +0000 Subject: [Koha-bugs] [Bug 7001] User Configurable Slips In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7001 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Passed QA CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 8 16:56:23 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Aug 2012 14:56:23 +0000 Subject: [Koha-bugs] [Bug 7001] User Configurable Slips In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7001 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 8 17:11:07 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Aug 2012 15:11:07 +0000 Subject: [Koha-bugs] [Bug 8596] New: Reports interface date picker doesn't force ISO formatted dates Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8596 Priority: P5 - low Change sponsored?: --- Bug ID: 8596 Assignee: gmcharlt at gmail.com Summary: Reports interface date picker doesn't force ISO formatted dates Severity: normal Classification: Unclassified OS: All Reporter: robin at catalyst.net.nz Hardware: All Status: NEW Version: master Component: Reports Product: Koha If you create a report with <>, the resulting date picker interface when running the report doesn't force dates to ISO form, instead they are created using the date format of the system. This is passed to mysql which complains about the format not being right, understandably. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 8 17:12:02 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Aug 2012 15:12:02 +0000 Subject: [Koha-bugs] [Bug 8596] Reports interface date picker doesn't force ISO formatted dates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8596 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |oleonard at myacpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 8 17:14:20 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Aug 2012 15:14:20 +0000 Subject: [Koha-bugs] [Bug 8549] DataTables upgrade broke display of next/previous buttons in table controls In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8549 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 8 17:53:32 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Aug 2012 15:53:32 +0000 Subject: [Koha-bugs] [Bug 8551] Course reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8551 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8215 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 8 17:53:32 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Aug 2012 15:53:32 +0000 Subject: [Koha-bugs] [Bug 8215] Add Course Reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8551 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 8 17:55:16 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Aug 2012 15:55:16 +0000 Subject: [Koha-bugs] [Bug 8597] New: New theme for the OPAC with a mobile view Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8597 Priority: P5 - low Change sponsored?: --- Bug ID: 8597 Assignee: oleonard at myacpl.org Summary: New theme for the OPAC with a mobile view Severity: enhancement Classification: Unclassified OS: All Reporter: fcapovilla at live.ca Hardware: All Status: NEW Version: rel_3_8 Component: OPAC Product: Koha Created attachment 11448 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11448&action=edit New theme for the OPAC We created a new OPAC theme for our client and he agreed to share it with the community. This new theme also includes a mobile version using mediaqueries in another patch. How to install : 1. Add the image files found in the attached "images.zip" file to the "koha-tmpl/opac-tmpl/prog/images" folder. 2. Apply the patch file on your Koha instance. This patch file includes new js and css files, and some template modifications. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 8 17:55:59 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Aug 2012 15:55:59 +0000 Subject: [Koha-bugs] [Bug 8597] New theme for the OPAC with a mobile view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8597 --- Comment #1 from Fr?d?rick Capovilla --- Created attachment 11449 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11449&action=edit Images files for the new theme Patch sponsored by the CCSR ( http://www.ccsr.qc.ca ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 8 17:56:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Aug 2012 15:56:37 +0000 Subject: [Koha-bugs] [Bug 8597] New theme for the OPAC with a mobile view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8597 Fr?d?rick Capovilla changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Change sponsored?|--- |Sponsored Assignee|oleonard at myacpl.org |fcapovilla at live.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 8 18:02:13 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Aug 2012 16:02:13 +0000 Subject: [Koha-bugs] [Bug 8597] New theme for the OPAC with a mobile view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8597 --- Comment #2 from Fr?d?rick Capovilla --- Created attachment 11450 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11450&action=edit Add a mobile view for the OPAC using mediaqueries Here is the patch that adds the mobile view for the OPAC. This patch need to be applied after patch 11449. Note : The mobile.css file contains strings that need to be translated into other languages, mainly column names for tables that had to be converted into lists for the mobile view. Last time I checked, the translate.pl script didn't support translations in CSS files, so we must find a way to make those strings translatables. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 8 18:05:20 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Aug 2012 16:05:20 +0000 Subject: [Koha-bugs] [Bug 8598] New: borrower image and home library disappear on Files tab Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8598 Priority: P5 - low Change sponsored?: --- Bug ID: 8598 CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Assignee: koha-bugs at lists.koha-community.org Summary: borrower image and home library disappear on Files tab Severity: normal Classification: Unclassified OS: All Reporter: nengard at gmail.com URL: /cgi-bin/koha/members/files.pl?borrowernumber=52 Hardware: All Status: NEW Version: master Component: Patrons Product: Koha Created attachment 11451 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11451&action=edit patron on all other tabs When looking at patron files the patron's image and home library on the top left disappear. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 8 18:05:40 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Aug 2012 16:05:40 +0000 Subject: [Koha-bugs] [Bug 8598] borrower image and home library disappear on Files tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8598 --- Comment #1 from Nicole C. Engard --- Created attachment 11452 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11452&action=edit patron image on files tab -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 8 18:09:52 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Aug 2012 16:09:52 +0000 Subject: [Koha-bugs] [Bug 8597] New theme for the OPAC with a mobile view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8597 Fr?d?rick Capovilla changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_8 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 8 18:09:52 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Aug 2012 16:09:52 +0000 Subject: [Koha-bugs] [Bug 8594] A report containing a subquery that has a 'limit' will have that limit stripped out In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8594 --- Comment #1 from Robin Sheat --- Created attachment 11453 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11453&action=edit Bug 8594 - prevent the report system from breaking some subqueries If you had a report query that had a subquery in the fields list, and that subquery had a LIMIT specifier, then it would be removed which could break your query. This patch prevents this case from breaking by ensuring that only a LIMIT that follows the last WHERE in the query is removed. If you don't have a WHERE, then it will behave like it always did, removing all the cases of LIMIT (which would still break a subquery but this is a) more rare, and b) would require more intelligent parsing to deal with. Also adds test cases and function documentation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 8 18:11:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Aug 2012 16:11:58 +0000 Subject: [Koha-bugs] [Bug 8594] A report containing a subquery that has a 'limit' will have that limit stripped out In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8594 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 8 18:12:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Aug 2012 16:12:11 +0000 Subject: [Koha-bugs] [Bug 8584] Improve cleanup_database.pl to only purge emails older than X days. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8584 Fr?d?rick Capovilla changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_8 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 8 18:13:31 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Aug 2012 16:13:31 +0000 Subject: [Koha-bugs] [Bug 8594] A report containing a subquery that has a 'limit' will have that limit stripped out In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8594 --- Comment #2 from Robin Sheat --- This also applies cleanly against 3.8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 8 18:16:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Aug 2012 16:16:28 +0000 Subject: [Koha-bugs] [Bug 8598] borrower image and home library disappear on Files tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8598 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 8 18:19:54 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Aug 2012 16:19:54 +0000 Subject: [Koha-bugs] [Bug 8597] New theme for the OPAC with a mobile view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8597 Maxime Pelletier changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pelletiermaxime at gmail.com --- Comment #3 from Maxime Pelletier --- A few notes : The mobile css needs our there to work. You can see what it looks like on one of our installations at https://sherbrooke dot koha.ccsr.qc.ca/. Just resize the window if you want to see the mobile view. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 8 18:22:45 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Aug 2012 16:22:45 +0000 Subject: [Koha-bugs] [Bug 8447] can't save new records / indicator error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8447 wajasu changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matted-34813 at mypacks.net --- Comment #3 from wajasu --- I looked into this. After a Z39.50 search, where I "import" a biblio, and upon "save" this error happens. Reason: With AutoCreateAuthorities = generate AND LinkerOptions containing broader_headings Workaround?: Once I remove broader_headings I can save. But I don't know the ramifications of removing broader_headings. See C4/Linker/Default.pm code related to linking a matched authority. I don't have enough knowledge of indicators to know why they are being copied, but maybe it is related to other side-effects for searches or such. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 8 19:01:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Aug 2012 17:01:57 +0000 Subject: [Koha-bugs] [Bug 8599] New: Amazon Image cover dont display for movie Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8599 Priority: P5 - low Change sponsored?: --- Bug ID: 8599 Assignee: oleonard at myacpl.org Summary: Amazon Image cover dont display for movie Severity: enhancement Classification: Unclassified OS: All Reporter: anthony.laquerre at ccsr.qc.ca Hardware: All Status: NEW Version: rel_3_8 Component: OPAC Product: Koha Image cover seem to work only for books ? I am not able to make it work for movie. From bugzilla-daemon at bugs.koha-community.org Wed Aug 8 19:16:54 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Aug 2012 17:16:54 +0000 Subject: [Koha-bugs] [Bug 8599] Amazon Image cover dont display for movie In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8599 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_8 |master --- Comment #1 from Jared Camins-Esakov --- The cover image code currently works only with ISBNs, which are stored in 020$a in MARC21. I imagine it would probably be possible to teach the cover image code to try other standard identifiers too, but at the moment the system does not. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 8 19:29:32 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Aug 2012 17:29:32 +0000 Subject: [Koha-bugs] [Bug 8599] Amazon Image cover dont display for movie In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8599 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #2 from Owen Leonard --- To be very specific, the image code only works with ISBNs because the image path for Amazon covers contains the actual ISBN: http://images.amazon.com/images/P/0385334206.01.MZZZZZZZ.jpg ...where 0385334206 is the ISBN. > CUP in that case is : 841887006255 > And if I search it in Amazon the movie exist... > > See : > http://www.amazon.ca/s/ref=nb_sb_noss?url=search-alias%3Daps&field- > keywords=841887006255&x=0&y=0 In cases like the above example where there isn't an ISBN, Amazon links the image using their own number, ASIN: http://images.amazon.com/images/P/B000CPHAA6.01.MZZZZZZZ.jpg There isn't any way to guess that number based on standard bibliographic information, and anyway the number wouldn't be valid for pulling the cover from other sources like Google Books or OpenLibrary. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 8 19:38:54 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Aug 2012 17:38:54 +0000 Subject: [Koha-bugs] [Bug 8600] New: Remove search terms in advanced search Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8600 Priority: P5 - low Change sponsored?: Sponsored Bug ID: 8600 Assignee: oleonard at myacpl.org Summary: Remove search terms in advanced search Severity: enhancement Classification: Unclassified OS: All Reporter: pelletiermaxime at gmail.com Hardware: All Status: NEW Version: master Component: OPAC Product: Koha Patch attached adds in [-] in the advanced search page before the [+] to allow to remove search terms. To test click on the More options link in the advanced search page. Patch sponsored by the CCSR ( http://www.ccsr.qc.ca ). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 8 19:44:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Aug 2012 17:44:33 +0000 Subject: [Koha-bugs] [Bug 8600] Remove search terms in advanced search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8600 --- Comment #1 from Maxime Pelletier --- Created attachment 11454 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11454&action=edit patch to add link to remove a search term -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 8 20:22:01 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Aug 2012 18:22:01 +0000 Subject: [Koha-bugs] [Bug 8549] DataTables upgrade broke display of next/previous buttons in table controls In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8549 --- Comment #2 from Owen Leonard --- Created attachment 11455 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11455&action=edit Bug 8549 - DataTables upgrade broke display of next/previous buttons in table controls When the DataTables plugin was upgraded the DataTables CSS was not updated at the same time, causing problems in the display due to changes in how the plugin works. The DataTables upgrade added text lables to the image-only buttons in order to improve accessibility. This patch revises the CSS and the four_button pager modification to conform with the upgrade. To test, please view tables which use each of three types of pagers: default two-button (ex: circ/pendingreserves), custom four-button (ex: members/readingrec.pl) and full (ex: tools/quotes.pl). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 8 20:22:16 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Aug 2012 18:22:16 +0000 Subject: [Koha-bugs] [Bug 8549] DataTables upgrade broke display of next/previous buttons in table controls In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8549 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 8 20:24:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Aug 2012 18:24:47 +0000 Subject: [Koha-bugs] [Bug 8204] Authority viewer in OPAC ugly, unfriendly, and mostly useless In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8204 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #31 from Nicole C. Engard --- Comment 26 is still an issue in FF on Mac on Master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 8 20:35:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Aug 2012 18:35:25 +0000 Subject: [Koha-bugs] [Bug 8597] New theme for the OPAC with a mobile view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8597 Fr?d?rick Capovilla changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11448|0 |1 is obsolete| | Attachment #11449|0 |1 is obsolete| | --- Comment #4 from Fr?d?rick Capovilla --- Created attachment 11456 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11456&action=edit New theme for the OPAC. New version of the theme patch, based on master this time. Images are now included in the patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 8 20:40:46 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Aug 2012 18:40:46 +0000 Subject: [Koha-bugs] [Bug 8597] New theme for the OPAC with a mobile view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8597 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 8 21:08:20 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Aug 2012 19:08:20 +0000 Subject: [Koha-bugs] [Bug 8597] New theme for the OPAC with a mobile view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8597 Fr?d?rick Capovilla changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11450|0 |1 is obsolete| | --- Comment #5 from Fr?d?rick Capovilla --- Created attachment 11457 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11457&action=edit Add a mobile view for the OPAC using mediaqueries New version of the mobile patch, based on master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 8 21:13:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Aug 2012 19:13:29 +0000 Subject: [Koha-bugs] [Bug 8597] New theme for the OPAC with a mobile view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8597 Fr?d?rick Capovilla changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11457|0 |1 is obsolete| | --- Comment #6 from Fr?d?rick Capovilla --- Created attachment 11458 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11458&action=edit Add a mobile view for the OPAC using mediaqueries Small correction on the mobile patch, sorry. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 8 23:39:01 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Aug 2012 21:39:01 +0000 Subject: [Koha-bugs] [Bug 8549] DataTables upgrade broke display of next/previous buttons in table controls In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8549 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11455|0 |1 is obsolete| | --- Comment #3 from Chris Cormack --- Created attachment 11459 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11459&action=edit Bug 8549 - DataTables upgrade broke display of next/previous buttons in table controls When the DataTables plugin was upgraded the DataTables CSS was not updated at the same time, causing problems in the display due to changes in how the plugin works. The DataTables upgrade added text lables to the image-only buttons in order to improve accessibility. This patch revises the CSS and the four_button pager modification to conform with the upgrade. To test, please view tables which use each of three types of pagers: default two-button (ex: circ/pendingreserves), custom four-button (ex: members/readingrec.pl) and full (ex: tools/quotes.pl). Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 8 23:40:07 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Aug 2012 21:40:07 +0000 Subject: [Koha-bugs] [Bug 8549] DataTables upgrade broke display of next/previous buttons in table controls In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8549 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |chris at bigballofwax.co.nz --- Comment #4 from Chris Cormack --- Fix works well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 00:20:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Aug 2012 22:20:35 +0000 Subject: [Koha-bugs] [Bug 7417] Include alternate forms from authorities in bibliographic searches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7417 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11393|0 |1 is obsolete| | Attachment #11427|0 |1 is obsolete| | Attachment #11441|0 |1 is obsolete| | --- Comment #36 from Jared Camins-Esakov --- Created attachment 11460 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11460&action=edit Bug 7417 follow-up: incorporate QA comments This patch incorporates the following QA comments: * Renames Koha::Authority to Koha::DataObject::Authority * Uses Modern::Perl instead of 'use strict; use warnings;' * perltidied all new files again * wrote an intelligent constructor for Koha::DataObject::Authority which takes a hash with the construction criteria * added rudimentary error handling in C4::AuthoritiesMarc::GetAuthority * added missing t/AuthoritiesMarc.t This patch also improves test coverage, and eliminates the need for a database to test the EmbedSeeFromHeadings RecordProcessor plugin. In order to make the Koha codebase more consistent, this patch switches the RecordProcessor and Koha::DataObject::Authority code to use the Moose-like syntax supported by Class::Accessor. Squashed follow-up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 01:44:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Aug 2012 23:44:09 +0000 Subject: [Koha-bugs] [Bug 8601] New: Allow more pictures on Patron Cards Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8601 Priority: P5 - low Change sponsored?: --- Bug ID: 8601 Assignee: cnighswonger at foundations.edu Summary: Allow more pictures on Patron Cards Severity: enhancement Classification: Unclassified OS: All Reporter: derrynj at gmail.com Hardware: All Status: NEW Version: rel_3_8 Component: Label printing Product: Koha Currently there is only 2 pictures allowed on patron card. This is acceptable, however it would be nice to be able to add more with an "add another image" button or something along those lines. At the very least, could we free up a custom image by making the patron image a separate component? I've tried adding extra images to the XML code in the database, and it seems to work just by incrementing the image number value. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 01:44:51 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Aug 2012 23:44:51 +0000 Subject: [Koha-bugs] [Bug 8293] Software error when clicking on first or last result of each page on OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8293 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #2 from Chris Cormack --- I can't reproduce this error Here's what I did Search for fish Click on the 20th result .. no error Click on to page 2 Click on the first result ... no error What am I doing wrong? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 01:54:44 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Aug 2012 23:54:44 +0000 Subject: [Koha-bugs] [Bug 8602] New: Patron card creator - 'Units' don't stick in layouts Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8602 Priority: P5 - low Change sponsored?: --- Bug ID: 8602 Assignee: cnighswonger at foundations.edu Summary: Patron card creator - 'Units' don't stick in layouts Severity: normal Classification: Unclassified OS: All Reporter: derrynj at gmail.com Hardware: All Status: NEW Version: rel_3_8 Component: Label printing Product: Koha To reproduce: 1. Create a new layout 2. Change Units to SI Millimeters 3. Save 4. Edit the same layout 5. It's back to PostScript Points This bug could be related http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5181 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 01:58:01 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Aug 2012 23:58:01 +0000 Subject: [Koha-bugs] [Bug 8603] New: Patron card creator - 'Barcode Type' don't stick in layouts Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8603 Priority: P5 - low Change sponsored?: --- Bug ID: 8603 Assignee: cnighswonger at foundations.edu Summary: Patron card creator - 'Barcode Type' don't stick in layouts Severity: minor Classification: Unclassified OS: All Reporter: derrynj at gmail.com Hardware: All Status: NEW Version: rel_3_8 Component: Label printing Product: Koha To reproduce: 1. Make a new layout 2. Tick "Print card number as barcode" 3. Change 'Barcode Type' to anything other than Code39 4. Save 5. Edit it again 6. Its back to Code39 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 01:58:56 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Aug 2012 23:58:56 +0000 Subject: [Koha-bugs] [Bug 8603] Patron card creator - 'Barcode Type' doesn't stick in layouts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8603 Derryn changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Patron card creator - |Patron card creator - |'Barcode Type' don't stick |'Barcode Type' doesn't |in layouts |stick in layouts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 02:26:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 00:26:27 +0000 Subject: [Koha-bugs] [Bug 8378] syntax not working on overdues anymore In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8378 Derryn changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |derrynj at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 02:45:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 00:45:41 +0000 Subject: [Koha-bugs] [Bug 8293] Software error when clicking on first or last result of each page on OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8293 --- Comment #3 from Jared Camins-Esakov --- The fix for this was pushed several months ago. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 02:49:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 00:49:47 +0000 Subject: [Koha-bugs] [Bug 8293] Software error when clicking on first or last result of each page on OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8293 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #4 from Chris Cormack --- No wonder I can't recreate this, were you testing on master Fridolyn ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 03:56:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 01:56:35 +0000 Subject: [Koha-bugs] [Bug 8586] Small bug in die if no mapping in framework for biblioitems.biblioitemnumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8586 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11414|0 |1 is obsolete| | --- Comment #3 from Chris Cormack --- Created attachment 11461 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11461&action=edit Bug 8586: Small bug in die if no mapping in framework for biblioitems.biblioitemnumber Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 03:56:52 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 01:56:52 +0000 Subject: [Koha-bugs] [Bug 8586] Small bug in die if no mapping in framework for biblioitems.biblioitemnumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8586 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 06:01:03 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 04:01:03 +0000 Subject: [Koha-bugs] [Bug 8593] Add unique IDs to pending approval markup on staff client home page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8593 Jorgia changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jorgia_m_kelsey at hotmail.com |ity.org | --- Comment #3 from Jorgia --- Created attachment 11462 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11462&action=edit edited intranet-main file (box version) version of home page with edited suggestions pending w box around "suggestions pending" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 06:29:53 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 04:29:53 +0000 Subject: [Koha-bugs] [Bug 8593] Add unique IDs to pending approval markup on staff client home page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8593 --- Comment #4 from Jorgia --- Created attachment 11463 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11463&action=edit edited intranet-main file (without box version) Main staff page css script. Version of suggestions pending layout 2. (without box surrounding "suggestions pending" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 06:36:44 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 04:36:44 +0000 Subject: [Koha-bugs] [Bug 8593] Add unique IDs to pending approval markup on staff client home page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8593 Jorgia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11443|0 |1 is obsolete| | --- Comment #5 from Jorgia --- Created attachment 11464 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11464&action=edit signed off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 06:46:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 04:46:33 +0000 Subject: [Koha-bugs] [Bug 7417] Include alternate forms from authorities in bibliographic searches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7417 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11460|0 |1 is obsolete| | --- Comment #37 from Katrin Fischer --- Created attachment 11465 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11465&action=edit [SIGNED-OFF] Bug 7417 follow-up: incorporate QA comments This patch incorporates the following QA comments: * Renames Koha::Authority to Koha::DataObject::Authority * Uses Modern::Perl instead of 'use strict; use warnings;' * perltidied all new files again * wrote an intelligent constructor for Koha::DataObject::Authority which takes a hash with the construction criteria * added rudimentary error handling in C4::AuthoritiesMarc::GetAuthority * added missing t/AuthoritiesMarc.t This patch also improves test coverage, and eliminates the need for a database to test the EmbedSeeFromHeadings RecordProcessor plugin. In order to make the Koha codebase more consistent, this patch switches the RecordProcessor and Koha::DataObject::Authority code to use the Moose-like syntax supported by Class::Accessor. Signed-off-by: Katrin Fischer Follow up passes test plan. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 06:46:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 04:46:57 +0000 Subject: [Koha-bugs] [Bug 7417] Include alternate forms from authorities in bibliographic searches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7417 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 06:53:56 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 04:53:56 +0000 Subject: [Koha-bugs] [Bug 8593] Add unique IDs to pending approval markup on staff client home page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8593 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11462|0 |1 is obsolete| | --- Comment #6 from Chris Cormack --- Created attachment 11466 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11466&action=edit bug 8593: css file for the box version of "suggestions pending" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 07:03:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 05:03:33 +0000 Subject: [Koha-bugs] [Bug 5327] Unit tests required for all C4 modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 --- Comment #208 from Bart Jorgensen --- Created attachment 11467 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11467&action=edit Added fake db and a test -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 07:07:08 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 05:07:08 +0000 Subject: [Koha-bugs] [Bug 8593] Add unique IDs to pending approval markup on staff client home page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8593 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11463|0 |1 is obsolete| | --- Comment #7 from Chris Cormack --- Created attachment 11468 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11468&action=edit Bug 8593. css script version of "suggestions pending" without box -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 07:24:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 05:24:28 +0000 Subject: [Koha-bugs] [Bug 5327] Unit tests required for all C4 modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11339|0 |1 is obsolete| | Attachment #11340|0 |1 is obsolete| | Attachment #11341|0 |1 is obsolete| | Attachment #11440|0 |1 is obsolete| | Attachment #11467|0 |1 is obsolete| | --- Comment #209 from Katrin Fischer --- Created attachment 11469 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11469&action=edit [SIGNED-OFF] Bug 5327 : Added a few more lines of code to the ItemType.t unit test Signed-off-by: Jared Camins-Esakov Signed-off-by: Chris Cormack Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 07:24:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 05:24:47 +0000 Subject: [Koha-bugs] [Bug 5327] Unit tests required for all C4 modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 --- Comment #210 from Katrin Fischer --- Created attachment 11470 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11470&action=edit [SIGNED-OFF] Bug 5327 follow-up: add DBD::Mock dependency In order for the awesome new t/ItemType.t test to work, we need DBD::Mock. Signed-off-by: Chris Cormack Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 07:24:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 05:24:57 +0000 Subject: [Koha-bugs] [Bug 5327] Unit tests required for all C4 modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 --- Comment #211 from Katrin Fischer --- Created attachment 11471 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11471&action=edit [SIGNED-OFF] Bug 5327 Tests for C4::Matcher Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 07:25:08 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 05:25:08 +0000 Subject: [Koha-bugs] [Bug 5327] Unit tests required for all C4 modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 --- Comment #212 from Katrin Fischer --- Created attachment 11472 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11472&action=edit [SIGNED-OFF] Added and tested a mock-db tested a couple of features http://bugs.koha-community.org/show_bug.cgi?id=5327 Signed-off-by: Katrin Fischer All tests pass! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 07:25:19 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 05:25:19 +0000 Subject: [Koha-bugs] [Bug 5327] Unit tests required for all C4 modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 --- Comment #213 from Katrin Fischer --- Created attachment 11473 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11473&action=edit [SIGNED-OFF] Added a mock-db table and tested a line http://bugs.koha-community.org/show_bug.cgi?id=5327 Signed-off-by: Katrin Fischer All tests pass! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 08:09:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 06:09:33 +0000 Subject: [Koha-bugs] [Bug 8210] Headings in OPAC bib details should link to authority record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8210 --- Comment #2 from Katrin Fischer --- Created attachment 11474 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11474&action=edit screenshot Hi Jared, features works nicely. Only request I have is a little space between the magnifying glass and the term. I think we are also missing a space between the relator code and the term, but this can go on a separate bug. I love that the icon has a class, so I can hide it if a library doesn't like it: .authlink {display:none;} -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 08:46:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 06:46:37 +0000 Subject: [Koha-bugs] [Bug 8604] New: Patron cards made for patrons which don't have patron images use preceding card's image Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 Priority: P5 - low Change sponsored?: --- Bug ID: 8604 Assignee: cnighswonger at foundations.edu Summary: Patron cards made for patrons which don't have patron images use preceding card's image Severity: normal Classification: Unclassified OS: All Reporter: derrynj at gmail.com Hardware: All Status: NEW Version: rel_3_8 Component: Label printing Product: Koha Steps to reproduce: 1. In the patron creator, set up a layout with patron images enabled 2. Create a batch starting with a patron that does NOT have a picture stored 3. Next choose one that DOES 4. Finally choose one that does NOT 5. Export the batch 6. Resulting PDF will show i) the first one is correct (no picture) ii) the second one will correctly show it's own picture iii) the third one will (incorrectly) show the previous patron's picture -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 09:41:59 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 07:41:59 +0000 Subject: [Koha-bugs] [Bug 8587] Add a serial lifespan to serial subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8587 --- Comment #9 from Jonathan Druart --- (In reply to comment #7) > I have to disagree on this. I don't think hardcoding the number and just > translating the word year/years is the right way to go. I'm sure there's a > language out there where the number is after or something like that. I think it is possible to do that when you translate your po file. > I don't understand bug 8407. Maybe translation for [IF] inside options is > broken inside loops, but it's working for me in this patch. Yes, it works :) But the problem is the script xt/tt_valid.t does not accept this syntax. Then the test fails. > > 3/ Fonctionnaly what is the goal of this field? Indeed, you don't use this > > field, just store and display. > > Good question. We use it with a saved sql report here attached. Anyway I > wasn't really expecting this to be accepted. I think i'm fine leaving it > here as Failed QA and to be an option if something needs it. humm... ok :) But if this development is useful for some people it is a good idea to include it into Koha. Chris, what do you think about this development ? Do you think we want it ? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 09:53:42 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 07:53:42 +0000 Subject: [Koha-bugs] [Bug 8293] Software error when clicking on first or last result of each page on OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8293 --- Comment #5 from Fridolyn SOMERS --- I'm up to date on master : v3.09.00.030. I forgot to say you must activate 'OpacBrowseResults' syspref. I user Koha sandbox n?2 database. @Jared Camins-Esakov : Do you know which bug/commit ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 09:56:26 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 07:56:26 +0000 Subject: [Koha-bugs] [Bug 7417] Include alternate forms from authorities in bibliographic searches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7417 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #38 from Jonathan Druart --- All QA remarks has been integrated in last patch. Marked as Passed QA Jared and Katrin, thank you for your reactivity :-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 10:11:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 08:11:10 +0000 Subject: [Koha-bugs] [Bug 7560] SIP Self Checkout Ignoring Fines Thresholds for Not Being able to Check Out Books In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7560 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7772|0 |1 is obsolete| | --- Comment #2 from Chris Cormack --- Created attachment 11475 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11475&action=edit Bug 7560 - SIP Self Checkout Ignoring Fines Thresholds for Not Being able to Check Out Books Add checks in C4::ILS::Patron and C4::ILS::Transaction::Renew to make sure the patron is below the noissuescharge system pref for issues and OPACFineNoRenewals for renewals. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 10:12:03 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 08:12:03 +0000 Subject: [Koha-bugs] [Bug 8590] checked out from missing on patron detail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8590 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart at biblibre.co | |m --- Comment #4 from Jonathan Druart --- QA Comments: Works as expected, simple patch. Marked as Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 10:14:04 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 08:14:04 +0000 Subject: [Koha-bugs] [Bug 7560] SIP Self Checkout Ignoring Fines Thresholds for Not Being able to Check Out Books In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7560 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 10:30:45 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 08:30:45 +0000 Subject: [Koha-bugs] [Bug 6273] SIP2 Fee Paid and Fee Paid Response support In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6273 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6539|0 |1 is obsolete| | --- Comment #2 from Chris Cormack --- Created attachment 11476 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11476&action=edit Bug 6273: Add support for recording SIP2 Fee Paid Payment Type Adds support for recording in Koha accountlines a different accounttype depending on how the fee was paid at the SIP2 station (cash, credit, etc) Adds a new param to recordpayment(), $sip_paytype, which is appended to the 'Pay' type if present. The payment descriptin is also appended with " (via SIP2)" if this is present. In order for other scripts to keep working as expected, "eq 'Pay'" needed to be replaced with a regex comparison "=~ /^Pay/", so that 'Pay' and 'Pay-##' would continue to group together. To test: 1. Make a payment over a SIP2 connection 2. Check the patron record in the staff client; you should see the modified description 3. Attempt to print a invoice or a reciept for the borrower; the payment should show up where expected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 10:31:22 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 08:31:22 +0000 Subject: [Koha-bugs] [Bug 6273] SIP2 Fee Paid and Fee Paid Response support In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6273 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #3 from Chris Cormack --- I had to rebase and fix a conflict, not sure I got it right. So I would like someone else to sign off please. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 10:31:38 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 08:31:38 +0000 Subject: [Koha-bugs] [Bug 6832] Validation of total > budget in neworderempty In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6832 --- Comment #13 from Jonathan Druart --- QA Comments: It seems the patch does not work as expected. I think your ajax script must to return $budget->{budget_amount} - C4::Budgets::GetBudgetSpent($budget->{id}) (or GetBudgetOrdered ?). -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 10:32:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 08:32:14 +0000 Subject: [Koha-bugs] [Bug 6832] Validation of total > budget in neworderempty In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6832 --- Comment #14 from Jonathan Druart --- Hum... In fact, it is the current behaviour in master ! Do you confirm it is what we want ? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 11:14:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 09:14:47 +0000 Subject: [Koha-bugs] [Bug 8485] Make koha_perl_deps.pl batch friendly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8485 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart at biblibre.co | |m QA Contact| |jonathan.druart at biblibre.co | |m --- Comment #6 from Jonathan Druart --- QA comments: Works as expected, marked as Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 11:24:17 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 09:24:17 +0000 Subject: [Koha-bugs] [Bug 8590] checked out from missing on patron detail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8590 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #5 from Chris Cormack --- Pushed to 3.8.x, will be in 3.8.4 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 11:30:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 09:30:37 +0000 Subject: [Koha-bugs] [Bug 7973] Allow for new type of LDAP authentication In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7973 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 11:35:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 09:35:58 +0000 Subject: [Koha-bugs] [Bug 8524] Add barcode plugin that does not autofill In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8524 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart at biblibre.co | |m --- Comment #4 from Jonathan Druart --- You plan 15 tests in t/Barcodes_ValueBuilder.t but only 10 are run. You can replace use Test::More tests => 15; with use Test::More; and at the end of the file: done_testing; or use Test::More tests => 15; => use Test::More tests => 10; + 2 warnings: t/Barcodes_ValueBuilder.t .. 1/15 Use of uninitialized value $scr in numeric eq (==) at t/Barcodes_ValueBuilder.t line 43. C4::Barcodes::ValueBuilder::incremental::get_barcode returns 1 results not 2. $src is always undefined. Same thing for C4::Barcodes::ValueBuilder::annual::get_barcode Marking as Failed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 11:38:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 09:38:24 +0000 Subject: [Koha-bugs] [Bug 7751] Decrease loan period on items with a high number of holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7751 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10204|0 |1 is obsolete| | --- Comment #25 from Chris Cormack --- Created attachment 11477 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11477&action=edit Bug 7751 : Fix a couple of comparisons in C4::Circulation Changed a string comparison called on an integer Deal with case where value is not set without runtime warnings This is dependent on bug 5549 Signed-off-by: Martin Renvoize Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 11:38:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 09:38:37 +0000 Subject: [Koha-bugs] [Bug 8513] OPAC detail page broken with XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8513 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 11:39:15 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 09:39:15 +0000 Subject: [Koha-bugs] [Bug 7751] Decrease loan period on items with a high number of holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7751 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 11:47:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 09:47:43 +0000 Subject: [Koha-bugs] [Bug 7751] Decrease loan period on items with a high number of holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7751 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10204|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 11:48:05 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 09:48:05 +0000 Subject: [Koha-bugs] [Bug 7751] Decrease loan period on items with a high number of holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7751 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11477|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 11:48:17 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 09:48:17 +0000 Subject: [Koha-bugs] [Bug 7751] Decrease loan period on items with a high number of holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7751 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 11:52:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 09:52:33 +0000 Subject: [Koha-bugs] [Bug 8513] OPAC detail page broken with XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8513 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11378|0 |1 is obsolete| | --- Comment #5 from Chris Cormack --- Created attachment 11478 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11478&action=edit Bug 8513: OPAC detail page broken with XSLT Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 12:06:54 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 10:06:54 +0000 Subject: [Koha-bugs] [Bug 8572] Attempting to view an invalid authority in the OPAC gives an error instead of 404 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8572 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart at biblibre.co | |m --- Comment #3 from Jonathan Druart --- QA comments: It would have been more user-friendly to display an adapted error for this case. But Koha does not have a simply way to send messages (infos, warnings, errors) to the templates. So, I mark as Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 12:07:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 10:07:47 +0000 Subject: [Koha-bugs] [Bug 8572] Attempting to view an invalid authority in the OPAC gives an error instead of 404 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8572 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 12:09:00 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 10:09:00 +0000 Subject: [Koha-bugs] [Bug 8172] Missing dereference marker for buildQuery parameter in addbooks.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8172 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact| |jonathan.druart at biblibre.co | |m --- Comment #6 from Jonathan Druart --- Simple patch, Marked as Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 12:19:30 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 10:19:30 +0000 Subject: [Koha-bugs] [Bug 8572] Attempting to view an invalid authority in the OPAC gives an error instead of 404 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8572 --- Comment #4 from Chris Cormack --- Pushed to 3.8.x, will be in 3.8.4 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 13:02:38 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 11:02:38 +0000 Subject: [Koha-bugs] [Bug 8605] New: cs-CZ: Filesystem sent error: No such file or directory Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8605 Priority: P1 - high Change sponsored?: --- Bug ID: 8605 CC: frederic at tamil.fr Assignee: koha-bugs at lists.koha-community.org Summary: cs-CZ: Filesystem sent error: No such file or directory Severity: blocker Classification: Unclassified OS: All Reporter: black23 at gmail.com URL: http://translate.koha-community.org/cs/38/ Hardware: All Status: NEW Version: rel_3_8 Component: translate.koha-community.org Product: Koha If we can (download) upload files (from) into translation Project, we get error: Error accessing /home/koha/Pootle-2.1.6/po/38/cs, Filesystem sent error: No such file or directory -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 13:37:01 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 11:37:01 +0000 Subject: [Koha-bugs] [Bug 7679] stat wizrad: circulation (new filters) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt at gmail.com |julian.maurice at biblibre.com --- Comment #1 from Julian Maurice --- Created attachment 11479 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11479&action=edit Bug 7679: circulation statistics wizard improvements - Add patron branch to the list of possible rows, columns, and filters - Add extended patron attributes to the list of possible rows, columns, and filters - Allow to group period by hour - Allow to translate filter names -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 13:40:30 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 11:40:30 +0000 Subject: [Koha-bugs] [Bug 8210] Headings in OPAC bib details should link to authority record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8210 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11359|0 |1 is obsolete| | --- Comment #3 from Jared Camins-Esakov --- Created attachment 11480 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11480&action=edit Bug 8210: add links to authorities to headings in OPAC At the moment, there is no way to get to an authority record from a bib record that uses it other than doing a new search on the authority file. This patch adds a link (a cute little magnifying glass) to linked authority records on the OPAC detail view for MARC21 and NORMARC with XSLT enabled. A follow-up patch will add the link to regular mode. Because UNIMARC handles authorities differently, the link is not added to the XSLT. Test plan: 1) Set OPACXSLTDetailsDisplay to 'default' 2) View a record that has some headings that are linked to authority records in the OPAC (easiest way to find a record like that is to edit a record and add some headings using the thesaurus plugin) 3) Observe the cute little magnifying glass links to the authority. Revised version of the patch adds a space between the heading and the magnifying glass. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 13:47:13 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 11:47:13 +0000 Subject: [Koha-bugs] [Bug 8419] Suspended holds appear on the daily holds queue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8419 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart at biblibre.co | |m --- Comment #4 from Jonathan Druart --- QA Comments: Seems good for me, marking as Passed QA. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 13:47:22 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 11:47:22 +0000 Subject: [Koha-bugs] [Bug 8419] Suspended holds appear on the daily holds queue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8419 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 13:47:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 11:47:29 +0000 Subject: [Koha-bugs] [Bug 8524] Add barcode plugin that does not autofill In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8524 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 13:47:31 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 11:47:31 +0000 Subject: [Koha-bugs] [Bug 8524] Add barcode plugin that does not autofill In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8524 --- Comment #5 from Jared Camins-Esakov --- Created attachment 11481 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11481&action=edit Bug 8524 follow-up: fix broken test The t/Barcodes_ValueBuilder.t test had the wrong number of tests declared, and rather than checking that a variable was undefined I was checking that it had a length of zero. Fixed both issues. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 13:52:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 11:52:27 +0000 Subject: [Koha-bugs] [Bug 8575] Number of items expected is wrong In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8575 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart at biblibre.co | |m QA Contact| |jonathan.druart at biblibre.co | |m --- Comment #3 from Jonathan Druart --- Seems logical. Marked as Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 13:55:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 11:55:29 +0000 Subject: [Koha-bugs] [Bug 8606] New: Talking Tech broken by Bug 7001 Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8606 Priority: P5 - low Change sponsored?: --- Bug ID: 8606 Assignee: koha-bugs at lists.koha-community.org Summary: Talking Tech broken by Bug 7001 Severity: enhancement Classification: Unclassified OS: All Reporter: kyle at bywatersolutions.com Hardware: All Status: NEW Version: master Component: Notices Product: Koha The patches for bug 7001 removed the parseletter subroutine from C4::Letters without updating the talking tech script to use the new alternative. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 13:56:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 11:56:47 +0000 Subject: [Koha-bugs] [Bug 8606] Talking Tech broken by Bug 7001 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8606 --- Comment #1 from Kyle M Hall --- Created attachment 11482 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11482&action=edit Bug 8606 - Talking Tech broken by Bug 7001 The patches for bug 7001 removed the parseletter subroutine from C4::Letters without updating the talking tech script to use the new alternative. This patch rectifies that situation. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 13:57:02 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 11:57:02 +0000 Subject: [Koha-bugs] [Bug 8606] Talking Tech broken by Bug 7001 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8606 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 13:58:44 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 11:58:44 +0000 Subject: [Koha-bugs] [Bug 8606] Talking Tech broken by Bug 7001 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8606 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11482|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 11483 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11483&action=edit Bug 8606 - Talking Tech broken by Bug 7001 The patches for bug 7001 removed the parseletter subroutine from C4::Letters without updating the talking tech script to use the new alternative. This patch rectifies that situation. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 14:03:31 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 12:03:31 +0000 Subject: [Koha-bugs] [Bug 8524] Add barcode plugin that does not autofill In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8524 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11481|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 11484 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11484&action=edit Bug 8524 follow-up: fix broken test The t/Barcodes_ValueBuilder.t test had the wrong number of tests declared, and rather than checking that a variable was undefined I was checking that it had a length of zero. Fixed both issues. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 14:03:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 12:03:39 +0000 Subject: [Koha-bugs] [Bug 8440] Dates does not appear in suggestions management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8440 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact| |jonathan.druart at biblibre.co | |m --- Comment #10 from Jonathan Druart --- QA Comments: Make strings consistent. Marked as Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 14:04:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 12:04:14 +0000 Subject: [Koha-bugs] [Bug 8524] Add barcode plugin that does not autofill In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8524 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 14:07:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 12:07:39 +0000 Subject: [Koha-bugs] [Bug 8534] Remove unused variable from memberentry template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8534 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 14:08:20 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 12:08:20 +0000 Subject: [Koha-bugs] [Bug 8524] Add barcode plugin that does not autofill In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8524 --- Comment #7 from Jonathan Druart --- Created attachment 11485 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11485&action=edit Bug 8524: Followup FIX an undeclared variable $query -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 14:13:26 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 12:13:26 +0000 Subject: [Koha-bugs] [Bug 7419] Add authority deduplication script In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7419 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11412|0 |1 is obsolete| | --- Comment #9 from Julian Maurice --- Created attachment 11486 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11486&action=edit Bug 7419: Move indexation subs in C4::ZebraIndex Move indexation-related subs from rebuild_zebra.pl to new module C4::ZebraIndex and create two new subs IndexRecord and DeleteRecordIndex -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 14:15:12 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 12:15:12 +0000 Subject: [Koha-bugs] [Bug 7419] Add authority deduplication script In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7419 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11486|0 |1 is obsolete| | --- Comment #10 from Julian Maurice --- Created attachment 11487 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11487&action=edit Bug 7419: Move indexation subs in C4::ZebraIndex Move indexation-related subs from rebuild_zebra.pl to new module C4::ZebraIndex and create two new subs IndexRecord and DeleteRecordIndex -- Same patch as above, but with the right commit message. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 14:16:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 12:16:29 +0000 Subject: [Koha-bugs] [Bug 7419] Add authority deduplication script In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7419 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11413|0 |1 is obsolete| | --- Comment #11 from Julian Maurice --- Created attachment 11488 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11488&action=edit Bug 7419: New script dedup_authorities.pl It works this way: 1) authorities are fetched from the database. You can limit fetched results by authtypecode, or directly by specifying WHERE clause 2) for each authority: 2.1) build a Zebra query, depending on --match parameter(s) 2.2) run the query, retrieve the results 2.3) for each result check if result is really a duplicate. check is customizable with option --check. 2.4) among real duplicates, choose the one we want to keep (use --choose-method option). 2.5) use C4::Authorities::merge to merge authorities 3) index updated biblios and authorities, and remove from index removed authorities Use --help for more informations on options Script is in misc/migration_tools/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 14:18:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 12:18:09 +0000 Subject: [Koha-bugs] [Bug 7419] Add authority deduplication script In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7419 --- Comment #12 from Julian Maurice --- Indexation subs are now in a new module C4::ZebraIndex, instead of C4::Search (better to not "overload" C4::Search). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 14:29:22 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 12:29:22 +0000 Subject: [Koha-bugs] [Bug 8524] Add barcode plugin that does not autofill In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8524 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #8 from Jonathan Druart --- Jared, Sorry, but another problem already exists. When I click twice on '...' to fill with the barcode value, a JS error occured: "force is not defined". The issue only exist for the plugin barcode_manual.pl. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 14:32:16 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 12:32:16 +0000 Subject: [Koha-bugs] [Bug 8524] Add barcode plugin that does not autofill In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8524 --- Comment #9 from Jared Camins-Esakov --- (In reply to comment #8) > Jared, > Sorry, but another problem already exists. When I click twice on '...' to > fill with the barcode value, a JS error occured: "force is not defined". > The issue only exist for the plugin barcode_manual.pl. Ooh, good test. It never occurred to me to click twice. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 14:34:18 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 12:34:18 +0000 Subject: [Koha-bugs] [Bug 4045] No check for maximum number of allowed holds. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4045 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #40 from Julian Maurice --- Liz, the patch you submitted only removes an empty line. Is it the patch you wanted to submit? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 14:36:15 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 12:36:15 +0000 Subject: [Koha-bugs] [Bug 7688] Change subscriptions numbering pattern and frequencies In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688 --- Comment #36 from Kyle M Hall --- Created attachment 11489 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11489&action=edit Bug 7688: Change subscription numbering pattern and frequencies Serials numbering pattern and frequencies are no more hard-coded. Now it's possible to create, edit and delete numbering patterns (and frequencies). This implies new sql tables (subscription_numberpatterns and subscription_frequencies) Numbering patterns behave almost as before, there are still the same values to configure (addX, everyX, settoX, whenmorethanX). lastvalueX and innerloopX remain in subscription tables. There is a new value in numbering patterns: numberingX. For each "column" (X, Y or Z) you can tell how to format the number. Actually numberingX can be set to: - 'dayname' (name of the day) (0-6 or 1-7 depending on which day is the first of the week) - 'monthname' (name of the month) (0-11) - 'season' (name of the season) (0-3) (0 is Spring) These names are localized by using POSIX::setlocale and POSIX::strftime and setting a 'locale' value to the subscription. Locale have to be installed on the system. Note that season names are not localized using POSIX::strftime (it can't do this), so names are hardcoded into the code (available languages: en, fr). This could be fixed in the future by using a Perl localization framework. Frequencies can be configured using 3 parameters: - 'unit': one of 'day', 'week', 'month', 'year' - 'issuesperunit': integer >= 1, the number of received issues per 'unit' - 'unitsperissue': integer >= 1, the number of 'unit' between two issues One of 'issuesperunit' and 'unitsperissue' must be equal to 1. Examples: unit = 'day', issuesperunit=3, unitsperissue=1 => 3 issues per day unit = 'week', issuesperunit=1, unitsperissue=3 => 1 issue each 3 weeks Prediction pattern is now computed server-side and is more consistent with what Koha will do. The publication date is displayed alongside the serial number. Irregularities can now be checked one by one, in the prediction pattern table, or if frequency is 'day-based' (unit is 'day'), there is the possibility to check all issues for a week day at once. When an irregularity is found, there is the possibility to keep the serial number unchanged, or to skip it. It is configured at subscription creation or modification. For instance, with a daily subscription you can have: skip serial number | keep serial number ----------------------+---------------------- 2012-01-01 ? No 1 | 2012-01-01 ? No 1 2012-01-03 ? No 3 | 2012-01-03 ? No 2 To lighten the subscription modification page, manual history has been moved in its own page subscription-history.pl which is accessible on subscription-detail.pl, tab 'Planning'. Important note: updatedatabase.pl script takes into account existing subscriptions and create appropriate numbering patterns for them (it tries to create as few patterns as possible). Frequency is mapped to the correct entry in subscription_frequencies table. This patch includes kohastructure.sql and updatedatabase.pl changes + sample frequencies data and sample numberpatterns data for fresh installs (sample data is included in updatedatabase.pl) === TEST PLAN: === Create a new subscription: - Go to Serials module and click "New subscription" button - On the first page, choose a biblio and click next to go to the second page - Pick a first issue publication date - Choose frequency '1/day' - Choose a subscription length of 15 issues - Choose a subscription start date - Choose numbering pattern 'Volume, Number' - A table appears, fill 'Begins with' cells with '1' - Click on 'Test prediction pattern' button The prediction pattern is displayed at the right of the page. You can see in it the serial number, the publication date and a checkbox to allow you to choose which serials will not be received (irregularities). You can see that serial number start from "Vol 1, No 1" continue to "Vol 1, No 12" and then restart with "Vol 2, No 1". Frequency is '1/day' so you can see that publication date is incremented by one day line after line. - Now you can play a little with frequencies and numbering patterns, change one of them (or both) and click again on 'Test prediction pattern' - For example, choose frequency '3/weeks' and click on 'Test prediction pattern' button'. There is a little behaviour change compared with current master. Publication date will not be guessed within the week. Koha can't know when you will receive issues. So the publication date stay the same (monday of each week) for 3 consecutive issues and then jump to the next week. - Now choose frequency '1/3 months' and numbering pattern 'Seasonal' - Fill 'Begins with' cells with '2012' for Year and '0' for Season - Click on 'Test prediction pattern' - You should have something like 'Spring 2012', 'Summer 2012', ..., 'Winter 2012', 'Spring 2013' - Note that you can have seasons for south hemisphere by entering '2' in 'Year/Inner counter' - 2nd note: if you have some locales installed on your system, you can type its name in the 'Locale' field (actually it does not work for seasons name, only for month names and day names) If you want to modify the numbering pattern you can still do it here: - Click on 'Show/Hide advanced pattern' link. The advanced pattern table is shown but all fields are readonly - Click on 'Modify pattern' button. All readonly fields are now editable. Note that 'Begins with' and 'Inner counter' line are repeated here and any modifications in the small table will be replicated in the big table, and vice versa. - Pattern name is emptied, if you type a new name, a new pattern will be created, and if you type the same name as an existing numbering pattern, this one will be modified (with a confirmation message) - There is two new lines in this table: - Label: it's what is displayed in the smaller table headers above - Numbering: used to format numbers in different ways. can be 'seasons', 'monthname' or 'dayname'. Month name and day name can be localized using the 'Locale' field. Seasons can't (values for english and french are hard-coded in Serials.pm) - You can modify what you want in the table and click on 'Test prediction pattern' button each time you want to see your modifications. (Note that checkboxes for irregularities aren't displayed in this mode, and you can't save the subscription until you have saved or cancelled your changes). - To cancel your modifications, just click on 'Cancel modifications' button. - To save them, click on 'Save as new pattern'. If the pattern name is already existing, a confirmation box will ask you if you want to modify the existing numbering pattern. Otherwise a new pattern will be created and automatically selected. Once you have finished modifying numbering pattern. You can click again on 'Test prediction pattern' to define irregularities, and then click on 'Save subscription'. Now you can check the serials module still works correctly: - Check the subscription detail page to confirm that nothing is missing. Especially the 'Frequency' and 'Number pattern' infos - Try to receive some issues. Check that the serial number is correctly generated and if irregularities you have defined are taken into account (if you have defined some). - Check that receiving is blocked once you have reached the number of issues you have defined in subscription length (or once you have reached the subscription end date) In serials menu (to the left of almost each page of serials menu) you have two new links: 'Manage frequencies' and 'Manage numbering patterns'. 'Manage numbering patterns' lead to a page which list all numbering patterns and allow you to create, edit or delete them. The interface is almost the same as numbering pattern modification in subscription-add.pl 'Manage frequencies' lead to a page which list all frequencies and allow you to create, edit or delete them. Try to create a new frequency: - Click on 'Manage frequencies' link in the serials menu and then click on 'New frequency': - Fill in the description (mandatory). - Unit is one of 'day', 'week', 'month', year' or 'None' ('None' is for an irregular subscription) - If unit is different from 'None' you have to fill the two following fields (Issues per unit, and Units per issue) - Note that at least one of those must be equal to 1 - Issues per unit is the number of received issues by 'unit' and Units per issue is the number of 'unit' between two issues - Display order is used to build the drop-down list. Leave empty and it will be set to 0 (top of the list) - Then click on 'Save' - Check that this new frequency appears in the frequencies table and in the drop-down list in subscription-add.pl Subscription history has been moved in its own page. To test if it still works, choose a subscription with manual history enabled (or modify an existing subscription to turn on manual history). - On the detail page, tab 'Planning', you should have a link 'Edit history'. - Click on it - Modify history and click on Save - In tab 'Summary' you should have the infos you just entered And finally, you can check that old subscriptions (by old I mean subscriptions that existed before the update) are correctly linked to an existing numbering pattern and an existing frequency. Numbering patterns should be named 'Backup pattern X' where X is a number. Signed-off-by: Fr?d?ric Demians Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 14:36:23 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 12:36:23 +0000 Subject: [Koha-bugs] [Bug 7688] Change subscriptions numbering pattern and frequencies In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688 --- Comment #37 from Kyle M Hall --- Created attachment 11490 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11490&action=edit Bug 7688 follow-up: Small fixes for QA - # Subroutines::ProhibitExplicitReturnUndef: Got 1 violation(s) in C4::Serials::GetSubscriptionIrregularities - Bad template constructions fixed in serials/subscription-add.tt Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 14:36:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 12:36:43 +0000 Subject: [Koha-bugs] [Bug 7688] Change subscriptions numbering pattern and frequencies In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11299|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 14:36:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 12:36:58 +0000 Subject: [Koha-bugs] [Bug 7688] Change subscriptions numbering pattern and frequencies In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11300|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 14:37:06 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 12:37:06 +0000 Subject: [Koha-bugs] [Bug 7688] Change subscriptions numbering pattern and frequencies In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 14:38:38 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 12:38:38 +0000 Subject: [Koha-bugs] [Bug 8524] Add barcode plugin that does not autofill In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8524 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 14:38:40 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 12:38:40 +0000 Subject: [Koha-bugs] [Bug 8524] Add barcode plugin that does not autofill In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8524 --- Comment #10 from Jared Camins-Esakov --- Created attachment 11491 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11491&action=edit Bug 8524 follow-up: fix Javascript syntax error -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 14:43:16 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 12:43:16 +0000 Subject: [Koha-bugs] [Bug 4906] Problem with grace period calculation and fine intervals >1 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4906 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | --- Comment #3 from Kyle M Hall --- Katrin, I was trying to re-assign it to myself, but it looks like I only switched it to the default assignee. I was planning on taking a crack at this. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 14:43:52 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 12:43:52 +0000 Subject: [Koha-bugs] [Bug 4906] Problem with grace period calculation and fine intervals >1 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4906 --- Comment #4 from Kyle M Hall --- Katrin, I was trying to re-assign it to myself, but it looks like I only switched it to the default assignee. I was planning on taking a crack at this, but I have re-assigned it back to you in case you get to it first. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 14:59:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 12:59:41 +0000 Subject: [Koha-bugs] [Bug 8524] Add barcode plugin that does not autofill In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8524 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11491|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart --- Created attachment 11492 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11492&action=edit Bug 8524 follow-up: fix Javascript syntax error Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 15:04:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 13:04:24 +0000 Subject: [Koha-bugs] [Bug 8524] Add barcode plugin that does not autofill In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8524 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 15:04:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 13:04:39 +0000 Subject: [Koha-bugs] [Bug 8524] Add barcode plugin that does not autofill In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8524 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |jonathan.druart at biblibre.co | |m --- Comment #12 from Jonathan Druart --- (In reply to comment #9) > Ooh, good test. It never occurred to me to click twice. I didn't do it on purpose :) I just forgot to reload the page... Marked as Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 15:05:38 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 13:05:38 +0000 Subject: [Koha-bugs] [Bug 8524] Add barcode plugin that does not autofill In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8524 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11484|0 |1 is obsolete| | --- Comment #13 from Kyle M Hall --- Created attachment 11493 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11493&action=edit Bug 8524 follow-up: fix broken test The t/Barcodes_ValueBuilder.t test had the wrong number of tests declared, and rather than checking that a variable was undefined I was checking that it had a length of zero. Fixed both issues. Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 15:06:08 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 13:06:08 +0000 Subject: [Koha-bugs] [Bug 8524] Add barcode plugin that does not autofill In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8524 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11485|0 |1 is obsolete| | --- Comment #14 from Kyle M Hall --- Created attachment 11494 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11494&action=edit Bug 8524: Followup FIX an undeclared variable $query Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 15:06:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 13:06:33 +0000 Subject: [Koha-bugs] [Bug 8524] Add barcode plugin that does not autofill In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8524 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11492|0 |1 is obsolete| | --- Comment #15 from Kyle M Hall --- Created attachment 11495 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11495&action=edit Bug 8524 follow-up: fix Javascript syntax error Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 15:11:05 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 13:11:05 +0000 Subject: [Koha-bugs] [Bug 8573] Translation difficult in picture-upload.tt due to nested sentence in if/foreach/if/elsif - construction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8573 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |julian.maurice at biblibre.com --- Comment #2 from Julian Maurice --- The patch does what it says. But there are 2 typos: Two consecutive tags here: [% ELSIF ( filerror.OPNERR ) %]ERROR: and a remaining WARNING here (one tag should be removed also): [% ELSE %]WARNING:ERROR: -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 15:12:59 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 13:12:59 +0000 Subject: [Koha-bugs] [Bug 8524] Add barcode plugin that does not autofill In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8524 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 15:14:01 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 13:14:01 +0000 Subject: [Koha-bugs] [Bug 8534] Remove unused variable from memberentry template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8534 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED CC| |julian.maurice at biblibre.com --- Comment #5 from Julian Maurice --- I reset the status to ASSIGNED, as the actual patch cannot be signed-off. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 15:17:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 13:17:41 +0000 Subject: [Koha-bugs] [Bug 8524] Add barcode plugin that does not autofill In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8524 --- Comment #16 from Jonathan Druart --- Last question :) Why didn't you remove the other plugin (barcode.pl) ? It seems they do exacly the same (except for $autoBarcodeType eq 'EAN13'). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 15:27:04 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 13:27:04 +0000 Subject: [Koha-bugs] [Bug 8175] Check for something in materials field fails in catalogue/details.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8175 --- Comment #8 from Julian Maurice --- Created attachment 11496 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11496&action=edit Bug 8175 - Check for something in materials field fails in catalogue/details.pl The intent was clearly to know if the materials column should be displayed or not. As such, a defined check handles the NULL, 0, and '0' cases. The string match for /\S/ handles the intent of only displaying the column if is there is text in the materials field. Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 15:27:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 13:27:33 +0000 Subject: [Koha-bugs] [Bug 8175] Check for something in materials field fails in catalogue/details.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8175 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10620|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 15:27:40 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 13:27:40 +0000 Subject: [Koha-bugs] [Bug 8175] Check for something in materials field fails in catalogue/details.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8175 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |julian.maurice at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 15:35:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 13:35:28 +0000 Subject: [Koha-bugs] [Bug 8524] Add barcode plugin that does not autofill In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8524 --- Comment #17 from Jared Camins-Esakov --- (In reply to comment #16) > Last question :) Why didn't you remove the other plugin (barcode.pl) ? It > seems they do exacly the same (except for $autoBarcodeType eq 'EAN13'). barcode.pl works exactly the way it always has: whenever the barcode field has focus, it is populated. For many libraries this is not the desired functionality. barcode_manual.pl will not populate the barcode unless the ellipsis is clicked. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 15:40:22 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 13:40:22 +0000 Subject: [Koha-bugs] [Bug 8607] New: overdue_notices is broken Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8607 Priority: P5 - low Change sponsored?: --- Bug ID: 8607 Assignee: koha-bugs at lists.koha-community.org Summary: overdue_notices is broken Severity: enhancement Classification: Unclassified OS: All Reporter: jonathan.druart at biblibre.com Hardware: All Status: NEW Version: unspecified Component: Notices Product: Koha Bug 7447 introduces a critical bug in overdue_notices.pl The script is unusable. The variable $date is not replaced with its content. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 15:40:30 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 13:40:30 +0000 Subject: [Koha-bugs] [Bug 8607] overdue_notices is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8607 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 15:41:34 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 13:41:34 +0000 Subject: [Koha-bugs] [Bug 8607] overdue_notices is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8607 --- Comment #1 from Jonathan Druart --- Created attachment 11497 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11497&action=edit Bug 8607: FIX overdues_notices script: $date is not replaced -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 15:41:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 13:41:39 +0000 Subject: [Koha-bugs] [Bug 8607] overdue_notices is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8607 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 15:41:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 13:41:47 +0000 Subject: [Koha-bugs] [Bug 8607] overdue_notices is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8607 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |critical -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 15:42:31 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 13:42:31 +0000 Subject: [Koha-bugs] [Bug 7447] Allow to specify a date in overdue_notice.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7447 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #6 from Jonathan Druart --- This patch introduces a bug, see Bug 8607 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 15:48:20 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 13:48:20 +0000 Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 --- Comment #152 from Jonathan Druart --- (subliminal message: test me during the GBSD ;-)) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 16:03:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 14:03:11 +0000 Subject: [Koha-bugs] [Bug 7690] hidelostitems not working in Normal Display In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7690 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|oleonard at myacpl.org |fridolyn.somers at biblibre.co | |m --- Comment #1 from Fridolyn SOMERS --- Created attachment 11498 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11498&action=edit Proposed patch Main problem is that in opac-results.tt, the hidden items are managed in available items loop, but they are in others loop. Second problem is that adding hidden items in other items list will give false lost/damaged/withdrawn/onloan/onhold/... count number. Since these items are not displayed, there is no need to send them to template. So i changed behavior : if item is hidden it is not in item loops. Test plan : ----------- Check display with 'OpacHiddenItems' syspref hidding some items and all items. Check display with 'hidelostitems' syspref hidding some lost items and all items. Combine with and without XSLT. Test with bug 6488 tests : http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6488#c45 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 16:07:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 14:07:39 +0000 Subject: [Koha-bugs] [Bug 4226] bulkmarcimport.pl doesn't replace 001 when keepids is not specified In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4226 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |julian.maurice at biblibre.com --- Comment #9 from Julian Maurice --- Script seems to work as expected, but a few remarks: 1. GetOptions wait for a string after -a and -b parameters, which are boolean flags according to POD 2. --commit option is not used 3. binmode(STDOUT, ":utf8") is doing something strange. date outputs: jeudi 9 ao??t 2012, 15:47:12 (UTC+0200) if i remove binmode line, it looks ok 4. some printed strings have newline at end, some others don't. Some strings are printed only when $verbose is true while others are always printed (can't figure out why). Maybe you should use some wrapper sub like this: sub print_log { print @_, "\n" if $verbose; } 5. italian language (lines 126-127) should be translated. 6. More important: what happens if some ids (authid or biblionumber) are the same when resetting the primary key? I tested this: perl misc/migration_tools/sysno_keeper.pl -a 1 -v -t 009 having 2 records containing the same data in 009 field. Output: 1. dropping primary key for auth_header.authid 2. filling in auth_header.authid... 3. rebuilding primary key for auth_header.authid DBD::mysql::db do failed: ALTER TABLE causes auto_increment resequencing, resulting in duplicate entry '12345678' for key 'PRIMARY' at misc/migration_tools/sysno_keeper.pl line 104. Is there a way to detect such errors and cancel previous modifications ? Failed QA for 1 and 2. A follow-up for 6 would be great! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 16:17:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 14:17:11 +0000 Subject: [Koha-bugs] [Bug 8454] Holds to Pull : Show pull list on load. Otherwise, it looks like the pull list is empty. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8454 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |paul.poulain at biblibre.com --- Comment #2 from Paul Poulain --- Patch tested with a sandbox, by Delaye Stephane -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 16:17:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 14:17:24 +0000 Subject: [Koha-bugs] [Bug 8454] Holds to Pull : Show pull list on load. Otherwise, it looks like the pull list is empty. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8454 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10880|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 16:17:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 14:17:28 +0000 Subject: [Koha-bugs] [Bug 8454] Holds to Pull : Show pull list on load. Otherwise, it looks like the pull list is empty. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8454 --- Comment #3 from Paul Poulain --- Created attachment 11499 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11499&action=edit Bug 8454 - Holds to Pull : Show pull list on load. Otherwise, it looks like the pull list is empty. Currently, when you click "Holds to pull" from the Circulation menu, the only thing that you see is a white screen and a side navigation bar that says "Refine Results". Since there appear to be no results to refine, the holds to pull list appears completely empty. Staff have to know to click "Submit" on the "Refine Results" form to get anything. I propose that we have the "run_report" flag set to ON for the initial load. The report uses the default 2 days mentioned in the "Refine Results" form, so there is continuity across the board. Signed-off-by: Delaye Stephane -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 16:17:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 14:17:41 +0000 Subject: [Koha-bugs] [Bug 8175] Check for something in materials field fails in catalogue/details.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8175 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #9 from Jonathan Druart --- Hi Mark, Could you resubmit your patch after updating your commit message please ? (clarify "As such, a defined check handles the NULL, 0, and '0' cases.") -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 16:18:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 14:18:43 +0000 Subject: [Koha-bugs] [Bug 8112] Overdues with Fines giving duplicates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8112 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #4 from Julian Maurice --- GROUP BY borrowernumber will show only 1 entry by borrowernumber, even if he has fines on several items. Is this what we want? I would suggest to GROUP BY borrowers.borrowernumber, items.itemnumber -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 16:24:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 14:24:43 +0000 Subject: [Koha-bugs] [Bug 8462] OpacHiddenItems and hidelostitems hide items, but query result count is off In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion CC| |fridolyn.somers at biblibre.co | |m --- Comment #1 from Fridolyn SOMERS --- I confirm. The Bug 6488 introduced to hide a record with only hidden items. This concerns only records managed in result page (depends on offset and results per page). But this causes several problems : - search hints (total number of results) returned by Zebra seems false when there are hidden records. That's what reports D Ruth Bavousett. - offset and results per page does not correspond to results displayed when there are hidden records. There can be only 2 results displayed in first page with a 20 results per page and clicking on next page will be offset=20. - when there is only one result and this one is hidden, leads to a 404 error page. (Because test is based on zebra total hints). Note that hiding records in OPAC can be managed with OpacSuppress syspref. In this case Zebra does not return hidden records, so everything is correct. So can we keep this feature ? I seems very difficult to correct. I had the idea to perform hidden test during Zebra indexing to set OPAC suppress flag but this will cause a longer indexing (due to database queries). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 16:26:12 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 14:26:12 +0000 Subject: [Koha-bugs] [Bug 8462] OpacHiddenItems and hidelostitems hide items, but query result count is off In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P3 Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 16:27:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 14:27:11 +0000 Subject: [Koha-bugs] [Bug 5327] Unit tests required for all C4 modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m QA Contact|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 16:29:52 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 14:29:52 +0000 Subject: [Koha-bugs] [Bug 5327] Unit tests required for all C4 modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11469|0 |1 is obsolete| | --- Comment #214 from Jonathan Druart --- Created attachment 11500 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11500&action=edit Bug 5327 : Added a few more lines of code to the ItemType.t unit test Signed-off-by: Jared Camins-Esakov Signed-off-by: Chris Cormack Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 16:30:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 14:30:41 +0000 Subject: [Koha-bugs] [Bug 6886] Single branch mode should disable showing the branch name in front of all callnumbers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6886 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11367|0 |1 is obsolete| | --- Comment #8 from Julian Maurice --- Created attachment 11501 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11501&action=edit [SIGNED-OFF] Bug 6886 - OPAC XSLT respecting single branch mode This is only for the MARC21 XSLT at this stage, follow up patch for UNIMARC will come Conflicts: C4/XSLT.pm koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref Signed-off-by: Julian Maurice -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 16:31:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 14:31:28 +0000 Subject: [Koha-bugs] [Bug 6886] Single branch mode should disable showing the branch name in front of all callnumbers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6886 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11369|0 |1 is obsolete| | --- Comment #9 from Julian Maurice --- Created attachment 11502 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11502&action=edit Bug 6886 - Follow up for UNIMARC Signed-off-by: Julian Maurice -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 16:31:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 14:31:57 +0000 Subject: [Koha-bugs] [Bug 5327] Unit tests required for all C4 modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11471|0 |1 is obsolete| | --- Comment #215 from Jonathan Druart --- Created attachment 11503 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11503&action=edit Bug 5327 Tests for C4::Matcher Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 16:32:07 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 14:32:07 +0000 Subject: [Koha-bugs] [Bug 8608] New: replace checkboxes with edit links Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8608 Priority: P5 - low Change sponsored?: --- Bug ID: 8608 Assignee: cnighswonger at foundations.edu Summary: replace checkboxes with edit links Severity: enhancement Classification: Unclassified OS: All Reporter: nengard at gmail.com Hardware: All Status: NEW Version: master Component: Label printing Product: Koha When editing label templates or layouts or anything their are checkboxes you have to click before you click edit. You can't edit multiple at a time - an error appears - so why have that option to select multiple? I say we replace the check boxes with 'edit' links instead that way you click 'edit' to the right of the label you want to modify and you eliminate an extra click and confusion over why there are checkboxes there at all. Nicole -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 16:32:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 14:32:14 +0000 Subject: [Koha-bugs] [Bug 6886] Single branch mode should disable showing the branch name in front of all callnumbers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6886 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11370|0 |1 is obsolete| | --- Comment #10 from Julian Maurice --- Created attachment 11504 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11504&action=edit [SIGNED-OFF] Bug 6886 Follow up for NORMARC Signed-off-by: Julian Maurice -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 16:32:32 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 14:32:32 +0000 Subject: [Koha-bugs] [Bug 6886] Single branch mode should disable showing the branch name in front of all callnumbers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6886 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11502|Bug 6886 - Follow up for |[SIGNED-OFF] Bug 6886 - description|UNIMARC |Follow up for UNIMARC -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 16:33:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 14:33:39 +0000 Subject: [Koha-bugs] [Bug 5327] Unit tests required for all C4 modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11472|0 |1 is obsolete| | --- Comment #216 from Jonathan Druart --- Created attachment 11505 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11505&action=edit Added and tested a mock-db tested a couple of features http://bugs.koha-community.org/show_bug.cgi?id=5327 Signed-off-by: Katrin Fischer All tests pass! Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 16:34:52 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 14:34:52 +0000 Subject: [Koha-bugs] [Bug 6886] Single branch mode should disable showing the branch name in front of all callnumbers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6886 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |julian.maurice at biblibre.com --- Comment #11 from Julian Maurice --- Tested the 3 XSLT on master with singleBranchMode ON, branches are displayed. Tested the 3 XSLT with the patch with singleBranchMode ON, branches are not displayed Tested with singleBranchMode OFF, with and without the patch, display doesn't change. Ok. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 16:35:07 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 14:35:07 +0000 Subject: [Koha-bugs] [Bug 5327] Unit tests required for all C4 modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11473|0 |1 is obsolete| | --- Comment #217 from Jonathan Druart --- Created attachment 11506 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11506&action=edit Added a mock-db table and tested a line http://bugs.koha-community.org/show_bug.cgi?id=5327 Signed-off-by: Katrin Fischer All tests pass! Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 16:35:40 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 14:35:40 +0000 Subject: [Koha-bugs] [Bug 5327] Unit tests required for all C4 modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11470|[SIGNED-OFF] Bug 5327 |[PASSED-QA] Bug 5327 description|follow-up: add DBD::Mock |follow-up: add DBD::Mock |dependency |dependency -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 16:35:54 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 14:35:54 +0000 Subject: [Koha-bugs] [Bug 5327] Unit tests required for all C4 modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11500|Bug 5327 : Added a few more |[PASSED-QA]Bug 5327 : Added description|lines of code to the |a few more lines of code to |ItemType.t unit test |the ItemType.t unit test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 16:36:03 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 14:36:03 +0000 Subject: [Koha-bugs] [Bug 5327] Unit tests required for all C4 modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11503|Bug 5327 Tests for |[PASSED-QA]Bug 5327 Tests description|C4::Matcher |for C4::Matcher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 16:36:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 14:36:10 +0000 Subject: [Koha-bugs] [Bug 5327] Unit tests required for all C4 modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11505|Added and tested a mock-db |[PASSED-QA]Added and tested description|tested a couple of features |a mock-db tested a couple | |of features -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 16:36:16 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 14:36:16 +0000 Subject: [Koha-bugs] [Bug 5327] Unit tests required for all C4 modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11506|Added a mock-db table and |[PASSED-QA]Added a mock-db description|tested a line |table and tested a line -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 16:37:55 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 14:37:55 +0000 Subject: [Koha-bugs] [Bug 8569] Paying for a lost item overwrites nonpublic notes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8569 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |julian.maurice at biblibre.com --- Comment #3 from Julian Maurice --- Looks like the status should be signed off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 16:37:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 14:37:58 +0000 Subject: [Koha-bugs] [Bug 5327] Unit tests required for all C4 modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #218 from Jonathan Druart --- Last 5 patches resubmited (perltidy) Marked as Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 16:43:19 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 14:43:19 +0000 Subject: [Koha-bugs] [Bug 8449] Improve wording and styling for "cancelled holds" on Holds Awaiting Pickup screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8449 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |julian.maurice at biblibre.com --- Comment #2 from Julian Maurice --- Patch doesn't apply anymore Applying: Bug 8449 - Improve wording and styling for "cancelled holds" on Holds Awaiting Pickup screen Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/circ/waitingreserves.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/circ/waitingreserves.tt Failed to merge in the changes. Patch failed at 0001 Bug 8449 - Improve wording and styling for "cancelled holds" on Holds Awaiting Pickup screen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 16:48:44 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 14:48:44 +0000 Subject: [Koha-bugs] [Bug 8569] Paying for a lost item overwrites nonpublic notes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8569 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart at biblibre.co | |m --- Comment #4 from Jonathan Druart --- QA comments: Simple patch. We cannot translate the message put into the paidfor field but anyhow there is no easy way to do that. Marked as Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 16:56:06 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 14:56:06 +0000 Subject: [Koha-bugs] [Bug 4906] Problem with grace period calculation and fine intervals >1 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4906 --- Comment #5 from Kyle M Hall --- Created attachment 11507 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11507&action=edit Bug 4906 - Problem with grace period calculation and fine intervals >1 This patch adds the system preference FinesIncludeGracePeriod which allows the library the choice to include the grace period when calculating a fine ( Koha's current behavior ) or to ingore the grace period for the purposes of fines calculation. It is set by default to preserve the current behavior. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 16:57:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 14:57:21 +0000 Subject: [Koha-bugs] [Bug 4906] Problem with grace period calculation and fine intervals >1 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4906 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11507|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall --- Created attachment 11508 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11508&action=edit Bug 4906 - Problem with grace period calculation and fine intervals >1 This patch adds the system preference FinesIncludeGracePeriod which allows the library the choice to include the grace period when calculating a fine ( Koha's current behavior ) or to ingore the grace period for the purposes of fines calculation. It is set by default to preserve the current behavior. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 16:58:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 14:58:09 +0000 Subject: [Koha-bugs] [Bug 8412] add color icon set In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8412 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11382|0 |1 is obsolete| | --- Comment #8 from Julian Maurice --- Created attachment 11509 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11509&action=edit [SIGNED-OFF] Bug 8412: add color icon set Patch only adds image files in a new directory, so it's a safe change. Number of files have been reduced and SQL snippet attached to the patch, as requested by Owen. No reasons to not signoff. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 16:58:17 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 14:58:17 +0000 Subject: [Koha-bugs] [Bug 8412] add color icon set In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8412 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |julian.maurice at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 17:02:05 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 15:02:05 +0000 Subject: [Koha-bugs] [Bug 8110] Fines accruing on closed days In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8110 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart at biblibre.co | |m --- Comment #39 from Jonathan Druart --- QA comments: One test does not pass: # Failed test 'Christmas is a closed day' # at t/db_dependent/Holidays.t line 44. # got: '0' # expected: '1' After a quick debug, in Koha::Calendar, l.153: if ( exists $self->{day_month_closed_days}->{$month}->{$day} ) { should be if ( exists $self->{day_month_closed_days}->{$day}->{$month} ) { Marked as Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 17:12:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 15:12:41 +0000 Subject: [Koha-bugs] [Bug 6413] Notes in Fines doing wonky things In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413 --- Comment #31 from Nicole C. Engard --- Chris, Can you submit a new patch that will pass QA on this? Nicole -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 17:16:50 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 15:16:50 +0000 Subject: [Koha-bugs] [Bug 6413] Notes in Fines doing wonky things In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Patch doesn't apply CC| |wizzyrea at gmail.com --- Comment #32 from Liz Rea --- This patch no longer applies :( -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 17:29:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 15:29:49 +0000 Subject: [Koha-bugs] [Bug 4906] Problem with grace period calculation and fine intervals >1 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4906 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 17:54:00 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 15:54:00 +0000 Subject: [Koha-bugs] [Bug 8608] replace checkboxes with edit links In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8608 Chris Nighswonger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WONTFIX --- Comment #1 from Chris Nighswonger --- The check boxes are for a multi-delete feature which seems not to work at present. I'm marking this as WONTFIX in favor of the fix for bug 7386. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 18:15:51 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 16:15:51 +0000 Subject: [Koha-bugs] [Bug 8185] Plugin for linking records in MARC21 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8185 --- Comment #7 from Mirko Tietgen --- Created attachment 11510 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11510&action=edit Bug 8185 Follow-Up: Some more Italian strings changed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 18:18:17 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 16:18:17 +0000 Subject: [Koha-bugs] [Bug 7386] Label batches cannot be batch deleted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7386 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #3 from Nicole C. Engard --- I'd ask that we also add an edit link next to each item so that you don't have to use the checkboxes for editing, because that's 2 clicks where you really only need one cause you can't edit in bulk. Nicole -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 18:19:40 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 16:19:40 +0000 Subject: [Koha-bugs] [Bug 8185] Plugin for linking records in MARC21 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8185 --- Comment #8 from Mirko Tietgen --- Functionality is still fine, but I found more Italian strings. Sent a followup patch, somebody else needs to signoff. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 19:14:38 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 17:14:38 +0000 Subject: [Koha-bugs] [Bug 8609] New: Add an URL validation plugin for authority and biblio frameworks Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8609 Priority: P5 - low Change sponsored?: --- Bug ID: 8609 CC: m.de.rooy at rijksmuseum.nl Assignee: gmcharlt at gmail.com Summary: Add an URL validation plugin for authority and biblio frameworks Severity: enhancement Classification: Unclassified OS: All Reporter: fcapovilla at live.ca Hardware: All Status: NEW Version: master Component: Cataloging Product: Koha Created attachment 11511 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11511&action=edit Add an URL validation plugin for authority and biblio frameworks. This patch adds a new validation plugin that can be used in biblio and authority frameworks. The plugin uses a regex to validate that a field contains a valid url. For example, this plugin could be used for field 856$u of MARC21 biblio and authority frameworks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 19:15:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 17:15:25 +0000 Subject: [Koha-bugs] [Bug 8609] Add an URL validation plugin for authority and biblio frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8609 Fr?d?rick Capovilla changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Change sponsored?|--- |Sponsored Assignee|gmcharlt at gmail.com |fcapovilla at live.ca --- Comment #1 from Fr?d?rick Capovilla --- Patch sponsored by the CCSR ( http://www.ccsr.qc.ca ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 19:44:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 17:44:35 +0000 Subject: [Koha-bugs] [Bug 8610] New: Normalize records imported from Z39.50 servers to prevent Zebra search problems. Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8610 Priority: P5 - low Change sponsored?: --- Bug ID: 8610 CC: m.de.rooy at rijksmuseum.nl Assignee: gmcharlt at gmail.com Summary: Normalize records imported from Z39.50 servers to prevent Zebra search problems. Severity: enhancement Classification: Unclassified OS: All Reporter: fcapovilla at live.ca Hardware: All Status: NEW Version: rel_3_8 Component: Z39.50 / SRU / OpenSearch Servers Product: Koha Created attachment 11512 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11512&action=edit Normalize records imported from Z39.50 servers. Records with separated diacritics might not show up in Zebra searches if the search terms use accented characters, because typed UTF-8 accented characters normally use combined diacritics. Some Z39.50 server may use the MARC-8 encoding, which uses separated diacritics. By forcing a normalization, all imported records will have combined diacritics. Example serveur using separated diacritics (MARC-21): http://www.collectionscanada.gc.ca/amicus/006002-400-f.html Hostname: amicus.collectionscanada.gc.ca Port: 210 Database: BN Syntax: MARC21/USMARC Encoding: MARC-8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 19:45:05 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 17:45:05 +0000 Subject: [Koha-bugs] [Bug 8610] Normalize records imported from Z39.50 servers to prevent Zebra search problems. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8610 Fr?d?rick Capovilla changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Change sponsored?|--- |Sponsored Assignee|gmcharlt at gmail.com |fcapovilla at live.ca Severity|enhancement |normal --- Comment #1 from Fr?d?rick Capovilla --- Patch sponsored by the CCSR ( http://www.ccsr.qc.ca ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 19:50:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 17:50:57 +0000 Subject: [Koha-bugs] [Bug 8610] Normalize records imported from Z39.50 servers to prevent Zebra search problems. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8610 Jane Wagner changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jwagner at ptfs.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 19:52:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 17:52:39 +0000 Subject: [Koha-bugs] [Bug 6832] Validation of total > budget in neworderempty In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6832 --- Comment #15 from Maxime Pelletier --- (In reply to comment #13) > QA Comments: > > It seems the patch does not work as expected. > I think your ajax script must to return $budget->{budget_amount} - > C4::Budgets::GetBudgetSpent($budget->{id}) (or GetBudgetOrdered ?). My patch doesn't change the behavior of acqui/check_budget_total.pl at all, so i'm really not sure what you are talking about. Could you explain in more details ? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 19:57:03 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 17:57:03 +0000 Subject: [Koha-bugs] [Bug 8597] New theme for the OPAC with a mobile view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8597 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 21:46:51 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 19:46:51 +0000 Subject: [Koha-bugs] [Bug 8611] New: too many baskets on search results for acquisitions Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8611 Priority: P5 - low Change sponsored?: --- Bug ID: 8611 Assignee: koha-bugs at lists.koha-community.org Summary: too many baskets on search results for acquisitions Severity: major Classification: Unclassified OS: All Reporter: nengard at gmail.com Hardware: All Status: NEW Version: master Component: Acquisitions Product: Koha I'm pretty sure that Koha used to hide closed baskets that have everything in them received from the search results when doing a vendor search. Now every basket shows and for libraries that have lots of orders it slows down the vendor search results page and makes it unwieldy. There should be a preference to hide closed/received baskets or it should just hide them so that this is not an issue. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 21:53:51 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 19:53:51 +0000 Subject: [Koha-bugs] [Bug 8440] Dates does not appear in suggestions management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8440 --- Comment #11 from Chris Cormack --- Pushed follow up to 3.8.x, will be in 3.8.4 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 21:54:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 19:54:41 +0000 Subject: [Koha-bugs] [Bug 8587] Add a serial lifespan to serial subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8587 Maxime Pelletier changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11437|0 |1 is obsolete| | --- Comment #10 from Maxime Pelletier --- Created attachment 11513 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11513&action=edit Patch that passes tests Well in any case, here's a new patch that passes the template test. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 23:33:40 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 21:33:40 +0000 Subject: [Koha-bugs] [Bug 8612] New: System preference to have custom fields in exort csv basket Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612 Priority: P5 - low Change sponsored?: Sponsored Bug ID: 8612 Assignee: koha-bugs at lists.koha-community.org Summary: System preference to have custom fields in exort csv basket Severity: enhancement Classification: Unclassified OS: All Reporter: pelletiermaxime at gmail.com Hardware: All Status: NEW Version: master Component: Acquisitions Product: Koha New system preference where you can write the fields you want to have in the "Export this basket as CSV" button in a basket page of the acquisition module. This could be done in better ways, but this is what I came up with, in the time I had. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 23:36:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 21:36:48 +0000 Subject: [Koha-bugs] [Bug 8612] System preference to have custom fields in exort csv basket In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612 --- Comment #1 from Maxime Pelletier --- Created attachment 11514 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11514&action=edit patch that adds new syspref and uses it -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 9 23:47:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 21:47:35 +0000 Subject: [Koha-bugs] [Bug 8597] New theme for the OPAC with a mobile view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8597 --- Comment #7 from Fr?d?rick Capovilla --- Created attachment 11515 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11515&action=edit Add system preferences to configure the mobile view. This new patch adds some system preferences to configure the mobile view. This patch depends on the two others. New preferences : OpacMainUserBlockMobile : Text on the main page, only shown on the mobile view OPACMobileUserCSS : Same as OPACUserCSS, but only for the mobile view OpacShowFiltersPulldownMobile : Hide/Show the filters pulldown on the mobile view. OpacShowLibrariesPulldownMobile : Hide/Show the libraries pulldown on the mobile view. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 01:47:12 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Aug 2012 23:47:12 +0000 Subject: [Koha-bugs] [Bug 8613] New: Patron Messaging Preferences Template falsely states that Category Level Preferences are Applied to Patron Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8613 Priority: P5 - low Change sponsored?: --- Bug ID: 8613 CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Assignee: koha-bugs at lists.koha-community.org Summary: Patron Messaging Preferences Template falsely states that Category Level Preferences are Applied to Patron Severity: minor Classification: Unclassified OS: All Reporter: dcook at prosentient.com.au Hardware: All Status: NEW Version: master Component: Patrons Product: Koha The template for the Patron messaging preferences in the Patron Edit screen falsely states that Category Level Preferences are applied to the patron on save, if the patron does not select any messaging preferences. No matter how I test it, it never works. I suggest that we either eliminate this message, or actually make it so that this statement is true. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 04:44:22 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 02:44:22 +0000 Subject: [Koha-bugs] [Bug 8585] Add System Preference to specify Holds to Pull List Start Date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8585 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |dcook at prosentient.com.au |ity.org | --- Comment #1 from David Cook --- Created attachment 11516 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11516&action=edit Bug 8585 : Add System Preference to specify Holds to Pull List Start Date -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 05:43:54 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 03:43:54 +0000 Subject: [Koha-bugs] [Bug 8576] Software error on authority edition when using merge In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8576 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj at kohaaloha.com --- Comment #4 from Mason James --- (In reply to comment #3) > Created attachment 11404 [details] > Bug 8576: Software error on authority edition when using merge > > Signed-off-by: Chris Cormack looks good, passing QA on this mason at xen1:~/git/head$ koha-qa.pl - 7a6718d Bug 8576: Software error on authority edition when using merge C4/AuthoritiesMarc.pm misc/batchImportMARCWithBiblionumbers.pl - perlcritic-progressive tests... OK - perl -c syntax tests... OK - xt/tt_valid.t tests... OK - xt/author/vaild-template.t tests... OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 05:57:26 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 03:57:26 +0000 Subject: [Koha-bugs] [Bug 8573] Translation difficult in picture-upload.tt due to nested sentence in if/foreach/if/elsif - construction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8573 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11375|0 |1 is obsolete| | --- Comment #3 from Marc V?ron --- Created attachment 11517 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11517&action=edit Bug 8573 - Translation difficult in picture-upload.tt due to nested sentence in if/foreach/if/elsif - construction Text could not be correctly translated due to poor parsing of nested sentences in Pootle. *Sentences de-nested to have whole sentence in each if /elsif branch *Cleaned up
  • handling: moved closing outside the for each loop to prevent orphaned closing s. *Chanched indentation for better readibility *Changed WARNING to ERROR because it is an *Error* during upload. *Wording simplified (for translation). *In one case added hint to refer to online help (size). This way text should be easier to be translated in Pootle. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 06:00:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 04:00:37 +0000 Subject: [Koha-bugs] [Bug 8573] Translation difficult in picture-upload.tt due to nested sentence in if/foreach/if/elsif - construction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8573 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11517|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 06:08:16 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 04:08:16 +0000 Subject: [Koha-bugs] [Bug 8268] Koha should offer way to backup entire db In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8268 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj at kohaaloha.com --- Comment #37 from Mason James --- both (2) patches signed-off. looks good, passing QA on this mason at xen1:~/git/head$ koha-qa.pl -c 2 * 8374da8 Bug 8268: improve error checking tools/export.pl * 5a8dcc7 Bug 8268 follow-up: rewrite config correctly rewrite-config.PL - perlcritic-progressive tests... OK - perl -c syntax tests... OK - xt/tt_valid.t tests... OK - xt/author/valid-template.t tests... OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 06:10:52 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 04:10:52 +0000 Subject: [Koha-bugs] [Bug 6832] Validation of total > budget in neworderempty In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6832 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion CC| |mtj at kohaaloha.com --- Comment #16 from Mason James --- (In reply to comment #15) > (In reply to comment #13) > > QA Comments: > > > > It seems the patch does not work as expected. > > I think your ajax script must to return $budget->{budget_amount} - > > C4::Budgets::GetBudgetSpent($budget->{id}) (or GetBudgetOrdered ?). > > My patch doesn't change the behavior of acqui/check_budget_total.pl at all, > so i'm really not sure what you are talking about. Could you explain in more > details ? changing status to 'in discussion'... -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 06:16:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 04:16:29 +0000 Subject: [Koha-bugs] [Bug 8162] packaging scripts create user incorrectly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8162 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj at kohaaloha.com --- Comment #11 from Mason James --- (In reply to comment #10) > Created attachment 11180 [details] > Bug 8162: allow packages to work on Ubuntu Precise > > Signed-off-by: Jared Camins-Esakov > Works as promised. i'm going to pass QA on this, despite Jonathan's 'cat' suggestion (hope thats ok) mason at xen1:~/git/head$ koha-qa.pl * c1f0e96 Bug 8162: allow packages to work on Ubuntu Precise debian/scripts/koha-create debian/scripts/koha-remove - perlcritic-progressive tests... OK - perl -c syntax tests... OK - xt/tt_valid.t tests... OK - xt/author/valid-template.t tests... OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 06:20:07 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 04:20:07 +0000 Subject: [Koha-bugs] [Bug 8495] Javascript error when creating a new order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8495 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff CC| |mtj at kohaaloha.com --- Comment #3 from Mason James --- (In reply to comment #2) > Created attachment 11106 [details] > Bug 8495: Fix JS error when creating a new order > > bug introduced by bug 7178 > (http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7178) > > Signed-off-by: Jonathan Druart hmmm, we are waiting for a 'non BibLibre' sign-off here, before QA? i will change status to 'needs-signoff' (i hope that is ok?) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 06:23:18 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 04:23:18 +0000 Subject: [Koha-bugs] [Bug 8573] Translation difficult in picture-upload.tt due to nested sentence in if/foreach/if/elsif - construction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8573 --- Comment #4 from Marc V?ron --- Created attachment 11518 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11518&action=edit Bug 8573 - Translation difficult in picture-upload.tt due to nested sentence in if/foreach/if/elsif - construction Text could not be correctly translated due to poor parsing of nested sentences in Pootle. *Sentences de-nested to have whole sentence in each if /elsif branch *Cleaned up
  • handling: moved closing outside the for each loop to prevent orphaned closing s. *Changed indentation for better readibility *Changed WARNING to ERROR because it is an *Error* during upload. *Wording simplified (for translation). *In one case added hint to refer to online help (size). This way text should be easier to be translated in Pootle. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 06:25:38 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 04:25:38 +0000 Subject: [Koha-bugs] [Bug 8573] Translation difficult in picture-upload.tt due to nested sentence in if/foreach/if/elsif - construction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8573 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 06:57:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 04:57:35 +0000 Subject: [Koha-bugs] [Bug 8520] Authorities display incorrectly in staff results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8520 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj at kohaaloha.com --- Comment #14 from Mason James --- hmmm, this patch has already passed QA. i think there is no need to QA it again changing status ready for 'push to 3.8' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 07:04:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 05:04:10 +0000 Subject: [Koha-bugs] [Bug 8520] Authorities display incorrectly in staff results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8520 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion --- Comment #15 from Mason James --- (In reply to comment #10) > Created attachment 11420 [details] > Bug 8520: fix authority display in autocomplete Jared, this patch is surely for another bug? yes? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 07:12:19 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 05:12:19 +0000 Subject: [Koha-bugs] [Bug 8329] GetLostItems in C4::Items.pm has a SELECT * In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8329 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj at kohaaloha.com --- Comment #4 from Mason James --- (In reply to comment #3) > QA comment: this patch looks good, but a small question: why not > SELECT biblio,author,...,items.* (all items fields) ? would that solve your > performance problem ? if yest, I think it's better, because it will be more > evolutive in case one want to introduce a new column in the report. > > But I won't fail QA for that, if you say enumerating fields is needed, I'll > push your patch ok Paul, all QA tests pass, patch looks good - passing QA :) mason at xen1:~/git/head$ koha-qa.pl * d4f15be Bug 8329 - GetLostItems in C4::Items.pm has a SELECT * Provided a smaller list based on reports/itemlost.tt C4/Items.pm - perlcritic-progressive tests... OK - perl -c syntax tests... OK - xt/tt_valid.t tests... OK - xt/author/valid-template.t tests... OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 07:14:46 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 05:14:46 +0000 Subject: [Koha-bugs] [Bug 8395] order receive not sorting right In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8395 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj at kohaaloha.com --- Comment #4 from Mason James --- (In reply to comment #3) > Created attachment 11138 [details] > [SIGNED-OFF] Bug 8395: Fix sort order in parcel.tt (summary) > > Signed-off-by: Marc Veron > > Patch behaves as expected. trival patch, passing QA :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 07:18:16 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 05:18:16 +0000 Subject: [Koha-bugs] [Bug 8210] Headings in OPAC bib details should link to authority record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8210 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11480|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 11519 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11519&action=edit [SIGNED-OFF] Bug 8210: add links to authorities to headings in OPAC At the moment, there is no way to get to an authority record from a bib record that uses it other than doing a new search on the authority file. This patch adds a link (a cute little magnifying glass) to linked authority records on the OPAC detail view for MARC21 and NORMARC with XSLT enabled. A follow-up patch will add the link to regular mode. Because UNIMARC handles authorities differently, the link is not added to the XSLT. Test plan: 1) Set OPACXSLTDetailsDisplay to 'default' 2) View a record that has some headings that are linked to authority records in the OPAC (easiest way to find a record like that is to edit a record and add some headings using the thesaurus plugin) 3) Observe the cute little magnifying glass links to the authority. Revised version of the patch adds a space between the heading and the magnifying glass. Signed-off-by: Katrin Fischer Patch works nicely. If a library does not like to see the magnifying glass/link to the authority, it's easy to disable it by adding the line .authlink {display:none;} to OpacUserCSS. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 07:18:34 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 05:18:34 +0000 Subject: [Koha-bugs] [Bug 8210] Headings in OPAC bib details should link to authority record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8210 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 07:23:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 05:23:28 +0000 Subject: [Koha-bugs] [Bug 8614] New: Icon for scores on OPAC detail page broken Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8614 Priority: P5 - low Change sponsored?: --- Bug ID: 8614 Assignee: oleonard at myacpl.org Summary: Icon for scores on OPAC detail page broken Severity: enhancement Classification: Unclassified OS: All Reporter: katrin.fischer at bsz-bw.de Hardware: All Status: NEW Version: master Component: OPAC Product: Koha Created attachment 11520 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11520&action=edit screenshot The icon for scores on the OPAC detail page is not displaying correctly, instead following text is shown: Type: materialTypeLabelScore In other cases the score icon shows up on the result list, but on the detail page the article icon or the book is shown. It seems that different conditions are used to determine which icon to display on both pages. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 07:25:44 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 05:25:44 +0000 Subject: [Koha-bugs] [Bug 8614] Icon for scores on OPAC detail page broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8614 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 07:31:04 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 05:31:04 +0000 Subject: [Koha-bugs] [Bug 8513] OPAC detail page broken with XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8513 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj at kohaaloha.com --- Comment #6 from Mason James --- (In reply to comment #5) > Created attachment 11478 [details] > Bug 8513: OPAC detail page broken with XSLT > > Signed-off-by: Chris Cormack patch looks good and applies, passing QA fyi: we need to add some xsl, xml and javascript tests to the Koha qa-tools... :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 07:34:30 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 05:34:30 +0000 Subject: [Koha-bugs] [Bug 8615] New: XSLT on OPAC is broken for incomplete 6xx fields Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8615 Priority: P5 - low Change sponsored?: --- Bug ID: 8615 Assignee: oleonard at myacpl.org Summary: XSLT on OPAC is broken for incomplete 6xx fields Severity: enhancement Classification: Unclassified OS: All Reporter: katrin.fischer at bsz-bw.de Hardware: All Status: NEW Version: master Component: OPAC Product: Koha Created attachment 11521 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11521&action=edit screenshot Currently the OPAC XSLT page is broken, when you data includes an 6xx field, that includes no subfield that is marked for display (empty link). I was testing with German data that includes 689 fields for transporting "Schlagwortketten". To avoid the problem the XSLT should include a check for a displayable subfields before creating the link. Example with problematic data: c (DE-588c)4542874-8 (DE-576)213479192 swd Solesmes Kloster s (DE-588c)4021952-5 (DE-576)20894091X swd Gregorianischer Gesang DE-576 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 07:38:54 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 05:38:54 +0000 Subject: [Koha-bugs] [Bug 7671] add a real primary key "accountlinesid" in accountlines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7671 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #20 from Mason James --- (In reply to comment #19) > Created attachment 11374 [details] > Bug 7671 : add a real primary key accountlinesid in accountlines > > Signed-off-by: St?phane Delaune > Signed-off-by: Marc Veron > Signed-off-by: Chris Cormack patch looks good and applies to master 322a9c7fbbcf456084d1937f48345b3cdec058ce passing QA, nice patch - well done! mason at xen1:~/git/head$ koha-qa.pl * f6f6a46 Bug 7671 : add a real primary key accountlinesid in accountlines C4/Accounts.pm C4/Circulation.pm installer/data/mysql/kohastructure.sql installer/data/mysql/updatedatabase.pl koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt members/boraccount.pl members/pay.pl members/paycollect.pl members/printinvoice.pl - perlcritic-progressive tests... OK - perl -c syntax tests... OK - xt/tt_valid.t tests... OK - xt/author/valid-template.t tests... OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 07:41:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 05:41:09 +0000 Subject: [Koha-bugs] [Bug 8413] Space in barcode breaks GET request in benchmark_staff.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8413 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj at kohaaloha.com --- Comment #6 from Mason James --- (In reply to comment #5) > Created attachment 11397 [details] > Bug 8413 Space in barcodes breaks GET request in benchmark_staff.pl > > Signed-off-by: Chris Cormack trivial patch, passing QA mason at xen1:~/git/head$ koha-qa.pl * 363e671 Bug 8413 Space in barcodes breaks GET request in benchmark_staff.pl misc/load_testing/benchmark_staff.pl - perlcritic-progressive tests... OK - perl -c syntax tests... OK - xt/tt_valid.t tests... OK - xt/author/valid-template.t tests... OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 07:43:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 05:43:21 +0000 Subject: [Koha-bugs] [Bug 8513] OPAC detail page broken with XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8513 --- Comment #7 from Chris Cormack --- Check xt and xt/author tests for the xml and xslt already exist -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 07:44:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 05:44:33 +0000 Subject: [Koha-bugs] [Bug 8616] New: Displaying relator codes in OPAC Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8616 Priority: P5 - low Change sponsored?: --- Bug ID: 8616 Assignee: oleonard at myacpl.org Summary: Displaying relator codes in OPAC Severity: minor Classification: Unclassified OS: All Reporter: katrin.fischer at bsz-bw.de Hardware: All Status: NEW Version: master Component: OPAC Product: Koha Created attachment 11522 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11522&action=edit screenshot $4 subfields for relator codes are now displayed in OPAC. The relator code is shown is right behind the main heading. Example: "Bretzner, Christoph Friedrich[aut]" I think an additional space between the term an the code would be good. I am also worried about displaying this information in the OPAC. The codes are not easy to resolve and the patrons might get confused by it. It would be great if a class could be added to those fields, so it's possible to hide the codes in the OPAC easily. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 07:46:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 05:46:43 +0000 Subject: [Koha-bugs] [Bug 8514] Display of patron results changed display order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8514 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj at kohaaloha.com --- Comment #4 from Mason James --- (In reply to comment #3) > Created attachment 11171 [details] > [SIGNED-OFF] Bug 8514 Restore Patron Name Display Order > > Signed-off-by: Owen Leonard patch looks good, passing QA mason at xen1:~/git/head$ koha-qa.pl * 53b4f14 Bug 8514 Restore Patron Name Display Order koha-tmpl/intranet-tmpl/prog/en/includes/patron-title.inc koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt - perlcritic-progressive tests... OK - perl -c syntax tests... OK - xt/tt_valid.t tests... OK - xt/author/valid-template.t tests... OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 07:58:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 05:58:35 +0000 Subject: [Koha-bugs] [Bug 8617] New: Problem with display of comments waiting for moderation in OPAC Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8617 Priority: P5 - low Change sponsored?: --- Bug ID: 8617 Assignee: oleonard at myacpl.org Summary: Problem with display of comments waiting for moderation in OPAC Severity: normal Classification: Unclassified OS: All Reporter: katrin.fischer at bsz-bw.de Hardware: All Status: NEW Version: master Component: OPAC Product: Koha To test: 1) Check you have comments activated (system preference: reviewson) 2) Add a comment to a record in the OPAC. The comment is shown with a light green background and the message: Your comment (preview, pending approval) 3) Refresh the page. Problem: The comment will no longer be shown to the logged in user. 4) Go into staff and approve the comment. (Tools > Comments) 5) Refresh the page in OPAC again. The comment shows up as "Your comment" correctly. 6) Edit the comment and change the text. Problem: Now 2 entries are shown in the comment list. One "Your comment" with the original text and one "Your comment (preview, pending approval)" with the edited text. It's confusing and looks like a new comment has been added. 7) Refresh the page. Problem: Both comments are gone. 8) Go into staff and approve the edited comment again. The edited comment is back and visible. I think the behaviour on refreshing the page is confusing to the patron. The comments should show in their current state whenever I get to the page while being logged in. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 08:05:54 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 06:05:54 +0000 Subject: [Koha-bugs] [Bug 5342] Serial claiming improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5342 --- Comment #35 from Katrin Fischer --- Hi Jonathan, sorry that it took me so long to get back to this. I have a question about the functionality of the tag. You wrote: "(note the "order" tag could be "whatever")" What does this mean? I could write around my item fields and it would still get repeated correctly? I see that there is no tag to mark the repeating section in the HTML message you posted - how does the template know which parts to repeat for each serial that needs to be claimed? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 08:11:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 06:11:49 +0000 Subject: [Koha-bugs] [Bug 8550] Z39.50 searches for ISBN/ISSN problematic In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8550 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj at kohaaloha.com --- Comment #4 from Mason James --- (In reply to comment #3) > Created attachment 11304 [details] > Bug 8550: Z39.50 searches for ISBN/ISSN problematic - Signed Off > Signed-off-by: Joseph Alway patch looks good, passing QA mason at xen1:~/git/head$ koha-qa.pl * bc4a87d Bug 8550: Z39.50 searches for ISBN/ISSN problematic cataloguing/z3950_search.pl - perlcritic-progressive tests... OK - perl -c syntax tests... OK - xt/tt_valid.t tests... OK - xt/author/valid-template.t tests... OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 08:22:44 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 06:22:44 +0000 Subject: [Koha-bugs] [Bug 8573] Translation difficult in picture-upload.tt due to nested sentence in if/foreach/if/elsif - construction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8573 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11518|0 |1 is obsolete| | --- Comment #5 from Julian Maurice --- Created attachment 11523 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11523&action=edit [SIGNED-OFF] Bug 8573 - Translation difficult in picture-upload.tt due to nested sentence in if/foreach/if/elsif - construction Text could not be correctly translated due to poor parsing of nested sentences in Pootle. *Sentences de-nested to have whole sentence in each if /elsif branch *Cleaned up
  • handling: moved closing outside the for each loop to prevent orphaned closing s. *Changed indentation for better readibility *Changed WARNING to ERROR because it is an *Error* during upload. *Wording simplified (for translation). *In one case added hint to refer to online help (size). This way text should be easier to be translated in Pootle. Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 08:25:23 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 06:25:23 +0000 Subject: [Koha-bugs] [Bug 8573] Translation difficult in picture-upload.tt due to nested sentence in if/foreach/if/elsif - construction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8573 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 08:38:04 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 06:38:04 +0000 Subject: [Koha-bugs] [Bug 8618] New: Z3950 is not processing CCL Queries Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8618 Priority: P5 - low Change sponsored?: --- Bug ID: 8618 CC: m.de.rooy at rijksmuseum.nl Assignee: gmcharlt at gmail.com Summary: Z3950 is not processing CCL Queries Severity: major Classification: Unclassified OS: All Reporter: dcook at prosentient.com.au Hardware: All Status: NEW Version: master Component: Z39.50 / SRU / OpenSearch Servers Product: Koha When you click "Z3950 search" in the intranet search results, the title field in the Z3950 search formis preloaded with the CCL for the query that you executed in Koha. However, when you try searching, you will always get no results back. If you take out the CCL, and just type in your query (like "heart") into the title field, you will get results. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 08:59:15 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 06:59:15 +0000 Subject: [Koha-bugs] [Bug 8588] Duplicate field IDs cause problems with SQL report parameter entry In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8588 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj at kohaaloha.com --- Comment #3 from Mason James --- (In reply to comment #2) > Created attachment 11438 [details] > Bug 8588 - Duplicate field IDs cause problems with SQL report parameter entry > > Changes to markup and script to enable unique ids on form > fields. These changes allow for working label+input pairs > on one or more text and select inputs and multiple working > datepickers. > > To test, create a report with more than one date parameter, > at least one text parameter, and one or more authorised > value parameters. The datepickers should each work properly, > and labels should by clickable. > > Signed-off-by: Chris Cormack patch looks good, passing QA mason at xen1:~/git/head$ koha-qa.pl * b23ef0a Bug 8588 - Duplicate field IDs cause problems with SQL report parameter entry koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt reports/guided_reports.pl - perlcritic-progressive tests... OK - perl -c syntax tests... OK - xt/tt_valid.t tests... OK - xt/author/valid-template.t tests... OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 09:02:30 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 07:02:30 +0000 Subject: [Koha-bugs] [Bug 8522] Markup errors cause problems with customized CSS In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8522 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj at kohaaloha.com --- Comment #4 from Mason James --- (In reply to comment #3) > Created attachment 11396 [details] > Bug 8522 - Markup errors cause problems with customized CSS > > Some includes and templates contained duplicate "header" ids in > the markup. The problem should have come up in routine page > validation, but was obvious when custom CSS was applied. > > To test, load any of the affected pages and validate the > generated HTML. There should be no errors about 'ID "header" > already defined." Or, add custom CSS to intranetusercss: > > ...and confirm that only the topmost menu background is affected. > > Signed-off-by: Chris Cormack patch look good, passing QA mason at xen1:~/git/head$ koha-qa.pl * e6a5599 Bug 8522 - Markup errors cause problems with customized CSS koha-tmpl/intranet-tmpl/prog/en/includes/budgets-admin-search.inc koha-tmpl/intranet-tmpl/prog/en/includes/cities-admin-search.inc koha-tmpl/intranet-tmpl/prog/en/includes/patrons-admin-search.inc koha-tmpl/intranet-tmpl/prog/en/includes/roadtype-admin-search.inc koha-tmpl/intranet-tmpl/prog/en/includes/z3950-admin-search.inc koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt - perlcritic-progressive tests... OK - perl -c syntax tests... OK - xt/tt_valid.t tests... OK - xt/author/valid-template.t tests... OK mason at xen1:~/git/head$ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 09:05:42 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 07:05:42 +0000 Subject: [Koha-bugs] [Bug 8573] Translation difficult in picture-upload.tt due to nested sentence in if/foreach/if/elsif - construction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8573 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj at kohaaloha.com --- Comment #6 from Mason James --- (In reply to comment #5) > Created attachment 11523 [details] > [SIGNED-OFF] Bug 8573 - Translation difficult in picture-upload.tt due to > Signed-off-by: Julian Maurice patch looks good, passing QA mason at xen1:~/git/head$ koha-qa.pl * 5475444 Bug 8573 - Translation difficult in picture-upload.tt due to nested sentence in if/foreach/if/elsif - construction koha-tmpl/intranet-tmpl/prog/en/modules/tools/picture-upload.tt - perlcritic-progressive tests... OK - perl -c syntax tests... OK - xt/tt_valid.t tests... OK - xt/author/valid-template.t tests... OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 09:11:03 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 07:11:03 +0000 Subject: [Koha-bugs] [Bug 7589] tinymce editor broken in .deb packages - in 'en' templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7589 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at enger.priv.no --- Comment #9 from Magnus Enger --- I just tested on an installation of 3.8.3 running off the official packages, and it has tiny_mce working beautifully for both English and Norwegian. Maybe this is just a problem for 3.6.x now? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 09:16:32 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 07:16:32 +0000 Subject: [Koha-bugs] [Bug 8175] Check for something in materials field fails in catalogue/details.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8175 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion CC| |mtj at kohaaloha.com --- Comment #10 from Mason James --- (In reply to comment #9) > Hi Mark, > > Could you resubmit your patch after updating your commit message please ? > (clarify "As such, a defined check handles the NULL, 0, and '0' cases.") status modded to 'in discussion'... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 09:19:01 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 07:19:01 +0000 Subject: [Koha-bugs] [Bug 8549] DataTables upgrade broke display of next/previous buttons in table controls In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8549 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj at kohaaloha.com --- Comment #5 from Mason James --- (In reply to comment #3) > Created attachment 11459 [details] > Bug 8549 - DataTables upgrade broke display of next/previous buttons in > table controls > > Signed-off-by: Chris Cormack patch looks good, passing QA fyi: we need to add .css and .js validation tests to qa-tools too... :) mason at xen1:~/git/head$ koha-qa.pl * 35aa6ba Bug 8549 - DataTables upgrade broke display of next/previous buttons in table controls koha-tmpl/intranet-tmpl/prog/en/css/datatables.css koha-tmpl/intranet-tmpl/prog/en/js/datatables.js - perlcritic-progressive tests... OK - perl -c syntax tests... OK - xt/tt_valid.t tests... OK - xt/author/valid-template.t tests... OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 09:20:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 07:20:33 +0000 Subject: [Koha-bugs] [Bug 8419] Suspended holds appear on the daily holds queue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8419 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #5 from Chris Cormack --- Pushed to 3.8.x will be in 3.8.4 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 09:24:17 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 07:24:17 +0000 Subject: [Koha-bugs] [Bug 8172] Missing dereference marker for buildQuery parameter in addbooks.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8172 --- Comment #7 from Chris Cormack --- Pushed to 3.8.x will be in 3.8.4 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 09:26:02 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 07:26:02 +0000 Subject: [Koha-bugs] [Bug 8575] Number of items expected is wrong In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8575 --- Comment #4 from Chris Cormack --- Pushed to 3.8.x, will be in 3.8.4 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 09:27:30 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 07:27:30 +0000 Subject: [Koha-bugs] [Bug 8479] Opac Holds being created with priority set to NULL In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8479 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj at kohaaloha.com QA Contact| |mtj at kohaaloha.com --- Comment #3 from Mason James --- (In reply to comment #2) > Created attachment 11344 [details] > Bug 8479 Calculate rank irrespective of display option > > Signed-off-by: Kyle M Hall patch looks good, passing QA mason at xen1:~/git/head$ koha-qa.pl * 90dd666 Bug 8479 Calculate rank irrespective of display option opac/opac-reserve.pl - perlcritic-progressive tests... OK - perl -c syntax tests... OK - xt/tt_valid.t tests... OK - xt/author/valid-template.t tests... OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 09:34:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 07:34:09 +0000 Subject: [Koha-bugs] [Bug 8586] Small bug in die if no mapping in framework for biblioitems.biblioitemnumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8586 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj at kohaaloha.com QA Contact| |mtj at kohaaloha.com --- Comment #4 from Mason James --- (In reply to comment #3) > Created attachment 11461 [details] > Bug 8586: Small bug in die if no mapping in framework for > biblioitems.biblioitemnumber > > Signed-off-by: Chris Cormack patch looks good, passing QA mason at xen1:~/git/head$ koha-qa.pl * 4481197 Bug 8586: Small bug in die if no mapping in framework for biblioitems.biblioitemnumber C4/Biblio.pm - perlcritic-progressive tests... OK - perl -c syntax tests... OK - xt/tt_valid.t tests... OK - xt/author/valid-template.t tests... OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 09:35:23 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 07:35:23 +0000 Subject: [Koha-bugs] [Bug 8495] Javascript error when creating a new order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8495 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11106|0 |1 is obsolete| | --- Comment #4 from Chris Cormack --- Created attachment 11524 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11524&action=edit Bug 8495: Fix JS error when creating a new order bug introduced by bug 7178 (http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7178) Signed-off-by: Jonathan Druart Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 09:37:42 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 07:37:42 +0000 Subject: [Koha-bugs] [Bug 8495] Javascript error when creating a new order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8495 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 09:46:16 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 07:46:16 +0000 Subject: [Koha-bugs] [Bug 8112] Overdues with Fines giving duplicates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8112 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 09:53:32 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 07:53:32 +0000 Subject: [Koha-bugs] [Bug 5342] Serial claiming improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5342 --- Comment #36 from Jonathan Druart --- (In reply to comment #35) > Hi Jonathan, Hi Katrin, > You wrote: "(note the "order" tag could be "whatever")" What does this mean? > I could write around my item fields and it would still get repeated > correctly? Yes > I see that there is no tag to mark the repeating section in the HTML message > you posted - how does the template know which parts to repeat for each > serial that needs to be claimed? My development has been modified a lot of time and is not the one used by our customer. First patch needed an order tag. Now, since Bug 7001, this behaviour changed and I don't know exactly how it works. But I think the results (see comment 34) are what we want. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 10:02:12 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 08:02:12 +0000 Subject: [Koha-bugs] [Bug 8307] Set a value for items when receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8307 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |paul.poulain at biblibre.com --- Comment #4 from Paul Poulain --- Patch tested with a sandbox, by Delaye Stephane -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 10:02:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 08:02:25 +0000 Subject: [Koha-bugs] [Bug 8307] Set a value for items when receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8307 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11379|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 10:02:30 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 08:02:30 +0000 Subject: [Koha-bugs] [Bug 8307] Set a value for items when receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8307 --- Comment #5 from Paul Poulain --- Created attachment 11525 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11525&action=edit Bug 8307: Set a value for items when ordering If items are created when ordering, this patch allows to add a value for a field. Test plan: Define status for items.notforloan (mapping 995$o in unimarc), for example 4:On order, 5:On treatment Set the Syspref AcqCreateItem on "ordering". ACQ framework : set default value = 4 for 995$o (in unimarc) Syspref AcqItemStatusWhenReceived : set "995$o=5" When ordering the item, default status will be 4 ; when receiving the item, status will be changed from 4 to 5 Signed-off-by: Delaye Stephane -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 10:12:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 08:12:10 +0000 Subject: [Koha-bugs] [Bug 8581] Authority display doesn't like GND records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8581 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj at kohaaloha.com --- Comment #3 from Mason James --- (In reply to comment #2) > Created attachment 11395 [details] > Bug 8581: don't display parentheses when we don't have a type > > Signed-off-by: Chris Cormack patch looks good, passing QA *NOTE: PATCH MUST BE APPLIED AFTER 3462* mason at xen1:~/git/head$ git bz apply 3462 Bug 3462 - Link see alsos in authorities Bug 3462: Links in authorities should be hyperlinks Apply? [yn] y Applying: Bug 3462: Links in authorities should be hyperlinks mason at xen1:~/git/head$ git bz apply 8581 Bug 8581 - Authority display doesn't like GND records Bug 8581: don't display parentheses when we don't have a type Apply? [yn] y Applying: Bug 8581: don't display parentheses when we don't have a type mason at xen1:~/git/head$ mason at xen1:~/git/head$ koha-qa.pl * 645650a Bug 8581: don't display parentheses when we don't have a type koha-tmpl/intranet-tmpl/prog/en/includes/authorities-search-results.inc koha-tmpl/opac-tmpl/prog/en/includes/authorities-search-results.inc - perlcritic-progressive tests... OK - perl -c syntax tests... OK - xt/tt_valid.t tests... OK - xt/author/valid-template.t tests... OK mason at xen1:~/git/head$ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 10:16:34 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 08:16:34 +0000 Subject: [Koha-bugs] [Bug 3462] Link see alsos in authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3462 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj at kohaaloha.com --- Comment #14 from Mason James --- (In reply to comment #13) > Created attachment 11390 [details] > Bug 3462: Links in authorities should be hyperlinks > Signed-off-by: Jared Camins-Esakov > Rebased 26 July 2012 > > Signed-off-by: Jared Camins-Esakov > Rebased on master 1 August 2012 > > Signed-off-by: Jared Camins-Esakov > Rebased on master 6 August 2012 > > Signed-off-by: Katrin Fischer patch looks good, passing QA well done everyone :) mason at xen1:~/git/head$ koha-qa.pl * 02ea726 Bug 3462: Links in authorities should be hyperlinks C4/AuthoritiesMarc.pm koha-tmpl/intranet-tmpl/prog/en/includes/authorities-search-results.inc koha-tmpl/intranet-tmpl/prog/en/modules/authorities/searchresultlist.tt koha-tmpl/opac-tmpl/prog/en/includes/authorities-search-results.inc koha-tmpl/opac-tmpl/prog/en/modules/opac-authoritiessearchresultlist.tt opac/opac-authorities-home.pl - perlcritic-progressive tests... OK - perl -c syntax tests... OK - xt/tt_valid.t tests... OK - xt/author/valid-template.t tests... OK -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 10:18:32 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 08:18:32 +0000 Subject: [Koha-bugs] [Bug 7963] Parallel HTTP requests when checking URLs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7963 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion CC| |mtj at kohaaloha.com --- Comment #16 from Mason James --- (In reply to comment #15) > Hi Fr?d?ric, > > Thank you for submitting this patch such fast :) > It works very well in all my tests. > > Just somes little remarks: status modded to 'in discussion' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 10:19:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 08:19:28 +0000 Subject: [Koha-bugs] [Bug 6832] Validation of total > budget in neworderempty In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6832 --- Comment #17 from Jonathan Druart --- (In reply to comment #15) > (In reply to comment #13) > > QA Comments: > > > > It seems the patch does not work as expected. > > I think your ajax script must to return $budget->{budget_amount} - > > C4::Budgets::GetBudgetSpent($budget->{id}) (or GetBudgetOrdered ?). > > My patch doesn't change the behavior of acqui/check_budget_total.pl at all, > so i'm really not sure what you are talking about. Could you explain in more > details ? The ajax script returns $budget->{'budget_amount'}. In the tt/js code an alert appears if the total for the current order is > the amount of the selected budget. Suppose a budget A is created with 100? and 90? are already spent then we have a "base-level remaining" equal to 10?. If I create, for example, an order with this budget and a total cost = 40, the script does not display the alert. But the order amount is > to the amount remaining. Then I think the alert should not take into account the total budget allocated but the base-level remaining. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 10:20:59 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 08:20:59 +0000 Subject: [Koha-bugs] [Bug 8495] Javascript error when creating a new order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8495 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact| |mtj at kohaaloha.com --- Comment #5 from Mason James --- (In reply to comment #4) > Created attachment 11524 [details] > Bug 8495: Fix JS error when creating a new order > > bug introduced by bug 7178 > (http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7178) > > Signed-off-by: Jonathan Druart > Signed-off-by: Chris Cormack patch looks good, passing QA mason at xen1:~/git/head$ koha-qa.pl * cf863e0 Bug 8495: Fix JS error when creating a new order koha-tmpl/intranet-tmpl/prog/en/js/additem.js - perlcritic-progressive tests... OK - perl -c syntax tests... OK - xt/tt_valid.t tests... OK - xt/author/valid-template.t tests... OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 10:27:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 08:27:09 +0000 Subject: [Koha-bugs] [Bug 7168] Search orders by basket group name In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7168 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11416|0 |1 is obsolete| | --- Comment #2 from Marc V?ron --- Created attachment 11526 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11526&action=edit [SIGNED-OFF] Bug 7168: Add basket group search field in histsearch.pl Allow to search orders by basket group name Signed-off-by: Marc Veron Displays search field for baketgroup as expected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 10:27:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 08:27:27 +0000 Subject: [Koha-bugs] [Bug 7168] Search orders by basket group name In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7168 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 10:41:19 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 08:41:19 +0000 Subject: [Koha-bugs] [Bug 6617] table of contents not printing right if entered right In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6617 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj at kohaaloha.com --- Comment #25 from Mason James --- (In reply to comment #24) > Created attachment 11368 [details] > [SIGNED-OFF] Bug 6617: Improve MARC21 enhanced contents display (intranet) > > The display of "Enhanced" 505 (contents) fields in the MARC21 > XSLT is very poor, resulting in large, unreadable blocks of text, > and -- for some series -- so much unnecessary duplication in the > Notes tab that important information is entirely obscured. This > patch reformats "enhanced" contents fields (MARC21 505 fields with > $t and $r) so as to be more readable by breaking up entries on > separate lines and making titles bold (to make them stand out more). > > This patch does not address duplication of information in the Notes > tab, per discussion on the #koha IRC channel. > > To test: > 1) View record with enhanced 505 field before applying patch. Observe > it is very unfriendly. > 2) Apply patch. > 3) View same record, note that display is much improved. > > Signed-off-by: Katrin Fischer > Display in staff and OPAC is consistent and improved after > applying the patch. patch looks good, passing QA on all patches xslt files pass validation. mason at xen1:~/git/head$ prove ./t/00-valid-xml.t Result: PASS mason at xen1:~/git/head$ koha-qa.pl -c 2 * e4ad597 Bug 6617: Improve MARC21 enhanced contents display (intranet) koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slimUtils.xsl * 1a9cbf9 Bug 6617: Improve MARC21 enhanced contents display koha-tmpl/opac-tmpl/prog/en/css/opac.css koha-tmpl/opac-tmpl/prog/en/xslt/MARC21slim2OPACDetail.xsl koha-tmpl/opac-tmpl/prog/en/xslt/MARC21slimUtils.xsl - perlcritic-progressive tests... OK - perl -c syntax tests... OK - xt/tt_valid.t tests... OK - xt/author/valid-template.t tests... OK -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 10:46:18 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 08:46:18 +0000 Subject: [Koha-bugs] [Bug 7294] status "in order" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 delaye changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |stephane.delaye at biblibre.co | |m --- Comment #30 from delaye --- I try to understand the usefulness of the patch. Want to display order information from the search? Ok but why the OPAC? How useful for the borrowers to know the price or the reference quantity of the order? And then from the interface professional why delete this information after receipt? Why not limit the display to the internal interface and do not delete the information after the receipt? .... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 10:47:50 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 08:47:50 +0000 Subject: [Koha-bugs] [Bug 8498] can't specify an hour when specifying due date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8498 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj at kohaaloha.com --- Comment #13 from Mason James --- (In reply to comment #10) > Other than this, nothing against a passed QA status i think Kyle has answered Cait's and Paul's questions to satisfaction, so... patch looks good, passing QA :) mason at xen1:~/git/head$ koha-qa.pl * e99beda Bug 8498 - can't specify an hour when specifying due date circ/circulation.pl koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css koha-tmpl/intranet-tmpl/prog/en/lib/jquery/jquery-ui.css koha-tmpl/intranet-tmpl/prog/en/lib/jquery/jquery-ui.js koha-tmpl/intranet-tmpl/prog/en/lib/jquery/plugins/jquery-ui-timepicker-addon.js koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt - perlcritic-progressive tests... OK - perl -c syntax tests... OK - xt/tt_valid.t tests... OK - xt/author/valid-template.t tests... OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 10:51:26 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 08:51:26 +0000 Subject: [Koha-bugs] [Bug 5725] Batch modifications for Biblios In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5725 delaye changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |stephane.delaye at biblibre.co | |m --- Comment #63 from delaye --- At the functional level there is not a duplicate with the 8015 bz ?..... -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 10:55:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 08:55:24 +0000 Subject: [Koha-bugs] [Bug 7241] circulation action logs record biblionumber instead of item number In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7241 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj at kohaaloha.com --- Comment #22 from Mason James --- (In reply to comment #20) > Created attachment 11415 [details] > [SIGNED-OFF] Bug 7241: fix for the CIRC logs -> itemnumber stored correctly > > Signed-off-by: Owen Leonard patch looks good, passing QA mason at xen1:~/git/head$ koha-qa.pl * a82aaaf Bug 7241: fix for the CIRC logs -> itemnumber stored correctly C4/Circulation.pm - perlcritic-progressive tests... OK - perl -c syntax tests... OK - xt/tt_valid.t tests... OK - xt/author/valid-template.t tests... OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 10:59:31 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 08:59:31 +0000 Subject: [Koha-bugs] [Bug 8357] UNIMARCslim2OPACDetail.xsl, title without class and too links to views In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8357 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj at kohaaloha.com --- Comment #16 from Mason James --- (In reply to comment #10) > Created attachment 11269 [details] > Bug 8204: fix UNIMARC display > > UNIMARC display of authorities in the OPAC wasn't working due to > changes in the BuildSummary function since the code was originally > developed. > > Signed-off-by: Paul Poulain > Signed-off-by: Zeno Tajoli patch looks good, passing QA mason at xen1:~/git/head$ koha-qa.pl * 442dae6 Bug 8357: UNIMARCslim2OPACDetail.xsl, title without class and too links to views koha-tmpl/intranet-tmpl/prog/en/xslt/UNIMARCslimUtils.xsl koha-tmpl/opac-tmpl/prog/en/xslt/MARC21slim2OPACDetail.xsl koha-tmpl/opac-tmpl/prog/en/xslt/UNIMARCslim2OPACDetail.xsl - perlcritic-progressive tests... OK - perl -c syntax tests... OK - xt/tt_valid.t tests... OK - xt/author/valid-template.t tests... OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 11:01:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 09:01:58 +0000 Subject: [Koha-bugs] [Bug 8533] Non-numeric cardnumbers screw up autoMemberNum In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8533 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj at kohaaloha.com --- Comment #7 from Mason James --- (In reply to comment #6) > Created attachment 11249 [details] > Bug 8533 - Non-numeric cardnumbers screw up autoMemberNum > > Signed-off-by: Jonathan Druart > Removes a warning from mysql: > Truncated incorrect INTEGER value: 'P13000' patch looks good, passing QA - nice regex Kyle! :) mason at xen1:~/git/head$ koha-qa.pl * 38c7808 Bug 8533 - Non-numeric cardnumbers screw up autoMemberNum C4/Members.pm - perlcritic-progressive tests... OK - perl -c syntax tests... OK - xt/tt_valid.t tests... OK - xt/author/valid-template.t tests... OK -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 11:03:23 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 09:03:23 +0000 Subject: [Koha-bugs] [Bug 6813] Acquistions - duplicate search across orders, suggestions and catalog In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6813 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #4 from Marc V?ron --- Great enhancement (that b.t.w. was urgently asked by our librarians a couple of days ago). I tested the patch. It behaves as expected, and I would like to sign-off... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 11:04:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 09:04:35 +0000 Subject: [Koha-bugs] [Bug 7560] SIP Self Checkout Ignoring Fines Thresholds for Not Being able to Check Out Books In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7560 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |mtj at kohaaloha.com --- Comment #3 from Mason James --- (In reply to comment #2) > Created attachment 11475 [details] > Bug 7560 - SIP Self Checkout Ignoring Fines Thresholds for Not Being able to > Check Out Books > > Add checks in C4::ILS::Patron and C4::ILS::Transaction::Renew to make sure > the patron > is below the noissuescharge system pref for issues and OPACFineNoRenewals > for renewals. > > Signed-off-by: Chris Cormack perl syntax error in C4/SIP/ILS/Transaction/Renew.pm sorry, failing QA... mason at xen1:~/git/head$ koha-qa.pl * 2f47961 Bug 7560 - SIP Self Checkout Ignoring Fines Thresholds for Not Being able to Check Out Books C4/Overdues.pm C4/SIP/ILS/Patron.pm C4/SIP/ILS/Transaction/Renew.pm - perlcritic-progressive tests... OK - perl -c syntax tests... FAIL C4/SIP/ILS/Transaction/Renew.pm FAIL - xt/tt_valid.t tests... OK - xt/author/valid-template.t tests... OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 11:12:02 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 09:12:02 +0000 Subject: [Koha-bugs] [Bug 8520] Authorities display incorrectly in staff results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8520 --- Comment #16 from Jared Camins-Esakov --- (In reply to comment #15) > (In reply to comment #10) > > Created attachment 11420 [details] > > Bug 8520: fix authority display in autocomplete > > > Jared, this patch is surely for another bug? yes? No, same bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 11:19:07 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 09:19:07 +0000 Subject: [Koha-bugs] [Bug 7560] SIP Self Checkout Ignoring Fines Thresholds for Not Being able to Check Out Books In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7560 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #4 from Mason James --- (In reply to comment #3) > (In reply to comment #2) > > Created attachment 11475 [details] > > Bug 7560 - SIP Self Checkout Ignoring Fines Thresholds for Not Being able to > > Check Out Books > > > > Add checks in C4::ILS::Patron and C4::ILS::Transaction::Renew to make sure > > the patron > > is below the noissuescharge system pref for issues and OPACFineNoRenewals > > for renewals. > > > > Signed-off-by: Chris Cormack > > perl syntax error in C4/SIP/ILS/Transaction/Renew.pm > sorry, failing QA... > > oops, it looks like perl -c fails *before* this patch too :( ok, i'll have another look at it... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 11:21:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 09:21:35 +0000 Subject: [Koha-bugs] [Bug 8556] "Mark seen and continue" not translatable in inventory.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8556 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj at kohaaloha.com --- Comment #3 from Mason James --- (In reply to comment #2) > Created attachment 11289 [details] > Bug 8556 - "Mark seen and continue" not translatable in inventory.tt > > Added missing _(...) wrapper in JavaScript in inventory.tt > Additionaly added two blanks to separate buttons (were sticked together > without white space) > > Signed-off-by: Jonathan Druart patch looks good, passing QA mason at xen1:~/git/head$ koha-qa.pl * 6e44271 Bug 8556 - "Mark seen and continue" not translatable in inventory.tt koha-tmpl/intranet-tmpl/prog/en/modules/tools/inventory.tt - perlcritic-progressive tests... OK - perl -c syntax tests... OK - xt/tt_valid.t tests... OK - xt/author/valid-template.t tests... OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 11:42:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 09:42:41 +0000 Subject: [Koha-bugs] [Bug 5858] Default frameworks missing many MARC21 tags In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at enger.priv.no --- Comment #10 from Magnus Enger --- (In reply to comment #9) > I am not sure deleting them is a good idea - I would have to test it, but is > there a chance we loose data if someone imports data that uses fields that > are not defined in the default framework? I think I would prefer to see them > hidden and marked [OBSOLETE] to be sure no data can be lost. Should this be marked as "in discussion"? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 11:51:55 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 09:51:55 +0000 Subject: [Koha-bugs] [Bug 7294] status "in order" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 --- Comment #31 from Matthias Meusburger --- Kyle, are you sure you have mapped aqorders.ordernumber? This is mandatory. Anyway, here's my test plan: 1) Create the mappings using the ACQ framework. Here's what I have used for testing, using 930: a ordernumber Tab:9, | Koha field: aqorders.ordernumber, Not repeatable, Mandatory, Edit Delete b listprice Tab:9, | Koha field: aqorders.listprice, Not repeatable, Not mandatory, Edit Delete c branchcode Tab:9, | Koha field: aqorders.branchcode, Not repeatable, Not mandatory, Edit Delete d quantity Tab:9, | Koha field: aqorders.quantity, Not repeatable, Not mandatory, Edit Delete e test2 Tab:9, Not repeatable, Not mandatory, 2) Select a basket 3) Add an order to basket (in my case: from an existing record) 4) Fill item informations (syspref AcqCreateItem's value is: Create an item when placing an order) 5) Add the item 6) Quantity is now at 1. Select a budget. Fill order informations. Save. 7) You're back at the basket details screen. Click on the newly ordered title. Click on "Marc". Click on "9". Here's what i've got: 930 ## - order a ordernumber 38 c branchcode FPL d quantity 1 b listprice 12.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 12:04:52 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 10:04:52 +0000 Subject: [Koha-bugs] [Bug 5332] Add batch reversion capability to bin/commit_biblios_file.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5332 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED CC| |magnus at enger.priv.no Resolution|--- |DUPLICATE --- Comment #13 from Magnus Enger --- The main functionality of this patch (the --revert option) is covered by the patch for Bug 2060 (which is already signed off), as pointed out by Jared in Comment 12. I'm marking this bug as a duplicate of that bug. The present patch does introduce another option (--progress-interval) which is not present in the patches for Bug 2060, so that might be implemented on top of 2060 if someone wants to. *** This bug has been marked as a duplicate of bug 2060 *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 12:04:52 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 10:04:52 +0000 Subject: [Koha-bugs] [Bug 2060] Ability to import Authorities from Staff Client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2060 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dpk at randomnotes.org --- Comment #14 from Magnus Enger --- *** Bug 5332 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 12:05:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 10:05:35 +0000 Subject: [Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 delaye changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |stephane.delaye at biblibre.co | |m --- Comment #4 from delaye --- i test with a sandbox .it work. In the opac with have the two dates shown(AAAA-MM-JJ and text) *** an automatic mode for managing the date formats through authorised values ??activated in subscriptions records would also a idea ... but this does not mean the same developement..... *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 12:19:50 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 10:19:50 +0000 Subject: [Koha-bugs] [Bug 6488] opachiddenitems not working in master In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6488 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers at biblibre.co | |m See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=3194 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 12:19:50 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 10:19:50 +0000 Subject: [Koha-bugs] [Bug 3194] Hide records in the OPAC if all items are lost and "hidelostitems" is on In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3194 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=6488 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 12:19:53 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 10:19:53 +0000 Subject: [Koha-bugs] [Bug 6813] Acquistions - duplicate search across orders, suggestions and catalog In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6813 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED Assignee|amit.gupta at osslabs.biz |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 12:29:46 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 10:29:46 +0000 Subject: [Koha-bugs] [Bug 6813] Acquistions - duplicate search across orders, suggestions and catalog In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6813 --- Comment #5 from Jonathan Druart --- Created attachment 11527 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11527&action=edit Bug 6813: Followup: indentation + simplify conditions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 12:30:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 10:30:24 +0000 Subject: [Koha-bugs] [Bug 6813] Acquistions - duplicate search across orders, suggestions and catalog In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6813 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Assignee|jonathan.druart at biblibre.co |amit.gupta at osslabs.biz |m | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 12:33:26 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 10:33:26 +0000 Subject: [Koha-bugs] [Bug 4173] Statuses not appearing in the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4173 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 12:37:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 10:37:21 +0000 Subject: [Koha-bugs] [Bug 8619] New: Remove hidelostitems syspref Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8619 Priority: P5 - low Change sponsored?: --- Bug ID: 8619 Assignee: oleonard at myacpl.org Summary: Remove hidelostitems syspref Severity: enhancement Classification: Unclassified OS: All Reporter: fridolyn.somers at biblibre.com Hardware: All Status: NEW Version: master Component: OPAC Product: Koha With 'OpacHiddenItems' system preference, you can reproduce what's managed by 'hidelostitems' system preference. For example, if LOST values are 0,1,2,3 (0 meaning not lost), you can use in OpacHiddenItems : itemslost [1, 2, 3]. So hidelostitems is now deprecated since OpacHiddenItems is more rich. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 12:40:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 10:40:43 +0000 Subject: [Koha-bugs] [Bug 7908] Acquisitions: Maintain payment details against vendors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7908 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |julian.maurice at biblibre.com --- Comment #3 from Julian Maurice --- Hello Amit, I don't understand the purpose of this feature. What is it done for? I see we can attach some additional informations to invoices (chequeno, chequedate, and notes) but the interface is not clear for me. It looks like we are grouping invoice together for payment, but in fact nothing is grouped and we attach the same infos for all selected invoices. Does it make sense to have the same cheque no. for different invoices? Isn't the purpose of invoices to separate payments? Besides that, it's impossible to modify what was done. That could make sense, but punish immediately user that make a mistake. About 'notes', I didn't find any place where it is displayed. Did I miss something? I think you should take a look at Bug 5339. It move invoice informations into their own table and brings a couple of pages for managing them. I think you can easily integrate your feature into this development. just a last comment: datepicker doesn't work in payment.pl. The way to declare datepicker has changed recently, you have to remove the JS block, and just add class "datepicker" to your input -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 13:04:05 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 11:04:05 +0000 Subject: [Koha-bugs] [Bug 8240] There is dead code in orderreceive.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8240 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |In Discussion --- Comment #6 from Jonathan Druart --- (In reply to comment #5) > Changing status for need of clarification. Hi Marcel, For me, this kind of page needs an id (here ordernumber). 2 cases : - The id exists and the script can provide consistent results. - The id is not defined (or is a bad id, ie. there is no result) and the template displays an error (here "This ordernumber does not exist."). I think in the latter case the error message is necessary to inform the user (or developper) that the page should not exist. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 13:05:42 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 11:05:42 +0000 Subject: [Koha-bugs] [Bug 7684] inventory : datatable fix actions etc. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart at biblibre.co |matthias.meusburger at biblibr |m |e.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 13:13:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 11:13:57 +0000 Subject: [Koha-bugs] [Bug 7303] Not being able to create funds with the same name In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7303 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7683|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 11528 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11528&action=edit Bug 7303: Adds unicity for budget and fund This patch adds a unique key on fields: aqbudgets.budget_name aqbudgets.budget_code aqbudgetperiods.budget_period_description To test, try to: - create 2 budgets with same description - create 2 funds with same name - create 2 funds with same code All of these cases should be generate an error -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 13:14:56 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 11:14:56 +0000 Subject: [Koha-bugs] [Bug 7303] Not being able to create funds with the same name In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7303 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |In Discussion Assignee|jonathan.druart at biblibre.co |francois.charbonnier at biblib |m |re.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 13:24:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 11:24:10 +0000 Subject: [Koha-bugs] [Bug 7303] Not being able to create funds with the same name In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7303 --- Comment #8 from Katrin Fischer --- Hi Jonathan and all, I still think a unique key on aqbudgets.budget_name and aqbudgets.budget_code it's a bad idea and will break workflows for libraries. 1) The aqbudgets table already has a primary key (budget_id) as has aqbudgetperiods (budget_period_id). 2) It will make it impossible to duplicate your budget hierarchy for the next year which is a working feature in master. 3) A feature I am asked for is a way to move orders and money from one year to the next. I think if it's allowed to use the same codes, this is very easy to do - but if you are forced to change them each year, you will need some tool for mapping funds over several years. 4) The codes libraries here use do not change with each year - you would force them to add a prefix/suffix or something similar. This would make their life harder, for example when they need reports with the official codes and descriptions. 5) It's currently not enforced - I think the update database will not work? If this is only a check for libraries editing/adding new funds, couldn't we make it only check for duplicates in the same time period/budget? And a way to overwrite if it's intended? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 13:39:52 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 11:39:52 +0000 Subject: [Koha-bugs] [Bug 8185] Plugin for linking records in MARC21 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8185 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11327|0 |1 is obsolete| | --- Comment #9 from Mirko Tietgen --- Created attachment 11529 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11529&action=edit This is the plugin for linking records in Marc21. It works like the unimarc plugin unimarc_field_4XX. It insert: $9 -> biblionumber $w -> 001 $t -> 245$a (title ) $x -> 022$a (ISSN) $z -> 020$a (ISBN) The search is done on 'any' index. Data are inserted only in the working record. To insert data in the connected record, you need to open the other record. http://bugs.koha-community.org/show_bug.cgi?id=8185 Signed-off-by: Mirko Tietgen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 13:47:53 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 11:47:53 +0000 Subject: [Koha-bugs] [Bug 8185] Plugin for linking records in MARC21 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8185 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11510|0 |1 is obsolete| | --- Comment #10 from Mirko Tietgen --- Created attachment 11530 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11530&action=edit Bug 8185 Follow-Up: Some more Italian strings changed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 13:48:59 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 11:48:59 +0000 Subject: [Koha-bugs] [Bug 8185] Plugin for linking records in MARC21 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8185 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 13:51:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 11:51:10 +0000 Subject: [Koha-bugs] [Bug 8185] Plugin for linking records in MARC21 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8185 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 13:56:19 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 11:56:19 +0000 Subject: [Koha-bugs] [Bug 8185] Plugin for linking records in MARC21 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8185 --- Comment #11 from Mirko Tietgen --- I signed off on Zeno's patch. It works as expected. Since it had some Italian inside I provided a tiny followup. Only the followup needs a signoff by verifying that there is no Italian in the plugin. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 13:57:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 11:57:33 +0000 Subject: [Koha-bugs] [Bug 7887] Add Option To Include Items That Will Be Available When Calculating Holds Ratios In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7887 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |julian.maurice at biblibre.com --- Comment #5 from Julian Maurice --- 1. from patch: +my $not_for_loan_comparison = ( $include_will_be_available ) ? "<=" : "="; ... +notforloan $not_for_loan_comparison 0 AND damaged = 0 AND itemlost = 0 AND wthdrawn = 0 In which case notforloan will be lesser than 0? 2. As use of aqorders table is conditional, I think the join should be conditionnal too. 3. I get "Illegal division by zero at /home/julian/koha/versions/community-master/circ/reserveratios.pl line 155." when checking "Include on order items". It seems that x+NULL = NULL with MySQL. I think it can be fixed with (2) Failed QA for (3) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 14:02:22 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 12:02:22 +0000 Subject: [Koha-bugs] [Bug 7589] tinymce editor broken in .deb packages - in 'en' templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7589 --- Comment #10 from Mason James --- (In reply to comment #9) > I just tested on an installation of 3.8.3 running off the official packages, > and it has tiny_mce working beautifully for both English and Norwegian. > Maybe this is just a problem for 3.6.x now? well... looks like its still broken, in the latest stable .deb mason at gw1:~$ dpkg -c ./koha-common_3.8.3.1-1_all.deb |grep jscript |wc -l 0 what that '0' means is that there is ZERO dirs in the package called 'jscript' the 'jscript' dir gets deleted in ./debian/rules rm -r $(TMP)/usr/share/koha/intranet/htdocs/intranet-tmpl/prog/en/js/tinymce which means that the below call for tiny_mce in ./prog/en/modules/tools/koha-news.tt will fail (which is the bug) script language="javascript" type="text/javascript" src="[% themelang %]/js /tinymce/jscripts/tiny_mce/tiny_mce.js"> and thats the bug, that the patch fixes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 14:09:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 12:09:33 +0000 Subject: [Koha-bugs] [Bug 7589] tinymce editor broken in .deb packages - in 'en' templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7589 --- Comment #11 from Robin Sheat --- The next line is: ln -s /usr/share/tinymce2/www \ $(TMP)/usr/share/koha/intranet/htdocs/intranet-tmpl/prog/en/js/tinymce it's linking in the system copy of tinymce. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 14:09:42 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 12:09:42 +0000 Subject: [Koha-bugs] [Bug 8484] Add ability to choose if lost items are removed from a borrowers record. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8484 delaye changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |stephane.delaye at biblibre.co | |m --- Comment #4 from delaye --- i test the patch in a sandbox To test the patch I made ??the following steps I record a check out I edit the item and I put in 995$2 (UNIMARC) value 1 (items.lost) I return to the account of the borrower -> The items has not been checked in But regardless the value (check in, don('t check in) under the preference system ReturnLostItems the preference systeme work only if the item is update by the script misc/cronjobs/longoverdue.pl ?... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 14:20:44 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 12:20:44 +0000 Subject: [Koha-bugs] [Bug 6813] Acquistions - duplicate search across orders, suggestions and catalog In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6813 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9982|0 |1 is obsolete| | Attachment #11527|0 |1 is obsolete| | --- Comment #6 from Marc V?ron --- Created attachment 11531 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11531&action=edit Bug 6813: Acquistions duplicate search across orders, suggestions and catalog To Test: Create a an suggestion, order and catalog record for a certain title. Use the duplicate search tool available in the acquisitions menu (left navigation bar) to search and find the suggestion, order and catalog record matching the search term. Enter one or more of title, author and ISBN in the search criteria. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 14:22:19 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 12:22:19 +0000 Subject: [Koha-bugs] [Bug 6813] Acquistions - duplicate search across orders, suggestions and catalog In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6813 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11531|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 14:23:01 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 12:23:01 +0000 Subject: [Koha-bugs] [Bug 6813] Acquistions - duplicate search across orders, suggestions and catalog In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6813 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11527|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 14:23:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 12:23:21 +0000 Subject: [Koha-bugs] [Bug 6813] Acquistions - duplicate search across orders, suggestions and catalog In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6813 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9982|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 14:24:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 12:24:43 +0000 Subject: [Koha-bugs] [Bug 6813] Acquistions - duplicate search across orders, suggestions and catalog In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6813 --- Comment #7 from Marc V?ron --- Followed "Bugs with more than one patch" on http://wiki.koha-community.org/wiki/Git_bz_configuration ...but certainly did something wrong. Will try again.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 14:27:34 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 12:27:34 +0000 Subject: [Koha-bugs] [Bug 7589] tinymce editor broken in .deb packages - in 'en' templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7589 --- Comment #12 from Magnus Enger --- (In reply to comment #9) > I just tested on an installation of 3.8.3 running off the official packages, > and it has tiny_mce working beautifully for both English and Norwegian. > Maybe this is just a problem for 3.6.x now? A little more digging reminded me that I made some non-standard symlinks at one time, forget my saying this works for me! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 14:35:15 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 12:35:15 +0000 Subject: [Koha-bugs] [Bug 7589] tinymce editor broken in .deb packages - in 'en' templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7589 --- Comment #13 from Mason James --- (In reply to comment #9) > I just tested on an installation of 3.8.3 running off the official packages, > and it has tiny_mce working beautifully for both English and Norwegian. > Maybe this is just a problem for 3.6.x now? Magnus has confessed that he fixed this bug manually using symlinks :) so, 1) yes, its still confirmed busted in master 2) yes, the patch still fixes it -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 14:51:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 12:51:33 +0000 Subject: [Koha-bugs] [Bug 6813] Acquistions - duplicate search across orders, suggestions and catalog In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6813 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9982|0 |1 is obsolete| | Attachment #11527|0 |1 is obsolete| | --- Comment #8 from Marc V?ron --- Created attachment 11532 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11532&action=edit Bug 6813: Acquistions duplicate search across orders, suggestions and catalog To Test: Create a an suggestion, order and catalog record for a certain title. Use the duplicate search tool available in the acquisitions menu (left navigation bar) to search and find the suggestion, order and catalog record matching the search term. Enter one or more of title, author and ISBN in the search criteria. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 14:54:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 12:54:24 +0000 Subject: [Koha-bugs] [Bug 6813] Acquistions - duplicate search across orders, suggestions and catalog In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6813 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11532|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 14:54:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 12:54:57 +0000 Subject: [Koha-bugs] [Bug 6813] Acquistions - duplicate search across orders, suggestions and catalog In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6813 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9982|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 14:55:16 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 12:55:16 +0000 Subject: [Koha-bugs] [Bug 6813] Acquistions - duplicate search across orders, suggestions and catalog In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6813 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11527|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 15:11:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 13:11:24 +0000 Subject: [Koha-bugs] [Bug 6813] Acquistions - duplicate search across orders, suggestions and catalog In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6813 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9982|0 |1 is obsolete| | Attachment #11527|0 |1 is obsolete| | --- Comment #9 from Marc V?ron --- Created attachment 11533 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11533&action=edit [SIGNED-OFF] Bug 6813: Followup: indentation + simplify conditions Signed-off-by: Marc Veron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 15:15:59 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 13:15:59 +0000 Subject: [Koha-bugs] [Bug 7805] Exposing the new list permissions in opac and staff In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7805 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart at biblibre.co | |m --- Comment #11 from Jonathan Druart --- Last patch marked as Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 15:20:26 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 13:20:26 +0000 Subject: [Koha-bugs] [Bug 6813] Acquistions - duplicate search across orders, suggestions and catalog In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6813 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11533|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 15:20:51 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 13:20:51 +0000 Subject: [Koha-bugs] [Bug 6813] Acquistions - duplicate search across orders, suggestions and catalog In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6813 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9982|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 15:21:19 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 13:21:19 +0000 Subject: [Koha-bugs] [Bug 6813] Acquistions - duplicate search across orders, suggestions and catalog In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6813 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11527|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 15:27:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 13:27:14 +0000 Subject: [Koha-bugs] [Bug 6813] Acquistions - duplicate search across orders, suggestions and catalog In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6813 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9982|0 |1 is obsolete| | --- Comment #10 from Marc V?ron --- Created attachment 11534 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11534&action=edit [SIGNED-OFF] Bug 6813: Followup: indentation + simplify conditions Signed-off-by: Marc Veron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 15:28:55 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 13:28:55 +0000 Subject: [Koha-bugs] [Bug 6813] Acquistions - duplicate search across orders, suggestions and catalog In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6813 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11534|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 15:29:20 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 13:29:20 +0000 Subject: [Koha-bugs] [Bug 8454] Holds to Pull : Show pull list on load. Otherwise, it looks like the pull list is empty. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8454 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart at biblibre.co | |m --- Comment #4 from Jonathan Druart --- QA Comments: Your patch is the same as if ( 1 ){} I think a better way to do this is : my $run_report = ( not defined $input->param('run_report') ) ? 1 : $input->param('run_report'); If someone wants to load this page without running the report it is possible. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 15:29:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 13:29:28 +0000 Subject: [Koha-bugs] [Bug 6813] Acquistions - duplicate search across orders, suggestions and catalog In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6813 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9982|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 15:51:01 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 13:51:01 +0000 Subject: [Koha-bugs] [Bug 7986] Export issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7986 Bug 7986 depends on bug 5600, which changed state. Bug 5600 Summary: Bulk MARC biblio export script http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5600 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 15:51:00 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 13:51:00 +0000 Subject: [Koha-bugs] [Bug 5600] Bulk MARC biblio export script In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5600 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #25 from Julian Maurice --- Ok in master. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 15:57:22 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 13:57:22 +0000 Subject: [Koha-bugs] [Bug 8478] Update Ubuntu related files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8478 --- Comment #15 from Tom?s Cohen Arazi --- I'm not sure about the naming Mark. For the 3.8.x patch I see we have: INSTALL.ubuntu INSTALL.ubuntu.12.04 INSTALL.ubuntu.lucid I'd completely remove INSTALL.ubuntu (I don't think we need the user to make assumptions on what version is for) and I'd provide a more consistent naming schema (as you did for the packages files). The same applies for the version against master, which I signed-off. I also prefer this to be pushed so we can send patches against it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 16:00:40 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 14:00:40 +0000 Subject: [Koha-bugs] [Bug 5057] Update koha INSTALL.ubuntu In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5057 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #4 from Tom?s Cohen Arazi --- *** This bug has been marked as a duplicate of bug 8478 *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 16:00:40 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 14:00:40 +0000 Subject: [Koha-bugs] [Bug 8478] Update Ubuntu related files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8478 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sivaji2009 at gmail.com --- Comment #16 from Tom?s Cohen Arazi --- *** Bug 5057 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 16:02:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 14:02:28 +0000 Subject: [Koha-bugs] [Bug 5339] Parcel closing in acq In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5339 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11077|0 |1 is obsolete| | --- Comment #67 from Julian Maurice --- Created attachment 11535 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11535&action=edit [SIGNED-OFF] Bug 5339: Invoices management improvement - New pages: - invoices.pl: allow to search in invoices on several criteria - invoice.pl: permit to view and modify invoice details - shipment date - billing date - shipment cost and budget used for shipment cost Invoice informations are now stored in their own sql table and aqorders have a link to it Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 16:02:46 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 14:02:46 +0000 Subject: [Koha-bugs] [Bug 5339] Parcel closing in acq In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5339 --- Comment #68 from Julian Maurice --- Patch rebased on master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 16:23:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 14:23:09 +0000 Subject: [Koha-bugs] [Bug 8478] Update Ubuntu related files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8478 --- Comment #17 from M. Tompsett --- Okay, let's step back... The install_misc/ubuntu.{version}.packages files make sense as each version of ubuntu will have differing requirements (eg. yaz3 vs. yaz4). However, I think you are correct regarding the INSTALL files. I'm not so sure we need more than one. However, the dselect statement is going to differ based on OS version, so it will need to be reflected in the documentation. My understanding was that you were planning on tweaking the documentation, which is why I attached a patch in the first place. My plan was to get INSTALL.ubuntu.12.04 correct and in good order, and then hopefully that would mean removal of the other two. And then we wouldn't need to version it. Unfortunately, I'm in the midst of other work, and can't dedicate time to clean up the patches. The patch should include (M=modified, -=remove, +=add) compared to master or 3.8.X: M INSTALL.ubuntu (which should be the INSTALL.ubuntu.12.04 git mv'd over INSTALL.ubuntu -- after confirming nothing extra would be lost) - INSTALL.ubuntu.lucid (versioning of install instructions makes no sense) M install_misc/ubuntu-pkg-check.sh (should reflect my changes) - install_misc/ubuntu_maverick.packages (which really gets renamed) + install_misc/ubuntu.10.10.packages + install_misc/ubuntu.10.04.packages (which is really a copy of the original ubuntu.packages file) + install_misc/ubuntu.12.04.packages (which is a tweaked and corrected version for either 3.6.X, 3.8.X or master -- there may be differences) M install_misc/ubuntu.packages (which is a copy of ubuntu.12.04.packages) Removal of INSTALL files could be done as a follow up bug. After all this is about updating files, not removing files. Renaming does not remove anything. And the master patch above continues to keep the install_misc/ubuntu_maverick.packages file. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 16:27:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 14:27:58 +0000 Subject: [Koha-bugs] [Bug 7688] Change subscriptions numbering pattern and frequencies In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688 --- Comment #38 from Jonathan Druart --- QA Comment: It would be better that someone not from BibLibre make QA on this patch. To pass QA, some points would be great: - mandatory: perltidy on all new files - minor: you change prototype for ModReceiveOrder but you don't modify files into the test directory - some unit tests for your invoices routines would be perfect. See Bug 5327, using DBD::Mock it is very simple. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 16:32:20 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 14:32:20 +0000 Subject: [Koha-bugs] [Bug 8520] Authorities display incorrectly in staff results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8520 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 16:34:17 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 14:34:17 +0000 Subject: [Koha-bugs] [Bug 7589] tinymce editor broken in .deb packages - in 'en' templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7589 --- Comment #14 from Mason James --- (In reply to comment #11) > The next line is: > > ln -s /usr/share/tinymce2/www \ > > $(TMP)/usr/share/koha/intranet/htdocs/intranet-tmpl/prog/en/js/tinymce > > it's linking in the system copy of tinymce. yep, its that *specific* line that has the bug :) (hint: the destination path is wrong) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 16:42:05 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 14:42:05 +0000 Subject: [Koha-bugs] [Bug 8478] Update Ubuntu related files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8478 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11205|0 |1 is obsolete| | --- Comment #18 from Tom?s Cohen Arazi --- Created attachment 11536 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11536&action=edit Bug 8478 - Update Ubuntu related files (3.8.x) Updated allation instructions, cleaned up ubuntu-pkg-check.sh, renamed ubuntu*.packages files more consistently, updated files to include missing libraries, corrected incorrect libraries (yaz3->yaz4, mysqlclient v16 to v18, dropped the dev version of the client). Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 16:45:18 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 14:45:18 +0000 Subject: [Koha-bugs] [Bug 8520] Authorities display incorrectly in staff results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8520 --- Comment #17 from Tom?s Cohen Arazi --- The second patch is a neede follow up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 16:48:05 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 14:48:05 +0000 Subject: [Koha-bugs] [Bug 6813] Acquistions - duplicate search across orders, suggestions and catalog In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6813 --- Comment #11 from Marc V?ron --- Created attachment 11537 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11537&action=edit [SIGNED-OFF] Bug 6813: Followup: indentation + simplify conditions Signed-off-by: Marc Veron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 16:48:54 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 14:48:54 +0000 Subject: [Koha-bugs] [Bug 8478] Update Ubuntu related files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8478 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 17:00:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 15:00:27 +0000 Subject: [Koha-bugs] [Bug 6813] Acquistions - duplicate search across orders, suggestions and catalog In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6813 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11537|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 17:07:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 15:07:25 +0000 Subject: [Koha-bugs] [Bug 8519] Make koha-index-daemon run on startup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8519 --- Comment #3 from Tom?s Cohen Arazi --- To test this patch, install Koha, create a symlink for this script: On Ubuntu: $ ln -s /usr/share/koha/bin/koha-zebra-indexdaemon-ctl.sh /etc/init.d/koha-zebra-indexdaemon $ update-rc.d koha-zebra-indexdaemon defaults $ service koha-zebra-indexdaemon start Then: - Check it started without errors in the logs (/var/log/koha/koha-indexdaemon*) - Do some cataloguing (biblios, authorities) and see if they are properly indexed by zebra. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 17:07:45 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 15:07:45 +0000 Subject: [Koha-bugs] [Bug 6813] Acquistions - duplicate search across orders, suggestions and catalog In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6813 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9982|0 |1 is obsolete| | Attachment #11527|0 |1 is obsolete| | --- Comment #12 from Marc V?ron --- Created attachment 11538 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11538&action=edit [SIGNED-OFF] Bug 6813: Followup: indentation + simplify conditions Signed-off-by: Marc Veron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 17:08:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 15:08:21 +0000 Subject: [Koha-bugs] [Bug 6813] Acquistions - duplicate search across orders, suggestions and catalog In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6813 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11538|0 |1 is obsolete| | --- Comment #13 from Marc V?ron --- Created attachment 11539 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11539&action=edit [SIGNED-OFF] Bug 6813: Followup: indentation + simplify conditions Signed-off-by: Marc Veron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 17:09:40 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 15:09:40 +0000 Subject: [Koha-bugs] [Bug 6813] Acquistions - duplicate search across orders, suggestions and catalog In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6813 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11539|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 17:10:23 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 15:10:23 +0000 Subject: [Koha-bugs] [Bug 6813] Acquistions - duplicate search across orders, suggestions and catalog In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6813 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9982|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 17:10:54 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 15:10:54 +0000 Subject: [Koha-bugs] [Bug 6813] Acquistions - duplicate search across orders, suggestions and catalog In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6813 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11527|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 17:16:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 15:16:47 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 --- Comment #50 from Jonathan Druart --- Created attachment 11540 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11540&action=edit adding file b -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 17:21:34 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 15:21:34 +0000 Subject: [Koha-bugs] [Bug 6813] Acquistions - duplicate search across orders, suggestions and catalog In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6813 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9982|0 |1 is obsolete| | Attachment #11527|0 |1 is obsolete| | --- Comment #14 from Marc V?ron --- Created attachment 11541 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11541&action=edit [SIGNED-OFF] Bug 6813: Acquistions duplicate search across orders, suggestions and catalog To Test: Create a an suggestion, order and catalog record for a certain title. Use the duplicate search tool available in the acquisitions menu (left navigation bar) to search and find the suggestion, order and catalog record matching the search term. Enter one or more of title, author and ISBN in the search criteria. Signed-off-by: Marc Veron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 17:21:44 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 15:21:44 +0000 Subject: [Koha-bugs] [Bug 6813] Acquistions - duplicate search across orders, suggestions and catalog In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6813 --- Comment #15 from Marc V?ron --- Created attachment 11542 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11542&action=edit [SIGNED-OFF] Bug 6813: Followup: indentation + simplify conditions Signed-off-by: Marc Veron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 17:22:12 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 15:22:12 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 --- Comment #51 from Jonathan Druart --- Created attachment 11543 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11543&action=edit adding file a -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 17:22:15 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 15:22:15 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 --- Comment #52 from Jonathan Druart --- Created attachment 11544 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11544&action=edit adding file b -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 10 18:16:32 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Aug 2012 16:16:32 +0000 Subject: [Koha-bugs] [Bug 8377] Show HTML5 video/ audio for media files in OPAC and staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377 --- Comment #16 from Mirko Tietgen --- Created attachment 11545 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11545&action=edit Bug 8377 [ENH] Show HTML5 video/ audio for media files in OPAC and staff client This enhancement uses information from MARC field 856 to generate the appropriate HTML5 code to embed am media player for the file(s) in a tab in the OPAC and staff client detail view. This patch supports the HTML5