From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 01:17:58 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 Jul 2012 23:17:58 +0000
Subject: [Koha-bugs] [Bug 8543] enter an 001 at acquisitions
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8543
--- Comment #2 from Nicole C. Engard ---
In this case the librarian was asking for this because he has the OCLC number
now and enters it in the 001 at the time of acquisition in his current system.
So in this scenario it will be right :) But I of course do know what you mean
:)
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 02:02:01 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2012 00:02:01 +0000
Subject: [Koha-bugs] [Bug 8545] New: ZOOM is silent on connection errors
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8545
Priority: P5 - low
Change sponsored?: ---
Bug ID: 8545
Assignee: gmcharlt at gmail.com
Summary: ZOOM is silent on connection errors
Severity: enhancement
Classification: Unclassified
OS: All
Reporter: starsid at gmail.com
Hardware: All
Status: NEW
Version: unspecified
Component: Searching
Product: Koha
In file Context.pm,
# forge to server
$Zconn->connect($host, 0);
# check for errors and warn
if ($Zconn->errcode() !=0) {
warn "something wrong with the connection: ". $Zconn->errmsg();
}
the error checking code does not warn when I change $host to something garbage.
The subsequent search query just returns an empty set without any errors.
OS: Ubuntu 12.04
Koha: 3.9-1~git+20120524174206.f9352e89
Zoom: 1.26-1build2
I also checked this on CentOS 6.2 with Koha 3.08.03 and ZOOM installed as the
latest version from the latest CPAN (I can check exact version numbers if
needed).
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 02:02:58 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2012 00:02:58 +0000
Subject: [Koha-bugs] [Bug 8545] ZOOM is silent on connection errors
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8545
Siddhartha Bagaria changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |starsid at gmail.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 02:10:00 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2012 00:10:00 +0000
Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167
Chris Nighswonger changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #6476|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 02:10:16 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2012 00:10:16 +0000
Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167
Chris Nighswonger changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #11129|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 02:26:42 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2012 00:26:42 +0000
Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167
--- Comment #127 from Chris Nighswonger ---
(In reply to comment #113)
> All the tests we made with Jonathan:
> Tests made:
> ? start from a clean situation (drop the 3 tables created by the new
> mechanism)
> ? checked that the old updatedatabase is still working by
> ? adding a 3.09.00.028 update, that is empty
> ? checked that we're redirected and the update is OK
Here is as far as I got before hitting a show-stopper:
1. Performed a clean install over a clean branch off of a freshly updated
master
2. git bz apply 7167; all patches applied cleanly to a fresh branch off master
3. Added a 3.09.00.028 update to test the correct functionality of the old
update database mechanism after the application of the Bug 7167 code; Koha
failed to redirect to the update screen after the addition of the test update.
Paul/Jonathan, were your tests run over a clean install on a fresh branch or
over a branch which was developed on?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 02:56:59 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2012 00:56:59 +0000
Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167
--- Comment #128 from Chris Nighswonger ---
(In reply to comment #127)
> (In reply to comment #113)
> > All the tests we made with Jonathan:
> > Tests made:
> > ? start from a clean situation (drop the 3 tables created by the new
> > mechanism)
> > ? checked that the old updatedatabase is still working by
> > ? adding a 3.09.00.028 update, that is empty
> > ? checked that we're redirected and the update is OK
>
> Here is as far as I got before hitting a show-stopper:
>
> 1. Performed a clean install over a clean branch off of a freshly updated
> master
> 2. git bz apply 7167; all patches applied cleanly to a fresh branch off
> master
> 3. Added a 3.09.00.028 update to test the correct functionality of the old
> update database mechanism after the application of the Bug 7167 code; Koha
> failed to redirect to the update screen after the addition of the test
> update.
>
> Paul/Jonathan, were your tests run over a clean install on a fresh branch or
> over a branch which was developed on?
On a quick perusal of Auth.pm changes, I'm not sure how this step could ever
work with the value of $koha39 hard-coded to 3.0900027. Perhaps I'm
misunderstanding your test plan?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 03:49:38 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2012 01:49:38 +0000
Subject: [Koha-bugs] [Bug 8545] ZOOM is silent on connection errors
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8545
--- Comment #1 from Siddhartha Bagaria ---
This is because the error code will not necessarily work in the async mode.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 04:19:35 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2012 02:19:35 +0000
Subject: [Koha-bugs] [Bug 8545] ZOOM is silent on connection errors
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8545
--- Comment #2 from Siddhartha Bagaria ---
(In reply to comment #1)
> This is because the error code will not necessarily work in the async mode.
I was partly wrong above. The eval's catch block is commented out. So the error
is not caught immediately. If the async mode is off, then the connect failed
error is caught while making the query.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 09:46:27 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2012 07:46:27 +0000
Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167
--- Comment #129 from Paul Poulain ---
(In reply to comment #128)
> > Paul/Jonathan, were your tests run over a clean install on a fresh branch or
> > over a branch which was developed on?
>
> On a quick perusal of Auth.pm changes, I'm not sure how this step could ever
> work with the value of $koha39 hard-coded to 3.0900027. Perhaps I'm
> misunderstanding your test plan?
Yikes... when we made the tests, we made some changes to run installer (like
adding fake revisions -new and old mechanism-) and, murphy's law, I made a
mistake reverting them.
The following re-uploaded patches are exactly the same except for
"reimplementing Reimplementing Marcel's suggestions & fixes" that check against
3.0900028 instead of 3.0900027
We have found another hidden problem, we will upload another follow-up in the
next 2 hours
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 10:57:07 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2012 08:57:07 +0000
Subject: [Koha-bugs] [Bug 8546] New: OPAC Advanced Search Publication date
range guide text FAIL
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8546
Priority: P5 - low
Change sponsored?: ---
Bug ID: 8546
Assignee: oleonard at myacpl.org
Summary: OPAC Advanced Search Publication date range guide text
FAIL
Severity: trivial
Classification: Unclassified
OS: All
Reporter: m.kirjasto.hailuoto at gmail.com
Hardware: All
Status: NEW
Version: unspecified
Component: OPAC
Product: Koha
Guide text in the advanced search form is incorrect:
"For example: 1999-2001. You could also use "-1987" for everything published
before 1987 or "2008-" for everything published after 2008." is illogical.
The logically and functionally correct way being:
For example: 1999-2001. You could also use "-1987" for everything published
before 1988 or "2008-" for everything published after 2007.
Reproducing the bug:
Search date range 2008- for "everything published _after_2008_" and you'll get
also books published 2008, not only after 2008.
@
http://catalog.farmingtonlibraries.org/cgi-bin/koha/opac-search.pl
This text bug prevails in community's demo runs 3.8, 3.6, 3.2 and master,
provided by Bywater, CALYX, Equinox, Libriotech, software.coop
http://koha-community.org/demo/
The four TOF demo Opacs on the list.
Also in Bywater sandbox OPAC
http://catalog.bywatersolutions.com/
EVEN THOUGH text bug has been fixed in Bywater sandbox Intranet
(ver.3.09.00.026, whatever that would mean) (login bywater - bywater reqrd):
http://intranet.bywatersolutions.com/cgi-bin/koha/catalogue/search.pl
Bug shows in live instances too, e.g. Farmington Koha,
http://catalog.farmingtonlibraries.org/cgi-bin/koha/opac-search.pl
Most likely in KOHA 3.10 too.
FIX SUGEGSTION, that do not age along the years: like w Bywater
format: yyyy-yyyy
PS.
All in all, when I "patron-eyed" Farmington Adv search, I started to miss guide
text feature. The advSearch page is so long.
It could be shortened. Esp. the Item type list should be made drop-down type
and also divided into 2 or more categories: Item types and thematical types. Or
newest item types? Now the list doesn't work for, well, anybody. Schratching
here my head: some patrons could use this as an itemtype browsing feature.
(Well but this is now off-topic already.)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 11:29:59 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2012 09:29:59 +0000
Subject: [Koha-bugs] [Bug 8192] Update libraries and Missing library in
install_misc/ubuntu.packages
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8192
M. Tompsett changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |DUPLICATE
--- Comment #1 from M. Tompsett ---
A similar problem was also dealt with in bug 8489.
*** This bug has been marked as a duplicate of bug 8478 ***
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 11:29:59 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2012 09:29:59 +0000
Subject: [Koha-bugs] [Bug 8478] Update Ubuntu related files
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8478
--- Comment #14 from M. Tompsett ---
*** Bug 8192 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 11:42:19 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2012 09:42:19 +0000
Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167
--- Comment #130 from Paul Poulain ---
Created attachment 11235
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11235&action=edit
Bug 7167: New version for updatedatabase
This patch use DataTable, see BUG|BZ 6836
- css/datatables.css
- lib/jquery/plugins/jquery.dataTables.min.js
- js/datatables.js
http://bugs.koha-community.org/show_bug.cgi?id=7167
Bug 7167 follow-up
Major changes:
* creating database tables for update on the fly, the 1st time the update
script is called
* version is checked on mainpage.pl (and here only). If syspref Version differ
from kohaversion.pl, the old updatedatabase is launched. If there are updates
missing from new mechanism, the updatedatabase page is reached
* kohaversion check on each page is now useless in Auth.pm, removed dead code
* Updated installer: at the end of the process, retrieve all updates and
automatically mark them "OK", as they're included in installer
Minor changes:
* adding copyright
* adding poddoc
* updating a warning, for better clarity
* switching from $$var to $var->
* small TT glitch fixed in updatedatabase.tt
* about.pl now returns the Version systempreference PLUS all the patches that
have been applied
Bug 7167 follow-up perlcritic & numbers display & partial apply depending on
DEBUG
* add use strict to updatedatabase, that is now perlcritic compliant
* partial apply of DB revs is now managed by DEBUG env variable = if DEBUG=0,
the user can just apply every DBrev. If DEBUG=1, we're in a dev env, the user
know has the option to apply DBrevs one by one
Display:
* in updatedatabase, small spelling changes
* in about.pl, remove 0 just after . (3.06.01 is displayed as 3.6.1)
* improve the display of applied numbers on about.pl
- before this patch, if you have N, N+1, N+2, N+3 and N+10 DB rev applied,
about was displaying : , N+1 / N+2 / N+3 / N+10
- after this patch you have N......N+3 / N+10
* add ORDER BY into list_versions_already_knows to have number retrieved in the
same order whatever the order they are applied
http://bugs.koha-community.org/show_bug.cgi?id=6679
Signed-off-by: Chris Nighswonger
Signed-off-by: Paul Poulain
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 11:42:24 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2012 09:42:24 +0000
Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167
--- Comment #131 from Paul Poulain ---
Created attachment 11236
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11236&action=edit
Bug 7167: Now, we check versions on mainpage.pl and after login
Signed-off-by: Paul Poulain
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 11:42:28 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2012 09:42:28 +0000
Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167
--- Comment #132 from Paul Poulain ---
Created attachment 11237
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11237&action=edit
Bug 7167: Improve the update.pl script
* Added CLI options to update.pl
* Call update.pl from the installer.
Signed-off-by: Paul Poulain
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 11:42:34 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2012 09:42:34 +0000
Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167
--- Comment #133 from Paul Poulain ---
Created attachment 11238
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11238&action=edit
Bug 7167: Reimplementing Marcel's suggestions & fixes
* Fixing the bugguy old version check (that was made against 3.0900000 instead
of 3.0900027 -the last current kohaversion number
* in the CLI script, if there is nothing to report, just say it
Signed-off-by: Paul Poulain
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 11:42:39 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2012 09:42:39 +0000
Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167
--- Comment #134 from Paul Poulain ---
Created attachment 11239
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11239&action=edit
Bug 7167: Remove check_coherency
As suggested by Katrin, we've removed the call to check_coherency. It intended
to provide readable comments when some SQL was wrong. Removing this sub result
in the SQL error being displayed. That's OK because the sysadmin or the
developer can google the error, understand it, then fix it.
Signed-off-by: Paul Poulain
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 11:42:46 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2012 09:42:46 +0000
Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167
--- Comment #135 from Paul Poulain ---
Created attachment 11240
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11240&action=edit
Bug 7167: Changing in .sql parsing
We first split on delimiter and then extract comments. You can now put
\n for delimiter comments.
ex:
DELIMITER ;
-- this is a comment
SELECT * FROM my_table;
-- another comment
Before this patch, we had to write:
DELIMITER ;
-- this is a comment;
SELECT * FROM my_table;
-- another comment;
Signed-off-by: Paul Poulain
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 11:42:54 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2012 09:42:54 +0000
Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167
--- Comment #136 from Paul Poulain ---
Created attachment 11241
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11241&action=edit
Bug 7167: Add .pl and .sql examples
Those files are in version directory, so will never be executed by the updater
If you want to provide an update, do it in a 3.09/ directory (if your update is
expected for 3.10 version)
Note that the updater use a md5sum checker. So, if the same update is in 2
different places, it will be detected. That will be handy for changes made on
both stable and master: a library running stable will get the update when
updating. When upgrading to the next major release, Koha will detect the patch
has already been applied, and no error will be thrown. With the previous
mechanism, a DBRev ported to stable was re-executed when upgrading to master,
resulting in a nasty (but usually harmless) error message
Signed-off-by: Paul Poulain
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 11:42:58 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2012 09:42:58 +0000
Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167
--- Comment #137 from Paul Poulain ---
Created attachment 11242
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11242&action=edit
Bug 7167: Improve display + factorize get_queries
Despite it's size, this patch is dealing with display questions only:
* The text "comments" and "queries" was hardcoded in ajax-updatedb-getinfo.pl
script. It has been replaced by a JSON call, returning 2 separate values,
"comments:" and "queries:" is now in the template, making it translatable
* Some minor tweak in the display (like putting things in bold, displaying OK
in green, warnings in yellow and KO in red)
* Reordering the column headers for more readability:
* Status column is merged with availability, column is after status
* Status/availability terms more clear: "Not applied" instead of "unknown",
"Applied and OK", "Applied and failed", "Applied and forced" are the 3 other
statuses
* Removed one click to display comments on DBREv not yet applied: before
the patch, one had to click "Show details", then "Get comments", now, "Get
comments" is enough
Signed-off-by: Paul Poulain
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 11:43:03 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2012 09:43:03 +0000
Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167
--- Comment #138 from Paul Poulain ---
Created attachment 11243
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11243&action=edit
Bug 7167: FIX typos & moving a script to a proper place
* renamed availables to available
* renamed already_knows to already_applied
* fixed FSF & copyright headers
* removing a "use strict" because we already had use Modern::Perl
* fixed a tiny typo in about.tt
* moving update.pl to misc/bin because it's a CLI script
Signed-off-by: Paul Poulain
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 11:43:07 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2012 09:43:07 +0000
Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167
--- Comment #139 from Paul Poulain ---
Created attachment 11244
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11244&action=edit
Bug 7167: Add dependency File::Find::Rule
Signed-off-by: Paul Poulain
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 11:43:16 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2012 09:43:16 +0000
Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167
--- Comment #141 from Paul Poulain ---
Created attachment 11246
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11246&action=edit
Bug 7167 reindentation & removing dead code
* The if (! defined $ENV{PERL5LIB}... block was wrongly intented
* The 3 lines running update.pl are useless: the update (new mechanism) is run
from admin/updatedatabase.pl script. This part of install.pl is run only when
you have "old style" DB revisions.
Summary:
* old mechanism = it's run as previously, by reaching the
installer/install.pl?step=3 page, that applies all revisions
* new mechanism = when you log-in or reach mainpage.pl, you reach
admin/updatedatabase.pl, where you can see what will be run, and run it
Tiny side effect = the check for old mechanism is now done *after*
authentification (thus it's not done on each page call). It means that the user
will have to enter login/password twice :
* first to log-in to Koha
* second to run installer/updatedatabase.pl?step=3
As the old mechanism is deprecated, we can expect this will happend only a few
time in the history of a setup, it's not a big deal.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 11:43:11 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2012 09:43:11 +0000
Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167
--- Comment #140 from Paul Poulain ---
Created attachment 11245
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11245&action=edit
Bug 7167: We want to execute non-numeric version with the -all option
Dealing with Marcel comment 100:
> Note that the current code around line 52/53 does not
> handle that correctly:
> Argument "\x{74}\x{65}..." isn't numeric in numeric ge (>=) at
> installer/data/mysql/update.pl line 52.
Now, a non-numeric DBRev will be applied if you provide the --all parameter,
without throwing the error
Signed-off-by: Paul Poulain
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 11:44:34 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2012 09:44:34 +0000
Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167
Paul Poulain changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #11222|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 11:44:47 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2012 09:44:47 +0000
Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167
Paul Poulain changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #11223|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 11:45:02 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2012 09:45:02 +0000
Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167
Paul Poulain changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #11224|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 11:45:15 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2012 09:45:15 +0000
Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167
Paul Poulain changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #11225|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 11:45:28 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2012 09:45:28 +0000
Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167
Paul Poulain changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #11226|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 11:45:40 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2012 09:45:40 +0000
Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167
Paul Poulain changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #11227|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 11:45:53 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2012 09:45:53 +0000
Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167
Paul Poulain changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #11228|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 11:46:04 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2012 09:46:04 +0000
Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167
Paul Poulain changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #11229|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 11:46:18 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2012 09:46:18 +0000
Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167
Paul Poulain changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #11230|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 11:46:32 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2012 09:46:32 +0000
Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167
Paul Poulain changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #11231|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 11:46:45 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2012 09:46:45 +0000
Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167
Paul Poulain changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #11232|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 11:50:17 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2012 09:50:17 +0000
Subject: [Koha-bugs] [Bug 6832] Validation of total > budget in neworderempty
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6832
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Patch doesn't apply
CC| |jonathan.druart at biblibre.co
| |m
--- Comment #9 from Jonathan Druart ---
The proposed patch does not apply :
fatal: cannot convert from UTF-8utf-8 to UTF-8
Please resubmit this patch well formated.
On the way, replace the french commit message ;-)
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 11:50:37 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2012 09:50:37 +0000
Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167
--- Comment #142 from Paul Poulain ---
The 12 patches attached does not differ a lot from the 11 attached yesterday:
* The " Bug 7167: Reimplementing Marcel's suggestions & fixes" fixes the
3.09.00.028 problem (see comment 129)
* The "Bug 7167 reindentation & removing dead code" reindent a block and
remove some useless (& bugguy) code
I've amended our test plan, so repeating it here:
Tests made:
? Start from a clean situation (drop the 3 tables created by the new mechanism
drop table updatedb_error;drop table updatedb_query;drop table
updatedb_report;)
? Checked that the old updatedatabase is still working by
? adding a 3.09.00.028 update, that is empty
? checked that we're redirected and the update is OK
? Created a 3.09/sample.sql that contains "UPDATE systempreferences SET
value='nothing' WHERE variable='NOTHING_TOO';" with a comment "test doing
nothing"
? verified that, on mainpage, we're redirected to new updatedatabase
? verified that, trying to acces, unidentified, to a page (in circulation),
we're redirected to new updatedatabase
? going to mode DEBUG=1 in Apache config, confirmed that the button "Execute"
appears. Checked that DEBUG=0 make the link disappearing
? Tested the 2 sample files (the .sql.sample and the .pl.sample) by copying
them in 3.09/ directory
? Checked that Koha displays "2 updates available", let apply both in one
click (UPDATE ALL)
? Tested that forcing applying a given update (by manually entering the number:
/cgi-bin/koha/admin/updatedatabase.pl?op=update&version=3.09.01.001) result in
a message saying it has already been executed
? checked that, if you have 2 files with the same content (ie: same md5sum, but
not same name), the installer detect it's a duplicate
? Created an invalid update file,
? Checked that applying it result in a message, with a link to force "mark as
applied".
? Checked that the link mark the DBRev as applied and the updater understand
it must not bother
? Verified what happen when you have an invalid .pl file that does not even
compile
? checked that there is an error thrown
? checked that the Perl error is reported (if the pl is invalid, it means the
patch has not been applied, the "librarian" is a developer, displaying the Perl
error is relevant)
? checked that you can't "force OK" this error = the .pl must be fixed, no
reason to be able to force
? Verified non numeric behaviour
? created a file 3.09/Bug_1234.sql
? Tested that it appears first and can be applied
? Tested that, once the but has been renamed to a number (ie: it has been
pushed), Koha detect it's a duplicate already applied
? Possible improvement = if you apply many non-numeric DBRevs because you're
testing, they all appear in first place. This can be fixed by removing the
entries in tables updatedb_error, updatedb_query, updatedb_report. An
improvement could be to have this in the staff interface. For now:
? DELETE FROM updatedb_error WHERE version=?;
? DELETE FROM updatedb_query WHERE version=?;
? DELETE FROM updatedb_report WHERE version=?;
? Checked that, in CLI, misc/bin/updatedb.pl --all execute all available DB
updates
? Checked mix of old and new updatedatabase mechanism:
? Applied some new system revisions
? Added some lines in installer/data/mysql/updatedatabase.pl, and checked the
old versioning system runs
? Tested that a full install (drop database / create database / run
installer.pl) works well
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 11:55:43 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2012 09:55:43 +0000
Subject: [Koha-bugs] [Bug 6832] Validation of total > budget in neworderempty
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6832
--- Comment #10 from Katrin Fischer ---
Hi Jonathan,
this patch will apply if you change the patch file and remove one line:
Content-Type: text/plain; charset="utf-8"
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 12:01:54 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2012 10:01:54 +0000
Subject: [Koha-bugs] [Bug 8544] Make RSS icon styleable
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8544
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #11234|0 |1
is obsolete| |
--- Comment #3 from Jonathan Druart ---
Created attachment 11247
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11247&action=edit
Bug 8544 - make the RSS icon CSS-changeable
This gives the RSS bits on the search results some CSS classes so it can
be modified with CSS or javascript.
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 12:02:27 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2012 10:02:27 +0000
Subject: [Koha-bugs] [Bug 8544] Make RSS icon styleable
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8544
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
CC| |jonathan.druart at biblibre.co
| |m
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 12:33:19 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2012 10:33:19 +0000
Subject: [Koha-bugs] [Bug 8437] Plack and database backup
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8437
Paul Poulain changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |dpavlin at rot13.org
--- Comment #2 from Paul Poulain ---
Dobrica, could you sign-off this one pls ?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 12:38:04 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2012 10:38:04 +0000
Subject: [Koha-bugs] [Bug 8486] Critical error in
Koha::Calendar::days_between calculation
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8486
Paul Poulain changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #11179|0 |1
is obsolete| |
--- Comment #12 from Paul Poulain ---
Created attachment 11248
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11248&action=edit
Bug 8486 - Follow up making the tests db independent
Signed-off-by: Paul Poulain
Makes the test db independant by specifying the date format. Thus, there is no
call to ->preference() that retrieve a systempreference
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 12:38:39 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2012 10:38:39 +0000
Subject: [Koha-bugs] [Bug 8486] Critical error in
Koha::Calendar::days_between calculation
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8486
Paul Poulain changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--- Comment #13 from Paul Poulain ---
Patch signed off. Will also pass QA and push in one go, trivial & valid fix
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 12:38:47 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2012 10:38:47 +0000
Subject: [Koha-bugs] [Bug 8486] Critical error in
Koha::Calendar::days_between calculation
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8486
Paul Poulain changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 12:39:11 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2012 10:39:11 +0000
Subject: [Koha-bugs] [Bug 8486] Critical error in
Koha::Calendar::days_between calculation
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8486
Paul Poulain changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |Pushed to Master
--- Comment #14 from Paul Poulain ---
Follow-up making the tests db independant pushed on master
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 12:39:04 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2012 10:39:04 +0000
Subject: [Koha-bugs] [Bug 8408] Odd OPAC message when OPAC Renewals are
disabled and OPACFineNoRenewals is set to blank
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8408
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
CC| |jonathan.druart at biblibre.co
| |m
--- Comment #6 from Jonathan Druart ---
This patch fixes the reported issue.
Marking as Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 13:31:53 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2012 11:31:53 +0000
Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167
--- Comment #143 from M. de Rooy ---
(In reply to comment #126)
> Hi Paul and Jonathan, I know that you have put a lot of work and thought
> into this, but it is a big change in a critical area. I would like to see
> this pass QA first before being pushed. 1 day (tomorrow, if you want to push
> on Thursday) seems a very short amount of time for the QA team or for anyone
> who wants to follow your test plan.
If we deviate from the standard workflow, please check with the community or
dev list first. Note also that many hours have been spent on QA+ing several
versions of this development, but it never reached the final status yet
(although I certainly hope that it will!).
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 13:36:29 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2012 11:36:29 +0000
Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167
--- Comment #144 from M. de Rooy ---
Just from glancing through some code:
+ # check if you're uptodate, and if you're not, head to updater
+ my $koha39 =~ "3.0900000";
Should this be an assignment? Note that I also corrected this before.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 13:37:30 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2012 11:37:30 +0000
Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167
--- Comment #145 from M. de Rooy ---
(In reply to comment #144)
> Just from glancing through some code:
> + # check if you're uptodate, and if you're not, head to updater
> + my $koha39 =~ "3.0900000";
>
> Should this be an assignment? Note that I also corrected this before.
Maybe too fast. Seems to be corrected by another patch...
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 13:48:41 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2012 11:48:41 +0000
Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167
--- Comment #146 from Paul Poulain ---
(In reply to comment #143)
> (In reply to comment #126)
> > Hi Paul and Jonathan, I know that you have put a lot of work and thought
> > into this, but it is a big change in a critical area. I would like to see
> > this pass QA first before being pushed. 1 day (tomorrow, if you want to push
> > on Thursday) seems a very short amount of time for the QA team or for anyone
> > who wants to follow your test plan.
>
> If we deviate from the standard workflow, please check with the community or
> dev list first. Note also that many hours have been spent on QA+ing several
> versions of this development, but it never reached the final status yet
> (although I certainly hope that it will!).
As I've announced already, i'll be afk for 3 weeks, on friday. passed QA or
not, I think/feel it's unwise to push such a patch just before leaving. If
something goes wrong, everybody will be scared (including me !)
So I won't push this patch before coming back from holiday.
(In reply to comment #145)
> > Should this be an assignment? Note that I also corrected this before.
>
> Maybe too fast. Seems to be corrected by another patch...
I hesitated to squash all patches or have follow-ups to clearly point the
differences. I choose to keep follow-ups. I feel this question is an unsolvable
one... both options have their advantages and their limits...
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 13:54:15 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2012 11:54:15 +0000
Subject: [Koha-bugs] [Bug 8233] New search engine layer - introduce solr
without breaking anything else
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8233
Paul Poulain changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--- Comment #36 from Paul Poulain ---
QA comment: tiny follow-up to please jenkins, passed QA
(but I agree it's a workaround, valid because solr is experimental)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 13:54:24 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2012 11:54:24 +0000
Subject: [Koha-bugs] [Bug 8233] New search engine layer - introduce solr
without breaking anything else
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8233
Paul Poulain changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |Pushed to Master
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 14:10:14 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2012 12:10:14 +0000
Subject: [Koha-bugs] [Bug 8533] Non-numeric cardnumbers screw up
autoMemberNum
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8533
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jonathan.druart at biblibre.co
| |m
--- Comment #4 from Jonathan Druart ---
Hi Kyle,
I can't reproduce the issue without your patch.
I am under the impression, your patch is useless:
mysql> SELECT CAST( "P13000" AS SIGNED );
+----------------------------+
| CAST( "P13000" AS SIGNED ) |
+----------------------------+
| 0 |
+----------------------------+
Indeed, a non-numeric cast as SIGNED is equal to 0
Maybe I missed something ?
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 1 14:11:06 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Aug 2012 12:11:06 +0000
Subject: [Koha-bugs] [Bug 8407] xt/tt_valid.t is too strict
In-Reply-To:
References:
Message-ID:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8407
Paul Poulain changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Failed QA
--- Comment #12 from Paul Poulain ---
chris, could you describe the exact tests you made.
I did the following:
in memberentrygen.tt, replaced
[% IF ( categoryloo.categorycodeselected ) %]
[% ELSE %]
by
in english, no problems.
then ./translate update fr-FR
translate blablabla into bliblibli
then ./translate install fr-FR
switching to english, I get a very nasty:
Template process failed: file error - parse error -
/home/paul/koha.dev/koha-community/koha-tmpl/intranet-tmpl/prog/fr-FR/modules/members/memberentrygen.tt
line 520: unexpected token (%)
[% "[%">[% categoryloo.categoryname %] at
/home/paul/koha.dev/koha-community/C4/Templates.pm line 127.
at /home/paul/koha.dev/koha-community/members/memberentry.pl line 842
Checking the french templates, I see:
[% FOREACH typeloo IN typeloop %] [% FOREACH categoryloo IN
typeloo.categoryloop %] [% IF ( loop.first ) %] [% IF ( typeloo.typename_C )
%]