[Koha-bugs] [Bug 6720] Saved authorities always show as 'Default'

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6720

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |ASSIGNED

--- Comment #25 from Paul Poulain <paul.poulain at biblibre.com> ---
I think I've found a big problem with this patch.
Under certain circumstances (I think it's because zebra & mysql are unsynched,
this can happen when you just deleted an authority, and it hasn't been deleted
on zebra) I get:

Can't use an undefined value as a HASH reference at
/home/paul/koha.dev/koha-community/C4/AuthoritiesMarc.pm line 355.
 at /home/paul/koha.dev/koha-community/authorities/authorities-home.pl line 203

git blame tells me the culprit is here. Investigating a little bit, I see that:
+   GetAuthType($authtypecode)->{'summary'};
will fail if GetAuthType() returns nothing
Changing this line to 
 ( GetAuthType($authtypecode) ? $_->{'authtypetext'}:'');

seems to fix the problem. Jared, could you check, confirm & provide a patch,
i'll sign it immediately

Another problem, maybe not related = the authorities in the list are now
displayed  HASH(0xb67ed88)

-- 
You are receiving this mail because:
You are watching all bug changes.