[Koha-bugs] [Bug 8209] "Did you mean?" suggestions based on authorities

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8209

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Jared, 
the new patch applies, a few first findings:

1) Tiny: +our $NAME    = 'EmbedItems';  looks suspicious to me.

2) Tiny: The database update message has a tiny typo:
Upgrade to 3.09.00.XXX done (Add system preference DidYouMeanFromAuthorities))

3) Blocker: The suggestions don't show up correctly after activating the
feature in system preferences:

Did you mean: HASH(0x42a70e0) HASH(0x42a6ed0) HASH(0x429fbd0) HASH(0x429f630)

4) Might be data: I don't get results for the an=[0-9]* searches. I am not sure
if this is my database or a general problem, but will wait with testing until
3) is fixed.

5) Suggestion: Use links instead of buttons for display of the suggestions.

6) Tiny: If I have no results for my search and no suggestions are generated,
the "Sorry, no suggestions." section covers my "Powered by Koha".

The variant for deactivated Javascript works very nicely, except for 3).

Sorry to fail QA :(

Because Paul pushed so many authority related featured today: I rebased the
patch to current master shortly before I started testing.
commit 9226ae46419a5c54447c7d6e27b6163d2c6fd95a

-- 
You are receiving this mail because:
You are watching all bug changes.