[Koha-bugs] [Bug 7417] Include alternate forms from authorities in bibliographic searches

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7417

--- Comment #13 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Hi Jared,

For discussion:

This patch is interesting. It introduces some new notions into Koha.
For example, objects appear into Koha with an (not one of the least) Authority
module \o/
But ... :)

Why do you choose an old method to do OOP in Perl (bless, SUPER) ? I think you
may have heard about Moose or Moo, why don't use one of them directly from the
beginning of the Koha::* rewriting?

It seems your naming into the Koha namespace is not in agreement with the wiki
page: http://wiki.koha-community.org/wiki/Koha_Namespace_RFC

For new files, I think a best practice is to use "use Modern::Perl" instead of
"use strict; use warnings;"
But nothing is written on the wiki. You are free to keep these lines.

I really like your system of plugin. Our BibLibre dev/solr branch already have
this kind of plugin for the routine index_record. This system is used for 1
index (for example we have a lot of plugins: Date (for index containing dates),
Callnumber, isbn (for a dash management), etc.).
Here we want to add a processing in 1 case (but other cases  will certainly
come). We can imagine to add a new part in the searchengine configuration page
containing a list of features like this one.
Thus, the routine will grow quickly and make it unmaintanable. In fact, we
would have a pluggable system here too. But it is not for now...

-- 
You are receiving this mail because:
You are watching all bug changes.