[Koha-bugs] [Bug 7417] Include alternate forms from authorities in bibliographic searches

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7417

--- Comment #15 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to comment #14)

Chris, 
Thanks for your answer.

> Which introduces no new dependencies
Koha already use a lot of dependencies. For a dependency as much important part
(OOP) I think it is not a good argument.
Furthermore this dependency will be used elsewhere :) 

> and importantly it's fast Class::Accessor does not employ an autoloader
Yes, I agree with you, fastness is one of the more important thing

> thus it is much faster than you'd think. Its generated methods incur no 
> special penalty over ones you'd write yourself.
Ok cool.
But it is just for accessor isn't it ?
I think we will quickly want to add relations between our classes (roles,
superclasses, etc.).
Before introducing new important classes (as Authority) in the Koha namespace,
I think it is important to start a global discussion. What do we want for this
new namespace and for this rewriting ?

It would be great to have new classes written as we want from the beginning.
This would show what are the best practices to follow for futures classes.
To have a reflexion about how we want to rewrite the C4 modules seems to be the
first step. How we want to order our classes ? What Koha::Authority must do ?
We agree we don't want all C4::AuthoritiesMarc into Koha::Authority :)

Mo[o][se] module[s] permits to create classes (with attr, method, etc.),
inheritance, etc. In fact it allows to do OO, very simply if an application
design has been made before.

If we don't take the time to make cleanly things, my fear is to see a lot of
extra developements inside the module not related to it.

-- 
You are receiving this mail because:
You are watching all bug changes.