[Koha-bugs] [Bug 4226] bulkmarcimport.pl doesn't replace 001 when keepids is not specified

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4226

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |julian.maurice at biblibre.com

--- Comment #9 from Julian Maurice <julian.maurice at biblibre.com> ---
Script seems to work as expected, but a few remarks:

1. GetOptions wait for a string after -a and -b parameters, which are boolean
flags according to POD

2. --commit option is not used

3. binmode(STDOUT, ":utf8") is doing something strange. date outputs:
jeudi 9 août 2012, 15:47:12 (UTC+0200)
if i remove binmode line, it looks ok

4. some printed strings have newline at end, some others don't. Some strings
are printed only when $verbose is true while others are always printed (can't
figure out why). Maybe you should use some wrapper sub like this:
sub print_log {
   print @_, "\n" if $verbose;
}

5. italian language (lines 126-127) should be translated.

6. More important: what happens if some ids (authid or biblionumber) are the
same when resetting the primary key?

I tested this:
perl misc/migration_tools/sysno_keeper.pl -a 1 -v -t 009
having 2 records containing the same data in 009 field.

Output:
1. dropping primary key for auth_header.authid
2. filling in auth_header.authid... 3. rebuilding primary key for
auth_header.authid
DBD::mysql::db do failed: ALTER TABLE causes auto_increment resequencing,
resulting in duplicate entry '12345678' for key 'PRIMARY' at
misc/migration_tools/sysno_keeper.pl line 104.

Is there a way to detect such errors and cancel previous modifications ?


Failed QA for 1 and 2. A follow-up for 6 would be great!

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.