[Koha-bugs] [Bug 8329] GetLostItems in C4::Items.pm has a SELECT *

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8329

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
                 CC|                            |mtj at kohaaloha.com

--- Comment #4 from Mason James <mtj at kohaaloha.com> ---
(In reply to comment #3)
> QA comment: this patch looks good, but a small question: why not
> SELECT biblio,author,...,items.* (all items fields) ? would that solve your
> performance problem ? if yest, I think it's better, because it will be more
> evolutive in case one want to introduce a new column in the report.
> 
> But I won't fail QA for that, if you say enumerating fields is needed, I'll
> push your patch

ok Paul,

all QA tests pass, patch looks good - passing QA :)


mason at xen1:~/git/head$ koha-qa.pl 
        * d4f15be Bug 8329 - GetLostItems in C4::Items.pm has a SELECT *
Provided a smaller list based on reports/itemlost.tt
                C4/Items.pm

- perlcritic-progressive tests... OK
- perl -c syntax tests... OK
- xt/tt_valid.t tests... OK
- xt/author/valid-template.t tests... OK

-- 
You are receiving this mail because:
You are watching all bug changes.