[Koha-bugs] [Bug 8588] Duplicate field IDs cause problems with SQL report parameter entry

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri Aug 10 08:59:15 CEST 2012


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8588

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
                 CC|                            |mtj at kohaaloha.com

--- Comment #3 from Mason James <mtj at kohaaloha.com> ---
(In reply to comment #2)
> Created attachment 11438 [details]
> Bug 8588 - Duplicate field IDs cause problems with SQL report parameter entry
> 
> Changes to markup and script to enable unique ids on form
> fields. These changes allow for working label+input pairs
> on one or more text and select inputs and multiple working
> datepickers.
> 
> To test, create a report with more than one date parameter,
> at least one text parameter, and one or more authorised
> value parameters. The datepickers should each work properly,
> and labels should by clickable.
> 
> Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>

patch looks good, passing QA


mason at xen1:~/git/head$ koha-qa.pl
        * b23ef0a Bug 8588 - Duplicate field IDs cause problems with SQL report
parameter entry
               
koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
                reports/guided_reports.pl

- perlcritic-progressive tests... OK
- perl -c syntax tests... OK
- xt/tt_valid.t tests... OK
- xt/author/valid-template.t tests... OK

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list