[Koha-bugs] [Bug 8522] Markup errors cause problems with customized CSS

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8522

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
                 CC|                            |mtj at kohaaloha.com

--- Comment #4 from Mason James <mtj at kohaaloha.com> ---
(In reply to comment #3)
> Created attachment 11396 [details]
> Bug 8522 - Markup errors cause problems with customized CSS
> 
> Some includes and templates contained duplicate "header" ids in
> the markup. The problem should have come up in routine page
> validation, but was obvious when custom CSS was applied.
> 
> To test, load any of the affected pages and validate the
> generated HTML. There should be no errors about 'ID "header"
> already defined." Or, add custom CSS to intranetusercss:
> 
> ...and confirm that only the topmost menu background is affected.
> 
> Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>

patch look good, passing QA


mason at xen1:~/git/head$ koha-qa.pl
        * e6a5599 Bug 8522 - Markup errors cause problems with customized CSS
               
koha-tmpl/intranet-tmpl/prog/en/includes/budgets-admin-search.inc
               
koha-tmpl/intranet-tmpl/prog/en/includes/cities-admin-search.inc
               
koha-tmpl/intranet-tmpl/prog/en/includes/patrons-admin-search.inc
               
koha-tmpl/intranet-tmpl/prog/en/includes/roadtype-admin-search.inc
                koha-tmpl/intranet-tmpl/prog/en/includes/z3950-admin-search.inc
                koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt

- perlcritic-progressive tests... OK
- perl -c syntax tests... OK
- xt/tt_valid.t tests... OK
- xt/author/valid-template.t tests... OK
mason at xen1:~/git/head$

-- 
You are receiving this mail because:
You are watching all bug changes.