[Koha-bugs] [Bug 6617] table of contents not printing right if entered right

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri Aug 10 10:41:19 CEST 2012


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6617

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
                 CC|                            |mtj at kohaaloha.com

--- Comment #25 from Mason James <mtj at kohaaloha.com> ---
(In reply to comment #24)
> Created attachment 11368 [details]
> [SIGNED-OFF] Bug 6617: Improve MARC21 enhanced contents display (intranet)
> 
> The display of "Enhanced" 505 (contents) fields in the MARC21
> XSLT is very poor, resulting in large, unreadable blocks of text,
> and -- for some series -- so much unnecessary duplication in the
> Notes tab that important information is entirely obscured. This
> patch reformats "enhanced" contents fields (MARC21 505 fields with
> $t and $r) so as to be more readable by breaking up entries on
> separate lines and making titles bold (to make them stand out more).
> 
> This patch does not address duplication of information in the Notes
> tab, per discussion on the #koha IRC channel.
> 
> To test:
> 1) View record with enhanced 505 field before applying patch. Observe
> it is very unfriendly.
> 2) Apply patch.
> 3) View same record, note that display is much improved.
> 
> Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
> Display in staff and OPAC is consistent and improved after
> applying the patch.



patch looks good, passing QA on all patches

xslt files pass validation. 
 mason at xen1:~/git/head$ prove ./t/00-valid-xml.t 
 Result: PASS


mason at xen1:~/git/head$ koha-qa.pl -c 2
        * e4ad597 Bug 6617: Improve MARC21 enhanced contents display (intranet)
                koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css
               
koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl
                koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slimUtils.xsl
        * 1a9cbf9 Bug 6617: Improve MARC21 enhanced contents display
                koha-tmpl/opac-tmpl/prog/en/css/opac.css
                koha-tmpl/opac-tmpl/prog/en/xslt/MARC21slim2OPACDetail.xsl
                koha-tmpl/opac-tmpl/prog/en/xslt/MARC21slimUtils.xsl

- perlcritic-progressive tests... OK
- perl -c syntax tests... OK
- xt/tt_valid.t tests... OK
- xt/author/valid-template.t tests... OK

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.


More information about the Koha-bugs mailing list