[Koha-bugs] [Bug 7887] Add Option To Include Items That Will Be Available When Calculating Holds Ratios

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7887

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |julian.maurice at biblibre.com

--- Comment #5 from Julian Maurice <julian.maurice at biblibre.com> ---
1. from patch:
+my $not_for_loan_comparison = ( $include_will_be_available ) ? "<=" : "=";
...
+notforloan $not_for_loan_comparison 0 AND damaged = 0 AND itemlost = 0 AND
wthdrawn = 0

In which case notforloan will be lesser than 0?

2. As use of aqorders table is conditional, I think the join should be
conditionnal too.

3. I get "Illegal division by zero at
/home/julian/koha/versions/community-master/circ/reserveratios.pl line 155."
when checking "Include on order items".
It seems that x+NULL = NULL with MySQL. I think it can be fixed with (2)

Failed QA for (3)

-- 
You are receiving this mail because:
You are watching all bug changes.