[Koha-bugs] [Bug 8110] Fines accruing on closed days

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8110

Kyle M Hall <kyle.m.hall at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #40 from Kyle M Hall <kyle.m.hall at gmail.com> ---
Jonathan, I failed to see how this is a problem with this patch. The test
failing does not mean this patch is bad, it *is* the test. The test failing
means there is something wrong with the calendar modules.


(In reply to comment #39)
> QA comments:
> 
> One test does not pass:
> #   Failed test 'Christmas is a closed day'
> #   at t/db_dependent/Holidays.t line 44.
> #          got: '0'
> #     expected: '1'
> 
> After a quick debug, in Koha::Calendar, l.153:
>     if ( exists $self->{day_month_closed_days}->{$month}->{$day} ) {
> should be
>     if ( exists $self->{day_month_closed_days}->{$day}->{$month} ) {
> 
> Marked as Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.