[Koha-bugs] [Bug 8110] Fines accruing on closed days

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8110

Jared Camins-Esakov <jcamins at cpbibliography.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #41 from Jared Camins-Esakov <jcamins at cpbibliography.com> ---
(In reply to comment #40)
> Jonathan, I failed to see how this is a problem with this patch. The test
> failing does not mean this patch is bad, it *is* the test. The test failing
> means there is something wrong with the calendar modules.

Based on Dobrica's comment #35, there may already be a patch that fixes the
problem. If that is true, the tests are wrong, and should be updated to test
for correct functioning (because they will fail when the code is working, and
pass only when it is not working in a very particular way). If that is not
true, the patch fails to fix the problem, and therefore does not pass QA for
that reason. If the intention is only to provide a test suite that highlights
where the code is broken, the patches should probably just be moved to a
different bug, so that no one is expecting a fix for the "Fines accruing on
closed days issue" when they see this mentioned in the release notes, and so
that the QA team is not confused.

Also, I am in agreement with Dobrica that day_month_closed_days should probably
be renamed to month_day_closed_days if we are switching the order. Not that
either name makes all that much sense, but at least there's some argument in
favor of the latter.

-- 
You are receiving this mail because:
You are watching all bug changes.