[Koha-bugs] [Bug 5339] Parcel closing in acq

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Mon Aug 13 09:46:26 CEST 2012


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5339

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

--- Comment #69 from Jonathan Druart <jonathan.druart at biblibre.com> ---
QA Comment:
It would be better that someone not from BibLibre make QA on this patch.

To pass QA, some points would be great:
- mandatory: perltidy on all new files
- minor: you change prototype for ModReceiveOrder but you don't modify files
into the test directory
- some unit tests for your invoices routines would be perfect. See Bug 5327,
using DBD::Mock it is very simple.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.


More information about the Koha-bugs mailing list