[Koha-bugs] [Bug 5339] Parcel closing in acq

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Mon Aug 13 14:17:18 CEST 2012


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5339

--- Comment #72 from Julian Maurice <julian.maurice at biblibre.com> ---
(In reply to comment #69)
> QA Comment:
> - minor: you change prototype for ModReceiveOrder but you don't modify files
> into the test directory

It only adds an optional parameter in last position, so ModReceiveOrder should
still behave as expected.
However, ModReceiveOrder is used GetParcels.pm and GetParcel.pm
(t/db_dependant/Acquisition/). Is this used somewhere?


> - some unit tests for your invoices routines would be perfect. See Bug 5327,
> using DBD::Mock it is very simple.

I'm not writing tests with DBD::Mock since I don't know how to use it (see
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327#c219)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.


More information about the Koha-bugs mailing list