[Koha-bugs] [Bug 8649] C4::Search needs a unit test

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8649

--- Comment #7 from wajasu <matted-34813 at mypacks.net> ---
Created attachment 11652
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11652&action=edit
[SIGNED-OFF] 0006-bug-8649-quiet-a-variable-use-warning.patch

For the record, when signing off, jcamins, gmcharlt, and wajasu 
collabrated for the patches, and it resulted in 5 commits, which preserve 
the history of work done. 

Pardon my explicit TODO list: 

1) git clone git://git.koha-community.org/koha.git kohaclone ; cd kohaclone 
2) git remote add gkohatest https://github.com/gmcharlt/koha-test.git    
3) git fetch gkohatest 
4) git branch bug8649_signed_off gkohatest/bug8649_signed_off 
5) git checkout bug8649_signed_off 
6) prove t/db_dependent/Search.t 
t/db_dependent/Search.t .. ok      
All tests successful. 
Files=1, Tests=57,  7 wallclock secs ( 0.02 usr  0.01 sys +  2.37 cusr  0.41
csys =  2.81 CPU) 
Result: PASS 
7) there was much rejoicing 
8) commited the last commits in my local test branch pertaining to this bug
git commit --amend -s -c fd27241a0c57e696a28966abe4024ce29616660b
git commit --amend -s -c 6f379b594363b6703f7b261c0f6c03bd164a70c0 
git commit --amend -s -c e1e21badfc45f4b442870d4ebea719836d012b18 
git commit --amend -s -c 3719c6c3f61243a058bd34101e7d1cb787ba9713 
git commit --amend -s -c 9efbc14cf9eaab554881e189916b5ac2eca8c712 
9) git format-patch -s origin/master   and sent patches to  mailing list
10) attached them to bugzilla
Note: 0002-0006 ( a total of 5 patches ) is what is required

Congrats to jcamins on the excellent test for zebra Search 
and to gmcharlt on supportive patches which runs without a hitch 
in my koha test VM, over a sshfs mounted kohaclone. :) 

wajasu

-- 
You are receiving this mail because:
You are watching all bug changes.