[Koha-bugs] [Bug 8429] Unnecessary use of Exporter in SIP/ILS objects
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Sun Aug 19 10:04:48 CEST 2012
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8429
Chris Cormack <chris at bigballofwax.co.nz> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #10796|0 |1
is obsolete| |
--- Comment #2 from Chris Cormack <chris at bigballofwax.co.nz> ---
Created attachment 11685
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11685&action=edit
Bug 8429: Remove unnecessary use of Exporter from SIP/ILS
All the modules in the SIP/ILS tree are objects
The addition of calls to Exporter or hand manipulation of
@ISA added unnecessary bloat
Removed the "self = shift or return" idiom as it is nonsensical
if the method can only be called via an object.
standardized inheritance via use parent
added a $self = shift in a couple of places where it
was not strictly necessary as its absence seemed to have
misled readers in the past
Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list