[Koha-bugs] [Bug 8293] Software error when clicking on first or last result of each page on OPAC

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8293

--- Comment #7 from Fridolyn SOMERS <fridolyn.somers at biblibre.com> ---
In my opinion, the bug can be explained by looking at the actual code
(v3.09.00.030):

In opac-details.pl, the searchAgain method contains :
  my @records = $results_hashref->{$server}->{"RECORDS"};
  @newresults = searchResults('opac', '', $hits, $results_per_page, $offset,
$arrParamsBusc->{'scan'}, \@records,,
C4::Context->preference('hidelostitems'));

But, in opac-search.pl there is :
  @newresults = searchResults('opac', $query_desc, $hits, $results_per_page,
$offset, $scan, $results_hashref->{$server}->{"RECORDS"});

In both, $results_hashref comes from C4::Search::getRecords.
In this method, search results are added to the results of a server by : 
  $results_hash->{'RECORDS'}[$j] = $record;

So the hash entry $results_hash->{'RECORDS'} contains a ref to an array of
records.

Therefore, my patch proposes to use in opac-details.pl/searchAgain the same
syntax as in opac-search.pl where it works fine.

Test :
------

You can reproduce the bug by using Sandbox n°2 (check that OpacBrowseResults
syspref is on) : http://wiki.koha-community.org/wiki/Sandboxes.
Perform a search with more than 20 results and click on first result of second
page.

I think it corrects the bug 7894 which is not fully corrected : see
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7894#c7

-- 
You are receiving this mail because:
You are watching all bug changes.