[Koha-bugs] [Bug 8600] Remove search terms in advanced search

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8600

--- Comment #4 from Maxime Pelletier <pelletiermaxime at gmail.com> ---
(In reply to comment #3)
> I'll get my petty comment out of the way first: Shouldn't it be [+][-]
> instead of [-][+]? I don't know why I think that.
> 
> More importantly: I think the [-] option should only be applied to fields
> which are dynamically added. If you remove a field which wasn't dynamically
> added you're using the operation as a defacto "clear" button, which we offer
> only in rare circumstances.
> 
> The other problem with being able to remove a "hard-coded" row with [-] is
> that it makes it possible to remove the last row which contains the [+]. If
> you remove that one you don't have the option anymore to add more rows. The
> final version of this enhancement should prevent/work around that problem.

I disagree with the +- order because I feel like the - should be aligned. But
it doesn't matter.
I disagree about having the - only on dynamic lines. I do like it being some
kind of clear. If I type words in 3 fields and change my mind on one I can
remove it and add a new one.

I have a few possible solutions and ideas and I would like your opinion on the
best one to take.

What I propose is to have a link "Add a new search term" at the top instead of
the little [+]. That way it would always be in the same position and it would
be clearer. In most app the + is to show something hidden, so a text link would
help imo.
Also I will change my patch to have a small red x instead of a - for the same
reasons.

Would that be alright with you ?

-- 
You are receiving this mail because:
You are watching all bug changes.