[Koha-bugs] [Bug 8240] There is dead code in orderreceive.tt

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8240

--- Comment #7 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to comment #6)
> - The id is not defined (or is a bad id, ie. there is no result) and the
> template displays an error (here "This ordernumber does not exist.").
> 
> I think in the latter case the error message is necessary to inform the user
> (or developper) that the page should not exist.

I tested this with ordernumber= (making it blank)
In that case there are many results for the line:
my $results = SearchOrder($ordernumber,$search);

The script presented the first result (order 1).

I still think that you should add some checks for this situation.

-- 
You are receiving this mail because:
You are watching all bug changes.