[Koha-bugs] [Bug 8378] <fine> syntax not working on overdues anymore

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Thu Aug 23 20:58:03 CEST 2012


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8378

--- Comment #5 from wajasu <matted-34813 at mypacks.net> ---
Created attachment 11804
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11804&action=edit
Bug-8378-fine-syntax-broken-NFC-and-charset-utf8

After applying Bug 8607's patch and Bug 8378
0001-Bug-8378-fine-syntax-not-working-on-overdues-anymore,
this followup patch takes care of NFC and charset issues for utf8: 
Bug-8378-fine-syntax-broken-NFC-and-charset-utf8.patch
0) configure the KohaAdminEmailAddress syspref (or leave as root at localhost if
   you don't want to test email). Yout can "select * from message_queue" to see
whats queued, and verifiy charset changes as well.
1) create or use a patron WITHOUT primary email address set and with category
(such as student) that gets overdue messages.
2) checkout an item for that patron, one with a checkout due date 1 day prior
to today
3) checkout an item for that patron, one with a checkout due date 2 days prior
to today
4) configure circulation rules (see attachment above)
5) configure overdue actions (Tool->Overdue notice/status triggers)
Refer to the attachment for the "First tab"
For the "Second" tab, make it the same, except with a delay of 2
6) verify/confogure a overdue ODUE notice template with a <fine> within items.
<item>"<<biblio.title>>" by <<biblio.author>>, <<items.itemcallnumber>>,
Barcode: <<items.barcode>> Fine: <fine>USD</fine></item>
7) run ./misc/cronjobs/fines.pl    (this will calculate fines)
8) There are multiple ways to generate notices:
 ./misc/cronjobs/overdue_notice.pl
 ./misc/cronjobs/overdue_notice.pl -t         (triggered)
       (these will generate an email)
 (if the patron doesn't have a primary email, the email notices are batched
  up and sent to the KohaAdminEmailAddress syspref)
9) query the message_queue table content column to see what was generated.
10) verify:
  a) that items show up for the overdues for your patron. 
     "Fine: $1.50" and one with "$3.00"
   I've seen multiple notices for the same person, or all in one notice.
  b) that email header  Conent-Type: "text/plain"; also has charset="utf-8"
     for both the main letter body AND attachments.  You can see this in the
mysql query for the content. If you process the message_queue, sending eamil,
you can view source of the email and see the same information.
11) add a primary email address to your patron, and generate notices again
(step 8) This will test a different code path (no attachments) and send the
notice to the patron email.
12) query the message_queue table to see what is getting emailed.
13) view email for patron to verifiy all Fine: $  curreny symbols appear.

14) Bonus: Bug 8299 - Since the uninitialized matching error were addressed and
you did not see them when you ran overdue_notice.pl, you can close bug 8299 as
a dup.

Note: NFC normalization will apply to other letters/notices as well, and
hopefully allow certain UTF8 codes to be stored as well.
Note: Bug 8299 would be fixed bby this Bug 8378, since I addressed those
warnings.  I don't see them anymore with this patch.
Note: I did NFC normalization on the attachment filename, since filenames will
have unicode chars increasingly in the future. (I think)
Note: We use NFC in Record.pm, and other places. That seems to be our standard.

wajasu

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.


More information about the Koha-bugs mailing list