[Koha-bugs] [Bug 8350] Searching for a 10 or 13 digit string (with a number in it) that does not exist in one's catalog will fail to affect SQL statement correctly in C4::Breeding

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Thu Aug 30 06:41:10 CEST 2012


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8350

--- Comment #6 from M. Tompsett <mtompset at hotmail.com> ---
Put in patching equivalent to my 3.6.3 system. No errors!

However, fixing Breeding.pm may not be the only problem. I noticed, while
trying to think through the possibilities that there are issues in addbooks.pl
The BreedingSearch call has either title=undef or isbn=undef. Is this a
reasonable expectation?

Additionally, BreedingSearch has three parameters: search, isbn, z3950random.
By calling with only two parameters, z3950 is always undef. This means that the
"else" always runs. And as Julian Maurice pointed out, there is only one
program currently using the BreedingSearch.

Perhaps an optimization of the function needs to be made too? I was thinking of
a substitution for a different function, but I'm not so sure of that. Someone
else more familiar with the addbooks.pl processing would need to make that
call.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list