[Koha-bugs] [Bug 8454] Holds to Pull : Show pull list on load. Otherwise, it looks like the pull list is empty.

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8454

--- Comment #6 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to comment #5)
> I figured the "if ( 1 ){}" approach would be the easiest, as it meant the
> fewest changes to the code, but I'm certainly up for alternative strategies
> :).
> 
> I'm not sure that I understand your conditional here though. Doesn't that
> say that $run_report will be 1, if $input->param('run_report') isn't
> set/defined? Otherwise, if it is defined...then it will just be the param
> that's passed, which amounts to 1 anyway? 
> 
> In either case, it seems inevitable that the page will load the report upon
> page load, which I'm proposing is a good idea. 
> 
> However, in that event, how would it be possible for someone to load this
> page without running the report, as you suggest? 

Hi David,
Your patch does not allow to open the page without launching the report.
For me it is not logical to have a cgi param (run_report) and to not check it.
And "the fewest changes to the code" is not a good reason for me if it is not
consistent :)

If, on the master code, you replace 
   my $run_report=$input->param('run_report');
with
   my $run_report = ( not defined $input->param('run_report') ) ? 1 :
$input->param('run_report');

the page can be displayed without the report if you call it with run_report=0.
In all others cases, the report will be displayed (even if the param is not
passed). I think it is a good behaviour.

-- 
You are receiving this mail because:
You are watching all bug changes.