[Koha-bugs] [Bug 8435] new permissions on subscriptions "superserials"

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Thu Aug 30 13:15:34 CEST 2012


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #5 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
Just a question about:
sub can_edit_subscription {
+    my ( $subscription, $userid ) = @_;
+    my $flags = C4::Context->userenv->{flags};
+    $userid ||= C4::Context->userenv->{'id'};
+    if( C4::Context->preference('IndependantBranches')
+        and (
+               $flags % 2 == 1
+               or C4::Auth::haspermission( $userid, {serials =>
'superserials'}),
+            or not defined $subscription->{branchcode}
+            or $subscription->{branchcode} eq ''
+            or $subscription->{branchcode} eq C4::Context->userenv->{'branch'}
+        )
+    ) {
+        return 1;
+    }
+     return 0;
+}

If IndependantBranches is off, you may not edit? Somewhat confusing. Please
clarify..

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list