[Koha-bugs] [Bug 8017] Remove unnecessary processing on return of GetAllIssues

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri Aug 31 17:29:54 CEST 2012


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8017

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |paul.poulain at biblibre.com

--- Comment #8 from Paul Poulain <paul.poulain at biblibre.com> ---
I realize that this patch modify a SELECT * that is LARGE as it's a JOIN on
issues / biblio / items / biblioitems

I agree it was like this before the patch. But Colin, could you improve it to
return only needed columns, because that's probably also a source of the perfs
problem.

Side note : there is a call to 
+my $branches = GetBranches();
+foreach my $issue ( @{$issues} ) {
+    $issue->{issuingbranch} = $branches->{ $issue->{branchcode}
}->{branchname};
 }
That could be replaced by another JOIN (not sure it's a good idea, just
sharing)

(not failing QA, the mistake was here before your patch. If you can't provide a
follow-up, i'll push like this. But if you agree for a follow-up, it will be
cool ;-) )

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list