[Koha-bugs] [Bug 7896] Acquisition statistics wizard: add filters and cell values

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7896

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
   Patch complexity|---                         |Medium patch
         QA Contact|koha.sekjal at gmail.com       |katrin.fischer at bsz-bw.de

--- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Julian, 

I looked at the patch and there are lots of smaller things I noted while
testing:

1) Terms and capitalization
- Budget/All budgets is labelled wrong, as it really shows the funds
- All Item Types should be 'All item types'
- All Suppliers should be 'All vendors'

2) Untranslatable terms
- $select{''} = "All budgets";
- $select{''} = "All Item Types";

3) POD
- Old copy & paste error: plugin that shows a stats on borrowers

4) Item type - biblio level only?
- Looking at the code it seems like only bibio level itypes are taken into 
  account. I wonder if the stats should use 'item-level itypes'. If that can't
  be done, a little note would be helpful.

5) Error logs

(can be reproduced by sending the form with preselected options)

[Sun Dec 02 10:24:14 2012] [error] [client 127.0.0.1] [Sun Dec  2 10:24:14
2012] acquisitions_stats.pl: Use of uninitialized value in addition (+) at
/home/katrin/kohaclone/reports/acquisitions_stats.pl line 582., referer:
http://localhost:8080/cgi-bin/koha/reports/acquisitions_stats.pl

That all said, perlcritic passes, all tests pass, and most problems are
preexistant to your patches. But I would love to see a follow up addressing
some of the other problems.

-- 
You are receiving this mail because:
You are watching all bug changes.