[Koha-bugs] [Bug 6835] Ability to specify types of email address in overdue_notices.pl

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6835

--- Comment #30 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
Still two questions looking at the code again:

1) $email = C4::Members::GetFirstValidEmailAddress($borrowernumber);
                        push @emails_to_use, $email;
Shouldn't you test what you get back from this routine? Could be nothing.
Could you use a temp variable instead of $email? (see point 2)

2)  $email = 1 if (@emails_to_use);
Does this work later on? I would rather test later on @emails_to_use and not
change a variable that is a record value used in the while loop (l.488).
See also line 535. And the template vars on 591/620.

Thanks.

-- 
You are receiving this mail because:
You are watching all bug changes.