[Koha-bugs] [Bug 9130] Remove old javascript from Parcel

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9130

--- Comment #15 from David Cook <dcook at prosentient.com.au> ---
(In reply to comment #11)
> Thanks David for your followup.
> 
> 1 little remark: when you add a value (60*60*24*1000), could you add
> directly the result (86400000)? Because like this the calculation is not
> performed each time.
> It is JS code so it is not crucial and not blocker.
> 
> Marked as Passed QA.

Good point, Jonathan. In retrospect, I could've just added the result. When
looking through other examples (like in jquery.cookie.min.js), I noticed them
writing out the whole calculation, so I just copied that at the time. I don't
know if it's worth a follow-up, but certainly something to keep in mind for
future Datatable mods.

-- 
You are receiving this mail because:
You are watching all bug changes.