[Koha-bugs] [Bug 9174] Item type image does not display for biblio-level itemtypes in list display in OPAC

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Mon Dec 10 11:57:49 CET 2012


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9174

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |m.de.rooy at rijksmuseum.nl
   Patch complexity|---                         |Small patch
         QA Contact|                            |m.de.rooy at rijksmuseum.nl

--- Comment #3 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
QA Comment:
Works as expected. Code looks good to me too.
Small sidenote: POD documentation of getitemtypeinfo was copied from
getitemtype. Still contains wrong procedure name. You touched that line. Could
you correct it when you look at the following point? 

Also note that the second parameter is optional. It is called more often than
from lists. If you do not test if $interface is defined, you will create a lot
of noise in the logs due to it being uninitialized. See the line with test
$interface eq 'opac' in C4/Koha.pm routine getitemtypeinfo.
For the last reason parking this report to Failed QA. Please correct or send a
follow-up. Thanks.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list