[Koha-bugs] [Bug 7674] Separate tabs for my holdings and others holdings

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7674

--- Comment #44 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 13993
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13993&action=edit
[SIGNED-OFF] Bug 7674 - Followup - Add missing right-hand curly bracket

Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>

All tests and perlcritic pass.

Tests:

Database update
- OK, system preferences were added correctly
- Version number of updatedatabase was only XXX, changed to 3.11.00.XX

OPAC
1) Detail page
- OK, no visible change when OpacSeparateHoldings is turned off
- OK, switching OpacSeparateHoldingsBranch works correctly
- OK, shelf browser opens in correct tab
- OK, only one tab shows when logged out

INTRANET
2) Detail page
- OK, no visible change when SeparateHoldings is turned off
- Number of items is missing on top of the tabs

Notes:
- database update doesn't include bug number
- other holdings tab does show when there are 0 items at other branches,
  it could be hidden in those cases
- if there are over 50 items in the holdings or Other holdings tab, the
  warning and link 'This record has many physical items. Click here
  to view them all.' is only shown for the first tab.
- closing the shelf browser on the second tab goes back to first tab
- number ofitems is missing on top of the tabs
- there are lots of indentation changes in the second patch,
  this makes it very hard to see the changes, please provide separate
  patches in the future

-- 
You are receiving this mail because:
You are watching all bug changes.