[Koha-bugs] [Bug 6813] Acquistions - duplicate search across orders, suggestions and catalog

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Tue Dec 11 20:33:29 CET 2012


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6813

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|                            |paul.poulain at biblibre.com

--- Comment #27 from Paul Poulain <paul.poulain at biblibre.com> ---
QA comment:
 * passes koha-qa.pl, except for a POD mistake revealed in C4/Suggestions.pm, I
attach a follow-up fixing this problem
 * the patch work as expected, no side effect or any problem spotted.

However, I won't pass QA this patch immediately because I've 2 questions = why
is this tool in the acquisition module ? It is not specifically related to
acquisition ? I think it's something that looks like the
/cataloguing/addbooks.pl, that searches in the catalog and the reservoir.
Shouldn't we replace the cataloguing/addbooks.pl by this new script (on which
we would add a "reservoir" tab) ? Once the librarian has done his search, we
could have, instead of just "New record" (to catalogate a new biblio), a "New
record" and a "New suggestion" button.

That would improve consistency imo.

I won't fail QA for now, waiting for patch authors opinion.
That will require more effort, but I think it's worth it, because it will both
improve Koha functionally, usability, and code quality.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list