[Koha-bugs] [Bug 9108] Add uk/euro date sort filter to pages which require it

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9108

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |In Discussion

--- Comment #7 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to comment #6)
> QA comment:
[...]
> Thus, the lines just after this new one in Auth.pm can be removed:
>     if(C4::Context->preference('dateformat')){
>         if(C4::Context->preference('dateformat') eq "metric"){
>             $template->param(dateformat_metric => 1);
>         } elsif(C4::Context->preference('dateformat') eq "us"){
>             $template->param(dateformat_us => 1);
>         } else {
>             $template->param(dateformat_iso => 1);
>         }
>     } else {
>         $template->param(dateformat_iso => 1);
>     }
> 
> and all references to dateformat_metric, dateformat_us and dateformat_iso
> should be replaced :
> [% IF (dateformat_us ) %]
> to replace with:
> [% IF (dateformat eq 'us') %]
> 
> There is something like a dozen of templates that uses this construction.

Yes but I don't want to introduce any regression and I think my patch is more
flexible than your proposition.
Like this anyone is allowed to use the format he wants.
In the same way, the patches still submitted in BZ but not pushed will not be
broken (if using one of the two formats).

-- 
You are receiving this mail because:
You are watching all bug changes.