[Koha-bugs] [Bug 8378] <fine> syntax not working on overdues anymore

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8378

--- Comment #23 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
We had to revert bz8378 in Rennes 2 to get overdues working properly. So I can
confirm this patch is broken somewhere.

In overdue_notice.pl I noticed the following problem :
I checked the value of the variable $letter_template just before and after this
piece of code :
 my $letter = parse_letter(
                    { letter_code => $overdue_rules->{"letter$i"},
                        letter => $letter_template,

=>
The value of $letter_template was modified after the call to parse_letter,
which is not normal I presume.

In sub parse_letter, the function C4::Letters::GetProcessedLetter is called.
And this function was altered by bz8378.

BEFORE applying bz8378, in sub parse_letter, the value of $param->{letter} is
unchanged after it passed as an argument to GetProcessedLetter.

AFTER bz8378, the value of $param->{letter} is changed after it passed as an
argument to GetProcessedLetter.

I hope it could help

M. Saby
Rennes 2 University

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.