[Koha-bugs] [Bug 9243] Bad delete order in sub index_records in rebuild_zebra.pl

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Thu Dec 13 11:58:50 CET 2012


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9243

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #2 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
As far as I can see, this problem is already fixed in master. Your patch
introduces the following problem:
Can't use an undefined value as a HASH reference at ./rebuild_zebra.pl line
422.
This has to do with the uninitialized $records_deleted.

Please note however that the routine export_marc_records_from_list gets the
deleted records hash and skips these deleted records when creating the file for
the update step.
This is done in the following rather obscure code:
    foreach my $record_number ( map { $_->{biblio_auth_number} }
                                grep { !$found{ $_->{biblio_auth_number} }++ }
                                @$entries ) {

I tested update and delete with and without your patch.
With your patch, the above error occurs.
Without your patch, the problem does not occur and the records are deleted from
zebra. 
I suggest to close this report. Do you agree with the above explanation in
mind?

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list