[Koha-bugs] [Bug 7294] status "in order"

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294

Matthias Meusburger <matthias.meusburger at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #46 from Matthias Meusburger <matthias.meusburger at biblibre.com> ---
* There are many $$x{Y} that should be written $x->{Y} 

=> Done.


* I think/fear that the aqorders.branchcode feature is a bad idea: how will it
work when syspref AcqCreateItem=ordering ? How will you deal, when you don't
have AcqCreadItem=ordering, with creation of items, will this value be used for
defining the branch ? How will you deal with cases where you order 3 items for
different branches ? The items table has some fields that are already related
to acquisition: items.booksellerid, items.price, items.replacementprice.

=> I don't see the problem here, because the branchcode that is used is the one
in the aqorders table (added by this patch), so it doesn't matter which value
has AcqCreateItem syspref. The branchcode is asked when creating a new order
and that's it. Moreover, the values inserted in the MARC Record are here for
information, they're not reused afterwards. 


* split the patch in 2, to separate branchcode feature from the link2marc
feature, that's 2 different things

=> Same as before, branchcode is an aqorders field, just like the others. I
don't see how it is different and why it should be handled separately.

-- 
You are receiving this mail because:
You are watching all bug changes.