[Koha-bugs] [Bug 9307] Allow libraries to add/edit status for suggestion management.

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9307

--- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> ---
I was thinking about that. I'll write a new patch that just adds new statuses,
and doesn't affect the old ones.

Kyle

(In reply to comment #3)
> Hi Kyle,
> 
> I am not so happy with this change, trying to explain why:
> 
> 1) Currently authorized values are one language only - we have no way to
> make them more than 'one language at a time'. So if we change something that
> is translated in the templates now back to database, that makes me unhappy.
> Especially if it's strings in the OPAC.
> 
> -                    [% IF ( suggestions_loo.ASKED ) %]Requested[% END %]
> -                    [% IF ( suggestions_loo.CHECKED ) %]Checked by the
> library[% END %]
> -                    [% IF ( suggestions_loo.ACCEPTED ) %]Accepted by the
> library[% END %]
> -                    [% IF ( suggestions_loo.ORDERED ) %]Ordered by the
> library[% END %]
> -                    [% IF ( suggestions_loo.REJECTED ) %]Suggestion
> declined [% END %]
>                      [% IF ( suggestions_loo.AVAILABLE ) %]Available in the
> library[% END %]
> +                    [% KohaAuthorisedValues.GetByCode( 'SUGGEST_STATUS',
> suggestions_loo.STATUS, 1 ) %
> 
> 2) You only added the new authorized value to the English sample files. This
> makes me unhappy too, because it means when you use any non-English
> installer, the suggestions are going to be broken.
> 
> 3) The status values are hardcoded in other places afaikt. Some status
> changes also send out emails to the patrons, like rejecting or accepting
> their suggestion. Ordering and receiving should, although I am not sure that
> is working right now (I filed bug reports sometime somewhere). If you leave
> it to the library to choose the status codes, the chance they will
> accidentally break functionality being not aware of this is quite high.
> 
> Would it be possible to only allow to add additional status or or allow to
> overwrite hardcoded status by the library?

-- 
You are receiving this mail because:
You are watching all bug changes.