[Koha-bugs] [Bug 6838] Filtering and pagination in subscriptions table

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6838

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |paul.poulain at biblibre.com

--- Comment #15 from Paul Poulain <paul.poulain at biblibre.com> 2012-02-01 21:30:04 UTC ---
QA comment

There is a small difference between readingrec (that is using Table sorter) and
serials filter : the previous/next button have the text AND the button on this
patch, there is only the button on readingrec.
There is a 1 between pagination button on this patch, nothing on readingrec

For consistency reason, please do on this patch as on readingrec.

QA comment #2:
I think the following code :
        if ( $previousbiblio eq $line->{biblionumber} ) {
            # Disabled for sorting and filtering on issn and title
            # to work on serials-home.pl
            #$line->{title} = "";
            #$line->{issn}  = "";
        } else {
            $previousbiblio = $line->{biblionumber};
            $odd           = -$odd;
        }
        $line->{toggle} = 1 if $odd == 1;
is useless. i've removed it, without seing any difference. Could you check ? if
i'm right, the "my $previousbiblio='' and my $odd=1 " a few lines before are
useless too

-- 
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are watching all bug changes.