[Koha-bugs] [Bug 7190] written off fines being refunded

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7190

--- Comment #7 from Paul Poulain <paul.poulain at biblibre.com> 2012-02-03 08:11:18 UTC ---
(In reply to comment #6)
> Paul,
> 
> It is not equivalent. The purpose is to catch 'W'.
> * With "SELECT * FROM accountlines WHERE itemnumber = ? AND accounttype IN
> ('L', 'Rep') ORDER BY date DESC, accountno DESC" 'W' is ignored. It says "The
> latest fine" and the latest fine is acted upon.
> * With "accounttype IN ('L', 'Rep', 'W')" it says "Latest fine or writeoff",
> and if it is a writeoff we walk away.

Yes, that's what I understood at the end. But relying on the date to discover
if there is a writeoff is quite dangerous. And it's more as the date field is
only a date.
Suppose the fine and the writeoff are made the same day. We are not sure of the
order mySQL return.
Or suppose someone or something changes the date.

However, your patch relies on how Koha works today, so I have pushed it.
> 
> Re clumsiness, well it is not just this sub, it is the accounting side as a
> whole.
You're right. Its a kind of "oldies but NOT goodies"...

> There's no proper accounting/billing implemented, and the best thing
> would be to integrate a third party solution, but that is another subject.
agreed (to all part of this sentence : no proper & third party solution &
that's another subject)

-- 
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.