[Koha-bugs] [Bug 7422] Prevent creation of vendors with the same name

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri Feb 3 12:16:28 CET 2012


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7422

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #8 from M. de Rooy <m.de.rooy at rijksmuseum.nl> 2012-02-03 11:16:28 UTC ---
QA Comment:
Adrien, thanks for submitting this patch. I would prefer however to do the
check for a duplicate vendor more economical.
With the call to GetBookSellers, you ask for all records. And then you make an
exact comparison in perl.
In that case you could just pass the string to GetBookSellers too!

On the other hand, if I have a vendor like Erasmus BV and I am testing for
Erasmus, I would be happy if I at least would be warned for it. You now give OK
for that situation since you only test exact equivalence.

Hoping that you could make some adjustments in this direction. Changing status
to reflect that.

-- 
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.


More information about the Koha-bugs mailing list