[Koha-bugs] [Bug 6413] Notes in Fines doing wonky things

Mon Feb 6 21:33:28 CET 2012

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413

Kyle M Hall <kyle.m.hall at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle.m.hall at gmail.com

--- Comment #8 from Kyle M Hall <kyle.m.hall at gmail.com> 2012-02-06 20:33:28 UTC ---
Attempted testing of this patch, does not appear to work completely. Applies
cleanly.

1) I created a series of manual invoices with notes, those notes appear in the
Note column on boraccount.pl

2) Switch to pay.pl. Here, the Payment Note column appears with a text box, but
does not pull over the fine note ( I'm not sure if that is supposed to be part
of the functionality or not, but I thought I'd mention it ).

4) Tested with pay, writeoff, and writeoff all buttons, works as stated.

HOWEVER, everything gets broken and messed up if special characters are used in
*any* of the notes fields. 

The data being passed is not being url encoded properly. 

For example, if I make the payment note "Test Payment #12 Note", the payment
note will be "Test Payment ". It gets truncated at the special character. If
you look at the passed params, you will see "payment_note=Test Payment #12
Note" rather than "payment_note=Test%20Payment%20%2312%20Note", as it should
be. 

It gets worse if you used special characters in the Description of charges, or
the Note field. In that case, no part of the note will show up, as everything
is truncated at the special character even earlier.

So, patch essentially works, but everything needs to be url encoded properly or
librarians will not understand why their notes aren't showing up correctly.

-- 
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are watching all bug changes.