[Koha-bugs] [Bug 4032] XSLT systempreference should take a path to file rather than YesNo

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4032

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |paul.poulain at biblibre.com

--- Comment #15 from Paul Poulain <paul.poulain at biblibre.com> 2012-02-07 08:22:09 UTC ---
(In reply to comment #13)
> I think this will confuse your average user, and the software is for them, not
> us.  
> This patch would need two things to get my signoff:
> 1. better documentation in the syspref description 
> 2. no 1/0 on/off usage. This is so confusing for your average user, and
> considering that most libraries will use the default xslt (*not* define a
> specific stylesheet), unnecessarily so.

We had a discussion about your comments with Stéphane.
* I don't see clearly the difference between display without and the default
xslt. I'm wondering if you're not implying to make the default XSLT being the
default display. In this case, an easy change would be to have those sysprefs
being for specific XSLT, if they're empty, then use default XSLT
* Stéphane is right about XSLT made for specific display. Many/most of our
libraries want some tweaks on XSLT. So we use 2 options only: no XSLT or
specific XSLT
* there is also a problem with XSLT syspref as we've today : on a server with
more than 1 Koha (using koha-tools), it's impossible to have a specific XSLT
for each setup

A simple answer to your proposition would be to change the behaviour and have 3
options:
* empty => no XLST
* the string "default" or "1" => default XSLT
* a full XSL path => the specific XSL you've defined.
it could easily be documented on syspref.pl page
Would you be OK with this ?

Note that what is great with this patch is also that we can have full URLs
(http://xslt.koha-community.org/nekls.xsl for example), so we could share XSLT
as we're already sharing SQL queries on the server. Add a meaningfull wiki
page, pointing all existing XSLT and their look, and you get a nice feature

-- 
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are watching all bug changes.