[Koha-bugs] [Bug 6874] File upload in MARC

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874

Jared Camins-Esakov <jcamins at cpbibliography.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |jcamins at cpbibliography.com

--- Comment #17 from Jared Camins-Esakov <jcamins at cpbibliography.com> 2012-02-07 15:45:13 UTC ---
I've tested this, and encountered a number of problems.

The following issues cause the patch to fail QA:
1. The syspref does not appear in the syspref interface.
2. There's no explanation of what the syspref should be set to.
3. This patch adds C4::UploadedFiles (notice the 's') with no indication of how
it relates to C4::UploadedFile (notice the lack of the 's'). It's possible
there is a legitimate reason for this, but there is absolutely no documentation
of the new class.

The following issues do not cause the patch to fail QA, but are worth noting:
4. Uploaded files can only be accessed when the display is set to normal mode.
They do not work with XSLT mode. Perhaps the uploader could be modified to
insert the entire URL so that it would work with XSLT displays too?
5. The patch does not rebase cleanly due to changes in the various installer
files. You might as well fix this when you address issues 1-3 above, so that
the next sign-off-er doesn't need to resolve the conflicts again.
6. The patch should not modify kohaversion.pl (again, easy to fix at sign off,
but you might as well do it while fixing the above).
7. Instructions to activate the upload.pl plugin for 856 (or whatever) are not
displayed on update.

In terms of functionality in normal mode, when the 856$u is linked to the
catalog.pl plugin, this is *very* cool.

-- 
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are watching all bug changes.