[Koha-bugs] [Bug 4158] cannot create list whose title is '0'

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4158

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
           Platform|PC                          |All

--- Comment #3 from Owen Leonard <oleonard at myacpl.org> 2012-02-07 17:21:10 UTC ---
This is a little confusing: the second patch here doesn't apply without the
first, but seems to re-implement all the changes in the first one.

Anyway, I tested with both patches applied. The patch fixes the problem in 50%
of the cases. If I use the "new list" function from the lists page, either in
the OPAC or staff client, I can successfully create a list named "0" and am
prevented from creating a list called " ".

However if I do a search, select items, and try to add them to a new list none
of these improvements are apparent. It doesn't look like this use case was
examined.

Another note: Instead of checking whether a list name starts or ends with
whitespace, wouldn't it make more sense to trim whitespace from the submitted
name and check to see if there's anything left? If I accidentally try to name
my list " foo" I would prefer that Koha assume I meant "foo" rather than reject
the operation.

-- 
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.