[Koha-bugs] [Bug 7458] New call number allocation plugin

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7458

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off
                 CC|                            |brendan at bywatersolutions.co
                   |                            |m

--- Comment #16 from Brendan Gallagher <brendan at bywatersolutions.com> 2012-02-07 17:48:00 UTC ---
(In reply to comment #15)
> Since this plugin is for a callnumber schema used by a single library, I do not
> believe it in itself warrants any kind of changes to core Koha code.  In many
> ways, it's like a third-party service; this call number schema is locally
> developed by KU, and it's reusability is... unlikely.  Having it as a plugin is
> just fine; when that plugin starts to dictate changes to the way the rest of
> Koha behaves, I believe that's a problem.
> 
> An index on items.itemcallnumber isn't a bad idea, but it should be filed as
> it's own separate bug report and patch.  If that index is required for this
> plugin to work, please list the newly filed bug report as a dependency.

Wait this is not passing because the QAM thinks that others will not use this? 
That's kind of a crazy idea.  So since something is programmed in a good manner
and works and does not effect any other aspects of Koha - unless you change
your framework to use this plugin - AND the QAM even said that the indexes on
itemcallnumber are a good idea (well shouldn't the QAM pass this?). 

This comment "Having it as a plugin is
> just fine; when that plugin starts to dictate changes to the way the rest of
> Koha behaves, I believe that's a problem."  Should be examined again - reviewing the code I do not see how this changes core Koha code???  It adds an index to itemcallnumber - which even the QAM agrees to..

Sorry just a bit perplexed as to why this was failed QA?

-- 
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.