[Koha-bugs] [Bug 7351] ability to edit a range of holidays

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7351

--- Comment #10 from Christophe Croullebois <christophe.croullebois at biblibre.com> 2012-02-09 10:46:10 UTC ---
Hello Owen,
yes it's the reason why I said "needs deep testing", I think this patch must
have multiple advices.
For the first point : the weekly repeatable days, I think we are ok, we can
stay on what we have, day by day for deleting or exceptions.
A part of the choices I have made was in regard of the technical structure and
my lazy side. ;o)
The patch can on a range of date either delete the single or repeated days,
depending of the radio button selected. BUT if 'single' selected, and if in
your range you have other kinds of holidays, only 'single' will be deleted, the
same for 'repeated'...
I have made the functions able to exit if there is some bad values, so if you
don't put a value in 'to date:' for example or if the values are not in the
scope, koha does nothing, I have chosen this option because you have the visual
of dates on the calandar and if no action is done you can see it on calandar,
and at my sense it's more ergonomic than some warnings messages with a clic to
close them...
But it's just my advice.
On the other hand, you gave me an idea, I think I could add a third option to
put exceptions on a range of date regarding the yearly repeated holidays...
What do you think about ?
thx

-- 
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.