[Koha-bugs] [Bug 4045] No check for maximum number of allowed holds.

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri Feb 10 18:09:28 CET 2012


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4045

--- Comment #10 from Kyle M Hall <kyle.m.hall at gmail.com> 2012-02-10 17:09:28 UTC ---
(In reply to comment #9)

I assume you are referring to issuingrules.reservesallowed? It is being used in
C4::Reserves::CanItemBeReserved(), so pulling it out is not a good idea. 

The maxreserves system pref is not used anywhere in C4::Reserves at the moment.
It *is* being used in reserve/request.pl, and opac/opac-reserve, and that
appears to be it.

I'm thinking option B is the better option at the moment. Strip out all
references to maxreserves, replace with the new issuingrules reserves, and get
rid of the maxreserves line in the systemprefs sql file.

> I am not sure the new maxreserves from circulation rules is used anywhere - so
> if we are not reapairing it, we should perhaps remove it. Repairing is of
> course better. Do we know where/how it works exactly?

-- 
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are watching all bug changes.


More information about the Koha-bugs mailing list