[Koha-bugs] [Bug 6634] manager_id not populated when paying fines

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6634

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #19 from Paul Poulain <paul.poulain at biblibre.com> 2012-02-13 14:38:33 UTC ---
QA comment

small patch, code is OK.

Will push it, but my tests shows that there is one case that is still not
covered: when paying fines with the button "Pay Selected" or "Pay Amount", the
columns are still NULL (manager_id and itemnumber)
When paying from "Pay" or "Pay Amount", it's OK though

I see in the sub recordpayement that the same kind of fix should be made:

    my $usth = $dbh->prepare(
        "INSERT INTO accountlines
  (borrowernumber,
accountno,date,amount,description,accounttype,amountoutstanding)
  VALUES (?,?,now(),?,'Payment,thanks','Pay',?)"

The sub chargelostitem has also the same problem:
        my $sth2=$dbh->prepare("INSERT INTO accountlines
       
(borrowernumber,accountno,date,amount,description,accounttype,amountoutstanding,itemnumber)
        VALUES (?,?,now(),?,?,'L',?,?)");

(itemnumber is OK, but manager_id is not)

-- 
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are watching all bug changes.